[GitHub] [incubator-pinot] fx19880617 commented on issue #5977: Allow ServiceManager to install tables prior to listening on service ports or a healthy status

2020-09-04 Thread GitBox
fx19880617 commented on issue #5977: URL: https://github.com/apache/incubator-pinot/issues/5977#issuecomment-686966038 I like this feature would you like to work on this? This is an automated message from the Apache Git

[GitHub] [incubator-pinot] adriancole commented on issue #5977: Allow ServiceManager to install tables prior to listening on service ports or a healthy status

2020-09-04 Thread GitBox
adriancole commented on issue #5977: URL: https://github.com/apache/incubator-pinot/issues/5977#issuecomment-686971197 FYI here is a work around. I can help next week https://github.com/hypertrace/pinot/pull/28 This is an a

[GitHub] [incubator-pinot] kishoreg commented on pull request #5979: Improve test coverage for TransformFunctionType

2020-09-04 Thread GitBox
kishoreg commented on pull request #5979: URL: https://github.com/apache/incubator-pinot/pull/5979#issuecomment-687016624 Thanks for your contribution! This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-pinot] QiAnXinCodeSafe opened a new issue #5980: Unreleased Resource: Streams

2020-09-04 Thread GitBox
QiAnXinCodeSafe opened a new issue #5980: URL: https://github.com/apache/incubator-pinot/issues/5980 https://github.com/apache/incubator-pinot/blob/6640affe5b2ac6bc0a972c7a9e291c1d5189effb/thirdeye/thirdeye-hadoop/src/main/java/org/apache/pinot/thirdeye/hadoop/backfill/BackfillControllerAPI

[GitHub] [incubator-pinot] shahsank3t opened a new pull request #5981: Support for Update & Delete in ZooKeeper Browser and added SQL Functions in SQL Editor autocomplete list

2020-09-04 Thread GitBox
shahsank3t opened a new pull request #5981: URL: https://github.com/apache/incubator-pinot/pull/5981 ## Description Added support for Update & Delete in Zookeeper Browser. ![image](https://user-images.githubusercontent.com/6761317/92245823-83d4c380-eee2-11ea-8ab3-314a2ac78941.png)

[GitHub] [incubator-pinot] mr-agrwal opened a new issue #5982: Upgrade Pinot Docker to Java 11 (LTS) from current Java 8

2020-09-04 Thread GitBox
mr-agrwal opened a new issue #5982: URL: https://github.com/apache/incubator-pinot/issues/5982 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-pinot] yupeng9 commented on pull request #5967: Adding push job type of segment metadata only mode

2020-09-04 Thread GitBox
yupeng9 commented on pull request #5967: URL: https://github.com/apache/incubator-pinot/pull/5967#issuecomment-687256508 > > Curious, why is this mode needed? Could this lead to inconsistency between metadata and segments? > > This mode should be used in caution. > We observed for

[GitHub] [incubator-pinot] npawar commented on pull request #5966: Validate timeColumnName when adding/updating schema/tableConfig

2020-09-04 Thread GitBox
npawar commented on pull request #5966: URL: https://github.com/apache/incubator-pinot/pull/5966#issuecomment-687284187 > We do allow to have tables without a schema. I have not had the time to go through this fully, but do you account for the fact that a (offline) table may not have a sch

[incubator-pinot] branch master updated: [TE] Adding Holiday Events in helm chart (#5976)

2020-09-04 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 107ec3f [TE] Adding Holiday Events in

[GitHub] [incubator-pinot] apucher merged pull request #5976: [TE] Adding Holiday Events in helm chart

2020-09-04 Thread GitBox
apucher merged pull request #5976: URL: https://github.com/apache/incubator-pinot/pull/5976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-pinot] branch remove-host-from-swagger created (now 6fdae11)

2020-09-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch remove-host-from-swagger in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 6fdae11 Remove host from swagger setting This branch includes the following new commits:

[incubator-pinot] 01/01: Remove host from swagger setting

2020-09-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch remove-host-from-swagger in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 6fdae114f53b86c3bf19363ef3886d6720330446 Author: Jack Li(Analytics Engineering) AuthorDate: Fri

[GitHub] [incubator-pinot] jackjlli opened a new pull request #5983: Remove host from swagger setting

2020-09-04 Thread GitBox
jackjlli opened a new pull request #5983: URL: https://github.com/apache/incubator-pinot/pull/5983 ## Description This PR removed the host from swagger setting. This allows us to open two controllers in the same machine and send request respectively. ---

[incubator-pinot] branch master updated: Remove host from swagger setting (#5983)

2020-09-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 6d8ea75 Remove host from swagger setting

[GitHub] [incubator-pinot] jackjlli merged pull request #5983: Remove host from swagger setting

2020-09-04 Thread GitBox
jackjlli merged pull request #5983: URL: https://github.com/apache/incubator-pinot/pull/5983 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5893: Support for segmentPartitionedDistinctCount in Star Tree Index Pre aggregation Functions.

2020-09-04 Thread GitBox
Jackie-Jiang commented on issue #5893: URL: https://github.com/apache/incubator-pinot/issues/5893#issuecomment-687324697 > In the intermediate star-tree nodes, we should be able to store the final results. You mean the long values? There is no way to aggregate them inside the segme

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5979: Improve test coverage for TransformFunctionType

2020-09-04 Thread GitBox
Jackie-Jiang merged pull request #5979: URL: https://github.com/apache/incubator-pinot/pull/5979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[incubator-pinot] branch master updated: Improve test coverage for TransformFunctionType (#5979)

2020-09-04 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 8900ebb Improve test coverage for Tran

[incubator-pinot] branch add-row-based-schema-validator created (now 98216c7)

2020-09-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-row-based-schema-validator in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 98216c7 Add row based schema validation code to detect schema mismatch This branch i

[incubator-pinot] 01/01: Add row based schema validation code to detect schema mismatch

2020-09-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch add-row-based-schema-validator in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 98216c725bd1bec72db2cbab4ac2b12d7ff237bf Author: Jack Li(Analytics Engineering) AuthorDat

[GitHub] [incubator-pinot] jackjlli opened a new pull request #5984: Add row based schema validation code to detect schema mismatch

2020-09-04 Thread GitBox
jackjlli opened a new pull request #5984: URL: https://github.com/apache/incubator-pinot/pull/5984 ## Description This PR adds row based schema validation code to detect schema mismatch. This validation will capture the schema mismatch on row basis, so that we don't miss any cases

[GitHub] [incubator-pinot] fx19880617 closed issue #5968: New Swagger UI blocks access from container port forwarding or remote access

2020-09-04 Thread GitBox
fx19880617 closed issue #5968: URL: https://github.com/apache/incubator-pinot/issues/5968 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] fx19880617 commented on issue #5968: New Swagger UI blocks access from container port forwarding or remote access

2020-09-04 Thread GitBox
fx19880617 commented on issue #5968: URL: https://github.com/apache/incubator-pinot/issues/5968#issuecomment-687334722 Thanks @jackjlli for quick fix in https://github.com/apache/incubator-pinot/pull/5983 This is an automa

[GitHub] [incubator-pinot] suvodeep-pyne opened a new pull request #5985: [TE] Add ingress, traefik to helm chart

2020-09-04 Thread GitBox
suvodeep-pyne opened a new pull request #5985: URL: https://github.com/apache/incubator-pinot/pull/5985 This change was previously reverted. However, turns out that this provides the user more flexibility in installation. Changes - Added an (conditional) ingress - Added traefik

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5962: [TE] Severity based alerter

2020-09-04 Thread GitBox
vincentchenjl commented on a change in pull request #5962: URL: https://github.com/apache/incubator-pinot/pull/5962#discussion_r483806658 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java ## @@ -570,4 +574,19 @@ publ

[incubator-pinot] branch add-row-based-schema-validator updated (98216c7 -> fe64f56)

2020-09-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-row-based-schema-validator in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 98216c7 Add row based schema validation code to detect schema mismatch add fe64f

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5934: Segment processing framework

2020-09-04 Thread GitBox
npawar commented on a change in pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r483874738 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/partitioner/PartitionerFactory.java ## @@ -0,0 +1,82 @@ +/** + * L

[incubator-pinot] branch add-row-based-schema-validator updated (fe64f56 -> ae94529)

2020-09-04 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-row-based-schema-validator in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard fe64f56 Add row based schema validation code to detect schema mismatch add ae945

[GitHub] [incubator-pinot] npawar commented on a change in pull request #5934: Segment processing framework

2020-09-04 Thread GitBox
npawar commented on a change in pull request #5934: URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r483876019 ## File path: pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentReducer.java ## @@ -0,0 +1,151 @@ +/** + * Licens

[GitHub] [incubator-pinot] bradengroom opened a new pull request #5986: Improve code coverage for pinot-common

2020-09-04 Thread GitBox
bradengroom opened a new pull request #5986: URL: https://github.com/apache/incubator-pinot/pull/5986 ## Description This adds some tests for uncovered lines in `pinot/common/function` and updates `.codecov.yml` to ignore all generated files in `pinot/common/request`. -

[GitHub] [incubator-pinot] bradengroom commented on a change in pull request #5986: Improve code coverage for pinot-common

2020-09-04 Thread GitBox
bradengroom commented on a change in pull request #5986: URL: https://github.com/apache/incubator-pinot/pull/5986#discussion_r483909440 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/AggregationFunctionType.java ## @@ -75,15 +75,6 @@ public String ge

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5986: Improve code coverage for pinot-common

2020-09-04 Thread GitBox
codecov-commenter commented on pull request #5986: URL: https://github.com/apache/incubator-pinot/pull/5986#issuecomment-687552085 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5986?src=pr&el=h1) Report > Merging [#5986](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5986: Improve code coverage for pinot-common

2020-09-04 Thread GitBox
codecov-commenter edited a comment on pull request #5986: URL: https://github.com/apache/incubator-pinot/pull/5986#issuecomment-687552085 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5986?src=pr&el=h1) Report > Merging [#5986](https://codecov.io/gh/apache/incubator-pin

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5986: Improve code coverage for pinot-common

2020-09-04 Thread GitBox
codecov-commenter edited a comment on pull request #5986: URL: https://github.com/apache/incubator-pinot/pull/5986#issuecomment-687552085 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5986?src=pr&el=h1) Report > Merging [#5986](https://codecov.io/gh/apache/incubator-pin