fx19880617 commented on issue #6003:
URL:
https://github.com/apache/incubator-pinot/issues/6003#issuecomment-690914135
S3PinotFs is fixed in #6002
This is an automated message from the Apache Git Service.
To respond to
fx19880617 opened a new issue #6003:
URL: https://github.com/apache/incubator-pinot/issues/6003
Per https://github.com/apache/incubator-pinot/pull/6002, S3 has a limit on
each ListObject call response. I think this policy may also be true for other
blob store.
This issue is created
kishoreg commented on a change in pull request #6002:
URL: https://github.com/apache/incubator-pinot/pull/6002#discussion_r486810483
##
File path:
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java
##
@@ -374,33 +375,39 @@
fx19880617 commented on pull request #6002:
URL: https://github.com/apache/incubator-pinot/pull/6002#issuecomment-690912063
We should also review other PinotFs implementations to ensure the similar
issues are not presenting there.
--
fx19880617 opened a new pull request #6002:
URL: https://github.com/apache/incubator-pinot/pull/6002
## Description
S3 API has a bounded limit(1000) for the objects returned in ListObject API,
which means each call may at most returned 1000 S3 objects.
This PR will check `ListObje
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch fixing_s3_list_api
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 86659186e8e2196b199a5c2bb011dd560a5a524f
Author: Xiang Fu
AuthorDate: Thu Sep 10 23:38:37 2020 -07
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_s3_list_api
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 8665918 Fix S3PinotFS List API may not return full results
This branch includes the following
fx19880617 commented on pull request #5917:
URL: https://github.com/apache/incubator-pinot/pull/5917#issuecomment-690867454
Right, this PR will be included in next release(0.6.0)
This is an automated message from the Apache G
kishoreg merged pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
kishoreg pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from e0ed179 Validate timeColumnName when adding/updating
schema/tableConfig (#5966)
add 0c1d604 [TE] M
adriancole commented on pull request #5917:
URL: https://github.com/apache/incubator-pinot/pull/5917#issuecomment-690859024
PS this seems it didn't make it to 0.5.0. Can it be added to the next
release after that? It will help to not be perpetually on snapshots
---
suvodeep-pyne commented on pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#issuecomment-690852472
Thanks a lot @akshayrai !
This is an automated message from the Apache Git Service.
To respond to
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486700161
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java
##
@@ -0,0 +1,194 @@
+/**
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486699922
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorConfig.java
##
@@ -0,0 +1,181 @@
+/**
+
suvodeep-pyne commented on pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#issuecomment-690791054
Thanks a lot @akshayrai
Let me know if you have any other concerns.
This is an automated messa
suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486691580
##
File path: thirdeye/pom.xml
##
@@ -22,17 +22,18 @@
4.0.0
org.apache.pinot.thirdeye
thirdeye
- ${revision}${sha1}
Review commen
suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486691580
##
File path: thirdeye/pom.xml
##
@@ -22,17 +22,18 @@
4.0.0
org.apache.pinot.thirdeye
thirdeye
- ${revision}${sha1}
Review commen
suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486692447
##
File path: thirdeye/pom.xml
##
@@ -543,6 +550,17 @@
log4j-slf4j-impl
${log4j2.version}
+
+org.apa
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486692906
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/partitioner/TableConfigPartitioner.java
##
@@ -0,0 +1,45 @@
+/**
+
suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486692492
##
File path:
thirdeye/thirdeye-spi/src/main/java/org/apache/pinot/thirdeye/datalayer/pojo/AlertConfigBean.java
##
@@ -211,7 +211,7 @@ publ
suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486692447
##
File path: thirdeye/pom.xml
##
@@ -543,6 +550,17 @@
log4j-slf4j-impl
${log4j2.version}
+
+org.apa
suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486692006
##
File path: thirdeye/pom.xml
##
@@ -22,17 +22,18 @@
4.0.0
org.apache.pinot.thirdeye
thirdeye
- ${revision}${sha1}
+ 0.1.0-SNAPS
suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486691580
##
File path: thirdeye/pom.xml
##
@@ -22,17 +22,18 @@
4.0.0
org.apache.pinot.thirdeye
thirdeye
- ${revision}${sha1}
Review commen
suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486691075
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/dto/OnlineDetectionDataDTO.java
##
@@ -1,6 +0,0 @@
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486690778
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/partitioner/ColumnValuePartitioner.java
##
@@ -0,0 +1,39 @@
+/**
+
suvodeep-pyne commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486690825
##
File path:
thirdeye/thirdeye-spi/src/main/java/org/apache/pinot/thirdeye/datalayer/dto/AlertSnapshotDTO.java
##
@@ -80,48 +75,6 @@ publi
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486683841
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/partitioner/NoOpPartitioner.java
##
@@ -0,0 +1,32 @@
+/**
+ * Lice
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486683505
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/collector/RollupCollector.java
##
@@ -0,0 +1,159 @@
+/**
+ * Licen
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486677843
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/collector/Collector.java
##
@@ -0,0 +1,55 @@
+/**
+ * Licensed to
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486676878
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/utils/SegmentProcessorUtils.java
##
@@ -0,0 +1,113 @@
+/**
+ * Lic
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486673217
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorConfig.java
##
@@ -0,0 +1,181 @@
+/**
+
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486672513
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/collector/CollectorConfig.java
##
@@ -0,0 +1,103 @@
+/**
+ * Licen
npawar commented on a change in pull request #5934:
URL: https://github.com/apache/incubator-pinot/pull/5934#discussion_r486657189
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/collector/ValueAggregator.java
##
@@ -16,7 +16,7 @@
* specific l
fx19880617 merged pull request #5987:
URL: https://github.com/apache/incubator-pinot/pull/5987
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
npawar closed issue #5915:
URL: https://github.com/apache/incubator-pinot/issues/5915
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
npawar merged pull request #5966:
URL: https://github.com/apache/incubator-pinot/pull/5966
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e0ed179 Validate timeColumnName whe
akshayrai opened a new pull request #6001:
URL: https://github.com/apache/incubator-pinot/pull/6001
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
npawar commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r486601450
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java
##
@@ -318,4 +324,19 @@ pri
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 462cf57 [TE] adding back metricUrn in AnomalyFilterWrapper.run()
(#5999)
add 41f3a94 upgrade to jav
icefury71 commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r486588035
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/util/SchemaUtilsTest.java
##
@@ -35,6 +43,115 @@
*/
public class SchemaUtilsTes
akshayrai commented on a change in pull request #5991:
URL: https://github.com/apache/incubator-pinot/pull/5991#discussion_r486578318
##
File path:
thirdeye/thirdeye-spi/src/main/java/org/apache/pinot/thirdeye/datalayer/pojo/AlertConfigBean.java
##
@@ -211,7 +211,7 @@ public S
Jackie-Jiang commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r486562121
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java
##
@@ -318,4 +324,19
fx19880617 opened a new issue #6000:
URL: https://github.com/apache/incubator-pinot/issues/6000
Current controller `/brokers` APIs only returns instance id and expect
instance is in the format of `ROLE_HOSTNAME_PORT`, however this is not the
right thing any more.
So we propose the new `
jihaozh merged pull request #5999:
URL: https://github.com/apache/incubator-pinot/pull/5999
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from e0f8c11 Add ingestion descriptor in the header (#5995)
add 462cf57 [TE] adding back metricUrn in Anoma
vincentchenjl opened a new pull request #5999:
URL: https://github.com/apache/incubator-pinot/pull/5999
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
npawar commented on issue #5928:
URL:
https://github.com/apache/incubator-pinot/issues/5928#issuecomment-690594852
`A Pravega stream comprises a set of parallel segments, and that set can
change over time according to a scaling policy` - is "set of segments" like
partitions within the str
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e0f8c11 Add ingestion descriptor in the
jackjlli merged pull request #5995:
URL: https://github.com/apache/incubator-pinot/pull/5995
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
fx19880617 opened a new issue #5998:
URL: https://github.com/apache/incubator-pinot/issues/5998
We already have table level and per segment level stats right now.
The next question here is that what's the per column level information/stats
we can expose.
One typical question i
icefury71 commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r486512420
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java
##
@@ -171,7 +173,8 @@ p
jihaozh commented on a change in pull request #5972:
URL: https://github.com/apache/incubator-pinot/pull/5972#discussion_r486511634
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/AnomalyFilterWrapper.java
##
@@ -81,21 +80,7 @@ p
npawar commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r486497471
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java
##
@@ -171,7 +173,8 @@ publ
npawar commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r486488972
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java
##
@@ -171,7 +173,8 @@ publ
fx19880617 merged pull request #5997:
URL: https://github.com/apache/incubator-pinot/pull/5997
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from b2fa2ca Add 0.5 to website. (#5996)
add 473353d Fixing website doc hyper links (#5997)
No new revis
npawar commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r486484365
##
File path:
pinot-core/src/test/java/org/apache/pinot/core/util/SchemaUtilsTest.java
##
@@ -35,6 +43,115 @@
*/
public class SchemaUtilsTest {
npawar commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r486480697
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##
@@ -74,19 +80,37 @@ public static void validateTableNam
fx19880617 opened a new pull request #5997:
URL: https://github.com/apache/incubator-pinot/pull/5997
## Description
Fixing the hyperlinks in `docs/misc/build-docker.md`
This is an automated message from the Apache Git Ser
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch fixing_doc_link
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 5804663f1d853b95cff437ce53d1c8ced7191469
Author: Xiang Fu
AuthorDate: Thu Sep 10 00:38:10 2020 -0700
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch fixing_doc_link
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 5804663 Fixing website doc hyper links
This branch includes the following new commits:
new
62 matches
Mail list logo