This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch throw-exception-when-column-mismatch
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 7c6b34e Address PR comments
add 1c01c8b Address PR comments
This update
codecov-io edited a comment on pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#issuecomment-707475996
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6044?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#issuecomment-707475996
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6044?src=pr=h1)
Report
> Merging
yupeng9 commented on a change in pull request #6113:
URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r503668532
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##
@@ -132,6 +146,19 @@
codecov-io edited a comment on pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#issuecomment-707475996
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6044?src=pr=h1)
Report
> Merging
codecov-io commented on pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#issuecomment-707475996
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6044?src=pr=h1)
Report
> Merging
mayankshriv commented on a change in pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503640614
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
##
@@ -231,58 +239,130 @@ private
mayankshriv commented on a change in pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503640236
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
##
@@ -231,58 +239,130 @@ private
mayankshriv commented on a change in pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503637782
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -47,8 +57,32 @@
@ThreadSafe
mayankshriv commented on a change in pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503637680
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/BrokerReduceService.java
##
@@ -47,8 +57,32 @@
@ThreadSafe
mayankshriv commented on a change in pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503636090
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##
@@ -166,6 +166,11 @@
public static final
mayankshriv commented on a change in pull request #6044:
URL: https://github.com/apache/incubator-pinot/pull/6044#discussion_r503635525
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -102,7 +102,7 @@
npawar commented on a change in pull request #6094:
URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r503600877
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/mergestrategy/MergeStrategy.java
##
@@ -0,0 +1,28 @@
codecov-io edited a comment on pull request #6066:
URL: https://github.com/apache/incubator-pinot/pull/6066#issuecomment-707443440
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6066?src=pr=h1)
Report
> Merging
codecov-io commented on pull request #6066:
URL: https://github.com/apache/incubator-pinot/pull/6066#issuecomment-707443440
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6066?src=pr=h1)
Report
> Merging
vincentchenjl opened a new pull request #6135:
URL: https://github.com/apache/incubator-pinot/pull/6135
This PR is to fix the failure when maven runs `maven-assembly-plugin` before
the `maven-shade-plugin`, which causes that maven cannot find
`thirdeye-dashboard-1.0.0-SNAPSHOT.jar` for
jackjlli commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-pinot/pull/6066#discussion_r503610443
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -769,94 +786,133 @@ private
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch throw-exception-when-column-mismatch
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard bb210aa Address PR comments
add 7c6b34e Address PR comments
This update
jackjlli commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-pinot/pull/6066#discussion_r503610423
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -769,94 +786,133 @@ private
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch throw-exception-when-column-mismatch
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 16167e9 Add warn level message and emit metric if this behavior
detected
jihaozh merged pull request #6097:
URL: https://github.com/apache/incubator-pinot/pull/6097
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 6275818 Fix superset docker image build script (#5965)
add 86ce7c6 [TE] Fix Thirdeye Maven publish
mcvsubbu commented on a change in pull request #6124:
URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r503594418
##
File path:
pinot-minion/src/main/java/org/apache/pinot/minion/executor/PinotTaskExecutor.java
##
@@ -26,6 +26,12 @@
*/
public interface
Jackie-Jiang commented on a change in pull request #6125:
URL: https://github.com/apache/incubator-pinot/pull/6125#discussion_r503583619
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java
##
@@ -62,73 +63,73
codecov-io edited a comment on pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#issuecomment-704563263
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6112?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#issuecomment-704563263
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6112?src=pr=h1)
Report
> Merging
mcvsubbu commented on a change in pull request #6124:
URL: https://github.com/apache/incubator-pinot/pull/6124#discussion_r503580109
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/RealtimeToOfflineSegmentsTaskGenerator.java
codecov-io edited a comment on pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#issuecomment-704563263
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6112?src=pr=h1)
Report
> Merging
codecov-io edited a comment on pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#issuecomment-704563263
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6112?src=pr=h1)
Report
> Merging
mcvsubbu commented on a change in pull request #6113:
URL: https://github.com/apache/incubator-pinot/pull/6113#discussion_r503515858
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##
@@ -132,6 +146,19 @@
deemoliu commented on a change in pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503563957
##
File path:
pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java
##
@@ -80,6 +80,18 @@ public void testFieldSpec() {
chenboat commented on a change in pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503563222
##
File path:
pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java
##
@@ -80,6 +80,18 @@ public void testFieldSpec() {
deemoliu commented on a change in pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503562057
##
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java
##
@@ -499,6 +499,15 @@ public SchemaBuilder
mcvsubbu commented on issue #6121:
URL:
https://github.com/apache/incubator-pinot/issues/6121#issuecomment-707370550
Follow up discussion in slack
This is an automated message from the Apache Git Service.
To respond to the
deemoliu commented on a change in pull request #6112:
URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503541176
##
File path:
pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java
##
@@ -80,6 +80,18 @@ public void testFieldSpec() {
codecov-io edited a comment on pull request #6134:
URL: https://github.com/apache/incubator-pinot/pull/6134#issuecomment-707351920
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6134?src=pr=h1)
Report
> Merging
codecov-io commented on pull request #6134:
URL: https://github.com/apache/incubator-pinot/pull/6134#issuecomment-707351920
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6134?src=pr=h1)
Report
> Merging
fx19880617 opened a new pull request #6134:
URL: https://github.com/apache/incubator-pinot/pull/6134
## Description
- Adding a flag in PinotServiceManager to allow health check includes all
components health check
This
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch pinotSM_flag_for_health_check
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 0141965 Adding a flag in PinotServiceManager to allow health check
includes all
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch pinotSM_flag_for_health_check
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 01419655e077675768a9e641258a8313be767b13
Author: Xiang Fu
AuthorDate: Mon Oct 12
Jackie-Jiang commented on pull request #6022:
URL: https://github.com/apache/incubator-pinot/pull/6022#issuecomment-707302712
> Why do we need a transform function to support subquery? Can we use the
standard SQL syntax of providing the subquery inside parentheses to clearly
distinguish
codecov-io edited a comment on pull request #6133:
URL: https://github.com/apache/incubator-pinot/pull/6133#issuecomment-707295123
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6133?src=pr=h1)
Report
> Merging
codecov-io commented on pull request #6133:
URL: https://github.com/apache/incubator-pinot/pull/6133#issuecomment-707295123
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6133?src=pr=h1)
Report
> Merging
npawar opened a new pull request #6133:
URL: https://github.com/apache/incubator-pinot/pull/6133
It seems the order returned in File#listFiles() is not guaranteed. The
results of this test change depending on the order of the files returned in
File#listFiles(). We received some
sajjad-moradi commented on a change in pull request #6129:
URL: https://github.com/apache/incubator-pinot/pull/6129#discussion_r503462097
##
File path: compatibility-verifier/compCheck.sh
##
@@ -157,20 +181,27 @@ fi
# Setup initial cluster with olderCommit and do rolling
sajjad-moradi commented on a change in pull request #6129:
URL: https://github.com/apache/incubator-pinot/pull/6129#discussion_r503461466
##
File path: compatibility-verifier/compCheck.sh
##
@@ -157,20 +181,27 @@ fi
# Setup initial cluster with olderCommit and do rolling
mcvsubbu opened a new issue #6132:
URL: https://github.com/apache/incubator-pinot/issues/6132
We see this occasionally:
Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.924 sec
<<< FAILURE! - in
org.apache.pinot.core.segment.processing.framework.SegmentReducerTest
fx19880617 commented on a change in pull request #6131:
URL: https://github.com/apache/incubator-pinot/pull/6131#discussion_r503389188
##
File path: Dockerfile.jdk14
##
@@ -0,0 +1,74 @@
+#
Review comment:
should you put this under thirdeye/docker ?
adriancole commented on pull request #6039:
URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-707063779
functionally, this works if the "add table" commands are done last (because
effectively, you end up needing to wait for everything anyway). Verified here
venkatvghub opened a new pull request #6131:
URL: https://github.com/apache/incubator-pinot/pull/6131
## Description
- Adds drone.yml
- Adds support for java 11+
- Updates mysql connector to 8+
- Adds custom Docker file for above changes
venkatvghub closed pull request #6130:
URL: https://github.com/apache/incubator-pinot/pull/6130
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
venkatvghub commented on pull request #6130:
URL: https://github.com/apache/incubator-pinot/pull/6130#issuecomment-707011270
Invalid
This is an automated message from the Apache Git Service.
To respond to the message, please
venkatvghub opened a new pull request #6130:
URL: https://github.com/apache/incubator-pinot/pull/6130
## Description
- Merges from upstream master
- Adds support for drone, JDK 14 and Mysql 8
## Documentation
If you have introduced a new feature or configuration, please add it
adriancole commented on pull request #6039:
URL: https://github.com/apache/incubator-pinot/pull/6039#issuecomment-706963614
nagging https://github.com/apache/incubator-pinot/issues/5975 as ran into it
again.
This is an
54 matches
Mail list logo