[GitHub] [pinot] kkrugler commented on pull request #7400: Fix classpath with plugins java 8

2021-09-20 Thread GitBox
kkrugler commented on pull request #7400: URL: https://github.com/apache/pinot/pull/7400#issuecomment-923095379 Bump - hoping this fix can get rolled in before the next release of Pinot. Note other users posting on Slack about what I think is the same problem. -- This is an automated mes

[GitHub] [pinot] walterddr commented on a change in pull request #7114: Support REGEXP_EXTRACT

2021-09-20 Thread GitBox
walterddr commented on a change in pull request #7114: URL: https://github.com/apache/pinot/pull/7114#discussion_r712353579 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/RegexpExtractTransformFunction.java ## @@ -0,0 +1,116 @@ +/** +

[GitHub] [pinot] mayankshriv commented on a change in pull request #7400: Fix classpath with plugins java 8

2021-09-20 Thread GitBox
mayankshriv commented on a change in pull request #7400: URL: https://github.com/apache/pinot/pull/7400#discussion_r712354124 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginClassLoader.java ## @@ -31,27 +32,53 @@ public class PluginClassLoader extends

[GitHub] [pinot] MeihanLi opened a new issue #7453: Unclear query response to debug JSON_MATCH on one column without json index

2021-09-20 Thread GitBox
MeihanLi opened a new issue #7453: URL: https://github.com/apache/pinot/issues/7453 Hi, the Pinot Controller query response is unclear to show the root cause when we use JSON_MATCH on one column without proper json index. However, we can find more information from server logs. It is good t

[GitHub] [pinot] jackjlli commented on a change in pull request #7267: Offset based realtime consumption status checker

2021-09-20 Thread GitBox
jackjlli commented on a change in pull request #7267: URL: https://github.com/apache/pinot/pull/7267#discussion_r712379434 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -1363,6 +1369,16 @@ public LLRe

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7114: Support REGEXP_EXTRACT

2021-09-20 Thread GitBox
codecov-commenter edited a comment on pull request #7114: URL: https://github.com/apache/pinot/pull/7114#issuecomment-872439509 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7114?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] sajjad-moradi commented on a change in pull request #7267: Offset based realtime consumption status checker

2021-09-20 Thread GitBox
sajjad-moradi commented on a change in pull request #7267: URL: https://github.com/apache/pinot/pull/7267#discussion_r712390764 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java ## @@ -236,13 +242,27 @@ public synchronized Status getServ

[GitHub] [pinot] sajjad-moradi commented on a change in pull request #7267: Offset based realtime consumption status checker

2021-09-20 Thread GitBox
sajjad-moradi commented on a change in pull request #7267: URL: https://github.com/apache/pinot/pull/7267#discussion_r712393126 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -1363,6 +1369,16 @@ public

[GitHub] [pinot] sajjad-moradi commented on a change in pull request #7267: Offset based realtime consumption status checker

2021-09-20 Thread GitBox
sajjad-moradi commented on a change in pull request #7267: URL: https://github.com/apache/pinot/pull/7267#discussion_r712396354 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/helix/OffsetBasedConsumptionStatusChecker.java ## @@ -0,0 +1,114 @@ +/** + *

[pinot] branch master updated: Offset based realtime consumption status checker (#7267)

2021-09-20 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 53cfdf3 Offset based realtime consumption status c

[GitHub] [pinot] jackjlli merged pull request #7267: Offset based realtime consumption status checker

2021-09-20 Thread GitBox
jackjlli merged pull request #7267: URL: https://github.com/apache/pinot/pull/7267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7450: Unify CombineOperator multi-threading logic

2021-09-20 Thread GitBox
Jackie-Jiang commented on a change in pull request #7450: URL: https://github.com/apache/pinot/pull/7450#discussion_r712426897 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByOrderByCombineOperator.java ## @@ -125,43 +123,44 @@ public Strin

[pinot] branch master updated (53cfdf3 -> b990c57)

2021-09-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 53cfdf3 Offset based realtime consumption status checker (#7267) add b990c57 Support REGEXP_EXTRACT (#7114) No

[GitHub] [pinot] Jackie-Jiang merged pull request #7114: Support REGEXP_EXTRACT

2021-09-20 Thread GitBox
Jackie-Jiang merged pull request #7114: URL: https://github.com/apache/pinot/pull/7114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[pinot] branch master updated (b990c57 -> fabda2b)

2021-09-20 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from b990c57 Support REGEXP_EXTRACT (#7114) add fabda2b create pinot-integration-test-base module test-jar (#7399)

[GitHub] [pinot] Jackie-Jiang merged pull request #7399: create pinot-integration-test-base module test-jar

2021-09-20 Thread GitBox
Jackie-Jiang merged pull request #7399: URL: https://github.com/apache/pinot/pull/7399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] npawar commented on issue #7168: I am not able to manage offline flows ( from realtime to offline)

2021-09-20 Thread GitBox
npawar commented on issue #7168: URL: https://github.com/apache/pinot/issues/7168#issuecomment-923219725 Closing this issue as there's been no activity for > 2 months. Also I believe there have been discussions on the Slack channel about this. Please reopen if issue still exists. -- Thi

[GitHub] [pinot] npawar closed issue #7168: I am not able to manage offline flows ( from realtime to offline)

2021-09-20 Thread GitBox
npawar closed issue #7168: URL: https://github.com/apache/pinot/issues/7168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] richardstartin commented on a change in pull request #7450: Unify CombineOperator multi-threading logic

2021-09-20 Thread GitBox
richardstartin commented on a change in pull request #7450: URL: https://github.com/apache/pinot/pull/7450#discussion_r712463571 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByOrderByCombineOperator.java ## @@ -125,43 +123,44 @@ public Str

[GitHub] [pinot] richardstartin commented on a change in pull request #7450: Unify CombineOperator multi-threading logic

2021-09-20 Thread GitBox
richardstartin commented on a change in pull request #7450: URL: https://github.com/apache/pinot/pull/7450#discussion_r712465217 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByOrderByCombineOperator.java ## @@ -125,43 +123,44 @@ public Str

[GitHub] [pinot] richardstartin opened a new pull request #7454: bit-sliced index for int, long SV columns

2021-09-20 Thread GitBox
richardstartin opened a new pull request #7454: URL: https://github.com/apache/pinot/pull/7454 ## Description This isn't complete yet (the `float` and `double` to `long` mapping isn't properly defined yet, and MV column support won't be implemented in this PR, but this open for visi

[GitHub] [pinot] Jackie-Jiang commented on issue #7448: Support stateful ScalarFunction

2021-09-20 Thread GitBox
Jackie-Jiang commented on issue #7448: URL: https://github.com/apache/pinot/issues/7448#issuecomment-923282158 Great proposal! Currently the scalar function class is actually stateful (one instance of class in the `FunctionInvoker`). We do have a test for that (see `InbuiltFunctionEvalu

[pinot] branch exclude-healthcheck-from-auth created (now 72e1ca5)

2021-09-20 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch exclude-healthcheck-from-auth in repository https://gitbox.apache.org/repos/asf/pinot.git. at 72e1ca5 exclude healthcheck endpoint from auth This branch includes the following new commit

[pinot] 01/01: exclude healthcheck endpoint from auth

2021-09-20 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch exclude-healthcheck-from-auth in repository https://gitbox.apache.org/repos/asf/pinot.git commit 72e1ca5ee2b2a005a5189de3c834d9d625123bf4 Author: Alexander Pucher AuthorDate: Mon Sep 20 13:43:14

[GitHub] [pinot] apucher opened a new pull request #7455: exclude healthcheck endpoint from auth

2021-09-20 Thread GitBox
apucher opened a new pull request #7455: URL: https://github.com/apache/pinot/pull/7455 ## Description Fixes the omission of the `/health` endpoint in unprotected paths. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, S

[GitHub] [pinot] richardstartin commented on a change in pull request #7454: bit-sliced index for int, long SV columns

2021-09-20 Thread GitBox
richardstartin commented on a change in pull request #7454: URL: https://github.com/apache/pinot/pull/7454#discussion_r712536121 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java ## @@ -304,6 +306,13 @@

[GitHub] [pinot] richardstartin commented on a change in pull request #7450: Unify CombineOperator multi-threading logic

2021-09-20 Thread GitBox
richardstartin commented on a change in pull request #7450: URL: https://github.com/apache/pinot/pull/7450#discussion_r712465217 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByOrderByCombineOperator.java ## @@ -125,43 +123,44 @@ public Str

[GitHub] [pinot] apucher merged pull request #7455: exclude healthcheck endpoint from auth

2021-09-20 Thread GitBox
apucher merged pull request #7455: URL: https://github.com/apache/pinot/pull/7455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pinot] branch master updated (fabda2b -> 2c74f20)

2021-09-20 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from fabda2b create pinot-integration-test-base module test-jar (#7399) add 2c74f20 exclude healthcheck endpoint f

[GitHub] [pinot] richardstartin commented on a change in pull request #7454: bit-sliced index for int, long SV columns

2021-09-20 Thread GitBox
richardstartin commented on a change in pull request #7454: URL: https://github.com/apache/pinot/pull/7454#discussion_r712556088 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ## @@ -0,0 +

[GitHub] [pinot] richardstartin commented on a change in pull request #7454: bit-sliced index for int, long SV columns

2021-09-20 Thread GitBox
richardstartin commented on a change in pull request #7454: URL: https://github.com/apache/pinot/pull/7454#discussion_r712556493 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ## @@ -0,0 +

[GitHub] [pinot] codecov-commenter commented on pull request #7454: bit-sliced index for int, long SV columns

2021-09-20 Thread GitBox
codecov-commenter commented on pull request #7454: URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7450: Unify CombineOperator multi-threading logic

2021-09-20 Thread GitBox
Jackie-Jiang commented on a change in pull request #7450: URL: https://github.com/apache/pinot/pull/7450#discussion_r712606625 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByOrderByCombineOperator.java ## @@ -125,43 +123,44 @@ public Strin

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7454: bit-sliced index for int, long SV columns

2021-09-20 Thread GitBox
Jackie-Jiang commented on a change in pull request #7454: URL: https://github.com/apache/pinot/pull/7454#discussion_r712615224 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java ## @@ -0,0 +1,

[pinot] branch acquire_release created (now 0f3ff19)

2021-09-20 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a change to branch acquire_release in repository https://gitbox.apache.org/repos/asf/pinot.git. at 0f3ff19 Acquire-release This branch includes the following new commits: new 0f3ff19 Acquire-relea

[pinot] 01/01: Acquire-release

2021-09-20 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch acquire_release in repository https://gitbox.apache.org/repos/asf/pinot.git commit 0f3ff1918fafad93149406d4f61f1d21ee959fd8 Author: Neha Pawar AuthorDate: Mon Sep 20 20:16:17 2021 -0700 A

[GitHub] [pinot] amrishlal commented on issue #7437: Range Index Enhancement Proposal

2021-09-20 Thread GitBox
amrishlal commented on issue #7437: URL: https://github.com/apache/pinot/issues/7437#issuecomment-923691071 The proposal doc is very interesting reading. Thanks for creating it. I am still in the process of reading through it, but wanted to add a few points regarding the current RangeIndex