amrishlal edited a comment on issue #7437:
URL: https://github.com/apache/pinot/issues/7437#issuecomment-924631371
@mayankshriv @kishoreg I am also a strong +1 on this proposal :-) as this
appears to be a good approach. I didn't mean to imply in any way that this
should not be done. I was
richardstartin commented on a change in pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#discussion_r713637989
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
##
@@ -144,17 +153,29 @@ public static ProcessingExce
amrishlal edited a comment on issue #7437:
URL: https://github.com/apache/pinot/issues/7437#issuecomment-924631371
@mayankshriv @kishoreg I am also a strong +1 on this proposal :-) as this
appears to be a good approach. I didn't mean to imply in any way that this
should not be done. I was
amrishlal commented on issue #7437:
URL: https://github.com/apache/pinot/issues/7437#issuecomment-924631371
@mayankshriv @kishoreg I am also a strong +1 on this proposal :-) as this
appears to be a good approach. I didn't mean to imply in any way this should
not be done. I was just wonderi
atris commented on a change in pull request #7405:
URL: https://github.com/apache/pinot/pull/7405#discussion_r713604426
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/nativefst/ConstantArcSizeFST.java
##
@@ -0,0 +1,159 @@
+/**
+ * Licensed
Jackie-Jiang commented on a change in pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#discussion_r713499775
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
##
@@ -144,17 +153,29 @@ public static ProcessingExcept
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4972110 Unify CombineOperator multi-threading lo
Jackie-Jiang merged pull request #7450:
URL: https://github.com/apache/pinot/pull/7450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
Jackie-Jiang commented on a change in pull request #7450:
URL: https://github.com/apache/pinot/pull/7450#discussion_r713481255
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByOrderByCombineOperator.java
##
@@ -125,43 +119,41 @@ public Strin
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6976697 Update some usage of BatchConfig (#7459)
Jackie-Jiang merged pull request #7459:
URL: https://github.com/apache/pinot/pull/7459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
npawar commented on a change in pull request #7450:
URL: https://github.com/apache/pinot/pull/7450#discussion_r713458027
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByOrderByCombineOperator.java
##
@@ -125,43 +119,41 @@ public String getO
npawar commented on a change in pull request #7450:
URL: https://github.com/apache/pinot/pull/7450#discussion_r713457443
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByOrderByCombineOperator.java
##
@@ -125,43 +119,41 @@ public String getO
codecov-commenter edited a comment on pull request #7459:
URL: https://github.com/apache/pinot/pull/7459#issuecomment-924396286
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7459?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7459:
URL: https://github.com/apache/pinot/pull/7459#issuecomment-924396286
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7459?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7459:
URL: https://github.com/apache/pinot/pull/7459#issuecomment-924396286
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7459?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
walterddr commented on a change in pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#discussion_r713401822
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
##
@@ -154,7 +154,8 @@ public static String getTruncatedSt
walterddr commented on issue #7433:
URL: https://github.com/apache/pinot/issues/7433#issuecomment-924365636
this should be closed by #7458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
walterddr closed issue #7433:
URL: https://github.com/apache/pinot/issues/7433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 0f42295 fix manifest scan which drives /version endpoint (#7456)
add a3df342 Add additional override in Segment
Jackie-Jiang merged pull request #7458:
URL: https://github.com/apache/pinot/pull/7458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
Jackie-Jiang commented on a change in pull request #7460:
URL: https://github.com/apache/pinot/pull/7460#discussion_r713395547
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
##
@@ -154,7 +154,8 @@ public static String getTruncate
codecov-commenter edited a comment on pull request #7458:
URL: https://github.com/apache/pinot/pull/7458#issuecomment-924311133
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7458:
URL: https://github.com/apache/pinot/pull/7458#issuecomment-924311133
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7458:
URL: https://github.com/apache/pinot/pull/7458#issuecomment-924311133
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7450:
URL: https://github.com/apache/pinot/pull/7450#issuecomment-922169843
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7450?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7458:
URL: https://github.com/apache/pinot/pull/7458#issuecomment-924311133
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
walterddr opened a new pull request #7460:
URL: https://github.com/apache/pinot/pull/7460
should fix #7453 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
kishoreg commented on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-924295119
> Regarding the config (`IndexingConfig`), do you think it makes sense to
keep two separate lists for old value range index and new bit-sliced range
index? Users might want to mi
walterddr opened a new pull request #7459:
URL: https://github.com/apache/pinot/pull/7459
## Description
Looking at the usage of StreamConfig and BatchConfig. it seems like they
should be used as
- an internal representation after parsing the TableConfig class
- performs validatio
Jackie-Jiang commented on pull request #7450:
URL: https://github.com/apache/pinot/pull/7450#issuecomment-924256834
> BTW how did the coverage improve so much? I haven't fully understood the
Codecov reports yet.
I think it is caused by a recent master build test failure/cancellation.
walterddr opened a new pull request #7458:
URL: https://github.com/apache/pinot/pull/7458
## Description
Currently the `SegmentWriter` and `SegmentUploader` doesn't allow overrides
on top of TableConfig.
However, it looks like the `BatchConfig` construct is exactly built to allow
Jackie-Jiang commented on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-924247996
Regarding the config (`IndexingConfig`), do you think it makes sense to keep
two separate lists for old value range index and new bit-sliced range index?
Users might want to
Jackie-Jiang commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r713299682
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java
##
@@ -0,0 +1,171
Jackie-Jiang commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r713297152
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java
##
@@ -175,7 +17
walterddr commented on issue #7453:
URL: https://github.com/apache/pinot/issues/7453#issuecomment-924215406
looking at the exception returned via controller. it seems to repeat itself
3 times with the exact same message as the exception thrown from the server
side. The only difference is t
kkrugler commented on issue #7393:
URL: https://github.com/apache/pinot/issues/7393#issuecomment-924159735
@richardstartin - I don't know if you want to keep using this issue for
fixes/improvements to plugin classloading, so I haven't closed it. I would
favor a new issue that describes the
kkrugler commented on issue #7393:
URL: https://github.com/apache/pinot/issues/7393#issuecomment-924158376
See useful documentation on [Flink's
classloading](https://ci.apache.org/projects/flink/flink-docs-master/docs/ops/debugging/debugging_classloading/).
We don't yet support building se
kkrugler commented on issue #7457:
URL: https://github.com/apache/pinot/issues/7457#issuecomment-924153723
@richardstartin - wanted to mention this issue, for when you're looking into
the PluginClassLoader.
--
This is an automated message from the Apache Git Service.
To respond to the me
kkrugler opened a new issue #7457:
URL: https://github.com/apache/pinot/issues/7457
There's an issue with how the PluginManager (the only class using
PluginClassLoader) gets initialized. It has a static PluginManager variable
that uses system properties to locate classes to load, which is
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 0f42295 fix manifest scan which drives /version
mayankshriv closed issue #7449:
URL: https://github.com/apache/pinot/issues/7449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
mayankshriv merged pull request #7456:
URL: https://github.com/apache/pinot/pull/7456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
richardstartin commented on pull request #7456:
URL: https://github.com/apache/pinot/pull/7456#issuecomment-924139203
As per the description, since this logic depends on built jars, this is
quite difficult to test. One option would be to generate a jar file with a
MANIFEST.MF in it with "p
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 9224590 Fix classpath with plugins java 8 (#740
mayankshriv merged pull request #7400:
URL: https://github.com/apache/pinot/pull/7400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
richardstartin opened a new pull request #7456:
URL: https://github.com/apache/pinot/pull/7456
## Description
This fixes the manifest scan which drives the /version endpoint which
doesn't work on JDK11 (fixes #7449). The problem is that the application class
loader is no longer a `URLCl
codecov-commenter edited a comment on pull request #7400:
URL: https://github.com/apache/pinot/pull/7400#issuecomment-913222570
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7400?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
kishoreg commented on issue #7437:
URL: https://github.com/apache/pinot/issues/7437#issuecomment-924054486
@amrishlal I suggest reading the design doc in detail again.
The problem with any combination of approx filter and then scan to filter
again can have bad edge cases. Moreover, t
mayankshriv commented on pull request #7400:
URL: https://github.com/apache/pinot/pull/7400#issuecomment-924039182
Restarted tests to see if the failure was intermittent @kkrugler , will
approve and merge once all tests pass.
--
This is an automated message from the Apache Git Service.
T
mayankshriv commented on issue #7437:
URL: https://github.com/apache/pinot/issues/7437#issuecomment-924026665
@amrishlal Thanks for sharing your thoughts on the existing range index
impl. Do you have an implementation or numbers to compare with? From what I
understand, the proposal here is
richardstartin commented on pull request #7400:
URL: https://github.com/apache/pinot/pull/7400#issuecomment-923962965
@kkrugler I had a deeper look at this.
I think adding the URLs to `PluginClassLoader.class.getClassLoader()` is an
historical workaround for plugin classes being loa
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on pull request #7400:
URL: https://github.com/apache/pinot/pull/7400#issuecomment-923877662
@kkrugler sorry for dropping this, I am working on this today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on pull request #7450:
URL: https://github.com/apache/pinot/pull/7450#issuecomment-923858764
BTW how did the coverage improve so much? I haven't fully understood the
Codecov reports yet.
--
This is an automated message from the Apache Git Service.
To respond to t
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r712905345
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java
##
@@ -0,0 +
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#issuecomment-923413058
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r712833048
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/BitSlicedRangeIndexReader.java
##
@@ -0,0 +1,17
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r712830215
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java
##
@@ -49,6 +49,7 @@
pu
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r712829817
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java
##
@@ -175,7 +
richardstartin commented on a change in pull request #7454:
URL: https://github.com/apache/pinot/pull/7454#discussion_r712797242
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java
##
@@ -304,6 +306,13 @@
63 matches
Mail list logo
