walterddr commented on a change in pull request #7621:
URL: https://github.com/apache/pinot/pull/7621#discussion_r734927855
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/tuner/TableConfigTuner.java
##
@@ -32,13 +33,13 @@
public interface TableConfig
mqliang commented on a change in pull request #7624:
URL: https://github.com/apache/pinot/pull/7624#discussion_r734924360
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/impl/BloomFilterRule.java
##
@@ -109,7 +109,8 @@ private FixedLe
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 7bcbda1 Use maxEndTimeMs for merge/roll-up delay
snleee merged pull request #7617:
URL: https://github.com/apache/pinot/pull/7617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
jtao15 commented on a change in pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#discussion_r734910389
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
snleee commented on a change in pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#discussion_r734900769
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
codecov-commenter edited a comment on pull request #7624:
URL: https://github.com/apache/pinot/pull/7624#issuecomment-950031307
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7624?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7624:
URL: https://github.com/apache/pinot/pull/7624#issuecomment-950031307
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7624?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7624:
URL: https://github.com/apache/pinot/pull/7624#issuecomment-950031307
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7624?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7624:
URL: https://github.com/apache/pinot/pull/7624#issuecomment-950031307
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7624?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
GSharayu opened a new issue #7625:
URL: https://github.com/apache/pinot/issues/7625
Currently, MergeRangeFilterOptimizer don't support operations to optimize
query with filter patterns consisting of predicate A < 10 OR A = 10 as A<=10.
this issue will track removal of that limitation and p
GSharayu opened a new pull request #7624:
URL: https://github.com/apache/pinot/pull/7624
Support in the execution engine was added for bloom filter (#7005) based
pruning using IN predicate. The index recommendation rule isn't yet updated to
support IN predicate. The current implementation
codecov-commenter edited a comment on pull request #7622:
URL: https://github.com/apache/pinot/pull/7622#issuecomment-950016231
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7622?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7623:
URL: https://github.com/apache/pinot/pull/7623#issuecomment-950006202
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7623?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7622:
URL: https://github.com/apache/pinot/pull/7622#issuecomment-950016231
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7622?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7619:
URL: https://github.com/apache/pinot/pull/7619#issuecomment-950007246
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7619?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on pull request #7622:
URL: https://github.com/apache/pinot/pull/7622#issuecomment-950014357
> We are replacing the JDK implementation with our own, and I feel JIT might
be able to optimize on the JDK default method, and the benchmark might have
different result in
richardstartin commented on a change in pull request #7622:
URL: https://github.com/apache/pinot/pull/7622#discussion_r734886249
##
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/ByteArray.java
##
@@ -94,7 +94,23 @@ public boolean equals(Object o) {
@Overrid
codecov-commenter edited a comment on pull request #7623:
URL: https://github.com/apache/pinot/pull/7623#issuecomment-950006202
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7623?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
mqliang commented on a change in pull request #7622:
URL: https://github.com/apache/pinot/pull/7622#discussion_r734885268
##
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/ByteArray.java
##
@@ -94,7 +94,23 @@ public boolean equals(Object o) {
@Override
pu
codecov-commenter commented on pull request #7619:
URL: https://github.com/apache/pinot/pull/7619#issuecomment-950007246
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7619?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter commented on pull request #7623:
URL: https://github.com/apache/pinot/pull/7623#issuecomment-950006202
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7623?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
richardstartin commented on a change in pull request #7622:
URL: https://github.com/apache/pinot/pull/7622#discussion_r734883398
##
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/ByteArray.java
##
@@ -94,7 +94,23 @@ public boolean equals(Object o) {
@Overrid
mqliang commented on a change in pull request #7622:
URL: https://github.com/apache/pinot/pull/7622#discussion_r734883165
##
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/ByteArray.java
##
@@ -94,7 +94,23 @@ public boolean equals(Object o) {
@Override
pu
codecov-commenter edited a comment on pull request #7621:
URL: https://github.com/apache/pinot/pull/7621#issuecomment-950002029
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7621?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
Jackie-Jiang commented on a change in pull request #7621:
URL: https://github.com/apache/pinot/pull/7621#discussion_r734877659
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/tuner/TableConfigTuner.java
##
@@ -32,13 +33,13 @@
public interface TableCon
mqliang commented on a change in pull request #7622:
URL: https://github.com/apache/pinot/pull/7622#discussion_r734881229
##
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/ByteArray.java
##
@@ -94,7 +94,23 @@ public boolean equals(Object o) {
@Override
pu
codecov-commenter commented on pull request #7621:
URL: https://github.com/apache/pinot/pull/7621#issuecomment-950002029
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7621?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
richardstartin opened a new pull request #7622:
URL: https://github.com/apache/pinot/pull/7622
## Description
Speed up `ByteArray.hashCode` which speeds up building column statistics.
Unfortunately the algorithm needs to be maintained in case it has been used for
partitioning, but i
walterddr opened a new pull request #7621:
URL: https://github.com/apache/pinot/pull/7621
We made tuner stateless a while ago so now it is requires some extra
properties for run. for example some of the unused properties set by
`TunerConfig`.
This adds additional map field at the en
thealmightygrant commented on a change in pull request #7620:
URL: https://github.com/apache/pinot/pull/7620#discussion_r734861988
##
File path:
pinot-plugins/pinot-input-format/pinot-thrift/src/main/java/org/apache/pinot/plugin/inputformat/thrift/ThriftMessageDecoder.java
##
thealmightygrant opened a new pull request #7620:
URL: https://github.com/apache/pinot/pull/7620
## Description
This is a WIP for adding a Stream Decoder that can read Thrift. I used the
[SimpleAvroMessageDecoder](https://github.com/apache/pinot/blob/9275a430049ff0d2888cb353fc7ef369d
richardstartin opened a new pull request #7619:
URL: https://github.com/apache/pinot/pull/7619
## Description
By checking whether a value has been added to the `_values` set before, we
can avoid doing things like UTF-8 encoding, evaluating partitioning functions
and so on more than once
This is an automated email from the ASF dual-hosted git repository.
mayanks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new a114cd2 (fix) Query console doesn't load (#7618
mayankshriv merged pull request #7618:
URL: https://github.com/apache/pinot/pull/7618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
mayankshriv closed issue #7614:
URL: https://github.com/apache/pinot/issues/7614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
mayankshriv commented on issue #7560:
URL: https://github.com/apache/pinot/issues/7560#issuecomment-949960320
+1 to @Jackie-Jiang's suggestion. With the Theta-Sketches implementations we
had enhanced the query execution engine to support aggregation functions
multiple arguments, and this o
codecov-commenter edited a comment on pull request #7618:
URL: https://github.com/apache/pinot/pull/7618#issuecomment-949945745
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin edited a comment on pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#issuecomment-949950995
You're right, `System.nanoTime()` does not record wall time.
~`System.currentTimeMillis() - bufferTimeMs` is an elapsed time (a duration),
unless I'm missing somethi
codecov-commenter edited a comment on pull request #7618:
URL: https://github.com/apache/pinot/pull/7618#issuecomment-949945745
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#issuecomment-949950995
You're right, `System.nanoTime()` does not record wall time.
`System.currentTimeMillis() - bufferTimeMs` is an elapsed time (a duration),
unless I'm missing something? The
codecov-commenter edited a comment on pull request #7605:
URL: https://github.com/apache/pinot/pull/7605#issuecomment-949929162
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
jtao15 commented on pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#issuecomment-949946633
> What happens if the system clock is adjusted backwards so that
`bufferTimeMs` > `System.currentTimeMillis()`? Durations should be recorded
using `System.nanoTime()`.
@rich
codecov-commenter commented on pull request #7618:
URL: https://github.com/apache/pinot/pull/7618#issuecomment-949945745
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7605:
URL: https://github.com/apache/pinot/pull/7605#issuecomment-949929162
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#issuecomment-949914591
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7605:
URL: https://github.com/apache/pinot/pull/7605#issuecomment-949929162
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#issuecomment-949914591
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
shahsank3t opened a new pull request #7618:
URL: https://github.com/apache/pinot/pull/7618
## Description
This fixes https://github.com/apache/pinot/issues/7614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
codecov-commenter edited a comment on pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#issuecomment-949914591
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#issuecomment-949914591
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
weixiangsun commented on a change in pull request #7584:
URL: https://github.com/apache/pinot/pull/7584#discussion_r734793772
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java
##
@@ -156,6 +157,46 @@ public
lakshmanan-v commented on a change in pull request #7584:
URL: https://github.com/apache/pinot/pull/7584#discussion_r734791697
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java
##
@@ -156,6 +157,46 @@ public
richardstartin commented on pull request #7617:
URL: https://github.com/apache/pinot/pull/7617#issuecomment-949900593
What happens if the system clock is adjusted backwards so that
`bufferTimeMs` > `System.currentTimeMillis()`? Durations should be recorded
using `System.nanoTime()`.
--
jtao15 opened a new pull request #7617:
URL: https://github.com/apache/pinot/pull/7617
- For single level merge or the lowest merge level of multi-level, the
equation is updated as
```(Math.min(System.currentTimeMillis() - bufferTimeMs, maxEndTimeMs) -
watermarkMs) / bucketTimeMs```
kriti-sc commented on pull request #7605:
URL: https://github.com/apache/pinot/pull/7605#issuecomment-949885810
@npawar
If a segment is `CONSUMING` or `DONE`, this check is already being performed
[here](https://github.com/apache/pinot/blob/1bd899c9ba45676d1ac25979274391431bdf5ce9/pinot-
richardstartin opened a new issue #7616:
URL: https://github.com/apache/pinot/issues/7616
We would like to introduce a new format for raw forward indexes, which does
not need a constant number of documents per chunk, instead partitioning columns
based on uncompressed size. It is expected t
mayankshriv closed issue #7187:
URL: https://github.com/apache/pinot/issues/7187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
mayankshriv commented on issue #7187:
URL: https://github.com/apache/pinot/issues/7187#issuecomment-949770103
Thanks @suddendust for fixing the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
kishoreg closed issue #2270:
URL: https://github.com/apache/pinot/issues/2270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
codecov-commenter edited a comment on pull request #7615:
URL: https://github.com/apache/pinot/pull/7615#issuecomment-949637246
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7615?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7615:
URL: https://github.com/apache/pinot/pull/7615#issuecomment-949637246
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7615?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7615:
URL: https://github.com/apache/pinot/pull/7615#issuecomment-949637246
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7615?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
thealmightygrant closed pull request #6427:
URL: https://github.com/apache/pinot/pull/6427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
This is an automated email from the ASF dual-hosted git repository.
kishoreg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new aed1307 Add MV raw forward index and MV `BYTES
kishoreg merged pull request #7595:
URL: https://github.com/apache/pinot/pull/7595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
codecov-commenter edited a comment on pull request #7615:
URL: https://github.com/apache/pinot/pull/7615#issuecomment-949637246
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7615?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7615:
URL: https://github.com/apache/pinot/pull/7615#issuecomment-949637246
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7615?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
richardstartin opened a new pull request #7615:
URL: https://github.com/apache/pinot/pull/7615
## Description
Previously deserialising tableConfig with field config e.g.
```json
"fieldConfigList": [
{
"encodingType": "RAW",
"indexType": "JSON",
codecov-commenter edited a comment on pull request #7595:
URL: https://github.com/apache/pinot/pull/7595#issuecomment-946634547
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7595?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7595:
URL: https://github.com/apache/pinot/pull/7595#issuecomment-946634547
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7595?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin opened a new issue #7614:
URL: https://github.com/apache/pinot/issues/7614
On the master branch when loading the query console an error is encountered
https://user-images.githubusercontent.com/16439049/138432863-fe8dccc8-45bb-48e5-8a68-6752487fee8d.png";>
Ste
richardstartin commented on a change in pull request #7595:
URL: https://github.com/apache/pinot/pull/7595#discussion_r734373632
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/minion/RawIndexConverter.java
##
@@ -207,7 +207,7 @@ private void convertColumn(FieldSp
richardstartin commented on a change in pull request #7595:
URL: https://github.com/apache/pinot/pull/7595#discussion_r734373235
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/BaseChunkSVForwardIndexWriter.java
##
@@ -151,8 +154,1
richardstartin commented on a change in pull request #7595:
URL: https://github.com/apache/pinot/pull/7595#discussion_r734372096
##
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkSVForwardIndexWriter.java
##
@@ -33,27 +33
suddendust commented on issue #7187:
URL: https://github.com/apache/pinot/issues/7187#issuecomment-949374038
Can this be closed? The PR was merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
76 matches
Mail list logo
