codecov-commenter commented on pull request #8059:
URL: https://github.com/apache/pinot/pull/8059#issuecomment-1019831202
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8059?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
codecov-commenter edited a comment on pull request #8059:
URL: https://github.com/apache/pinot/pull/8059#issuecomment-1019831202
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8059?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter commented on pull request #7959:
URL: https://github.com/apache/pinot/pull/7959#issuecomment-1019871784
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7959?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
codecov-commenter edited a comment on pull request #7959:
URL: https://github.com/apache/pinot/pull/7959#issuecomment-1019871784
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7959?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
lksvenoy-r7 commented on pull request #8055:
URL: https://github.com/apache/pinot/pull/8055#issuecomment-1019917333
All comments addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
codecov-commenter edited a comment on pull request #8059:
URL: https://github.com/apache/pinot/pull/8059#issuecomment-1019831202
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8059?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
rodrigorigotti commented on pull request #7997:
URL: https://github.com/apache/pinot/pull/7997#issuecomment-1019919667
Hi @xiangfu0, do you have any updates regarding this PR? 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
codecov-commenter edited a comment on pull request #8059:
URL: https://github.com/apache/pinot/pull/8059#issuecomment-1019831202
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8059?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8059:
URL: https://github.com/apache/pinot/pull/8059#issuecomment-1019831202
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8059?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8059:
URL: https://github.com/apache/pinot/pull/8059#issuecomment-1019831202
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8059?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
richardstartin commented on pull request #8057:
URL: https://github.com/apache/pinot/pull/8057#issuecomment-1019933247
hi @kriti-sc could you cover this with some tests please? I would want to
see both:
* Unit tests at the Kafka consumer level e.g. the correct offsets are
produced from
richardstartin commented on a change in pull request #8057:
URL: https://github.com/apache/pinot/pull/8057#discussion_r790593249
##
File path:
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamMetadataProvider.java
###
richardstartin commented on a change in pull request #8057:
URL: https://github.com/apache/pinot/pull/8057#discussion_r790594370
##
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimeUtils.java
##
@@ -194,4 +198,20 @@ public static boolean isPeriodValid(String ti
richardstartin commented on a change in pull request #8057:
URL: https://github.com/apache/pinot/pull/8057#discussion_r790605906
##
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimeUtils.java
##
@@ -194,4 +198,20 @@ public static boolean isPeriodValid(String ti
richardstartin commented on a change in pull request #8057:
URL: https://github.com/apache/pinot/pull/8057#discussion_r790605906
##
File path: pinot-spi/src/main/java/org/apache/pinot/spi/utils/TimeUtils.java
##
@@ -194,4 +198,20 @@ public static boolean isPeriodValid(String ti
richardstartin commented on a change in pull request #8057:
URL: https://github.com/apache/pinot/pull/8057#discussion_r790609981
##
File path:
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaStreamMetadataProvider.java
###
ddcprg closed pull request #7541:
URL: https://github.com/apache/pinot/pull/7541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
ddcprg closed pull request #7672:
URL: https://github.com/apache/pinot/pull/7672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
atris opened a new issue #8060:
URL: https://github.com/apache/pinot/issues/8060
This issue tracks the development of the feature that brings multiple
grouping sets to Pinot.
**What is A Grouping Set?**
Consider the following query:
```
SELECT
brand,
se
atris commented on issue #8060:
URL: https://github.com/apache/pinot/issues/8060#issuecomment-1019987354
I have started working on this and aim to publish a design document by end
of this week
--
This is an automated message from the Apache Git Service.
To respond to the message, please
suddendust commented on pull request #7959:
URL: https://github.com/apache/pinot/pull/7959#issuecomment-1020026435
@Jackie-Jiang Requesting review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
suddendust edited a comment on pull request #7959:
URL: https://github.com/apache/pinot/pull/7959#issuecomment-1020026435
@Jackie-Jiang @amrishlal @siddharthteotia Requesting review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
PrachiPrakash commented on pull request #7972:
URL: https://github.com/apache/pinot/pull/7972#issuecomment-1020256316
@Jackie-Jiang, siddharthteotia made the changes as per the review by
removing expressionContainsColumn(expr) and making all the logic changes in
validateGroupByClause(Pi
npawar commented on pull request #8053:
URL: https://github.com/apache/pinot/pull/8053#issuecomment-1020262029
Need to merge this, already have two users in OSS waiting for this. If
there's any concerns, will address separately in follow-ups
--
This is an automated message from the Apach
npawar merged pull request #8053:
URL: https://github.com/apache/pinot/pull/8053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4e4b1ea Smallest offset for new partitionGrou
walterddr commented on issue #8060:
URL: https://github.com/apache/pinot/issues/8060#issuecomment-1020293534
Hi @atris . This looks like a super powerful feature. thanks for working on
this.
on the higher level, would you please describe briefly the scope of this
design? specificall
jadami10 opened a new issue #8061:
URL: https://github.com/apache/pinot/issues/8061
If you have a table with the following config:
```
tenants:
broker: "TenantA"
server: "TenantB"
```
The `/instance/BROKER_` page will not show your table.
The `/tenants` page will not
KKcorps opened a new pull request #8062:
URL: https://github.com/apache/pinot/pull/8062
This PR handles the issue #8031 . The PR adds support to parse username and
password from JDBC params and generate auth token.
The user can provide authorization token directly in the properties as
`
Jackie-Jiang merged pull request #8058:
URL: https://github.com/apache/pinot/pull/8058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 4e4b1ea Smallest offset for new partitionGroups (#8053)
add 9f40d1b Fix the PinotLLCRealtimeSegmentManager on s
xiangfu0 commented on issue #7941:
URL: https://github.com/apache/pinot/issues/7941#issuecomment-1020369110
https://github.com/apache/pinot/pull/8059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
xiangfu0 commented on pull request #8024:
URL: https://github.com/apache/pinot/pull/8024#issuecomment-1020369583
> > This would allow a user to use a git repository as a way to version
control and manage configurations for each of the different components. Any
thoughts on this @amrishlal?
xiangfu0 closed issue #7941:
URL: https://github.com/apache/pinot/issues/7941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
xiangfu0 merged pull request #8059:
URL: https://github.com/apache/pinot/pull/8059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e7ea235 Adding a config file to override quicks
Jackie-Jiang commented on a change in pull request #7959:
URL: https://github.com/apache/pinot/pull/7959#discussion_r791006174
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -1487,6 +1498,41 @@ static void up
Jackie-Jiang commented on a change in pull request #7972:
URL: https://github.com/apache/pinot/pull/7972#discussion_r791014213
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -146,23 +146,30 @@ static void validate(PinotQuery p
walterddr opened a new pull request #8063:
URL: https://github.com/apache/pinot/pull/8063
PinotFS should be an interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
mcvsubbu commented on pull request #8063:
URL: https://github.com/apache/pinot/pull/8063#issuecomment-1020434032
We can (and probably should) change this, but it will be an incompat change.
please be sure to mark it as such in the release.
--
This is an automated message from the Apache
Jackie-Jiang commented on a change in pull request #8063:
URL: https://github.com/apache/pinot/pull/8063#discussion_r791074899
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/BasePinotFS.java
##
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Fo
walterddr opened a new issue #8064:
URL: https://github.com/apache/pinot/issues/8064
Currently PinotFS doesn't support batch operation API extensions easily.
For some usage such as SegmentDeletionManager. once has to iterate over all
files checking for deletion and then do the actua
Jackie-Jiang commented on a change in pull request #8063:
URL: https://github.com/apache/pinot/pull/8063#discussion_r791075735
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/BasePinotFS.java
##
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Fo
walterddr commented on pull request #8063:
URL: https://github.com/apache/pinot/pull/8063#issuecomment-1020456214
thanks for the feedback @mcvsubbu :-) yes I have the exact same concern and
will do just that. will follow up @Jackie-Jiang 's comment too. here is the
context https://github.c
richardstartin opened a new pull request #8065:
URL: https://github.com/apache/pinot/pull/8065
This adds a benchmark which measures FixedBitSVReader performance when there
are multiple cardinalities and therefore multiple implementations present,
which illustrates that existing benchmarks
codecov-commenter commented on pull request #8065:
URL: https://github.com/apache/pinot/pull/8065#issuecomment-1020537555
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
codecov-commenter edited a comment on pull request #8065:
URL: https://github.com/apache/pinot/pull/8065#issuecomment-1020537555
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8065:
URL: https://github.com/apache/pinot/pull/8065#issuecomment-1020537555
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8036:
URL: https://github.com/apache/pinot/pull/8036#issuecomment-1015902387
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8036?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter commented on pull request #8063:
URL: https://github.com/apache/pinot/pull/8063#issuecomment-1020604070
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8063?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
snleee opened a new pull request #8066:
URL: https://github.com/apache/pinot/pull/8066
- Improve the code to add the log only if the segments are deleted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
jackjlli commented on a change in pull request #8066:
URL: https://github.com/apache/pinot/pull/8066#discussion_r791218886
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
##
@@ -258,10 +258,11 @@ private void
snleee commented on a change in pull request #8066:
URL: https://github.com/apache/pinot/pull/8066#discussion_r791221941
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
##
@@ -258,10 +258,11 @@ private void
m
codecov-commenter edited a comment on pull request #8036:
URL: https://github.com/apache/pinot/pull/8036#issuecomment-1015902387
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8036?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8036:
URL: https://github.com/apache/pinot/pull/8036#issuecomment-1015902387
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8036?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
mqliang opened a new pull request #8067:
URL: https://github.com/apache/pinot/pull/8067
## Description
https://github.com/apache/pinot/pull/6466 adds EmptySegmentPruner to prune
empty segments, this EmptySegmentPruner is added to all tables during the
routing table build, and wi
mqliang commented on pull request #8067:
URL: https://github.com/apache/pinot/pull/8067#issuecomment-1020673842
cc @snleee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
codecov-commenter commented on pull request #8066:
URL: https://github.com/apache/pinot/pull/8066#issuecomment-1020674259
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8066?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
mqliang edited a comment on pull request #8067:
URL: https://github.com/apache/pinot/pull/8067#issuecomment-1020673842
cc @snleee @npawar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
codecov-commenter edited a comment on pull request #8066:
URL: https://github.com/apache/pinot/pull/8066#issuecomment-1020674259
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8066?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8063:
URL: https://github.com/apache/pinot/pull/8063#issuecomment-1020604070
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8063?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
mqliang closed pull request #8067:
URL: https://github.com/apache/pinot/pull/8067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
jackjlli commented on a change in pull request #8066:
URL: https://github.com/apache/pinot/pull/8066#discussion_r791275075
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
##
@@ -258,10 +257,11 @@ private void
codecov-commenter commented on pull request #8067:
URL: https://github.com/apache/pinot/pull/8067#issuecomment-1020719849
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8067?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa
codecov-commenter edited a comment on pull request #8067:
URL: https://github.com/apache/pinot/pull/8067#issuecomment-1020719849
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8067?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8067:
URL: https://github.com/apache/pinot/pull/8067#issuecomment-1020719849
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8067?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8067:
URL: https://github.com/apache/pinot/pull/8067#issuecomment-1020719849
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8067?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8036:
URL: https://github.com/apache/pinot/pull/8036#issuecomment-1015902387
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8036?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8036:
URL: https://github.com/apache/pinot/pull/8036#issuecomment-1015902387
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8036?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
Manis99803 opened a new issue #8068:
URL: https://github.com/apache/pinot/issues/8068
Issue:
Currently, with a Fixed type in the Pinot SegmentNameGenerator, we are able
to generate a segment with an user-defined name. However, there is some issue
with respect to this when we want to
codecov-commenter edited a comment on pull request #8036:
URL: https://github.com/apache/pinot/pull/8036#issuecomment-1015902387
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8036?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8036:
URL: https://github.com/apache/pinot/pull/8036#issuecomment-1015902387
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8036?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
codecov-commenter edited a comment on pull request #8036:
URL: https://github.com/apache/pinot/pull/8036#issuecomment-1015902387
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8036?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=
atris commented on pull request #8016:
URL: https://github.com/apache/pinot/pull/8016#issuecomment-1020904236
This PR will be merged in 24 hours from now, barring objections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
74 matches
Mail list logo
