[GitHub] [pinot] KKcorps commented on pull request #6703: Remove slf4j-impl (#6364)

2022-05-02 Thread GitBox
KKcorps commented on PR #6703: URL: https://github.com/apache/pinot/pull/6703#issuecomment-1115753602 @kkrugler - Makes sense. So what this PR does for s3 plugin has to be repeated for every other plugin as well, right? -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pinot] vvivekiyer opened a new issue, #8627: Support filtering for literals

2022-05-02 Thread GitBox
vvivekiyer opened a new issue, #8627: URL: https://github.com/apache/pinot/issues/8627 Handle `false`, `0` and `0.0` as FALSE. All other values as true. This is a follow-up change to #8444 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [pinot] vvivekiyer commented on issue #8444: Filtering on a boolean field with just the field name results in NullPointerException

2022-05-02 Thread GitBox
vvivekiyer commented on issue #8444: URL: https://github.com/apache/pinot/issues/8444#issuecomment-1115721040 Hi Johan, yes it should. I just tested it out locally for a use-case. I didn't add a test-case example because AND, OR, NOT are processed similarly. -- This is an automated messa

[GitHub] [pinot] codecov-commenter commented on pull request #8626: [PQL Cleanup] Remove all PQL related code

2022-05-02 Thread GitBox
codecov-commenter commented on PR #8626: URL: https://github.com/apache/pinot/pull/8626#issuecomment-1115562862 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] saurabhd336 commented on issue #8318: Indicate what fields are getting ignored when adding configs

2022-05-02 Thread GitBox
saurabhd336 commented on issue #8318: URL: https://github.com/apache/pinot/issues/8318#issuecomment-1115561178 These PRs add this functionality https://github.com/apache/pinot/pull/8514 https://github.com/apache/pinot/pull/8606 -- This is an automated message from the Apache Git Serv

[GitHub] [pinot] jadami10 commented on issue #8444: Filtering on a boolean field with just the field name results in NullPointerException

2022-05-02 Thread GitBox
jadami10 commented on issue #8444: URL: https://github.com/apache/pinot/issues/8444#issuecomment-1115558830 thanks for working on this! I didn't see a test example, but does `WHERE NOT ` work correctly? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pinot] npawar commented on a diff in pull request #8601: Add support for indexes during offline segment creation

2022-05-02 Thread GitBox
npawar commented on code in PR #8601: URL: https://github.com/apache/pinot/pull/8601#discussion_r863331285 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java: ## @@ -64,6 +64,7 @@ public class IndexingConfig extends BaseJsonConfig { // TODO: Add

[GitHub] [pinot] npawar merged pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs

2022-05-02 Thread GitBox
npawar merged PR #8606: URL: https://github.com/apache/pinot/pull/8606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.

[pinot] branch master updated (d49d1173f9 -> 4e14101f57)

2022-05-02 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from d49d1173f9 Support filtering on bool/scalar fields without evaluator (#8518) add 4e14101f57 Add unrecognizedPr

[GitHub] [pinot] npawar commented on a diff in pull request #8601: Add support for indexes during offline segment creation

2022-05-02 Thread GitBox
npawar commented on code in PR #8601: URL: https://github.com/apache/pinot/pull/8601#discussion_r863329647 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java: ## @@ -64,6 +64,7 @@ public class IndexingConfig extends BaseJsonConfig { // TODO: Add

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #8626: [PQL Cleanup] Remove all PQL related code

2022-05-02 Thread GitBox
Jackie-Jiang opened a new pull request, #8626: URL: https://github.com/apache/pinot/pull/8626 Sub-task of #7430 Remove all PQL related code. The UI cleanup for the PQL endpoint will be done separately. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pinot] siddharthteotia closed issue #8444: Filtering on a boolean field with just the field name results in NullPointerException

2022-05-02 Thread GitBox
siddharthteotia closed issue #8444: Filtering on a boolean field with just the field name results in NullPointerException URL: https://github.com/apache/pinot/issues/8444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pinot] siddharthteotia commented on issue #8444: Filtering on a boolean field with just the field name results in NullPointerException

2022-05-02 Thread GitBox
siddharthteotia commented on issue #8444: URL: https://github.com/apache/pinot/issues/8444#issuecomment-1115494899 Fixed with https://github.com/apache/pinot/pull/8518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pinot] siddharthteotia commented on issue #8487: boolean function not recognized in filter clause

2022-05-02 Thread GitBox
siddharthteotia commented on issue #8487: URL: https://github.com/apache/pinot/issues/8487#issuecomment-1115494826 Fixed with https://github.com/apache/pinot/pull/8518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pinot] siddharthteotia commented on issue #8607: Explain plan can be misleading

2022-05-02 Thread GitBox
siddharthteotia commented on issue #8607: URL: https://github.com/apache/pinot/issues/8607#issuecomment-1115493629 One approach could be: - Send query to all segments and all servers - On the broker, pick the response with deepest tree and avoid merging across segments I thi

[GitHub] [pinot] siddharthteotia commented on issue #8607: Explain plan can be misleading

2022-05-02 Thread GitBox
siddharthteotia commented on issue #8607: URL: https://github.com/apache/pinot/issues/8607#issuecomment-1115489590 Working on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[pinot] branch master updated: Support filtering on bool/scalar fields without evaluator (#8518)

2022-05-02 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d49d1173f9 Support filtering on bool/scalar f

[GitHub] [pinot] siddharthteotia merged pull request #8518: Support filtering on bool/scalar fields without evaluator

2022-05-02 Thread GitBox
siddharthteotia merged PR #8518: URL: https://github.com/apache/pinot/pull/8518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8384: Implement Native Text Operator

2022-05-02 Thread GitBox
Jackie-Jiang commented on code in PR #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r863245187 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java: ## @@ -36,6 +40,45 @@ static void cleanupTextIndex(File segDir,

[GitHub] [pinot] walterddr commented on a diff in pull request #8314: Access Control management Development

2022-05-02 Thread GitBox
walterddr commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r863216579 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/user/AccessType.java: ## @@ -0,0 +1,23 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] walterddr commented on a diff in pull request #8314: Access Control management Development

2022-05-02 Thread GitBox
walterddr commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r863216579 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/user/AccessType.java: ## @@ -0,0 +1,23 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] walterddr commented on a diff in pull request #8314: Access Control management Development

2022-05-02 Thread GitBox
walterddr commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r863216579 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/user/AccessType.java: ## @@ -0,0 +1,23 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] walterddr commented on a diff in pull request #8314: Access Control management Development

2022-05-02 Thread GitBox
walterddr commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r863219275 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/user/AccessType.java: ## @@ -0,0 +1,23 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] walterddr commented on a diff in pull request #8314: Access Control management Development

2022-05-02 Thread GitBox
walterddr commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r863225039 ## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ## @@ -240,6 +242,8 @@ private static long getRandomInitialDelayInSeconds() { priva

[GitHub] [pinot] walterddr commented on a diff in pull request #8314: Access Control management Development

2022-05-02 Thread GitBox
walterddr commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r863223973 ## pinot-core/src/main/java/org/apache/pinot/core/auth/BasicAuthUtils.java: ## @@ -61,21 +64,43 @@ private BasicAuthUtils() { * @return list of BasicAuthPrincipals

[GitHub] [pinot] walterddr commented on a diff in pull request #8314: Access Control management Development

2022-05-02 Thread GitBox
walterddr commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r863222689 ## pinot-core/src/main/java/org/apache/pinot/core/auth/BasicAuthUtils.java: ## @@ -61,21 +64,43 @@ private BasicAuthUtils() { * @return list of BasicAuthPrincipals

[GitHub] [pinot] walterddr commented on a diff in pull request #8314: Access Control management Development

2022-05-02 Thread GitBox
walterddr commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r863224473 ## pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java: ## @@ -240,6 +242,8 @@ private static long getRandomInitialDelayInSeconds() { priva

[GitHub] [pinot] walterddr commented on a diff in pull request #8314: Access Control management Development

2022-05-02 Thread GitBox
walterddr commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r863216579 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/user/AccessType.java: ## @@ -0,0 +1,23 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #8518: Support filtering on bool/scalar fields without evaluator

2022-05-02 Thread GitBox
vvivekiyer commented on code in PR #8518: URL: https://github.com/apache/pinot/pull/8518#discussion_r863226578 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/PredicateComparisonRewriter.java: ## @@ -33,75 +36,126 @@ public class PredicateComparisonRewriter i

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #8518: Support filtering on bool/scalar fields without evaluator

2022-05-02 Thread GitBox
vvivekiyer commented on code in PR #8518: URL: https://github.com/apache/pinot/pull/8518#discussion_r863226257 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/PredicateComparisonRewriter.java: ## @@ -33,75 +36,126 @@ public class PredicateComparisonRewriter i

[GitHub] [pinot] kkrugler commented on pull request #6703: Remove slf4j-impl (#6364)

2022-05-02 Thread GitBox
kkrugler commented on PR #6703: URL: https://github.com/apache/pinot/pull/6703#issuecomment-1115404396 @KKcorps - A jar that has a `main()` method that's used from the command line needs a logging implementation. Everything else should only be using the `slf4j-api`. Otherwise (e.g. with the

[GitHub] [pinot] skhatri opened a new pull request, #6703: Remove slf4j-impl (#6364)

2022-05-02 Thread GitBox
skhatri opened a new pull request, #6703: URL: https://github.com/apache/pinot/pull/6703 ## Description Add a description of your PR here. Fix logging dependencies in pinot-spi #6364 ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller

[GitHub] [pinot] KKcorps commented on pull request #6703: Remove slf4j-impl (#6364)

2022-05-02 Thread GitBox
KKcorps commented on PR #6703: URL: https://github.com/apache/pinot/pull/6703#issuecomment-1115367053 @kkrugler I closed it for inactivity. I am not sure if this change is needed. Opening it again for review. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pinot] ddcprg commented on a diff in pull request #8625: Add support to select timestamp arrays

2022-05-02 Thread GitBox
ddcprg commented on code in PR #8625: URL: https://github.com/apache/pinot/pull/8625#discussion_r863186080 ## pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java: ## @@ -597,6 +599,14 @@ public static Serializable getFormattedValue(Object v

[GitHub] [pinot] atris commented on a diff in pull request #8384: Implement Native Text Operator

2022-05-02 Thread GitBox
atris commented on code in PR #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r863163455 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java: ## @@ -36,6 +40,45 @@ static void cleanupTextIndex(File segDir, String

[GitHub] [pinot] deemoliu commented on a diff in pull request #8355: add a experiment API for upsert heap memory estimation

2022-05-02 Thread GitBox
deemoliu commented on code in PR #8355: URL: https://github.com/apache/pinot/pull/8355#discussion_r863153536 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotUpsertCapacityEstimationRestletResource.java: ## @@ -0,0 +1,162 @@ +/** + * Licensed to t

[GitHub] [pinot] deemoliu commented on a diff in pull request #8355: add a experiment API for upsert heap memory estimation

2022-05-02 Thread GitBox
deemoliu commented on code in PR #8355: URL: https://github.com/apache/pinot/pull/8355#discussion_r863152979 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotUpsertCapacityEstimationRestletResource.java: ## @@ -0,0 +1,162 @@ +/** + * Licensed to t

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8384: Implement Native Text Operator

2022-05-02 Thread GitBox
Jackie-Jiang commented on code in PR #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r863129529 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java: ## @@ -36,6 +40,45 @@ static void cleanupTextIndex(File segDir,

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8384: Implement Native Text Operator

2022-05-02 Thread GitBox
Jackie-Jiang commented on code in PR #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r863124826 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NativeClusterIntegrationTest.java: ## @@ -0,0 +1,203 @@ +/** + * Licensed to the Apache So

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8518: Support filtering on bool/scalar fields without evaluator

2022-05-02 Thread GitBox
Jackie-Jiang commented on code in PR #8518: URL: https://github.com/apache/pinot/pull/8518#discussion_r863118643 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/PredicateComparisonRewriter.java: ## @@ -33,75 +36,126 @@ public class PredicateComparisonRewriter

[GitHub] [pinot] atris commented on a diff in pull request #8384: Implement Native Text Operator

2022-05-02 Thread GitBox
atris commented on code in PR #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r863118224 ## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NativeClusterIntegrationTest.java: ## @@ -0,0 +1,203 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8384: Implement Native Text Operator

2022-05-02 Thread GitBox
Jackie-Jiang commented on code in PR #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r863103934 ## pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkNativeVsLuceneTextIndex.java: ## @@ -0,0 +1,214 @@ +/** + * Licensed to the Apache Software Foundation (ASF

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8622: Support BigDecimal raw value forward index; Support BigDecimal in many transforms and operators

2022-05-02 Thread GitBox
Jackie-Jiang commented on code in PR #8622: URL: https://github.com/apache/pinot/pull/8622#discussion_r863048176 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SelectTupleElementTransformFunction.java: ## @@ -88,17 +90,24 @@ private static FieldSpe

[GitHub] [pinot] suddendust commented on issue #8399: Persist raw data from kafka topic as it is

2022-05-02 Thread GitBox
suddendust commented on issue #8399: URL: https://github.com/apache/pinot/issues/8399#issuecomment-1115181784 @Jackie-Jiang So I gave this a thought. Even if this new property is set to true, then filter configs and transform configs should keep working, right? As in, Pinot should store the

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8601: Add support for indexes during offline segment creation

2022-05-02 Thread GitBox
Jackie-Jiang commented on code in PR #8601: URL: https://github.com/apache/pinot/pull/8601#discussion_r863044298 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java: ## @@ -64,6 +64,7 @@ public class IndexingConfig extends BaseJsonConfig { // TODO

[GitHub] [pinot] kkrugler commented on pull request #6703: Remove slf4j-impl (#6364)

2022-05-02 Thread GitBox
kkrugler commented on PR #6703: URL: https://github.com/apache/pinot/pull/6703#issuecomment-1115139550 Hi @KKcorps - why was this closed? Removing direct dependencies on `slf4j-impl` in lower-level jars is a good thing, usually. Or did this get covered by a different PR? -- This is an au

[GitHub] [pinot] kkrugler commented on issue #8623: [Feature] can i use apache pinot to query data already stored in a Nosql DB deployed on cloud.

2022-05-02 Thread GitBox
kkrugler commented on issue #8623: URL: https://github.com/apache/pinot/issues/8623#issuecomment-1115135631 Hi @prashantg077 - this is a great question for the Pinot Slack workspace's #general channel. -- This is an automated message from the Apache Git Service. To respond to the message,

[pinot] branch helix-1.0 updated (6fd2c7211b -> dd57811e17)

2022-05-02 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git omit 6fd2c7211b Upgrade Helix to 1.0.2 add 71a6e6379b adding in OBJECT type resolver (#8608) add c373cb86e5 Add s

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #8518: Support filtering on bool/scalar fields without evaluator

2022-05-02 Thread GitBox
vvivekiyer commented on code in PR #8518: URL: https://github.com/apache/pinot/pull/8518#discussion_r863014083 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -163,94 +165,113 @@ public static FunctionContext getFunction(Fun

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #8518: Support filtering on bool/scalar fields without evaluator

2022-05-02 Thread GitBox
vvivekiyer commented on code in PR #8518: URL: https://github.com/apache/pinot/pull/8518#discussion_r863007035 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/PredicateComparisonRewriter.java: ## @@ -33,75 +36,126 @@ public class PredicateComparisonRewriter i

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #8518: Support filtering on bool/scalar fields without evaluator

2022-05-02 Thread GitBox
vvivekiyer commented on code in PR #8518: URL: https://github.com/apache/pinot/pull/8518#discussion_r863005987 ## pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FilterKind.java: ## @@ -19,33 +19,41 @@ package org.apache.pinot.pql.parsers.pql2.ast; public en

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #8518: Support filtering on bool/scalar fields without evaluator

2022-05-02 Thread GitBox
vvivekiyer commented on code in PR #8518: URL: https://github.com/apache/pinot/pull/8518#discussion_r863005499 ## pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FilterKind.java: ## @@ -19,33 +19,41 @@ package org.apache.pinot.pql.parsers.pql2.ast; public en

[GitHub] [pinot] vvivekiyer commented on a diff in pull request #8518: Support filtering on bool/scalar fields without evaluator

2022-05-02 Thread GitBox
vvivekiyer commented on code in PR #8518: URL: https://github.com/apache/pinot/pull/8518#discussion_r862999137 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java: ## @@ -163,94 +165,113 @@ public static FunctionContext getFunction(Fun

[GitHub] [pinot] ddcprg commented on pull request #8625: Add support to select timestamp arrays

2022-05-02 Thread GitBox
ddcprg commented on PR #8625: URL: https://github.com/apache/pinot/pull/8625#issuecomment-1115088561 Fixes #8624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [pinot] ddcprg opened a new pull request, #8625: Add support to select timestamp arrays

2022-05-02 Thread GitBox
ddcprg opened a new pull request, #8625: URL: https://github.com/apache/pinot/pull/8625 Allow selection and formatting of TIMESTAMP_ARRAY type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] ddcprg opened a new issue, #8624: Unable to select column defined as an array of timestamps

2022-05-02 Thread GitBox
ddcprg opened a new issue, #8624: URL: https://github.com/apache/pinot/issues/8624 Given the following schema: ``` { "schemaName": "alltypes", "dimensionFieldSpecs": [ { "name": "string_col", "dataType": "STRING"

[GitHub] [pinot] prashantg077 commented on issue #8623: [Feature] can i use apache pinot to query data already stored in a Nosql DB deployed on cloud.

2022-05-02 Thread GitBox
prashantg077 commented on issue #8623: URL: https://github.com/apache/pinot/issues/8623#issuecomment-1114830560 cc: @siddharthteotia @Jackie-Jiang @jasperjiaguo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pinot] richardstartin closed pull request #8619: Reduce Lucene fst allocations

2022-05-02 Thread GitBox
richardstartin closed pull request #8619: Reduce Lucene fst allocations URL: https://github.com/apache/pinot/pull/8619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [pinot] KKcorps commented on pull request #6703: Remove slf4j-impl (#6364)

2022-05-02 Thread GitBox
KKcorps commented on PR #6703: URL: https://github.com/apache/pinot/pull/6703#issuecomment-1114703864 Closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [pinot] KKcorps closed pull request #6703: Remove slf4j-impl (#6364)

2022-05-02 Thread GitBox
KKcorps closed pull request #6703: Remove slf4j-impl (#6364) URL: https://github.com/apache/pinot/pull/6703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [pinot] KKcorps commented on pull request #8467: pinot-java-client controller based broker selector

2022-05-02 Thread GitBox
KKcorps commented on PR #8467: URL: https://github.com/apache/pinot/pull/8467#issuecomment-1114702582 LGTM! The only issue I see is the changes needed to handle https connections. We can take that in another PR though. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [pinot] atris commented on a diff in pull request #8384: Implement Native Text Operator

2022-05-02 Thread GitBox
atris commented on code in PR #8384: URL: https://github.com/apache/pinot/pull/8384#discussion_r862663474 ## pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkNativeVsLuceneTextIndex.java: ## @@ -0,0 +1,267 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under