KKcorps commented on PR #6703:
URL: https://github.com/apache/pinot/pull/6703#issuecomment-1115753602
@kkrugler - Makes sense. So what this PR does for s3 plugin has to be
repeated for every other plugin as well, right?
--
This is an automated message from the Apache Git Service.
To respo
vvivekiyer opened a new issue, #8627:
URL: https://github.com/apache/pinot/issues/8627
Handle `false`, `0` and `0.0` as FALSE. All other values as true.
This is a follow-up change to #8444
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
vvivekiyer commented on issue #8444:
URL: https://github.com/apache/pinot/issues/8444#issuecomment-1115721040
Hi Johan, yes it should. I just tested it out locally for a use-case. I
didn't add a test-case example because AND, OR, NOT are processed similarly.
--
This is an automated messa
codecov-commenter commented on PR #8626:
URL: https://github.com/apache/pinot/pull/8626#issuecomment-1115562862
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/8626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
saurabhd336 commented on issue #8318:
URL: https://github.com/apache/pinot/issues/8318#issuecomment-1115561178
These PRs add this functionality
https://github.com/apache/pinot/pull/8514
https://github.com/apache/pinot/pull/8606
--
This is an automated message from the Apache Git Serv
jadami10 commented on issue #8444:
URL: https://github.com/apache/pinot/issues/8444#issuecomment-1115558830
thanks for working on this! I didn't see a test example, but does `WHERE NOT
` work correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message
npawar commented on code in PR #8601:
URL: https://github.com/apache/pinot/pull/8601#discussion_r863331285
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##
@@ -64,6 +64,7 @@ public class IndexingConfig extends BaseJsonConfig {
// TODO: Add
npawar merged PR #8606:
URL: https://github.com/apache/pinot/pull/8606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.
This is an automated email from the ASF dual-hosted git repository.
nehapawar pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from d49d1173f9 Support filtering on bool/scalar fields without evaluator
(#8518)
add 4e14101f57 Add unrecognizedPr
npawar commented on code in PR #8601:
URL: https://github.com/apache/pinot/pull/8601#discussion_r863329647
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##
@@ -64,6 +64,7 @@ public class IndexingConfig extends BaseJsonConfig {
// TODO: Add
Jackie-Jiang opened a new pull request, #8626:
URL: https://github.com/apache/pinot/pull/8626
Sub-task of #7430
Remove all PQL related code.
The UI cleanup for the PQL endpoint will be done separately.
--
This is an automated message from the Apache Git Service.
To respond to th
siddharthteotia closed issue #8444: Filtering on a boolean field with just the
field name results in NullPointerException
URL: https://github.com/apache/pinot/issues/8444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
siddharthteotia commented on issue #8444:
URL: https://github.com/apache/pinot/issues/8444#issuecomment-1115494899
Fixed with https://github.com/apache/pinot/pull/8518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
siddharthteotia commented on issue #8487:
URL: https://github.com/apache/pinot/issues/8487#issuecomment-1115494826
Fixed with https://github.com/apache/pinot/pull/8518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
siddharthteotia commented on issue #8607:
URL: https://github.com/apache/pinot/issues/8607#issuecomment-1115493629
One approach could be:
- Send query to all segments and all servers
- On the broker, pick the response with deepest tree and avoid merging
across segments
I thi
siddharthteotia commented on issue #8607:
URL: https://github.com/apache/pinot/issues/8607#issuecomment-1115489590
Working on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d49d1173f9 Support filtering on bool/scalar f
siddharthteotia merged PR #8518:
URL: https://github.com/apache/pinot/pull/8518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
Jackie-Jiang commented on code in PR #8384:
URL: https://github.com/apache/pinot/pull/8384#discussion_r863245187
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java:
##
@@ -36,6 +40,45 @@ static void cleanupTextIndex(File segDir,
walterddr commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r863216579
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/user/AccessType.java:
##
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
walterddr commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r863216579
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/user/AccessType.java:
##
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
walterddr commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r863216579
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/user/AccessType.java:
##
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
walterddr commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r863219275
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/user/AccessType.java:
##
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
walterddr commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r863225039
##
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##
@@ -240,6 +242,8 @@ private static long getRandomInitialDelayInSeconds() {
priva
walterddr commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r863223973
##
pinot-core/src/main/java/org/apache/pinot/core/auth/BasicAuthUtils.java:
##
@@ -61,21 +64,43 @@ private BasicAuthUtils() {
* @return list of BasicAuthPrincipals
walterddr commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r863222689
##
pinot-core/src/main/java/org/apache/pinot/core/auth/BasicAuthUtils.java:
##
@@ -61,21 +64,43 @@ private BasicAuthUtils() {
* @return list of BasicAuthPrincipals
walterddr commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r863224473
##
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##
@@ -240,6 +242,8 @@ private static long getRandomInitialDelayInSeconds() {
priva
walterddr commented on code in PR #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r863216579
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/user/AccessType.java:
##
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
vvivekiyer commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r863226578
##
pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/PredicateComparisonRewriter.java:
##
@@ -33,75 +36,126 @@ public class PredicateComparisonRewriter i
vvivekiyer commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r863226257
##
pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/PredicateComparisonRewriter.java:
##
@@ -33,75 +36,126 @@ public class PredicateComparisonRewriter i
kkrugler commented on PR #6703:
URL: https://github.com/apache/pinot/pull/6703#issuecomment-1115404396
@KKcorps - A jar that has a `main()` method that's used from the command
line needs a logging implementation. Everything else should only be using the
`slf4j-api`. Otherwise (e.g. with the
skhatri opened a new pull request, #6703:
URL: https://github.com/apache/pinot/pull/6703
## Description
Add a description of your PR here.
Fix logging dependencies in pinot-spi #6364
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Controller
KKcorps commented on PR #6703:
URL: https://github.com/apache/pinot/pull/6703#issuecomment-1115367053
@kkrugler I closed it for inactivity. I am not sure if this change is
needed. Opening it again for review.
--
This is an automated message from the Apache Git Service.
To respond to the
ddcprg commented on code in PR #8625:
URL: https://github.com/apache/pinot/pull/8625#discussion_r863186080
##
pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java:
##
@@ -597,6 +599,14 @@ public static Serializable getFormattedValue(Object v
atris commented on code in PR #8384:
URL: https://github.com/apache/pinot/pull/8384#discussion_r863163455
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java:
##
@@ -36,6 +40,45 @@ static void cleanupTextIndex(File segDir, String
deemoliu commented on code in PR #8355:
URL: https://github.com/apache/pinot/pull/8355#discussion_r863153536
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotUpsertCapacityEstimationRestletResource.java:
##
@@ -0,0 +1,162 @@
+/**
+ * Licensed to t
deemoliu commented on code in PR #8355:
URL: https://github.com/apache/pinot/pull/8355#discussion_r863152979
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotUpsertCapacityEstimationRestletResource.java:
##
@@ -0,0 +1,162 @@
+/**
+ * Licensed to t
Jackie-Jiang commented on code in PR #8384:
URL: https://github.com/apache/pinot/pull/8384#discussion_r863129529
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java:
##
@@ -36,6 +40,45 @@ static void cleanupTextIndex(File segDir,
Jackie-Jiang commented on code in PR #8384:
URL: https://github.com/apache/pinot/pull/8384#discussion_r863124826
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NativeClusterIntegrationTest.java:
##
@@ -0,0 +1,203 @@
+/**
+ * Licensed to the Apache So
Jackie-Jiang commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r863118643
##
pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/PredicateComparisonRewriter.java:
##
@@ -33,75 +36,126 @@ public class PredicateComparisonRewriter
atris commented on code in PR #8384:
URL: https://github.com/apache/pinot/pull/8384#discussion_r863118224
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/NativeClusterIntegrationTest.java:
##
@@ -0,0 +1,203 @@
+/**
+ * Licensed to the Apache Software
Jackie-Jiang commented on code in PR #8384:
URL: https://github.com/apache/pinot/pull/8384#discussion_r863103934
##
pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkNativeVsLuceneTextIndex.java:
##
@@ -0,0 +1,214 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Jackie-Jiang commented on code in PR #8622:
URL: https://github.com/apache/pinot/pull/8622#discussion_r863048176
##
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/SelectTupleElementTransformFunction.java:
##
@@ -88,17 +90,24 @@ private static FieldSpe
suddendust commented on issue #8399:
URL: https://github.com/apache/pinot/issues/8399#issuecomment-1115181784
@Jackie-Jiang So I gave this a thought. Even if this new property is set to
true, then filter configs and transform configs should keep working, right? As
in, Pinot should store the
Jackie-Jiang commented on code in PR #8601:
URL: https://github.com/apache/pinot/pull/8601#discussion_r863044298
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##
@@ -64,6 +64,7 @@ public class IndexingConfig extends BaseJsonConfig {
// TODO
kkrugler commented on PR #6703:
URL: https://github.com/apache/pinot/pull/6703#issuecomment-1115139550
Hi @KKcorps - why was this closed? Removing direct dependencies on
`slf4j-impl` in lower-level jars is a good thing, usually. Or did this get
covered by a different PR?
--
This is an au
kkrugler commented on issue #8623:
URL: https://github.com/apache/pinot/issues/8623#issuecomment-1115135631
Hi @prashantg077 - this is a great question for the Pinot Slack workspace's
#general channel.
--
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch helix-1.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
omit 6fd2c7211b Upgrade Helix to 1.0.2
add 71a6e6379b adding in OBJECT type resolver (#8608)
add c373cb86e5 Add s
vvivekiyer commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r863014083
##
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##
@@ -163,94 +165,113 @@ public static FunctionContext
getFunction(Fun
vvivekiyer commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r863007035
##
pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/PredicateComparisonRewriter.java:
##
@@ -33,75 +36,126 @@ public class PredicateComparisonRewriter i
vvivekiyer commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r863005987
##
pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FilterKind.java:
##
@@ -19,33 +19,41 @@
package org.apache.pinot.pql.parsers.pql2.ast;
public en
vvivekiyer commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r863005499
##
pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/FilterKind.java:
##
@@ -19,33 +19,41 @@
package org.apache.pinot.pql.parsers.pql2.ast;
public en
vvivekiyer commented on code in PR #8518:
URL: https://github.com/apache/pinot/pull/8518#discussion_r862999137
##
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##
@@ -163,94 +165,113 @@ public static FunctionContext
getFunction(Fun
ddcprg commented on PR #8625:
URL: https://github.com/apache/pinot/pull/8625#issuecomment-1115088561
Fixes #8624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
ddcprg opened a new pull request, #8625:
URL: https://github.com/apache/pinot/pull/8625
Allow selection and formatting of TIMESTAMP_ARRAY type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ddcprg opened a new issue, #8624:
URL: https://github.com/apache/pinot/issues/8624
Given the following schema:
```
{
"schemaName": "alltypes",
"dimensionFieldSpecs": [
{
"name": "string_col",
"dataType": "STRING"
prashantg077 commented on issue #8623:
URL: https://github.com/apache/pinot/issues/8623#issuecomment-1114830560
cc: @siddharthteotia @Jackie-Jiang @jasperjiaguo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
richardstartin closed pull request #8619: Reduce Lucene fst allocations
URL: https://github.com/apache/pinot/pull/8619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
KKcorps commented on PR #6703:
URL: https://github.com/apache/pinot/pull/6703#issuecomment-1114703864
Closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
KKcorps closed pull request #6703: Remove slf4j-impl (#6364)
URL: https://github.com/apache/pinot/pull/6703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
KKcorps commented on PR #8467:
URL: https://github.com/apache/pinot/pull/8467#issuecomment-1114702582
LGTM! The only issue I see is the changes needed to handle https connections.
We can take that in another PR though.
--
This is an automated message from the Apache Git Service.
To resp
atris commented on code in PR #8384:
URL: https://github.com/apache/pinot/pull/8384#discussion_r862663474
##
pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkNativeVsLuceneTextIndex.java:
##
@@ -0,0 +1,267 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
62 matches
Mail list logo