Aravind-Suresh commented on code in PR #10897:
URL: https://github.com/apache/pinot/pull/10897#discussion_r1228964194
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -64,24 +71,42 @@ public static String likeToRegexpLike(String
Aravind-Suresh commented on code in PR #10897:
URL: https://github.com/apache/pinot/pull/10897#discussion_r1228963312
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -64,24 +71,42 @@ public static String likeToRegexpLike(String
shounakmk219 commented on code in PR #10905:
URL: https://github.com/apache/pinot/pull/10905#discussion_r1229065216
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/MultipleTreesBuilder.java:
##
@@ -104,7 +106,7 @@ public MultipleTreesBuild
saurabhd336 commented on PR #10905:
URL: https://github.com/apache/pinot/pull/10905#issuecomment-1590517422
Some minor comments but overall looks good to me. @shounakmk219 Please add
the design doc to PR description.
--
This is an automated message from the Apache Git Service.
To respond
saurabhd336 commented on code in PR #10905:
URL: https://github.com/apache/pinot/pull/10905#discussion_r1229020395
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/startree/v2/builder/StarTreeIndexSeparatorTest.java:
##
@@ -0,0 +1,103 @@
+/**
+ * Licensed to t
saurabhd336 commented on code in PR #10905:
URL: https://github.com/apache/pinot/pull/10905#discussion_r1229017691
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/MultipleTreesBuilder.java:
##
@@ -104,7 +106,7 @@ public MultipleTreesBuilde
Aravind-Suresh commented on code in PR #10897:
URL: https://github.com/apache/pinot/pull/10897#discussion_r1228992428
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -64,24 +71,42 @@ public static String likeToRegexpLike(String
Aravind-Suresh commented on code in PR #10897:
URL: https://github.com/apache/pinot/pull/10897#discussion_r1228971813
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -64,24 +71,42 @@ public static String likeToRegexpLike(String
Aravind-Suresh commented on code in PR #10897:
URL: https://github.com/apache/pinot/pull/10897#discussion_r1228971334
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -18,16 +18,23 @@
*/
package org.apache.pinot.common.utils;
Aravind-Suresh commented on code in PR #10897:
URL: https://github.com/apache/pinot/pull/10897#discussion_r1228964194
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -64,24 +71,42 @@ public static String likeToRegexpLike(String
Aravind-Suresh commented on code in PR #10897:
URL: https://github.com/apache/pinot/pull/10897#discussion_r1228963312
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -64,24 +71,42 @@ public static String likeToRegexpLike(String
snleee merged PR #10874:
URL: https://github.com/apache/pinot/pull/10874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 449c95c6b9 Making segmentMapper do the init and cl
snleee commented on PR #10874:
URL: https://github.com/apache/pinot/pull/10874#issuecomment-1590409301
Thank you for addressing comments quickly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
codecov-commenter commented on PR #10909:
URL: https://github.com/apache/pinot/pull/10909#issuecomment-1590250067
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
ankitsultana opened a new issue, #10910:
URL: https://github.com/apache/pinot/issues/10910
Saw this in my PR:
https://github.com/apache/pinot/actions/runs/5261333672/jobs/9509328866?pr=10895
```
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.922
s - in
o
wirybeaver commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228831190
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -884,6 +865,47 @@ public SuccessResponse deleteSe
ankitsultana commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228820464
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -884,6 +865,47 @@ public SuccessResponse delete
codecov-commenter commented on PR #10908:
URL: https://github.com/apache/pinot/pull/10908#issuecomment-1590222667
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10908?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
ankitsultana commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228820464
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -884,6 +865,47 @@ public SuccessResponse delete
Jackie-Jiang opened a new pull request, #10909:
URL: https://github.com/apache/pinot/pull/10909
- Fix the wrong arguments in `waitForCondition()`: currently check interval
is 10s, while timeout is 1s
- Still validate the exception message, but also log the message if the
validation fails
jtao15 commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228816672
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -884,6 +865,47 @@ public SuccessResponse deleteSegmen
swaminathanmanish commented on PR #10874:
URL: https://github.com/apache/pinot/pull/10874#issuecomment-1589897248
> Since we are modifying this, I'd suggest just cleaning up the old code and
always open and close the file within the segment mapper. Keeping both
constructors adds a lot of co
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 1d9682fc67 Enable case insensitivity by default (#10771)
add 14670f49f6 Add clpDecode transform function for dec
chenboat merged PR #10885:
URL: https://github.com/apache/pinot/pull/10885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
Jackie-Jiang commented on issue #10793:
URL: https://github.com/apache/pinot/issues/10793#issuecomment-1590195526
> In the `ALL` columns mode, we generate min/max for all the columns. What
would be the possible reason for missing the min/max value for the metric
aggregation column? Thanks
GSharayu commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228803682
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -884,6 +865,47 @@ public SuccessResponse deleteSegm
walterddr commented on PR #10813:
URL: https://github.com/apache/pinot/pull/10813#issuecomment-1590192112
updating this PR with the suggestions above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
abhioncbr closed issue #10686: Incorrect float/double column comparison.
URL: https://github.com/apache/pinot/issues/10686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/pinot-plugins/pinot-stream-ingestion/pinot-pulsar/org.eclipse.jetty-jetty-server-9.4.51.v20230217
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 16007e
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/pinot-plugins/pinot-stream-ingestion/pinot-pulsar/org.eclipse.jetty-jetty-server-10.0.14
in repository https://gitbox.apache.org/repos/asf/pinot.git
was da0bd2c96f Bump
dependabot[bot] opened a new pull request, #10908:
URL: https://github.com/apache/pinot/pull/10908
Bumps [jetty-server](https://github.com/eclipse/jetty.project) from
9.4.45.v20220203 to 9.4.51.v20230217.
Release notes
Sourced from https://github.com/eclipse/jetty.project/releases"
dependabot[bot] closed pull request #10640: Bump jetty-server from
9.4.45.v20220203 to 10.0.14 in
/pinot-plugins/pinot-stream-ingestion/pinot-pulsar
URL: https://github.com/apache/pinot/pull/10640
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dependabot[bot] commented on PR #10640:
URL: https://github.com/apache/pinot/pull/10640#issuecomment-1590175532
Superseded by #10908.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
abhioncbr closed issue #10890: Update ReplicaGroupPartitionConfig &
ReplicaGroupStrategyConfig validation for partitionColumn
URL: https://github.com/apache/pinot/issues/10890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
Jackie-Jiang commented on code in PR #10874:
URL: https://github.com/apache/pinot/pull/10874#discussion_r1228656776
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java:
##
@@ -72,11 +73,34 @@ public SegmentProcessorFramew
wirybeaver commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228753300
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -1130,4 +1152,38 @@ private SuccessResponse
upda
walterddr commented on code in PR #10814:
URL: https://github.com/apache/pinot/pull/10814#discussion_r1228464036
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RelToPlanNodeConverter.java:
##
@@ -209,8 +209,8 @@ public static DataSchema.ColumnDataTyp
wirybeaver commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228752953
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotSegmentRestletResourceTest.java:
##
@@ -165,6 +165,30 @@ public void testSegmentCrcApi()
codecov-commenter commented on PR #10845:
URL: https://github.com/apache/pinot/pull/10845#issuecomment-1590081259
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
tibrewalpratik17 commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228721254
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/PinotSegmentRestletResourceTest.java:
##
@@ -165,6 +165,30 @@ public void testSegmentCrcApi()
tibrewalpratik17 commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1228718762
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -1130,4 +1152,38 @@ private SuccessResponse
chenboat commented on code in PR #10885:
URL: https://github.com/apache/pinot/pull/10885#discussion_r1228711755
##
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/CLPDecodeTransformFunction.java:
##
@@ -0,0 +1,120 @@
+/**
+ * Licensed to the Apache Sof
abhioncbr commented on issue #10890:
URL: https://github.com/apache/pinot/issues/10890#issuecomment-1590016938
I that case, we can close this issue as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
swaminathanmanish commented on code in PR #10874:
URL: https://github.com/apache/pinot/pull/10874#discussion_r1228679056
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java:
##
@@ -72,11 +73,34 @@ public SegmentProcessorF
swaminathanmanish commented on code in PR #10874:
URL: https://github.com/apache/pinot/pull/10874#discussion_r1228678255
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java:
##
@@ -72,11 +73,34 @@ public SegmentProcessorF
snleee commented on code in PR #10874:
URL: https://github.com/apache/pinot/pull/10874#discussion_r1228654274
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentProcessorFramework.java:
##
@@ -72,11 +73,34 @@ public SegmentProcessorFramework(Li
ege-st opened a new issue, #10907:
URL: https://github.com/apache/pinot/issues/10907
## Issue
Enabling NULL support on a table _after_ the table has data will result in
incorrect query results
for NULL expressions (i.e., `IS NULL` and `IS NOT NULL`). The Null Value
Vector bitmap is us
ankitsultana commented on PR #10895:
URL: https://github.com/apache/pinot/pull/10895#issuecomment-1589897506
@Jackie-Jiang : can you take a look at this again?
I'll run a test on local to verify the configs are indeed working and will
get back soon. But lmk if you have any other quest
abhioncbr commented on issue #10686:
URL: https://github.com/apache/pinot/issues/10686#issuecomment-1589880858
We can close this one. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
codecov-commenter commented on PR #10906:
URL: https://github.com/apache/pinot/pull/10906#issuecomment-1589876339
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10906?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
atris commented on issue #10865:
URL: https://github.com/apache/pinot/issues/10865#issuecomment-1589865736
I am trying to understand this -- is the ask that stop words be not removed
during analysis (i.e. allow pluggable analysers)?
--
This is an automated message from the Apache Git Serv
atris commented on code in PR #10897:
URL: https://github.com/apache/pinot/pull/10897#discussion_r1228567126
##
pinot-common/src/main/java/org/apache/pinot/common/utils/RegexpPatternConverterUtils.java:
##
@@ -18,16 +18,23 @@
*/
package org.apache.pinot.common.utils;
+impor
Jackie-Jiang commented on issue #10872:
URL: https://github.com/apache/pinot/issues/10872#issuecomment-1589844576
Same topic as #7043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Jackie-Jiang closed issue #10868: Segment Purger cannot purge old segments
after schema evolution
URL: https://github.com/apache/pinot/issues/10868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1d9682fc67 Enable case insensitivity by default (
Jackie-Jiang merged PR #10771:
URL: https://github.com/apache/pinot/pull/10771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on issue #10865:
URL: https://github.com/apache/pinot/issues/10865#issuecomment-1589835406
cc Lucene experts: @atris @siddharthteotia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
Jackie-Jiang commented on issue #10844:
URL: https://github.com/apache/pinot/issues/10844#issuecomment-1589832541
Do you have SSD attached to your servers? If so, you may change the data
directory in the server config to point to the SSD. You may reference this page
for the server config:
Jackie-Jiang merged PR #10814:
URL: https://github.com/apache/pinot/pull/10814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 3dbdaf60b5 Fix colocated join quickstart script (#10889)
add 0a97ca81f3 [multistage][float-double-comparison]: upd
Jackie-Jiang commented on issue #10890:
URL: https://github.com/apache/pinot/issues/10890#issuecomment-1589821230
I closed #10877 because I think the validation might be okay as it only
blocks new uploaded configs. It will force users to use the new
`partitionColumn` within the `ReplicaGrou
abhioncbr commented on PR #10814:
URL: https://github.com/apache/pinot/pull/10814#issuecomment-1589816555
Okay, it's good to be merged. Thanks, @walterddr, for the help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chenboat merged PR #10889:
URL: https://github.com/apache/pinot/pull/10889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3dbdaf60b5 Fix colocated join quickstart script
klsince opened a new pull request, #10906:
URL: https://github.com/apache/pinot/pull/10906
a bit cleanup for the aws sdk version as set in pom.xml files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
walterddr commented on issue #10901:
URL: https://github.com/apache/pinot/issues/10901#issuecomment-1589763083
thank you @abhioncbr please share what you had in mind before implementing
it.
there's 2 part in this.
1. syntax to explain physical plan. we might be able to do somethin
abhioncbr commented on issue #10901:
URL: https://github.com/apache/pinot/issues/10901#issuecomment-1589752350
Please assign this to me. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 207036950a Close PinotFS after Data Manager Shutdowns (#10888)
add 0420414fc2 bump awssdk version for a bugfix on h
walterddr merged PR #10898:
URL: https://github.com/apache/pinot/pull/10898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
shenyu0127 commented on code in PR #10613:
URL: https://github.com/apache/pinot/pull/10613#discussion_r1228422910
##
pinot-core/src/main/java/org/apache/pinot/core/operator/docvalsets/TransformBlockValSet.java:
##
@@ -46,47 +45,23 @@ public class TransformBlockValSet implements
abhioncbr commented on PR #10814:
URL: https://github.com/apache/pinot/pull/10814#issuecomment-1589611356
> this looks good to me. let's wait for the test to complete
I don't think integration test failure is related to these PR changes
```
Error: Failures:
Error:MultiNo
abhioncbr closed pull request #10814: [multistage][float-double-comparison]:
updated for CAST function addition based on correct precision.
URL: https://github.com/apache/pinot/pull/10814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
codecov-commenter commented on PR #10905:
URL: https://github.com/apache/pinot/pull/10905#issuecomment-1589367249
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10905?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
shounakmk219 opened a new pull request, #10905:
URL: https://github.com/apache/pinot/pull/10905
Currently if you add a new StarTree index to the table we end up throwing
all existing StarTree indexes and rebuild all from scratch, not the new one
only. Same goes for a StarTree index deletion
lukaseder commented on issue #10879:
URL: https://github.com/apache/pinot/issues/10879#issuecomment-1589205560
Folks, I was pointed here from twitter. Maybe, this blog post helps with the
delicate JDBC statement execution protocol:
https://blog.jooq.org/how-i-incorrectly-fetched-jdbc-resu
codecov-commenter commented on PR #10899:
URL: https://github.com/apache/pinot/pull/10899#issuecomment-1588753054
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10899?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
gortiz commented on issue #8837:
URL: https://github.com/apache/pinot/issues/8837#issuecomment-1588669490
The main issue with reverse iterator is that there are a lot of places where
it is assumed the cursors are ascending. Therefore adding a reverse iterator
seems very intrusive and may ha
78 matches
Mail list logo
