gortiz commented on PR #11090:
URL: https://github.com/apache/pinot/pull/11090#issuecomment-1633633421
Nice. AFAIK we don't directly use lombok in Pinot (which is great, I hate
lombok :laughing:) , but some of our dependencies does.
--
This is an automated message from the Apache Git
shounakmk219 commented on code in PR #11077:
URL: https://github.com/apache/pinot/pull/11077#discussion_r1262024816
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -4128,6 +4129,29 @@ public PeriodicTaskInvocationRes
saurabhd336 commented on code in PR #11077:
URL: https://github.com/apache/pinot/pull/11077#discussion_r1261988572
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -4128,6 +4129,29 @@ public PeriodicTaskInvocationResp
codecov-commenter commented on PR #11097:
URL: https://github.com/apache/pinot/pull/11097#issuecomment-1633518930
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11097?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
snleee commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1261943671
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -884,6 +865,52 @@ public SuccessResponse deleteSegmen
snleee commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1261943671
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -884,6 +865,52 @@ public SuccessResponse deleteSegmen
xiangfu0 opened a new pull request, #11097:
URL: https://github.com/apache/pinot/pull/11097
Register dateTimeConverter,timeConvert,dateTrunc to v2 functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
codecov-commenter commented on PR #11096:
URL: https://github.com/apache/pinot/pull/11096#issuecomment-1633449426
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11096?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
shenyu0127 opened a new pull request, #11096:
URL: https://github.com/apache/pinot/pull/11096
@Jackie-Jiang helped me identify the root cause.
For more explanations see https://github.com/apache/pinot/issues/11084.
--
This is an automated message from the Apache Git Service.
To resp
shenyu0127 commented on issue #11084:
URL: https://github.com/apache/pinot/issues/11084#issuecomment-1633416641
@Jackie-Jiang helped me identify the root cause.
The realtime segments are created non-deterministically because the Kafka
partitioning is using the system time
([ref](http
zhouxiz9 commented on PR #10979:
URL: https://github.com/apache/pinot/pull/10979#issuecomment-1633346951
@Jackie-Jiang @jtao15 Your concern make sense. I'm thinking we can make this
an optional mode like the 'processAll' mode so that people can opt in to skip.
--
This is an automated mess
zhouxiz9 commented on code in PR #10979:
URL: https://github.com/apache/pinot/pull/10979#discussion_r1261828779
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##
@@ -656
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b39329966f Allow using Lucene text indexes on m
chenboat merged PR #11093:
URL: https://github.com/apache/pinot/pull/11093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
codecov-commenter commented on PR #11092:
URL: https://github.com/apache/pinot/pull/11092#issuecomment-1633317372
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11092?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
robertzych commented on code in PR #10463:
URL: https://github.com/apache/pinot/pull/10463#discussion_r1261780186
##
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##
@@ -136,4 +136,18 @@ public static class SegmentGenerationAndPushTask {
public
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4e1c8fc94f Adding alias for Transform function t
xiangfu0 merged PR #11094:
URL: https://github.com/apache/pinot/pull/11094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
JeffBolle commented on PR #10995:
URL: https://github.com/apache/pinot/pull/10995#issuecomment-1633231149
I think we are at a good place. I've pushed the changes to take in a list of
fields to parse, and I've got the branch building and passing tests in the
`pinot-pulsar` package.
--
Thi
egalpin commented on issue #10712:
URL: https://github.com/apache/pinot/issues/10712#issuecomment-1633182873
My original motivation was to add the ability to replace a table in a way
that was transparent to anything issuing queries. Ex. `myTable` is a realtime
upsert table with 8 kafka par
shenyu0127 commented on issue #11084:
URL: https://github.com/apache/pinot/issues/11084#issuecomment-1633156919
Taking a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
tibrewalpratik17 commented on issue #10606:
URL: https://github.com/apache/pinot/issues/10606#issuecomment-1633106208
I am working with @ankitsultana on the design doc for this.
Please assign to me! cc @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respon
codecov-commenter commented on PR #11094:
URL: https://github.com/apache/pinot/pull/11094#issuecomment-1633054955
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11094?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
davizucon opened a new pull request, #11095:
URL: https://github.com/apache/pinot/pull/11095
When submitting job for read data from some FS like S3, the minion need to
have permission to read data.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from c302354dd7 Minor fix on AddTableCommand.toString() (#11082)
add 20bef67a56 Upgrade swagger-ui from 3.23.11 to 5.1.
Jackie-Jiang merged PR #11091:
URL: https://github.com/apache/pinot/pull/11091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
mcvsubbu commented on issue #10712:
URL: https://github.com/apache/pinot/issues/10712#issuecomment-1633046260
>
I think the mytable_REALTIME and mytable_OFFLINE is not quite the same
analogy. In the case of REALTIME and OFFLINE, the expectation is that the two
tables contain the sam
Jackie-Jiang commented on PR #11073:
URL: https://github.com/apache/pinot/pull/11073#issuecomment-1633044428
Please take a look at the failed test, and consider adding some new test to
validate the change
--
This is an automated message from the Apache Git Service.
To respond to the messa
Jackie-Jiang commented on code in PR #11073:
URL: https://github.com/apache/pinot/pull/11073#discussion_r1261580052
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##
@@ -226,8 +226,12 @@ public RebalanceResult rebalance(T
mcvsubbu commented on issue #10712:
URL: https://github.com/apache/pinot/issues/10712#issuecomment-1633043820
> +1 on this. We can introduce the logical table concept which is used in
the query, and by default using the physical table name as the logical table.
With logical table concept, w
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 02715141f5 Upgraded commons-cli and commons-lang3 package version.
(#11083)
add c302354dd7 Minor fix on AddTableC
Jackie-Jiang merged PR #11082:
URL: https://github.com/apache/pinot/pull/11082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on PR #11089:
URL: https://github.com/apache/pinot/pull/11089#issuecomment-1633012503
cc @yupeng9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Jackie-Jiang commented on PR #11090:
URL: https://github.com/apache/pinot/pull/11090#issuecomment-1633010256
cc @gortiz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 4f45907931 Update jackson libraries to 2.13.5 (#11081)
add 02715141f5 Upgraded commons-cli and commons-lang3 packa
Jackie-Jiang merged PR #11083:
URL: https://github.com/apache/pinot/pull/11083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 5b157dfcf5 Delete an obsolete TODO. (#11080)
add 4f45907931 Update jackson libraries to 2.13.5 (#11081)
No new re
Jackie-Jiang merged PR #11081:
URL: https://github.com/apache/pinot/pull/11081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #10990:
URL: https://github.com/apache/pinot/pull/10990#discussion_r1261564543
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -605,6 +597,40 @@ static boolean i
richardstartin commented on issue #10986:
URL: https://github.com/apache/pinot/issues/10986#issuecomment-1632961236
I was suggesting to patch pinot to avoid calling `RangeBitmap.eq` in case
it's the cause of this bug. I can try to break `RangeBitmap.eq` and do a
release to unblock this, but
Jackie-Jiang commented on issue #10986:
URL: https://github.com/apache/pinot/issues/10986#issuecomment-1632957010
@shwin As @richardstartin suggested, can you try using BETWEEN with same
value and compare the result with EQ? Something like `where blockTimestamp_day
between fromDateTime('202
xiangfu0 opened a new pull request, #11094:
URL: https://github.com/apache/pinot/pull/11094
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
Jackie-Jiang merged PR #11080:
URL: https://github.com/apache/pinot/pull/11080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 3f15e10ffd Consistently use isNullRow in transform function tests.
(#11079)
add 5b157dfcf5 Delete an obsolete TOD
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3f15e10ffd Consistently use isNullRow in transfor
Jackie-Jiang merged PR #11079:
URL: https://github.com/apache/pinot/pull/11079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
JeffBolle commented on code in PR #10995:
URL: https://github.com/apache/pinot/pull/10995#discussion_r1261432675
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarMetadataExtractor.java:
##
@@ -0,0 +1,124 @@
+/**
+ * L
JeffBolle commented on code in PR #10995:
URL: https://github.com/apache/pinot/pull/10995#discussion_r1261431874
##
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarStreamMessage.java:
##
@@ -0,0 +1,47 @@
+/**
+ * Licens
codecov-commenter commented on PR #11093:
URL: https://github.com/apache/pinot/pull/11093#issuecomment-1632810862
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11093?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 7f855a5220 Fix grpc regression on multi-stage engine (#11086)
add 0350c9b5bd Set _disableAcl appropriately wh
saurabhd336 merged PR #11087:
URL: https://github.com/apache/pinot/pull/11087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.
kirkrodrigues opened a new pull request, #11093:
URL: https://github.com/apache/pinot/pull/11093
tags: bugfix
#11000 added support for Lucene text indexes on mutable MV columns; this PR
enables their use by updating `createMutableIndex` to reflect the change in
#11000.
# Testi
codecov-commenter commented on PR #11091:
URL: https://github.com/apache/pinot/pull/11091#issuecomment-1632703702
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11091?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
geekboood closed issue #10844: Long respond time with simple filter query
URL: https://github.com/apache/pinot/issues/10844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
geekboood commented on issue #10844:
URL: https://github.com/apache/pinot/issues/10844#issuecomment-1632650695
Adding SSD improved overall performance. I add a bcache layer using SSD to
Pinot data drive and the performance drastically improved, both initial
starting and querying. For Pinot,
geekboood commented on issue #10960:
URL: https://github.com/apache/pinot/issues/10960#issuecomment-1632644587
> When configuring xmx16G, java will use up to 16G heap and up to 16G direct
memory, mapped memory is not tracked though. The mapped memory can go over the
limit (OS should reclaim
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 437504331e Support for new dataTime format in
`DateTimeGranularitySpec` without explicitly setting size (#11057)
a
walterddr merged PR #11086:
URL: https://github.com/apache/pinot/pull/11086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
dario-liberman commented on PR #10867:
URL: https://github.com/apache/pinot/pull/10867#issuecomment-1632555378
> I am working on other aggregation strategies that do not require
partitioning -
[master...dario-liberman:pinot:funnel-strategies](https://github.com/apache/pinot/compare/master..
dario-liberman opened a new pull request, #11092:
URL: https://github.com/apache/pinot/pull/11092
PR for https://github.com/apache/pinot/issues/10866
This PR adds the remaining funnel count aggregation strategies documented in
[docs](https://github.com/dario-liberman/pinot-docs/blob/7
codecov-commenter commented on PR #11088:
URL: https://github.com/apache/pinot/pull/11088#issuecomment-1632419503
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11088?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #11089:
URL: https://github.com/apache/pinot/pull/11089#issuecomment-1632405785
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11089?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #11090:
URL: https://github.com/apache/pinot/pull/11090#issuecomment-1632404888
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11090?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
abhioncbr opened a new pull request, #11091:
URL: https://github.com/apache/pinot/pull/11091
- Upgrade `swagger-ui` dependency from `3.23.11` to `5.1.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.projectlombok-lombok-1.18.28
in repository https://gitbox.apache.org/repos/asf/pinot.git
at d94c2ed799 Bump lombok from 1.18.26 to 1.18.28
No new revisions were a
dependabot[bot] opened a new pull request, #11089:
URL: https://github.com/apache/pinot/pull/11089
Bumps jts-core from 1.16.1 to 1.19.0.
[ from 1.18.26 to
1.18.28.
Changelog
Sourced from https://github.com/projectlombok/lombok/blob/master/doc/changelog.markdown";>lo
tibrewalpratik17 commented on issue #11076:
URL: https://github.com/apache/pinot/issues/11076#issuecomment-1632304310
> hmm, I've explicitly build current master then revert
https://github.com/apache/pinot/pull/11074 and it fixed the problem...
maybe try to delete ~/.m2/repository/ cache
gortiz opened a new pull request, #11088:
URL: https://github.com/apache/pinot/pull/11088
Update AWS. This PR already derives from #11070 and therefore include these
changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xiangfu0 commented on issue #11076:
URL: https://github.com/apache/pinot/issues/11076#issuecomment-1632190711
maybe try to delete `~/.m2/repository/` cache then do `mvn clean install
-Pbin-dist -DskipTests -T1C` again ?
--
This is an automated message from the Apache Git Service.
To respo
codecov-commenter commented on PR #11087:
URL: https://github.com/apache/pinot/pull/11087#issuecomment-1632148585
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11087?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #11086:
URL: https://github.com/apache/pinot/pull/11086#issuecomment-1632131277
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11086?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
saurabhd336 opened a new pull request, #11087:
URL: https://github.com/apache/pinot/pull/11087
Allows for setting _disableAcl when initializing FS instance directly with
s3 client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
xiangfu0 commented on issue #11076:
URL: https://github.com/apache/pinot/issues/11076#issuecomment-1632045763
hmm, I've explicitly build current master then revert #11074 and it fixed
the problem...
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
tibrewalpratik17 commented on issue #11076:
URL: https://github.com/apache/pinot/issues/11076#issuecomment-1632038192
@xiangfu0 this change might not be related to this issue as it seems this is
happening in grpc-1.53.0 package. Plus i never pulled #11074 in my local as
it's very recent.
xiangfu0 commented on issue #11076:
URL: https://github.com/apache/pinot/issues/11076#issuecomment-1632033468
https://github.com/apache/pinot/pull/11086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
tibrewalpratik17 commented on issue #11076:
URL: https://github.com/apache/pinot/issues/11076#issuecomment-1632033455
> Can you share the EXACT command you used to build Pinot?
I used `mvn clean install -DskipTests -Pbin-dist` to build Pinot.
My maven version:
```
> mvn --vers
xiangfu0 opened a new pull request, #11086:
URL: https://github.com/apache/pinot/pull/11086
- revert `grpc-protobuf-lite` version
- Adding multi-stage quickstart to github Action CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
78 matches
Mail list logo
