Jackie-Jiang commented on code in PR #11715:
URL: https://github.com/apache/pinot/pull/11715#discussion_r1341915681
##
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java:
##
@@ -48,15 +48,12 @@ public static void
Jackie-Jiang commented on PR #11711:
URL: https://github.com/apache/pinot/pull/11711#issuecomment-1741687994
cc @gortiz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Jackie-Jiang opened a new issue, #11718:
URL: https://github.com/apache/pinot/issues/11718
```
Error: Failures:
Error:
StarTreeClusterIntegrationTest.testGeneratedQueries:163->testStarQuery:185
Query comparison failed for:
Star Query: SELECT avg(ArrDel15) FROM mytable WHERE
Jackie-Jiang commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1341914079
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -362,6 +365,11 @@ public static class QueryOptionKey {
public static
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ae1681273c Add more test for broker jersey
Jackie-Jiang merged PR #11705:
URL: https://github.com/apache/pinot/pull/11705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Jackie-Jiang opened a new pull request, #11717:
URL: https://github.com/apache/pinot/pull/11717
Fix #11435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
codecov-commenter commented on PR #11716:
URL: https://github.com/apache/pinot/pull/11716#issuecomment-1741607104
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11716?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
> Merging
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 82140f1177 JSON index: Add support for ignoring values longer than a
given length. (#11604)
add dcffc6dea1
Jackie-Jiang merged PR #11714:
URL: https://github.com/apache/pinot/pull/11714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
abhioncbr commented on code in PR #11653:
URL: https://github.com/apache/pinot/pull/11653#discussion_r1341865991
##
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##
@@ -297,6 +297,7 @@ public DataType toDataType() {
case TIMESTAMP:
Jackie-Jiang commented on PR #11716:
URL: https://github.com/apache/pinot/pull/11716#issuecomment-1741594165
This issue was introduced in #8503 where responses from aggregation are
stored as string, responses from other queries are stored as `BigDecimal`;
#11453 changed it to always store
Jackie-Jiang opened a new pull request, #11716:
URL: https://github.com/apache/pinot/pull/11716
It is best practice to store `BigDecimal` as string in JSON to prevent
losing precision.
Currently we directly serialize `BigDecimal` into number (without quote) in
the query response, but
abhioncbr commented on code in PR #11653:
URL: https://github.com/apache/pinot/pull/11653#discussion_r1341862027
##
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/ScalarTransformFunctionWrapperTest.java:
##
@@ -262,6 +262,27 @@ public void
walterddr closed pull request #11686: [multistage] support legacy query
function "lookup" in multi-stage
URL: https://github.com/apache/pinot/pull/11686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
walterddr commented on PR #11686:
URL: https://github.com/apache/pinot/pull/11686#issuecomment-1741579551
closing as it is not a full support fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
codecov-commenter commented on PR #11715:
URL: https://github.com/apache/pinot/pull/11715#issuecomment-1741574245
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11715?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
> Merging
vvivekiyer opened a new pull request, #11715:
URL: https://github.com/apache/pinot/pull/11715
In #9092, we added query execution stats to fetch
setNumConsumingSegmentsProcessed and setNumConsumingSegmentsMatched
In one of our production clusters, we observed that
codecov-commenter commented on PR #11714:
URL: https://github.com/apache/pinot/pull/11714#issuecomment-1741493424
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11714?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
> Merging
ege-st commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1341787880
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##
@@ -170,15 +171,18 @@ public
ege-st commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1341781521
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -168,6 +169,19 @@ protected byte[]
ege-st commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1341779996
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -318,6 +318,9 @@ public static class Broker {
weixiangsun opened a new pull request, #11714:
URL: https://github.com/apache/pinot/pull/11714
This is bugfix for Gapfill SumAvgGapfillProcessor. The bug is that
SumAvgGapfillProcessor is not using the correct previous value before doing the
gapfill. The value after the gapfill range
zhtaoxiang commented on PR #11711:
URL: https://github.com/apache/pinot/pull/11711#issuecomment-1741368196
I approved the PR by accident
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zhtaoxiang commented on code in PR #11711:
URL: https://github.com/apache/pinot/pull/11711#discussion_r1341714287
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentIndexCreationDriverImpl.java:
##
@@ -313,6 +325,36 @@ private void
Jackie-Jiang closed issue #11445: [multistage] infer query runner host from
broker or server hostname
URL: https://github.com/apache/pinot/issues/11445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
siddharthteotia commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1341681228
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -168,6 +169,19 @@ protected byte[]
siddharthteotia commented on PR #11575:
URL: https://github.com/apache/pinot/pull/11575#issuecomment-1741307162
I think @Jackie-Jiang has a comment. I am good with merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
siddharthteotia commented on PR #11575:
URL: https://github.com/apache/pinot/pull/11575#issuecomment-1741305937
> But maybe what do you mean is that in some place in this PR I'm not
calling the version with the supplier and therefore the value never change. It
wouldn't be strange given
jasperjiaguo commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1341666747
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -168,6 +169,19 @@ protected byte[]
siddharthteotia commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1341664954
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##
@@ -1654,6 +1669,24 @@ private long
siddharthteotia commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1341663123
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -362,6 +365,11 @@ public static class QueryOptionKey {
public static
siddharthteotia commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1341663319
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -318,6 +318,9 @@ public static class Broker {
siddharthteotia commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1341663319
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -318,6 +318,9 @@ public static class Broker {
vvivekiyer commented on PR #11710:
URL: https://github.com/apache/pinot/pull/11710#issuecomment-1741230828
> How will a user determine what the threshold should be?
@ege-st
Good question. We did think about this. The ideal answer is that the value
is use case dependent.
chenboat merged PR #11604:
URL: https://github.com/apache/pinot/pull/11604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 82140f1177 JSON index: Add support for
ege-st commented on PR #11710:
URL: https://github.com/apache/pinot/pull/11710#issuecomment-1740980503
Cool, thanks! I think reducing the likelyhood of DM OOMs is the logical next
step.
How will a user determine what the threshold should be? A critical
requirement for a feature like
codecov-commenter commented on PR #11713:
URL: https://github.com/apache/pinot/pull/11713#issuecomment-1740964085
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11713?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
> Merging
swaminathanmanish commented on code in PR #11712:
URL: https://github.com/apache/pinot/pull/11712#discussion_r1341419664
##
pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufRecordExtractor.java:
##
@@ -62,7 +62,7
mcvsubbu opened a new pull request, #11713:
URL: https://github.com/apache/pinot/pull/11713
Allows us to compute the total thread cpu time each table uses for queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
codecov-commenter commented on PR #11712:
URL: https://github.com/apache/pinot/pull/11712#issuecomment-1740862007
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11712?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
> Merging
gortiz opened a new pull request, #11712:
URL: https://github.com/apache/pinot/pull/11712
This PR adds a test to verify the correct nullability read on
`ProtoBufRecordExtractor`.
The PR is not yet ready to merge because for some reason the descriptor is
using v2 instead of 3.
codecov-commenter commented on PR #11711:
URL: https://github.com/apache/pinot/pull/11711#issuecomment-1740701803
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11711?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
> Merging
saurabhd336 opened a new pull request, #11711:
URL: https://github.com/apache/pinot/pull/11711
It may be desirable for some index types to be build post segment file has
been created. This PR allows for that.
--
This is an automated message from the Apache Git Service.
To respond to the
codecov-commenter commented on PR #11710:
URL: https://github.com/apache/pinot/pull/11710#issuecomment-1740388935
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11710?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
> Merging
gortiz commented on PR #11710:
URL: https://github.com/apache/pinot/pull/11710#issuecomment-1740385931
I've added some notes, but I think the PR is in good shape
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gortiz commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1340953692
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##
@@ -602,6 +602,16 @@ public void testTimeFunc(boolean
gortiz commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1340952925
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -168,6 +169,19 @@ protected byte[]
gortiz commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1340952382
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -168,6 +169,19 @@ protected byte[]
codecov-commenter commented on PR #11709:
URL: https://github.com/apache/pinot/pull/11709#issuecomment-1740361099
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11709?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
> Merging
xiangfu0 commented on code in PR #11574:
URL: https://github.com/apache/pinot/pull/11574#discussion_r1340932616
##
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##
@@ -549,6 +555,69 @@ protected void configure() {
dang-stripe commented on PR #11650:
URL: https://github.com/apache/pinot/pull/11650#issuecomment-1740356183
Yes, we still want to use the global sequence ID which isn't supported by
the `FixedSegmentNameGenerator`. Another option here is to update
`FixedSegmentNameGenerator` to support
vvivekiyer opened a new pull request, #11710:
URL: https://github.com/apache/pinot/pull/11710
When server responds for a query with a large response, the broker can
potentially crash with direct memory OOM.
In PR https://github.com/apache/pinot/pull/11496 - a fix was added to
54 matches
Mail list logo
