codecov-commenter commented on PR #12479:
URL: https://github.com/apache/pinot/pull/12479#issuecomment-1960869640
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12479?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
ankitsultana opened a new pull request, #12479:
URL: https://github.com/apache/pinot/pull/12479
In #10895 I introduced this config, but I had made an error. I never
actually set this config in the final Apache HttpClient that gets created. This
fixes that.
**Test Plan**: Several inte
Jackie-Jiang commented on code in PR #12464:
URL: https://github.com/apache/pinot/pull/12464#discussion_r1500266732
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##
@@ -490,6 +493,19 @@ public static void validateIngestionConfig
Jackie-Jiang commented on issue #12390:
URL: https://github.com/apache/pinot/issues/12390#issuecomment-1960810712
Can you check the log and see if server started from OFFLINE state after
re-connecting to Helix? I think it is very possible because when re-connecting
to Helix, server will gen
jadami10 commented on PR #12464:
URL: https://github.com/apache/pinot/pull/12464#issuecomment-1960737917
@Jackie-Jiang, good call on using `FieldIndexConfigsUtil`. That definitely
caught some other cases like `noDictionaryConfigs` that we use as well. I
retested creating new tables and upda
snleee commented on issue #12448:
URL: https://github.com/apache/pinot/issues/12448#issuecomment-1960673472
@davecromberge Does `FlinkDeltaConnector` emit CDC (change data capture)
stream? How does it going to handle records update or delete? In other words,
what would be the strategy to sy
codecov-commenter commented on PR #12444:
URL: https://github.com/apache/pinot/pull/12444#issuecomment-1960628363
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12444?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #12478:
URL: https://github.com/apache/pinot/pull/12478#issuecomment-1960623429
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12478?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
Jackie-Jiang commented on PR #12294:
URL: https://github.com/apache/pinot/pull/12294#issuecomment-1960603781
Can you please take a look at the linter failure?
It would be very helpful if you can also include how many missing lines are
covered within this new test
--
This is an automate
sullis commented on PR #12478:
URL: https://github.com/apache/pinot/pull/12478#issuecomment-1960603005
WDYT? @gortiz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
Jackie-Jiang commented on PR #12354:
URL: https://github.com/apache/pinot/pull/12354#issuecomment-1960600876
The result is a little bit counter intuitive. In most cases, when null
handling is enabled, it should be much slower than when it is disabled because
we need to pay overhead of itera
sullis opened a new pull request, #12478:
URL: https://github.com/apache/pinot/pull/12478
Motivation:
reduce enum array allocation in QueryLogger
Modifications:
cache QueryLogEntry.values() in a static variable
Result:
Java enum .values() method is invoked e
Jackie-Jiang commented on code in PR #12403:
URL: https://github.com/apache/pinot/pull/12403#discussion_r1500108209
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##
@@ -379,12 +384,11 @@ private void setStatusToDefault() {
}
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-eclipse-plugin-2.10
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 621acf3b07 Bump org.apache.maven.plugins:maven-eclips
Jackie-Jiang commented on PR #12471:
URL: https://github.com/apache/pinot/pull/12471#issuecomment-1960564768
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
Jackie-Jiang commented on issue #12477:
URL: https://github.com/apache/pinot/issues/12477#issuecomment-1960550089
I can see multiple potential solutions:
- Server maintaining freshness status, and put that in the query response
when it is queried
- Limitation: We can only gather the
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d7feaaf4f8 cleanup: fix apache rat violation (#1247
klsince merged PR #12476:
URL: https://github.com/apache/pinot/pull/12476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
dttung2905 commented on code in PR #12386:
URL: https://github.com/apache/pinot/pull/12386#discussion_r1500064984
##
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStartableUtils.java:
##
@@ -61,6 +65,7 @@ public static void applyClusterConfig(PinotConfiguration
dang-stripe opened a new issue, #12477:
URL: https://github.com/apache/pinot/issues/12477
We want to be able to tell how fresh the overall realtime table is as part
of Pinot's query response.
`minConsumingFreshnessTimeMs` exists on the query response today but seems
to have some limi
sullis commented on PR #12476:
URL: https://github.com/apache/pinot/pull/12476#issuecomment-1960076134
cc: @jayeshchoudhary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sullis opened a new pull request, #12476:
URL: https://github.com/apache/pinot/pull/12476
fix Apache Rat violation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
MeihanLi commented on PR #12340:
URL: https://github.com/apache/pinot/pull/12340#issuecomment-1960003244
@Jackie-Jiang can you help merge the PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sullis commented on PR #12444:
URL: https://github.com/apache/pinot/pull/12444#issuecomment-1959990189
cc: @gortiz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
egalpin commented on issue #12355:
URL: https://github.com/apache/pinot/issues/12355#issuecomment-1959985260
I did find that Impala[1] uses `:` as a delimiter for list-type options.
Used in this issue context, it might look like: `myColumn=inverted:range`.
I'll look a bit more for other ex
egalpin commented on code in PR #12414:
URL: https://github.com/apache/pinot/pull/12414#discussion_r1499609689
##
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##
@@ -145,6 +149,33 @@ public static boolean isSkipScanFilterReorder(Map que
egalpin commented on code in PR #12414:
URL: https://github.com/apache/pinot/pull/12414#discussion_r1499585136
##
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##
@@ -145,6 +149,33 @@ public static boolean isSkipScanFilterReorder(Map que
egalpin commented on code in PR #12414:
URL: https://github.com/apache/pinot/pull/12414#discussion_r1499580763
##
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##
@@ -145,6 +149,33 @@ public static boolean isSkipScanFilterReorder(Map que
egalpin commented on issue #12355:
URL: https://github.com/apache/pinot/issues/12355#issuecomment-1959870319
@gortiz totally makes sense that we should be more careful in cases of
setting precedent. Are there any similar features in other DBs that would
provide familiar syntax? I'll take a
xiangfu0 commented on code in PR #12386:
URL: https://github.com/apache/pinot/pull/12386#discussion_r1499534130
##
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStartableUtils.java:
##
@@ -61,6 +65,7 @@ public static void applyClusterConfig(PinotConfiguration
xiangfu0 commented on code in PR #12386:
URL: https://github.com/apache/pinot/pull/12386#discussion_r1499534130
##
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStartableUtils.java:
##
@@ -61,6 +65,7 @@ public static void applyClusterConfig(PinotConfiguration
xiangfu0 commented on code in PR #12386:
URL: https://github.com/apache/pinot/pull/12386#discussion_r1499534130
##
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStartableUtils.java:
##
@@ -61,6 +65,7 @@ public static void applyClusterConfig(PinotConfiguration
xiangfu0 commented on code in PR #12462:
URL: https://github.com/apache/pinot/pull/12462#discussion_r1499529185
##
pinot-common/src/main/java/org/apache/pinot/common/utils/tls/JvmDefaultSslContext.java:
##
@@ -0,0 +1,101 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
gortiz commented on issue #12457:
URL: https://github.com/apache/pinot/issues/12457#issuecomment-1959791294
I've tried to use type coersion, but it doesn't seem to work as I expected.
I've asked about that in Apache Calcite email list (see
https://lists.apache.org/thread/6tsom4d962qd6zco4t9
gortiz commented on issue #12457:
URL: https://github.com/apache/pinot/issues/12457#issuecomment-1959788564
I've created this draft PR where I implemented a way to fail when casting
anything that is not binary into binary:
https://github.com/apache/pinot/pull/12475
--
This is an automate
gortiz opened a new pull request, #12475:
URL: https://github.com/apache/pinot/pull/12475
This PR adds a check that fails if there is an implicit or explicit cast
from to Bytes.
I still need to add some automatic tests, but I've tested manually. In a
query like:
```sql
select *
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6b0cfebffe share the same table config object (#124
klsince merged PR #12463:
URL: https://github.com/apache/pinot/pull/12463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
vineethvp opened a new issue, #12474:
URL: https://github.com/apache/pinot/issues/12474
I have a realtime table with threshold as 300 MB. After a certain number of
rows ingested ( say 3 lakhs), the consumption stops. Is there a way to debug
what is causing this issue?
The debug infor
codecov-commenter commented on PR #12473:
URL: https://github.com/apache/pinot/pull/12473#issuecomment-1959547383
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12473?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
xiangfu0 opened a new pull request, #12473:
URL: https://github.com/apache/pinot/pull/12473
Remove mercateo test clock dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
codecov-commenter commented on PR #12471:
URL: https://github.com/apache/pinot/pull/12471#issuecomment-1959324757
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12471?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #12472:
URL: https://github.com/apache/pinot/pull/12472#issuecomment-1959327208
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12472?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #12469:
URL: https://github.com/apache/pinot/pull/12469#issuecomment-1959327223
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12469?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #12470:
URL: https://github.com/apache/pinot/pull/12470#issuecomment-1959324599
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/com.h2database-h2-2.2.224
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 75d13eca36 Bump com.h2database:h2 from 2.2.220 to 2.2.224
No new revisions wer
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.apache.maven.scm-maven-scm-provider-gitexe-2.0.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 9655b8c8e8 Bump org.apache.maven.scm:maven-scm-prov
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-eclipse-plugin-2.10
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 621acf3b07 Bump org.apache.maven.plugins:maven-eclips
dependabot[bot] opened a new pull request, #12471:
URL: https://github.com/apache/pinot/pull/12471
Bumps org.apache.maven.plugins:maven-eclipse-plugin from 2.9 to 2.10.
[ from
2.2.220 to 2.2.224.
Release notes
Sourced from https://github.com/h2database/h2database/releases";>com.h2datab
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/dropwizard-metrics.version-4.2.25
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 6a5066749e Bump dropwizard-metrics.version from 4.2.23 to 4.2.25
No n
dependabot[bot] opened a new pull request, #12469:
URL: https://github.com/apache/pinot/pull/12469
Bumps `dropwizard-metrics.version` from 4.2.23 to 4.2.25.
Updates `io.dropwizard.metrics:metrics-core` from 4.2.23 to 4.2.25
Release notes
Sourced from https://github.com/dropwizard
gortiz commented on code in PR #12414:
URL: https://github.com/apache/pinot/pull/12414#discussion_r1499056482
##
pinot-common/src/main/java/org/apache/pinot/common/utils/config/QueryOptionsUtils.java:
##
@@ -145,6 +149,33 @@ public static boolean isSkipScanFilterReorder(Map quer
gortiz commented on PR #12414:
URL: https://github.com/apache/pinot/pull/12414#issuecomment-1959184631
It LGTM. As said in the linked issue, my main concern is on the language to
use. I think URL args is fine, but maybe we would need to have a bigger picture
because the language we decide t
gortiz commented on issue #12355:
URL: https://github.com/apache/pinot/issues/12355#issuecomment-1959178580
I really like this feature. What I'm not sure about is the syntax. Not
because I'm against URL params. But I would like to prioritize consistency
here. It doesn't seem we have other q
gortiz commented on PR #12265:
URL: https://github.com/apache/pinot/pull/12265#issuecomment-1959085779
> Also, I don't see the CI running for this PR. Can you re-push the commit
to trigger it?
Nice catch. @vvivekiyer, can you do that?
--
This is an automated message from the Apache
gortiz commented on code in PR #12265:
URL: https://github.com/apache/pinot/pull/12265#discussion_r1498970724
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##
@@ -303,7 +303,7 @@ private ColumnConfigDeserialize
gortiz commented on code in PR #12265:
URL: https://github.com/apache/pinot/pull/12265#discussion_r1498929879
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/AbstractSerdeIndexContract.java:
##
@@ -103,6 +106,14 @@ protected C getActualConfig(S
gortiz commented on code in PR #12265:
URL: https://github.com/apache/pinot/pull/12265#discussion_r1498929879
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/AbstractSerdeIndexContract.java:
##
@@ -103,6 +106,14 @@ protected C getActualConfig(S
gortiz commented on code in PR #12265:
URL: https://github.com/apache/pinot/pull/12265#discussion_r1498926674
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##
@@ -288,7 +288,7 @@ private Map
calculateIndexConfi
codecov-commenter commented on PR #12468:
URL: https://github.com/apache/pinot/pull/12468#issuecomment-1958964222
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 133ad9e41d Publish helm 0.2.8 (#12465)
133ad9e41
xiangfu0 commented on code in PR #12465:
URL: https://github.com/apache/pinot/pull/12465#discussion_r1498847109
##
helm/pinot/Chart.yaml:
##
@@ -21,15 +21,15 @@ apiVersion: v1
appVersion: 1.0.0
name: pinot
description: Apache Pinot is a realtime distributed OLAP datastore, wh
xiangfu0 merged PR #12465:
URL: https://github.com/apache/pinot/pull/12465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
Jackie-Jiang commented on issue #12312:
URL: https://github.com/apache/pinot/issues/12312#issuecomment-1958936575
I feel this is related to kafka decoder.
@snleee @swaminathanmanish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Jackie-Jiang commented on issue #11836:
URL: https://github.com/apache/pinot/issues/11836#issuecomment-1958933303
You may search more about how to solve this error:
```
[ERROR] Failed to execute goal on project pinot-broker: Could not resolve
depend
encies for project org.apache.pin
MeihanLi opened a new pull request, #12468:
URL: https://github.com/apache/pinot/pull/12468
`observability`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 839a91edae bugfix: re-add support for `not
ankitsultana merged PR #12372:
URL: https://github.com/apache/pinot/pull/12372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
MeihanLi closed pull request #12467: [Adaptive Server Selection] Emit Metrics
for Adaptive Server Selection type
URL: https://github.com/apache/pinot/pull/12467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
71 matches
Mail list logo
