codecov-commenter commented on PR #12673:
URL: https://github.com/apache/pinot/pull/12673#issuecomment-2005922208
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12673?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
shounakmk219 commented on code in PR #12591:
URL: https://github.com/apache/pinot/pull/12591#discussion_r1529779916
##
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##
@@ -344,6 +331,46 @@ private DispatchableSubPlan toDispatchableSubPlan(RelRoo
shounakmk219 commented on code in PR #12591:
URL: https://github.com/apache/pinot/pull/12591#discussion_r1529779433
##
pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java:
##
@@ -44,14 +50,46 @@
*/
public class PinotCatalog implements Schema {
abhioncbr commented on PR #12672:
URL: https://github.com/apache/pinot/pull/12672#issuecomment-2005830577
Thanks @gibbonjj for the contribution.
We recently updated commons-configuration1 package usage to
commons-configuration2[[issue
reference](https://github.com/apache/pinot/issue
soumitra-st opened a new pull request, #12673:
URL: https://github.com/apache/pinot/pull/12673
Adding null checks for cases:
1. If literal null is passes
2. No value passed
3. A variable is passed with null value during runtime
`cleanup`
--
This is an automated mess
vineethvp commented on issue #12660:
URL: https://github.com/apache/pinot/issues/12660#issuecomment-2005753209
HI @Jackie-Jiang I have 2 controller instances. I have checked the logs for
other controller as well. not seeing any logs related to retention there.
--
This is an automated mess
swaminathanmanish commented on PR #12671:
URL: https://github.com/apache/pinot/pull/12671#issuecomment-2005732023
> Fix a bug where a static singleton buffer was shared when reading message
Any context on how you found this problem?
--
This is an automated message from the Apache Gi
gibbonjj commented on issue #7882:
URL: https://github.com/apache/pinot/issues/7882#issuecomment-2005647581
I picked this up as a first commit to begin getting aquatinted with the
code. Here's a PR if this is still wanted:
https://github.com/apache/pinot/pull/12672
--
This is an automat
gibbonjj opened a new pull request, #12672:
URL: https://github.com/apache/pinot/pull/12672
The default behavior of PropertiesConfiguration when reading a .properties
file is to create an array of the duplicate values for the key instead of a
single string. This change throws a Configurati
codecov-commenter commented on PR #12671:
URL: https://github.com/apache/pinot/pull/12671#issuecomment-2005513807
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12671?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
snleee commented on code in PR #12459:
URL: https://github.com/apache/pinot/pull/12459#discussion_r1529520945
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##
@@ -534,66 +535,85 @@ private synchronized Map
scheduleTasks(L
Jackie-Jiang commented on code in PR #12663:
URL: https://github.com/apache/pinot/pull/12663#discussion_r1529498271
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -666,26 +666,40 @@ public SuccessResponse delet
Jackie-Jiang opened a new pull request, #12671:
URL: https://github.com/apache/pinot/pull/12671
Fix a bug where a static singleton buffer was shared when reading message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
snleee commented on PR #12459:
URL: https://github.com/apache/pinot/pull/12459#issuecomment-2005385172
@swaminathanmanish +1 on your point. I think that this feature naturally
fits better to the `tenant` config?
--
This is an automated message from the Apache Git Service.
To respond to th
swaminathanmanish commented on PR #12459:
URL: https://github.com/apache/pinot/pull/12459#issuecomment-2005348069
> minionInstanceTag
Just a thought to get clarity -
@Jackie-Jiang , @snleee, @tibrewalpratik17 - Why should minionInstanceTag
be at taskTypeConfigsMap instead of bei
swaminathanmanish commented on code in PR #12459:
URL: https://github.com/apache/pinot/pull/12459#discussion_r1529466472
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTaskRestletResource.java:
##
@@ -667,13 +667,12 @@ public Map getCronSchedule
swaminathanmanish commented on code in PR #12459:
URL: https://github.com/apache/pinot/pull/12459#discussion_r1529417960
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##
@@ -483,15 +484,15 @@ public void registerTaskGenera
klsince commented on code in PR #12440:
URL: https://github.com/apache/pinot/pull/12440#discussion_r1529050750
##
pinot-spi/src/main/java/org/apache/pinot/spi/env/SegmentMetadataPropertyReader.java:
##
@@ -0,0 +1,85 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
ankitsultana commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1529449729
##
pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java:
##
@@ -104,6 +104,15 @@ default StreamPartitionMsgOffset
getNextStreamPartitionMsgOffset
ankitsultana commented on code in PR #12602:
URL: https://github.com/apache/pinot/pull/12602#discussion_r1529431564
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/StreamIngestionConfig.java:
##
@@ -37,6 +37,9 @@ public class StreamIngestionConfig extends
dorlevi opened a new issue, #12670:
URL: https://github.com/apache/pinot/issues/12670
On Pinot V1 and on the new RC there are some issues with equality/inequality.
We first noticed this issue as we were trying to use != and <> operators on
a big_decimal field and we gotten a general e
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new def8a47f56 Logging a warn message instead of throw
snleee merged PR #12546:
URL: https://github.com/apache/pinot/pull/12546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
Jackie-Jiang commented on code in PR #12252:
URL: https://github.com/apache/pinot/pull/12252#discussion_r1529336185
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinMaxRangeAggregationFunction.java:
##
@@ -61,37 +61,29 @@ public GroupByResultHolder
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 5df0781558 Bump confluent.version from 7.2.6 to 7.6.0 (#12665)
add 6f54aac50b Bump kr.motd.maven:os-maven-plugin f
Jackie-Jiang merged PR #12666:
URL: https://github.com/apache/pinot/pull/12666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/kr.motd.maven-os-maven-plugin-1.7.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 2c636eadd7 Bump kr.motd.maven:os-maven-plugin from 1.6.2 to 1.7.1
The r
tibrewalpratik17 commented on code in PR #12663:
URL: https://github.com/apache/pinot/pull/12663#discussion_r1529333411
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -666,26 +666,38 @@ public SuccessResponse d
Jackie-Jiang merged PR #12665:
URL: https://github.com/apache/pinot/pull/12665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/confluent.version-7.6.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 4ab251b030 Bump confluent.version from 7.2.6 to 7.6.0
The revisions that were on thi
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 1d4d2e7e27 Bump okio.version from 3.8.0 to 3.9.0 (#12664)
add 5df0781558 Bump confluent.version from 7.2.6 to 7.6.
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1f668c72d2 Assign default value to newly added de
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1d4d2e7e27 Bump okio.version from 3.8.0 to 3.9.0
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/okio.version-3.9.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 53240800b3 Bump okio.version from 3.8.0 to 3.9.0
The revisions that were on this branch a
Jackie-Jiang merged PR #12664:
URL: https://github.com/apache/pinot/pull/12664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #12648:
URL: https://github.com/apache/pinot/pull/12648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #12663:
URL: https://github.com/apache/pinot/pull/12663#discussion_r1529326790
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -666,26 +666,38 @@ public SuccessResponse delet
tibrewalpratik17 commented on PR #12663:
URL: https://github.com/apache/pinot/pull/12663#issuecomment-2005040093
> Shall we integrate it into DELETE /segments/{tableName} and add an extra
parameter for target segments? If segments are not provided, we delete all
segments
Sounds good
Jackie-Jiang commented on code in PR #12201:
URL: https://github.com/apache/pinot/pull/12201#discussion_r1529293061
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableInstances.java:
##
@@ -170,9 +171,12 @@ public List getLiveBrokersForTable(
hpvd commented on issue #12658:
URL: https://github.com/apache/pinot/issues/12658#issuecomment-2005009753
it's not only possible to list a helm chart but also operators etc.
see https://artifacthub.io/docs/topics/repositories/
--
This is an automated message from the Apache Git Service.
hpvd commented on issue #12658:
URL: https://github.com/apache/pinot/issues/12658#issuecomment-2004999617
you can also directly request the `official status` which shows up nicely
with a label and within their search filter and give some more trust to it...
see: https://artifacthub.io
Jackie-Jiang commented on issue #12660:
URL: https://github.com/apache/pinot/issues/12660#issuecomment-2004997235
How many controllers do you have? If you have multiple controllers, each
table has a lead controller which handles the retention for it
--
This is an automated message from th
Jackie-Jiang commented on issue #12367:
URL: https://github.com/apache/pinot/issues/12367#issuecomment-2004993115
Yes. Let's first try to reproduce the failure, then see if adding a cast can
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 7c6ce9dffa maven-compiler-plugin 3.13.0 (#12669)
Jackie-Jiang merged PR #12669:
URL: https://github.com/apache/pinot/pull/12669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f4ea58066b Ignore case when checking for Direct M
Jackie-Jiang merged PR #12657:
URL: https://github.com/apache/pinot/pull/12657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on issue #12658:
URL: https://github.com/apache/pinot/issues/12658#issuecomment-2004985581
cc @xiangfu0 @zhtaoxiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
ankitsultana commented on PR #12459:
URL: https://github.com/apache/pinot/pull/12459#issuecomment-2004960090
@snleee @Jackie-Jiang : we'll be working on getting this merged this week,
so would be great if you folks can share your feedback.
@tibrewalpratik17 : can you also share what's
codecov-commenter commented on PR #12669:
URL: https://github.com/apache/pinot/pull/12669#issuecomment-2004688959
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12669?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
sullis opened a new pull request, #12669:
URL: https://github.com/apache/pinot/pull/12669
https://maven.apache.org/plugins/maven-compiler-plugin/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rohityadav1993 commented on code in PR #11983:
URL: https://github.com/apache/pinot/pull/11983#discussion_r1528985173
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##
@@ -918,32 +918,43 @@ static void validatePartialUpsertStrate
tibrewalpratik17 commented on issue #12667:
URL: https://github.com/apache/pinot/issues/12667#issuecomment-2004433249
> can you check if it aligned with segment commit time (replace consuming
segment with sealed segment)?
it can be addressed by https://github.com/apache/pinot/pull/11964
deemoliu commented on issue #12667:
URL: https://github.com/apache/pinot/issues/12667#issuecomment-2004428520
can you check if it aligned with segment commit time (replace consuming
segment with sealed segment)?
it can be addressed by #11964
--
This is an automated message from the Ap
marregui commented on issue #11434:
URL: https://github.com/apache/pinot/issues/11434#issuecomment-2004226050
I have pushed this PR https://github.com/apache/pinot/pull/12668 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
marregui opened a new pull request, #12668:
URL: https://github.com/apache/pinot/pull/12668
As per the request in https://github.com/apache/pinot/issues/11434 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
gortiz commented on code in PR #12271:
URL: https://github.com/apache/pinot/pull/12271#discussion_r1528760432
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileEstAggregationFunction.java:
##
@@ -133,28 +144,32 @@ public void aggregateGroupBy
gortiz commented on code in PR #12271:
URL: https://github.com/apache/pinot/pull/12271#discussion_r1528758023
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/PercentileEstAggregationFunction.java:
##
@@ -133,28 +144,32 @@ public void aggregateGroupBy
gortiz closed pull request #12236: Null aggr
URL: https://github.com/apache/pinot/pull/12236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
tibrewalpratik17 commented on issue #12667:
URL: https://github.com/apache/pinot/issues/12667#issuecomment-2004123906
> I don't think we can do any of the suggested approaches since it won't
scale.
Agreed! Any other solution you can think of? Ideally, we should give back
older recor
ankitsultana commented on issue #12667:
URL: https://github.com/apache/pinot/issues/12667#issuecomment-2004057480
I don't think we can do any of the suggested approaches since it won't
scale. The gap between add/remove should be on the order of microseconds
afaict. Let's confirm if this is
tibrewalpratik17 opened a new issue, #12667:
URL: https://github.com/apache/pinot/issues/12667
We have an partial-upsert table where the number of updates per key is
pretty high in a short period of time (within an hour we get 1000s of updates
for a key).
Between this, if we are quer
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/kr.motd.maven-os-maven-plugin-1.7.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 2c636eadd7 Bump kr.motd.maven:os-maven-plugin from 1.6.2 to 1.7.1
N
dependabot[bot] opened a new pull request, #12666:
URL: https://github.com/apache/pinot/pull/12666
Bumps
[kr.motd.maven:os-maven-plugin](https://github.com/trustin/os-maven-plugin)
from 1.6.2 to 1.7.1.
Release notes
Sourced from https://github.com/trustin/os-maven-plugin/releases"
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/confluent.version-7.6.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 4ab251b030 Bump confluent.version from 7.2.6 to 7.6.0
No new revisions were adde
dependabot[bot] opened a new pull request, #12665:
URL: https://github.com/apache/pinot/pull/12665
Bumps `confluent.version` from 7.2.6 to 7.6.0.
Updates `io.confluent:kafka-schema-registry-client` from 7.2.6 to 7.6.0
Commits
https://github.com/confluentinc/schema-registry/co
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/okio.version-3.9.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 53240800b3 Bump okio.version from 3.8.0 to 3.9.0
No new revisions were added by this
dependabot[bot] opened a new pull request, #12664:
URL: https://github.com/apache/pinot/pull/12664
Bumps `okio.version` from 3.8.0 to 3.9.0.
Updates `com.squareup.okio:okio` from 3.8.0 to 3.9.0
Changelog
Sourced from https://github.com/square/okio/blob/master/CHANGELOG.md";>com.s
gortiz commented on code in PR #12591:
URL: https://github.com/apache/pinot/pull/12591#discussion_r1528284373
##
pinot-query-planner/src/main/java/org/apache/pinot/query/catalog/PinotCatalog.java:
##
@@ -44,14 +50,46 @@
*/
public class PinotCatalog implements Schema {
+ pu
shounakmk219 commented on code in PR #12648:
URL: https://github.com/apache/pinot/pull/12648#discussion_r1528251944
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java:
##
@@ -368,17 +368,15 @@ prot
gortiz commented on code in PR #12591:
URL: https://github.com/apache/pinot/pull/12591#discussion_r1528246069
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -749,6 +758,76 @@ public void testSearch()
a
71 matches
Mail list logo
