Re: [PR] [null support] Allow fill the derived column with null when transform function failed to execute [pinot]

2024-03-31 Thread via GitHub
codecov-commenter commented on PR #12763: URL: https://github.com/apache/pinot/pull/12763#issuecomment-2029220791 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12763?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Update metric rules to emit database as a label [pinot]

2024-03-31 Thread via GitHub
shounakmk219 commented on code in PR #12739: URL: https://github.com/apache/pinot/pull/12739#discussion_r1545989048 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java: ## @@ -241,7 +242,7 @@ public void cleanupSegmentCountGauge(final String reso

Re: [PR] Update metric rules to emit database as a label [pinot]

2024-03-31 Thread via GitHub
zhtaoxiang commented on code in PR #12739: URL: https://github.com/apache/pinot/pull/12739#discussion_r1545985390 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/ValidationMetrics.java: ## @@ -241,7 +242,7 @@ public void cleanupSegmentCountGauge(final String resour

Re: [I] Transform function not handle null value [pinot]

2024-03-31 Thread via GitHub
xiangfu0 commented on issue #12762: URL: https://github.com/apache/pinot/issues/12762#issuecomment-2029187506 https://github.com/apache/pinot/pull/12763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] Transform function not handle null value [pinot]

2024-03-31 Thread via GitHub
xiangfu0 opened a new issue, #12762: URL: https://github.com/apache/pinot/issues/12762 Found this issue while adding a new column and trying to fill it up using a transform function. Segment reload/ingestion may fail due to the null value. ``` 2024/03/30 21:37:46.805 ERROR [Bas

Re: [I] NPE when broker header is null [pinot]

2024-03-31 Thread via GitHub
shounakmk219 commented on issue #12745: URL: https://github.com/apache/pinot/issues/12745#issuecomment-2029142242 Sure, I will take this up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Deterministic Hash Function for UUID Primary Keys [pinot]

2024-03-31 Thread via GitHub
ankitsultana commented on PR #12538: URL: https://github.com/apache/pinot/pull/12538#issuecomment-2029083877 @chenboat @satishd : I was thinking about this today and I think appending a null-byte is not the right approach, since it can lead to collisions (albeit on sub-optimally defined pri

Re: [PR] upgrade to slf4j 2.0.12 [pinot]

2024-03-31 Thread via GitHub
codecov-commenter commented on PR #12761: URL: https://github.com/apache/pinot/pull/12761#issuecomment-2029073417 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12761?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] upgrade to slf4j 2.0.12 [pinot]

2024-03-31 Thread via GitHub
sullis opened a new pull request, #12761: URL: https://github.com/apache/pinot/pull/12761 https://www.slf4j.org/news.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Add some additional metrics for Minion tasks [pinot]

2024-03-31 Thread via GitHub
vvivekiyer merged PR #12710: URL: https://github.com/apache/pinot/pull/12710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

(pinot) branch master updated: Add some additional metrics for Minion tasks (#12710)

2024-03-31 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 28aec2e01c Add some additional metrics for Mi

Re: [PR] Cleanup Javax and Jakarta dependencies [pinot]

2024-03-31 Thread via GitHub
codecov-commenter commented on PR #12760: URL: https://github.com/apache/pinot/pull/12760#issuecomment-2029022712 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12760?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Cleanup Javax and Jakarta dependencies [pinot]

2024-03-31 Thread via GitHub
Jackie-Jiang opened a new pull request, #12760: URL: https://github.com/apache/pinot/pull/12760 Jakarta dependency versions: - jakarta.servlet-api.version: 6.0.0 - jakarta.validation-api.version: 3.0.2 - jakarta.annotation-api.version: 2.1.1 - jakarta.xml.bind-api.version: 4.0.2