Re: [PR] Fetch the query quota capacity utilization rate broker metric in a callback function [pinot]

2024-05-08 Thread via GitHub
jasperjiaguo commented on code in PR #12767: URL: https://github.com/apache/pinot/pull/12767#discussion_r1595001778 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/MaxHitRateTracker.java: ## @@ -80,4 +82,14 @@ int getMaxCountPerBucket(long now) {

Re: [PR] Revert "Using local copy of segment instead of downloading from remote" [pinot]

2024-05-08 Thread via GitHub
swaminathanmanish commented on PR #13114: URL: https://github.com/apache/pinot/pull/13114#issuecomment-2101988578 @klsince - Could you please review ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Revert "Using local copy of segment instead of downloading from remote" [pinot]

2024-05-08 Thread via GitHub
swaminathanmanish opened a new pull request, #13114: URL: https://github.com/apache/pinot/pull/13114 Reverts apache/pinot#12863 until further verification. Seeing an error after this change, during metadata push. 2024/05/09 00:43:51.276 WARN

Re: [PR] Refactor kinesis config and change default shard iterator type [pinot]

2024-05-08 Thread via GitHub
codecov-commenter commented on PR #13113: URL: https://github.com/apache/pinot/pull/13113#issuecomment-2101866175 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13113?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Add support to track if offset needs to honoured or not in Kinesis [pinot]

2024-05-08 Thread via GitHub
codecov-commenter commented on PR #13112: URL: https://github.com/apache/pinot/pull/13112#issuecomment-2101859058 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13112?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

[PR] Refactor kinesis config and change default shard iterator type [pinot]

2024-05-08 Thread via GitHub
KKcorps opened a new pull request, #13113: URL: https://github.com/apache/pinot/pull/13113 This config incorrectly communicates that we will start from this shard iterator type always However it's meant to be honoured only during the initialization of the shards for the first time.

Re: [PR] Fetch the query quota capacity utilization rate broker metric in a callback function [pinot]

2024-05-08 Thread via GitHub
jackjlli commented on code in PR #12767: URL: https://github.com/apache/pinot/pull/12767#discussion_r1594873816 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/MaxHitRateTracker.java: ## @@ -80,4 +82,14 @@ int getMaxCountPerBucket(long now) {

Re: [PR] Fetch the query quota capacity utilization rate broker metric in a callback function [pinot]

2024-05-08 Thread via GitHub
jasperjiaguo commented on code in PR #12767: URL: https://github.com/apache/pinot/pull/12767#discussion_r1594860919 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/MaxHitRateTracker.java: ## @@ -80,4 +82,14 @@ int getMaxCountPerBucket(long now) {

Re: [PR] Fetch the query quota capacity utilization rate broker metric in a callback function [pinot]

2024-05-08 Thread via GitHub
jasperjiaguo commented on code in PR #12767: URL: https://github.com/apache/pinot/pull/12767#discussion_r1594860919 ## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/MaxHitRateTracker.java: ## @@ -80,4 +82,14 @@ int getMaxCountPerBucket(long now) {

Re: [PR] Make Helix state transition handling idempotent [pinot]

2024-05-08 Thread via GitHub
klsince commented on code in PR #12886: URL: https://github.com/apache/pinot/pull/12886#discussion_r1591653392 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java: ## @@ -608,172 +721,153 @@ protected SegmentDataManager

(pinot) branch dependabot/maven/info.picocli-picocli-4.7.6 deleted (was d6180074a9)

2024-05-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/info.picocli-picocli-4.7.6 in repository https://gitbox.apache.org/repos/asf/pinot.git was d6180074a9 Bump info.picocli:picocli from 4.7.5 to 4.7.6 The revisions that were

(pinot) branch master updated (363a03eea8 -> 20764c8c33)

2024-05-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 363a03eea8 Enhance Parquet Test (#13082) add 20764c8c33 Bump info.picocli:picocli from 4.7.5 to 4.7.6 (#13109)

Re: [PR] Bump info.picocli:picocli from 4.7.5 to 4.7.6 [pinot]

2024-05-08 Thread via GitHub
Jackie-Jiang merged PR #13109: URL: https://github.com/apache/pinot/pull/13109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add protobuf codegen decoder [pinot]

2024-05-08 Thread via GitHub
rseetham commented on code in PR #12980: URL: https://github.com/apache/pinot/pull/12980#discussion_r1594720092 ## pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/com/google/protobuf/ProtobufInternalUtils.java: ## @@ -0,0 +1,28 @@ +/** + * Licensed to the Apache

Re: [PR] Add protobuf codegen decoder [pinot]

2024-05-08 Thread via GitHub
rseetham commented on code in PR #12980: URL: https://github.com/apache/pinot/pull/12980#discussion_r1594719607 ## pinot-plugins/pinot-input-format/pinot-protobuf/src/test/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufTestDataGenerator.java: ## @@ -0,0 +1,145 @@

Re: [PR] Add protobuf codegen decoder [pinot]

2024-05-08 Thread via GitHub
rseetham commented on code in PR #12980: URL: https://github.com/apache/pinot/pull/12980#discussion_r1594659636 ## pinot-plugins/pinot-input-format/pinot-protobuf/src/main/java/org/apache/pinot/plugin/inputformat/protobuf/ProtoBufUtils.java: ## @@ -48,21 +51,156 @@ public

Re: [PR] Add support to track if offset needs to honoured or not in Kinesis [pinot]

2024-05-08 Thread via GitHub
KKcorps commented on PR #13112: URL: https://github.com/apache/pinot/pull/13112#issuecomment-2101264042 cc: @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Add support to track if offset needs to honoured or not in Kinesis [pinot]

2024-05-08 Thread via GitHub
KKcorps opened a new pull request, #13112: URL: https://github.com/apache/pinot/pull/13112 This will allow us to resume from LATEST or EARLIEST instead of always starting from a sequence number -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] [multistage] Subqueries return different results depending on where clause [pinot]

2024-05-08 Thread via GitHub
RalfJL commented on issue #12949: URL: https://github.com/apache/pinot/issues/12949#issuecomment-2100456131 Different result set on successive calls of the same SQL. This might be the same root cause as above. So I have a complicated call ``` select b.ts, a.ts, a.callingstationid,

(pinot) branch dependabot/maven/org.wildfly.common-wildfly-common-2.0.0 created (now f683dd646f)

2024-05-08 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.wildfly.common-wildfly-common-2.0.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at f683dd646f Bump org.wildfly.common:wildfly-common from

[PR] Bump org.wildfly.common:wildfly-common from 1.7.0.Final to 2.0.0 [pinot]

2024-05-08 Thread via GitHub
dependabot[bot] opened a new pull request, #13111: URL: https://github.com/apache/pinot/pull/13111 Bumps [org.wildfly.common:wildfly-common](https://github.com/wildfly/wildfly-common) from 1.7.0.Final to 2.0.0. Commits

(pinot) branch dependabot/maven/org.apache.parquet-parquet-avro-1.14.0 created (now 19b8c7cfd6)

2024-05-08 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.parquet-parquet-avro-1.14.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 19b8c7cfd6 Bump org.apache.parquet:parquet-avro from 1.13.1 to

[PR] Bump org.apache.parquet:parquet-avro from 1.13.1 to 1.14.0 [pinot]

2024-05-08 Thread via GitHub
dependabot[bot] opened a new pull request, #13110: URL: https://github.com/apache/pinot/pull/13110 Bumps [org.apache.parquet:parquet-avro](https://github.com/apache/parquet-mr) from 1.13.1 to 1.14.0. Changelog Sourced from

(pinot) branch dependabot/maven/info.picocli-picocli-4.7.6 created (now d6180074a9)

2024-05-08 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/info.picocli-picocli-4.7.6 in repository https://gitbox.apache.org/repos/asf/pinot.git at d6180074a9 Bump info.picocli:picocli from 4.7.5 to 4.7.6 No new revisions

[PR] Bump info.picocli:picocli from 4.7.5 to 4.7.6 [pinot]

2024-05-08 Thread via GitHub
dependabot[bot] opened a new pull request, #13109: URL: https://github.com/apache/pinot/pull/13109 Bumps [info.picocli:picocli](https://github.com/remkop/picocli) from 4.7.5 to 4.7.6. Release notes Sourced from https://github.com/remkop/picocli/releases;>info.picocli:picocli's

(pinot) branch dependabot/maven/aws.sdk.version-2.25.46 deleted (was 9070f2ccf6)

2024-05-08 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/aws.sdk.version-2.25.46 in repository https://gitbox.apache.org/repos/asf/pinot.git was 9070f2ccf6 Bump aws.sdk.version from 2.25.44 to 2.25.46 The revisions that were

(pinot) branch dependabot/maven/aws.sdk.version-2.25.47 created (now a59aa0b448)

2024-05-08 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/aws.sdk.version-2.25.47 in repository https://gitbox.apache.org/repos/asf/pinot.git at a59aa0b448 Bump aws.sdk.version from 2.25.44 to 2.25.47 No new revisions were

Re: [PR] Bump aws.sdk.version from 2.25.44 to 2.25.46 [pinot]

2024-05-08 Thread via GitHub
dependabot[bot] closed pull request #13099: Bump aws.sdk.version from 2.25.44 to 2.25.46 URL: https://github.com/apache/pinot/pull/13099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump aws.sdk.version from 2.25.44 to 2.25.47 [pinot]

2024-05-08 Thread via GitHub
dependabot[bot] opened a new pull request, #13108: URL: https://github.com/apache/pinot/pull/13108 Bumps `aws.sdk.version` from 2.25.44 to 2.25.47. Updates `software.amazon.awssdk:bom` from 2.25.44 to 2.25.47 Updates `software.amazon.awssdk:apache-client` from 2.25.44 to 2.25.47

Re: [PR] Bump aws.sdk.version from 2.25.44 to 2.25.46 [pinot]

2024-05-08 Thread via GitHub
dependabot[bot] commented on PR #13099: URL: https://github.com/apache/pinot/pull/13099#issuecomment-2100348473 Superseded by #13108. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [Backfill] allow externally partitioned segment uploads for upsert tables [pinot]

2024-05-08 Thread via GitHub
rohityadav1993 opened a new pull request, #13107: URL: https://github.com/apache/pinot/pull/13107 `feature` `release-notes` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Lookup function using alias is giving error [pinot]

2024-05-08 Thread via GitHub
vineethvp commented on issue #12865: URL: https://github.com/apache/pinot/issues/12865#issuecomment-2100104096 @Jackie-Jiang @xiangfu0 Any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Consider leveraging inverted index to augment time range index performance [pinot]

2024-05-08 Thread via GitHub
gortiz commented on issue #11464: URL: https://github.com/apache/pinot/issues/11464#issuecomment-2099920742 I don't get this. Is there a reason why we cannot use the range index to prune segments? Or it is just that we didn't implement that yet? -- This is an automated message from the