snleee commented on code in PR #13232:
URL: https://github.com/apache/pinot/pull/13232#discussion_r1623143039
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -55,7 +55,7 @@
*/
public class RetentionManager extend
snleee commented on code in PR #13232:
URL: https://github.com/apache/pinot/pull/13232#discussion_r1623143039
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java:
##
@@ -55,7 +55,7 @@
*/
public class RetentionManager extend
codecov-commenter commented on PR #13291:
URL: https://github.com/apache/pinot/pull/13291#issuecomment-2143218505
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13291?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from e2c5e73970 Pass literal within AggregateCall via rexList (#13282)
add 26209ed6b0 Updated PDB and reload checksum c
Jackie-Jiang merged PR #13276:
URL: https://github.com/apache/pinot/pull/13276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang opened a new pull request, #13291:
URL: https://github.com/apache/pinot/pull/13291
- Introduce `PinotLogicalAggregate` to carry the `AggType` along with the
aggregate `RelNode`
- Remove the internal agg options which is no longer needed
--
This is an automated message from
Jackie-Jiang merged PR #13282:
URL: https://github.com/apache/pinot/pull/13282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e2c5e73970 Pass literal within AggregateCall via
tibrewalpratik17 commented on issue #13284:
URL: https://github.com/apache/pinot/issues/13284#issuecomment-2143181893
> just to confirm, I think you mean that we should select a replica-group
for each Kafka partition right?
That means if any segment of a kafka partition X are not availab
Jackie-Jiang commented on code in PR #13265:
URL: https://github.com/apache/pinot/pull/13265#discussion_r1623070697
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/DataTypeTransformer.java:
##
@@ -151,7 +151,20 @@ static Object standardize(S
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 3dd653a785 [bugfix] Handling null value for kafka
Jackie-Jiang merged PR #13279:
URL: https://github.com/apache/pinot/pull/13279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #13283:
URL: https://github.com/apache/pinot/pull/13283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from cb5596c4f2 Bump com.nimbusds:nimbus-jose-jwt from 9.39.1 to 9.39.3
(#13289)
add 34bab22861 Add support for raw JS
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 34bab22861 Add support for raw JSON filter predicates (#13283)
add 6c85de5015 Bump org.webjars:swagger-ui from 5.1
Jackie-Jiang merged PR #13286:
URL: https://github.com/apache/pinot/pull/13286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/org.webjars-swagger-ui-5.17.14
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 8dcfa4f2df Fix resource path
The revisions that were on this branch are still
Jackie-Jiang commented on issue #13077:
URL: https://github.com/apache/pinot/issues/13077#issuecomment-2143029902
IMO we can delete them. Wondering if we can access these values from the BOM
in case we have other dependencies sharing these values?
--
This is an automated message from the
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from f70ae2d9be Bump org.apache.maven.plugins:maven-shade-plugin from 3.5.3
to 3.6.0 (#13288)
add cb5596c4f2 Bump com.
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.39.3
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 031e5b8b89 Bump com.nimbusds:nimbus-jose-jwt from 9.39.1 to 9.39.3
The
Jackie-Jiang merged PR #13289:
URL: https://github.com/apache/pinot/pull/13289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 283363af87 Make allowDownloadFromServer minion-cluster-level config
(#13247)
add f70ae2d9be Bump org.apache.maven
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-shade-plugin-3.6.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 6bb5fae9ae Bump org.apache.maven.plugins:maven-shade-plugi
Jackie-Jiang merged PR #13288:
URL: https://github.com/apache/pinot/pull/13288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from bf84802571 Bump software.amazon.awssdk:bom from 2.25.61 to 2.25.63
(#13287)
add 283363af87 Make allowDownlo
ankitsultana merged PR #13247:
URL: https://github.com/apache/pinot/pull/13247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
abhioncbr commented on issue #13077:
URL: https://github.com/apache/pinot/issues/13077#issuecomment-2142883257
I was looking into it, and as I understand, the version mentioned takes
effect by importing the sub-projects BOM or including them as a dependency in
the parent pom. These properti
rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1622835600
##
pinot-common/src/main/java/org/apache/pinot/common/utils/UploadedRealtimeSegmentName.java:
##
@@ -0,0 +1,157 @@
+/**
+ * Licensed to the Apache Software Found
deepthi912 commented on issue #13278:
URL: https://github.com/apache/pinot/issues/13278#issuecomment-2142811974
Looking into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
rohityadav1993 commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1622832355
##
pinot-common/src/main/java/org/apache/pinot/common/utils/Benchmark.java:
##
@@ -0,0 +1,89 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 61ce07ff50 Bump org.apache.maven.plugins:maven-enforcer-plugin from
3.4.1 to 3.5.0 (#13270)
add bf84802571 Bump s
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.25.63
in repository https://gitbox.apache.org/repos/asf/pinot.git
was c9dbb4bf81 Bump software.amazon.awssdk:bom from 2.25.61 to 2.25.63
The r
Jackie-Jiang merged PR #13287:
URL: https://github.com/apache/pinot/pull/13287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on PR #13252:
URL: https://github.com/apache/pinot/pull/13252#issuecomment-2142792107
We do build java with 21. What failure did you encounter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-enforcer-plugin-3.5.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 01d01f8107 Bump org.apache.maven.plugins:maven-enforcer
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from a1f9b8997c Improve warn logs for requesting validDocID snapshots
(#13280)
add fcd7856412 Bump com.google.cloud:li
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from fcd7856412 Bump com.google.cloud:libraries-bom from 26.39.0 to 26.40.0
(#13272)
add 61ce07ff50 Bump org.apache.ma
Jackie-Jiang merged PR #13270:
URL: https://github.com/apache/pinot/pull/13270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.google.cloud-libraries-bom-26.40.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 26c33bfa35 Bump com.google.cloud:libraries-bom from 26.39.0 to 26.40.
Jackie-Jiang merged PR #13272:
URL: https://github.com/apache/pinot/pull/13272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/net.openhft-posix-2.26ea0
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 527f26bfd3 Bump net.openhft:posix from 2.25ea0 to 2.26ea0
add 055e1eb8e2 Bump
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/net.openhft-chronicle-core-2.26ea0
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard bb51e1751b Bump net.openhft:chronicle-core from 2.25ea15 to 2.26ea0
walterddr closed pull request #12302: [multistage][feature] FunctionRegistry
unification
URL: https://github.com/apache/pinot/pull/12302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/org.webjars-swagger-ui-5.17.14
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 33566e7ca2 Bump org.webjars:swagger-ui from 5.17.0 to 5.17.14
add 8dcfa4f
npawar commented on PR #13290:
URL: https://github.com/apache/pinot/pull/13290#issuecomment-2142618653
Please do add testing done and screenshots of validated rules as they appear
in jconsole / prometheus explore
--
This is an automated message from the Apache Git Service.
To respond to t
pengding-stripe commented on PR #13266:
URL: https://github.com/apache/pinot/pull/13266#issuecomment-2142615457
@Jackie-Jiang how can I merge this PR? looks like it still needs approval to
run a workflow
--
This is an automated message from the Apache Git Service.
To respond to the messag
klsince merged PR #13280:
URL: https://github.com/apache/pinot/pull/13280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new a1f9b8997c Improve warn logs for requesting validDo
shounakmk219 commented on PR #13290:
URL: https://github.com/apache/pinot/pull/13290#issuecomment-2142485592
> How shall we test it out? One possibility is to get the list of available
metrics on broker/controller/server using `curl localhost:8080` running 0.8.0,
then deploy this image, do
soumitra-st commented on PR #13290:
URL: https://github.com/apache/pinot/pull/13290#issuecomment-2142480075
Looks good, deferring to @suddendust to double check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
soumitra-st commented on PR #13290:
URL: https://github.com/apache/pinot/pull/13290#issuecomment-2142478946
How shall we test it out? One possibility is to get the list of available
metrics on broker/controller/server using `curl localhost:8080` running 0.8.0,
then deploy this image, do the
shounakmk219 commented on PR #13290:
URL: https://github.com/apache/pinot/pull/13290#issuecomment-2142284257
> Can you list the broken metrics and how they are fixed in this PR?
@soumitra-st Updated the description with metric details.
--
This is an automated message from the Ap
soumitra-st commented on PR #13290:
URL: https://github.com/apache/pinot/pull/13290#issuecomment-2142166914
Can you list the broken metrics and how they are fixed in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
yagmuratak closed issue #13268: Could not fetch Kafka topic message headers and
metadata
URL: https://github.com/apache/pinot/issues/13268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
yagmuratak commented on issue #13268:
URL: https://github.com/apache/pinot/issues/13268#issuecomment-2142084140
I figured it out finally. I set **"stream.kafka.metadata.populate": true**
configuration in **tableIndexConfig.streamConfigs** and
> {
"name": "__metadata$offset",
codecov-commenter commented on PR #13285:
URL: https://github.com/apache/pinot/pull/13285#issuecomment-2141887032
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13285?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
shounakmk219 opened a new pull request, #13290:
URL: https://github.com/apache/pinot/pull/13290
# Description
This PR fixes few jmx metric rules that were broken due to the database
prefix handling on metrics.
# labels
`bugfix`
--
This is an automated message from the Apache
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.39.3
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 031e5b8b89 Bump com.nimbusds:nimbus-jose-jwt from 9.39.1 to 9.39.3
dependabot[bot] closed pull request #13271: Bump com.nimbusds:nimbus-jose-jwt
from 9.39.1 to 9.39.2
URL: https://github.com/apache/pinot/pull/13271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dependabot[bot] opened a new pull request, #13289:
URL: https://github.com/apache/pinot/pull/13289
Bumps
[com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt)
from 9.39.1 to 9.39.3.
Changelog
Sourced from https://bitbucket.org/connect2id/nimbus-jose-jwt/
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.nimbusds-nimbus-jose-jwt-9.39.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
was cef92c45dc Bump com.nimbusds:nimbus-jose-jwt from 9.39.1 to 9.39.2
dependabot[bot] commented on PR #13271:
URL: https://github.com/apache/pinot/pull/13271#issuecomment-2141817187
Superseded by #13289.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.25.62
in repository https://gitbox.apache.org/repos/asf/pinot.git
was c703f9505d Bump software.amazon.awssdk:bom from 2.25.61 to 2.25.62
T
dependabot[bot] commented on PR #13275:
URL: https://github.com/apache/pinot/pull/13275#issuecomment-2141811204
Superseded by #13287.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #13287:
URL: https://github.com/apache/pinot/pull/13287
Bumps software.amazon.awssdk:bom from 2.25.61 to 2.25.63.
[
from 5.17.0 to 5.17.14.
Release notes
Sourced from https://github.com/swagger-api/swagger-ui/releases";>org.w
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.apache.maven.plugins-maven-shade-plugin-3.6.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 6bb5fae9ae Bump org.apache.maven.plugins:maven-shade-p
dependabot[bot] opened a new pull request, #13288:
URL: https://github.com/apache/pinot/pull/13288
Bumps
[org.apache.maven.plugins:maven-shade-plugin](https://github.com/apache/maven-shade-plugin)
from 3.5.3 to 3.6.0.
Commits
https://github.com/apache/maven-shade-plugin/commit
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.25.63
in repository https://gitbox.apache.org/repos/asf/pinot.git
at c9dbb4bf81 Bump software.amazon.awssdk:bom from 2.25.61 to 2.25.63
N
dependabot[bot] commented on PR #13210:
URL: https://github.com/apache/pinot/pull/13210#issuecomment-214180
Superseded by #13286.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
tibrewalpratik17 opened a new pull request, #13285:
URL: https://github.com/apache/pinot/pull/13285
label:
`optimization`
`enhancement`
This patch enhances the `doTakeSnapshot` flow to not snapshot all segments
in a given partition but only the ones which have been updated since
tibrewalpratik17 opened a new issue, #13284:
URL: https://github.com/apache/pinot/issues/13284
### Current scenario
All routing strategies are instance-based strategy.
In one of recent incidents in our cluster, we saw a lot of query failures
because 2 instances were marked as unav
codecov-commenter commented on PR #13283:
URL: https://github.com/apache/pinot/pull/13283#issuecomment-2141635006
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13283?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
yashmayya opened a new pull request, #13283:
URL: https://github.com/apache/pinot/pull/13283
- Currently, raw JSON values (non dictionary encoded) can't be queried
directly via predicates like `=`, `!=`, `IN`, `NOT IN` and JSON columns are
typically queried using the `JSON_MATCH` filter pre
tibrewalpratik17 commented on code in PR #13103:
URL: https://github.com/apache/pinot/pull/13103#discussion_r1622005593
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SanitizationTransformer.java:
##
@@ -32,51 +34,197 @@
*
* No {@cod
tibrewalpratik17 commented on code in PR #13103:
URL: https://github.com/apache/pinot/pull/13103#discussion_r1622004889
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SanitizationTransformer.java:
##
@@ -32,51 +34,197 @@
*
* No {@cod
Jackie-Jiang commented on code in PR #13282:
URL: https://github.com/apache/pinot/pull/13282#discussion_r1621891622
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##
@@ -244,78 +215,26 @@ private TransferableBlock consumeAggr
yashmayya commented on code in PR #13193:
URL: https://github.com/apache/pinot/pull/13193#discussion_r1621877566
##
pinot-common/src/main/java/org/apache/pinot/common/utils/SqlResultComparator.java:
##
@@ -163,6 +167,97 @@ public static boolean areEqual(JsonNode actual, JsonNode
82 matches
Mail list logo
