[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

2020-06-02 Thread GitBox
chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r433647278 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/AndDocIdIterator.java ## @@ -18,112 +18,52 @@ */

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

2020-06-02 Thread GitBox
chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r433642778 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/ArrayBasedDocIdIterator.java ## @@ -36,37 +35,15 @@ public

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

2020-06-02 Thread GitBox
chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r433641032 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/AndDocIdIterator.java ## @@ -18,112 +18,52 @@ */

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

2020-05-28 Thread GitBox
chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431615072 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/AndDocIdSet.java ## @@ -0,0 +1,156 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

2020-05-28 Thread GitBox
chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431606971 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/BlockMultiValIterator.java ## @@ -18,33 +18,15 @@ */ package

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

2020-05-28 Thread GitBox
chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431606505 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/BlockValIterator.java ## @@ -20,9 +20,23 @@ public interface

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

2020-05-28 Thread GitBox
chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431604976 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/BlockSingleValIterator.java ## @@ -18,37 +18,17 @@ */ package

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

2020-05-28 Thread GitBox
chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431604799 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/BlockDocIdSet.java ## @@ -21,6 +21,4 @@ public interface BlockDocIdSet {

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

2020-05-28 Thread GitBox
chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r431604484 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/BlockMultiValIterator.java ## @@ -18,33 +18,15 @@ */ package

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5444: Enhance and simplify the filtering

2020-05-26 Thread GitBox
chenboat commented on a change in pull request #5444: URL: https://github.com/apache/incubator-pinot/pull/5444#discussion_r430783521 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/BlockDocIdSet.java ## @@ -21,6 +21,4 @@ public interface BlockDocIdSet {