[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5639: Refactor how Pinot controller stores segment download url in Zookeeper to deal with peer uri format

2020-07-01 Thread GitBox
chenboat commented on a change in pull request #5639: URL: https://github.com/apache/incubator-pinot/pull/5639#discussion_r448738096 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -485,9 +4

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5639: Refactor how Pinot controller stores segment download url in Zookeeper to deal with peer uri format

2020-07-01 Thread GitBox
chenboat commented on a change in pull request #5639: URL: https://github.com/apache/incubator-pinot/pull/5639#discussion_r448736274 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -355,10 +

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5639: Refactor how Pinot controller stores segment download url in Zookeeper to deal with peer uri format

2020-07-01 Thread GitBox
chenboat commented on a change in pull request #5639: URL: https://github.com/apache/incubator-pinot/pull/5639#discussion_r448600944 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java ## @@ -355,8 +3

[GitHub] [incubator-pinot] chenboat commented on a change in pull request #5639: Refactor how Pinot controller stores segment download url in Zookeeper to deal with peer uri format

2020-07-01 Thread GitBox
chenboat commented on a change in pull request #5639: URL: https://github.com/apache/incubator-pinot/pull/5639#discussion_r448601088 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java ## @@ -1068,16 +1069,