[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6112: add max length support in schema builder

deemoliu commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503563957 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@ -80,6 +80,18 @@ public void testFieldSpec() {

[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6112: add max length support in schema builder

deemoliu commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503562057 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java ## @@ -499,6 +499,15 @@ public SchemaBuilder addSingleValueDimension(

[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6112: add max length support in schema builder

deemoliu commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r503541176 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@ -80,6 +80,18 @@ public void testFieldSpec() {

[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6112: add max length support in schema builder

deemoliu commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r502022511 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@ -80,6 +80,18 @@ public void testFieldSpec() {

[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6112: add max length support in schema builder

deemoliu commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r502043575 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@ -80,6 +80,18 @@ public void testFieldSpec() {

[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6112: add max length support in schema builder

deemoliu commented on a change in pull request #6112: URL: https://github.com/apache/incubator-pinot/pull/6112#discussion_r502022511 ## File path: pinot-common/src/test/java/org/apache/pinot/common/data/FieldSpecTest.java ## @@ -80,6 +80,18 @@ public void testFieldSpec() {