[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-31 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r839344775 ## File path: pinot-common/src/test/java/org/apache/pinot/common/request/RequestContextUtilsTest.java ## @@ -0,0 +1,191 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-31 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r839342393 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -563,6 +569,55 @@ private BrokerRespon

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-31 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r839342126 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -563,6 +569,55 @@ private BrokerRespon

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-30 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r838997714 ## File path: pinot-common/src/main/java/org/apache/pinot/common/request/context/FunctionContext.java ## @@ -84,7 +84,7 @@ public boolean equals(Object o)

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-30 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r838996763 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TimestampIndexGranularity.java ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-30 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r838996606 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TimestampIndexGranularity.java ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-30 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r838927613 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TimestampIndexGranularity.java ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-30 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r838925835 ## File path: pinot-common/src/test/java/org/apache/pinot/common/request/RequestContextUtilsTest.java ## @@ -0,0 +1,191 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-30 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r838849486 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/RangeIndexCreator.java ## @@ -112,12 +112,31 @@

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-30 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r838815765 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TimestampIndexGranularity.java ## @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-30 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r838815411 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java ## @@ -170,17 +188,14

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-30 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r838814735 ## File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/IndexCreationContext.java ## @@ -463,4 +492,17 @@ public boolean isFst(

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-20 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r830594702 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java ## @@ -559,6 +567,58 @@ private BrokerRespon

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8343: Timestamp type index

2022-03-12 Thread GitBox
xiangfu0 commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r825287132 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/pruner/DataSchemaSegmentPruner.java ## @@ -35,7 +38,9 @@ public void init(PinotConfigur