[GitHub] [pinot] xiangfu0 commented on a diff in pull request #9950: [multistage][testing] Add test for null handling, round func and some other cases

2022-12-13 Thread GitBox
xiangfu0 commented on code in PR #9950: URL: https://github.com/apache/pinot/pull/9950#discussion_r1046875679 ## pinot-query-runtime/src/test/resources/queries/NullHanlding.json: ## @@ -0,0 +1,40 @@ +{ + "select_expression_test": { Review Comment: duplicated test name. -

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #9950: [multistage][testing] Add test for null handling, round func and some other cases

2022-12-13 Thread GitBox
xiangfu0 commented on code in PR #9950: URL: https://github.com/apache/pinot/pull/9950#discussion_r1046874180 ## pinot-query-runtime/src/test/resources/queries/Cast.json: ## @@ -0,0 +1,20 @@ +{ + "select_expression_test": { Review Comment: Cast also has issue of: ```