Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

aditya0811 commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2231704910 Are these still open questions? I was unable to approach this as part of this issue. a) When we are adding src/main/java21, by configuring a different profile, how are we

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

gortiz commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2230610695 > we should also care for this because of End of Live (EOL) for Red Hat builds of Openjdk v11 on 30 Oct 2024 see e.g. https://endoflife.date/redhat-build-of-openjdk Just to

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

hpvd commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2230482503 > We should also discuss about the possibility of moving the codebase that is designed to be Java 11 compatible to 21 (aka everything but the driver). +1 on this beside

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

gortiz commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2230435605 I recently found another place where compiling with Java 21 would be useful. I was trying to change the pipeline to support that, but I wasn't able to fix it yet and I cannot focus

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

aditya0811 commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2221369422 1) Can we build the pinot with highest JDK version(>=22) in the CI? We have in pom.xml `${jdk.version}`, where jdk.version=11. `` [avoids any usage of future version

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

gortiz commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2158186978 pinot-test.yml is the one that tests the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

aditya0811 commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2155387509 I will leave the implementation part, for now, for this discussion. Let me try out things in these lines > how to mix code that requires modern versions of Java in

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

aditya0811 commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2148179476 @gortiz 1) Shall we start implementing Buffer using Foreign Memory by adding necessary files in ` pinot-plugins/pinot-foreign-memory/src/main/java22`? Or is there any other

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

gortiz commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2144497436 I think it make sense. Once we have that, we would need to study how to publish the code in the pipeline. Right now we compile with Java 11, so we would only publish an empty jar

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

gortiz commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2082757464 > why cant we use reflection as discussed in para 1 [here](https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html#the-forward-compatibility-solution)? What do

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

gortiz commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2055654108 I think there is a third part which may be more complex: How to compile a maven subproject that requires Java 22 while not affecting the rest of the project (which requires Java 11

Re: [I] Use Foreign Memory API, introduced in Java 22 [pinot]

aditya0811 commented on issue #12809: URL: https://github.com/apache/pinot/issues/12809#issuecomment-2053737215 Hello @gortiz I can try looking into this. I primarily see two parts to this. a) Implementing buffer implementation using Foreign API by creating maven sub project. b)