chenboat commented on PR #12680:
URL: https://github.com/apache/pinot/pull/12680#issuecomment-2130509561
Release note section added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
npawar commented on PR #12680:
URL: https://github.com/apache/pinot/pull/12680#issuecomment-2125680914
@chenboat following up here.. did you get a chance to add docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Jackie-Jiang commented on PR #12680:
URL: https://github.com/apache/pinot/pull/12680#issuecomment-2038487748
Thanks for adding the feature! Can you please add a `release-notes` section
to the PR description, and also update the Pinot documentation for this new
feature?
--
This is an
chenboat merged PR #12680:
URL: https://github.com/apache/pinot/pull/12680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chenboat commented on PR #12680:
URL: https://github.com/apache/pinot/pull/12680#issuecomment-2027833690
> What do you think about enabling this by default/not hiding this feature
behind a config? It seems that we should be able to infer whether a query is
valid single term lucene
chenboat commented on code in PR #12680:
URL: https://github.com/apache/pinot/pull/12680#discussion_r1544963199
##
pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java:
##
@@ -280,6 +282,34 @@ private List createTestData()
return rows;
}
+
chenboat commented on code in PR #12680:
URL: https://github.com/apache/pinot/pull/12680#discussion_r1544963390
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/text/LuceneTextIndexReader.java:
##
@@ -150,10 +155,14 @@ public
itschrispeck commented on PR #12680:
URL: https://github.com/apache/pinot/pull/12680#issuecomment-2024228403
What do you think about enabling this by default/not hiding this feature
behind a config? It seems that we should be able to infer whether a query is
valid single term lucene
itschrispeck commented on code in PR #12680:
URL: https://github.com/apache/pinot/pull/12680#discussion_r1542197858
##
pinot-core/src/test/java/org/apache/pinot/queries/TextSearchQueriesTest.java:
##
@@ -280,6 +282,34 @@ private List createTestData()
return rows;
}
+
ankitsultana commented on code in PR #12680:
URL: https://github.com/apache/pinot/pull/12680#discussion_r1542177535
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/LuceneTextIndexUtilsTest.java:
##
@@ -0,0 +1,100 @@
+/**
+ * Licensed to the Apache
chenboat commented on code in PR #12680:
URL: https://github.com/apache/pinot/pull/12680#discussion_r1538229272
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/LuceneTextIndexUtils.java:
##
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software
chenboat commented on code in PR #12680:
URL: https://github.com/apache/pinot/pull/12680#discussion_r1536461667
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/LuceneTextIndexUtils.java:
##
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software
ankitsultana commented on code in PR #12680:
URL: https://github.com/apache/pinot/pull/12680#discussion_r1534256159
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -119,7 +122,12 @@ public
codecov-commenter commented on PR #12680:
URL: https://github.com/apache/pinot/pull/12680#issuecomment-2010191688
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12680?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
chenboat opened a new pull request, #12680:
URL: https://github.com/apache/pinot/pull/12680
Pinot's TEXT_MATCH filter today does not support phrase search with wildcard
and prefix matching (e.g., "*apache pino*" to match "Apache Pinot") directly.
The kind of queries is very common in use
15 matches
Mail list logo
