Re: [PR] Avoid collision in SegmentLocks [pinot]

2024-07-16 Thread via GitHub
swaminathanmanish commented on code in PR #13632: URL: https://github.com/apache/pinot/pull/13632#discussion_r1680401702 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentLocks.java: ## @@ -18,30 +18,25 @@ */ package

Re: [PR] Avoid collision in SegmentLocks [pinot]

2024-07-16 Thread via GitHub
Jackie-Jiang commented on code in PR #13632: URL: https://github.com/apache/pinot/pull/13632#discussion_r1680390383 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentLocks.java: ## @@ -18,30 +18,25 @@ */ package

Re: [PR] Avoid collision in SegmentLocks [pinot]

2024-07-16 Thread via GitHub
Jackie-Jiang merged PR #13632: URL: https://github.com/apache/pinot/pull/13632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Avoid collision in SegmentLocks [pinot]

2024-07-16 Thread via GitHub
klsince commented on code in PR #13632: URL: https://github.com/apache/pinot/pull/13632#discussion_r1680227655 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentLocks.java: ## @@ -18,30 +18,25 @@ */ package org.apache.pinot.segment.local.utils;

Re: [PR] Avoid collision in SegmentLocks [pinot]

2024-07-16 Thread via GitHub
codecov-commenter commented on PR #13632: URL: https://github.com/apache/pinot/pull/13632#issuecomment-2232078122 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13632?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report