Jackie-Jiang merged PR #13618:
URL: https://github.com/apache/pinot/pull/13618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yashmayya commented on PR #13618:
URL: https://github.com/apache/pinot/pull/13618#issuecomment-2230571414
That makes sense, thanks for the explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gortiz commented on code in PR #13618:
URL: https://github.com/apache/pinot/pull/13618#discussion_r1679161515
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -704,6 +704,26 @@ public void
gortiz commented on PR #13618:
URL: https://github.com/apache/pinot/pull/13618#issuecomment-2230560722
> Technically, ARRAY_TO_MV is deterministic right since it is guaranteed to
always return the same result given the same operands? Essentially, we're never
going to get a different result
yashmayya commented on code in PR #13618:
URL: https://github.com/apache/pinot/pull/13618#discussion_r1679157684
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -704,6 +704,26 @@ public void
gortiz commented on code in PR #13618:
URL: https://github.com/apache/pinot/pull/13618#discussion_r1679150035
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -704,6 +704,26 @@ public void
yashmayya commented on PR #13618:
URL: https://github.com/apache/pinot/pull/13618#issuecomment-2230469468
> As defined in [SqlOperator Calcite
javadoc](https://calcite.apache.org/javadocAggregate/org/apache/calcite/sql/SqlOperator.html#isDeterministic()),
a function is deterministic if and
yashmayya commented on code in PR #13618:
URL: https://github.com/apache/pinot/pull/13618#discussion_r1679069817
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -704,6 +704,26 @@ public void
codecov-commenter commented on PR #13618:
URL: https://github.com/apache/pinot/pull/13618#issuecomment-2230425211
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13618?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
