Re: [PR] Make task manager APIs database aware [pinot]

2024-04-03 Thread via GitHub
KKcorps merged PR #12766: URL: https://github.com/apache/pinot/pull/12766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Make task manager APIs database aware [pinot]

2024-04-03 Thread via GitHub
shounakmk219 commented on code in PR #12766: URL: https://github.com/apache/pinot/pull/12766#discussion_r1547812702 ## pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java: ## @@ -587,64 +587,66 @@ public void fixSchemaNameInTableConfig() {

Re: [PR] Make task manager APIs database aware [pinot]

2024-04-02 Thread via GitHub
shounakmk219 commented on code in PR #12766: URL: https://github.com/apache/pinot/pull/12766#discussion_r1547812702 ## pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java: ## @@ -587,64 +587,66 @@ public void fixSchemaNameInTableConfig() {

Re: [PR] Make task manager APIs database aware [pinot]

2024-04-01 Thread via GitHub
codecov-commenter commented on PR #12766: URL: https://github.com/apache/pinot/pull/12766#issuecomment-2030040090 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12766?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

[PR] Make task manager APIs database aware [pinot]

2024-04-01 Thread via GitHub
shounakmk219 opened a new pull request, #12766: URL: https://github.com/apache/pinot/pull/12766 # Description Make `PinotTaskManager` APIs database aware and deprecate the downstream APIs which do not accept database as param in favour of database aware APIs # Deprecated APIs