xiangfu0 merged PR #12993:
URL: https://github.com/apache/pinot/pull/12993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xiangfu0 commented on code in PR #12993:
URL: https://github.com/apache/pinot/pull/12993#discussion_r1587453729
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/WindowFunction.java:
##
@@ -18,14 +18,75 @@
*/
package
xiangfu0 commented on PR #12993:
URL: https://github.com/apache/pinot/pull/12993#issuecomment-2090071828
> Can you add some more comments in the PR describing about the different
types of window functions extracted? What is their difference?
Following how presto models the
Jackie-Jiang commented on code in PR #12993:
URL: https://github.com/apache/pinot/pull/12993#discussion_r1580255906
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/WindowFunction.java:
##
@@ -18,14 +18,75 @@
*/
package
codecov-commenter commented on PR #12993:
URL: https://github.com/apache/pinot/pull/12993#issuecomment-2073982624
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12993?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
xiangfu0 opened a new pull request, #12993:
URL: https://github.com/apache/pinot/pull/12993
1. Partition the data to containers first
2. For each partition, generate the window agg results. using merger
functions for now
--
This is an automated message from the Apache Git Service.
To
