Re: [PR] Update getValidDocIdsMetadataFromServer to make call in batches to servers and other bug fixes [pinot]

2024-06-06 Thread via GitHub
klsince merged PR #13314: URL: https://github.com/apache/pinot/pull/13314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Update getValidDocIdsMetadataFromServer to make call in batches to servers and other bug fixes [pinot]

2024-06-05 Thread via GitHub
klsince commented on code in PR #13314: URL: https://github.com/apache/pinot/pull/13314#discussion_r1628544264 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/CompletionServiceHelper.java: ## @@ -129,13 +129,21 @@ private CompletionServiceResponse collectRespo

Re: [PR] Update getValidDocIdsMetadataFromServer to make call in batches to servers and other bug fixes [pinot]

2024-06-05 Thread via GitHub
klsince commented on code in PR #13314: URL: https://github.com/apache/pinot/pull/13314#discussion_r1628481078 ## pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java: ## @@ -235,8 +236,18 @@ public List getValidDocIdsMetadataFromServ