Jackie-Jiang merged PR #13020:
URL: https://github.com/apache/pinot/pull/13020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
davecromberge commented on PR #13020:
URL: https://github.com/apache/pinot/pull/13020#issuecomment-2088112915
@gortiz as a starting point, here are some empirical measurements that I
took from a run in our production environment. The build time refers to the
StarTree build time for a
davecromberge commented on PR #13020:
URL: https://github.com/apache/pinot/pull/13020#issuecomment-2088109017
> The PR looks fine to me, but it is a bit strange to approve a performance
wise PR without an actual benchmark we can reproduce. Could you include a JMH
benchmark as part of the
davecromberge commented on code in PR #13020:
URL: https://github.com/apache/pinot/pull/13020#discussion_r1585986210
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/aggregator/DistinctCountCPCSketchValueAggregatorTest.java:
##
@@ -34,19 +34,18 @@ public
gortiz commented on PR #13020:
URL: https://github.com/apache/pinot/pull/13020#issuecomment-2084818483
The PR looks fine to me, but it is a bit strange to approve a performance
wise PR without an actual benchmark we can reproduce. Could you include a JMH
benchmark as part of the PR?
--
gortiz commented on code in PR #13020:
URL: https://github.com/apache/pinot/pull/13020#discussion_r1584440068
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/aggregator/DistinctCountCPCSketchValueAggregatorTest.java:
##
@@ -34,19 +34,18 @@ public class
codecov-commenter commented on PR #13020:
URL: https://github.com/apache/pinot/pull/13020#issuecomment-2082425755
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13020?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
davecromberge opened a new pull request, #13020:
URL: https://github.com/apache/pinot/pull/13020
This addresses excessive resource consumption and performance problems with
the following Apache Datasketches value aggregators:
- Theta
- CPC
- Tuple (Integer)
When merging
