Author: rwhitcomb
Date: Fri Mar 12 19:50:08 2021
New Revision: 1887549
URL: http://svn.apache.org/viewvc?rev=1887549&view=rev
Log:
PIVOT-1032: Changes to eliminate checkstyle violations in the non-wtk Listener
classes.
Modified:
pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewCategoryListener.java
pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewListener.java
pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewSeriesListener.java
pivot/trunk/core/src/org/apache/pivot/collections/ListListener.java
pivot/trunk/core/src/org/apache/pivot/collections/MapListener.java
pivot/trunk/core/src/org/apache/pivot/collections/QueueListener.java
pivot/trunk/core/src/org/apache/pivot/collections/SetListener.java
pivot/trunk/core/src/org/apache/pivot/collections/StackListener.java
pivot/trunk/core/src/org/apache/pivot/json/JSONSerializerListener.java
pivot/trunk/core/src/org/apache/pivot/util/MessageBusListener.java
pivot/trunk/core/src/org/apache/pivot/xml/ElementListener.java
pivot/trunk/core/src/org/apache/pivot/xml/NodeListener.java
pivot/trunk/core/src/org/apache/pivot/xml/XMLSerializerListener.java
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/bxmlexplorer/FakeWindowListener.java
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/explorer/tools/ComponentInspectorListener.java
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/explorer/tools/EventLoggerListener.java
pivot/trunk/web/src/org/apache/pivot/web/QueryListener.java
Modified:
pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewCategoryListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewCategoryListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
---
pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewCategoryListener.java
(original)
+++
pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewCategoryListener.java
Fri Mar 12 19:50:08 2021
@@ -26,26 +26,25 @@ public interface ChartViewCategoryListen
/**
* Chart view category listener list.
*/
- public static class Listeners extends
ListenerList<ChartViewCategoryListener>
- implements ChartViewCategoryListener {
+ final class Listeners extends ListenerList<ChartViewCategoryListener>
implements ChartViewCategoryListener {
@Override
- public void categoryInserted(ChartView chartView, int index) {
+ public void categoryInserted(final ChartView chartView, final int
index) {
forEach(listener -> listener.categoryInserted(chartView, index));
}
@Override
- public void categoriesRemoved(ChartView chartView, int index,
- Sequence<ChartView.Category> categories) {
+ public void categoriesRemoved(final ChartView chartView, final int
index,
+ final Sequence<ChartView.Category> categories) {
forEach(listener -> listener.categoriesRemoved(chartView, index,
categories));
}
@Override
- public void categoryKeyChanged(ChartView chartView, int index, String
previousKey) {
+ public void categoryKeyChanged(final ChartView chartView, final int
index, final String previousKey) {
forEach(listener -> listener.categoryKeyChanged(chartView, index,
previousKey));
}
@Override
- public void categoryLabelChanged(ChartView chartView, int index,
String previousLabel) {
+ public void categoryLabelChanged(final ChartView chartView, final int
index, final String previousLabel) {
forEach(listener -> listener.categoryLabelChanged(chartView,
index, previousLabel));
}
}
@@ -56,7 +55,7 @@ public interface ChartViewCategoryListen
* @param chartView The chart that is changing.
* @param index The index of the new category that was inserted.
*/
- public void categoryInserted(ChartView chartView, int index);
+ void categoryInserted(ChartView chartView, int index);
/**
* Fired when a category is removed from a chart view.
@@ -65,7 +64,7 @@ public interface ChartViewCategoryListen
* @param index The index of the first category that was removed.
* @param categories The list of removed categories.
*/
- public void categoriesRemoved(ChartView chartView, int index,
+ void categoriesRemoved(ChartView chartView, int index,
Sequence<ChartView.Category> categories);
/**
@@ -75,7 +74,7 @@ public interface ChartViewCategoryListen
* @param index The index of the category whose key changed.
* @param previousKey Previous value of the changed key.
*/
- public void categoryKeyChanged(ChartView chartView, int index, String
previousKey);
+ void categoryKeyChanged(ChartView chartView, int index, String
previousKey);
/**
* Fired when a chart view's category label changes.
@@ -84,5 +83,5 @@ public interface ChartViewCategoryListen
* @param index The index of the category whose label changed.
* @param previousLabel Previous value of the changed label.
*/
- public void categoryLabelChanged(ChartView chartView, int index, String
previousLabel);
+ void categoryLabelChanged(ChartView chartView, int index, String
previousLabel);
}
Modified: pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewListener.java
(original)
+++ pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewListener.java Fri
Mar 12 19:50:08 2021
@@ -26,34 +26,34 @@ public interface ChartViewListener {
/**
* Chart view listener list.
*/
- public static class Listeners extends ListenerList<ChartViewListener>
implements ChartViewListener {
+ final class Listeners extends ListenerList<ChartViewListener> implements
ChartViewListener {
@Override
- public void chartDataChanged(ChartView chartView, List<?>
previousChartData) {
+ public void chartDataChanged(final ChartView chartView, final List<?>
previousChartData) {
forEach(listener -> listener.chartDataChanged(chartView,
previousChartData));
}
@Override
- public void seriesNameKeyChanged(ChartView chartView, String
previousSeriesNameKey) {
+ public void seriesNameKeyChanged(final ChartView chartView, final
String previousSeriesNameKey) {
forEach(listener -> listener.seriesNameKeyChanged(chartView,
previousSeriesNameKey));
}
@Override
- public void titleChanged(ChartView chartView, String previousTitle) {
+ public void titleChanged(final ChartView chartView, final String
previousTitle) {
forEach(listener -> listener.titleChanged(chartView,
previousTitle));
}
@Override
- public void horizontalAxisLabelChanged(ChartView chartView, String
previousXAxisLabel) {
+ public void horizontalAxisLabelChanged(final ChartView chartView,
final String previousXAxisLabel) {
forEach(listener -> listener.horizontalAxisLabelChanged(chartView,
previousXAxisLabel));
}
@Override
- public void verticalAxisLabelChanged(ChartView chartView, String
previousYAxisLabel) {
+ public void verticalAxisLabelChanged(final ChartView chartView, final
String previousYAxisLabel) {
forEach(listener -> listener.verticalAxisLabelChanged(chartView,
previousYAxisLabel));
}
@Override
- public void showLegendChanged(ChartView chartView) {
+ public void showLegendChanged(final ChartView chartView) {
forEach(listener -> listener.showLegendChanged(chartView));
}
}
@@ -64,7 +64,7 @@ public interface ChartViewListener {
* @param chartView The chart that is changing.
* @param previousChartData Previous data for the chart.
*/
- public void chartDataChanged(ChartView chartView, List<?>
previousChartData);
+ void chartDataChanged(ChartView chartView, List<?> previousChartData);
/**
* Fired when a chart view's series name key changes.
@@ -72,7 +72,7 @@ public interface ChartViewListener {
* @param chartView The chart that is changing.
* @param previousSeriesNameKey Previous value of the key for the series
name.
*/
- public void seriesNameKeyChanged(ChartView chartView, String
previousSeriesNameKey);
+ void seriesNameKeyChanged(ChartView chartView, String
previousSeriesNameKey);
/**
* Fired when a chart view's title changes.
@@ -80,7 +80,7 @@ public interface ChartViewListener {
* @param chartView The chart that changed.
* @param previousTitle Previous title for this chart.
*/
- public void titleChanged(ChartView chartView, String previousTitle);
+ void titleChanged(ChartView chartView, String previousTitle);
/**
* Fired when a chart view's horizontal axis label changes.
@@ -88,7 +88,7 @@ public interface ChartViewListener {
* @param chartView The chart that has changed.
* @param previousHorizontalAxisLabel Previous value of the horizontal
axis label.
*/
- public void horizontalAxisLabelChanged(ChartView chartView, String
previousHorizontalAxisLabel);
+ void horizontalAxisLabelChanged(ChartView chartView, String
previousHorizontalAxisLabel);
/**
* Fired when a chart view's vertical axis label changes.
@@ -96,12 +96,12 @@ public interface ChartViewListener {
* @param chartView The chart that has changed.
* @param previousVerticalAxisLabel Previous value of the vertical axis
label.
*/
- public void verticalAxisLabelChanged(ChartView chartView, String
previousVerticalAxisLabel);
+ void verticalAxisLabelChanged(ChartView chartView, String
previousVerticalAxisLabel);
/**
* Fired when a chart view's "show legend" flag changes.
*
* @param chartView The chart that has changed.
*/
- public void showLegendChanged(ChartView chartView);
+ void showLegendChanged(ChartView chartView);
}
Modified:
pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewSeriesListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewSeriesListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewSeriesListener.java
(original)
+++ pivot/trunk/charts/src/org/apache/pivot/charts/ChartViewSeriesListener.java
Fri Mar 12 19:50:08 2021
@@ -25,30 +25,29 @@ public interface ChartViewSeriesListener
/**
* Chart view series listener list.
*/
- public static class Listeners extends ListenerList<ChartViewSeriesListener>
- implements ChartViewSeriesListener {
+ final class Listeners extends ListenerList<ChartViewSeriesListener>
implements ChartViewSeriesListener {
@Override
- public void seriesInserted(ChartView chartView, int index) {
+ public void seriesInserted(final ChartView chartView, final int index)
{
forEach(listener -> listener.seriesInserted(chartView, index));
}
@Override
- public void seriesRemoved(ChartView chartView, int index, int count) {
+ public void seriesRemoved(final ChartView chartView, final int index,
final int count) {
forEach(listener -> listener.seriesRemoved(chartView, index,
count));
}
@Override
- public void seriesUpdated(ChartView chartView, int index) {
+ public void seriesUpdated(final ChartView chartView, final int index) {
forEach(listener -> listener.seriesUpdated(chartView, index));
}
@Override
- public void seriesCleared(ChartView chartView) {
+ public void seriesCleared(final ChartView chartView) {
forEach(listener -> listener.seriesCleared(chartView));
}
@Override
- public void seriesSorted(ChartView chartView) {
+ public void seriesSorted(final ChartView chartView) {
forEach(listener -> listener.seriesSorted(chartView));
}
}
@@ -59,7 +58,7 @@ public interface ChartViewSeriesListener
* @param chartView The chart that has changed.
* @param index Index of the series that was inserted.
*/
- public void seriesInserted(ChartView chartView, int index);
+ void seriesInserted(ChartView chartView, int index);
/**
* Fired when a series is removed from a chart view's data set.
@@ -68,14 +67,14 @@ public interface ChartViewSeriesListener
* @param index Starting index of the removed series.
* @param count Number of series removed.
*/
- public void seriesRemoved(ChartView chartView, int index, int count);
+ void seriesRemoved(ChartView chartView, int index, int count);
/**
* Fired when a chart view's series data is cleared.
*
* @param chartView The chart that has changed.
*/
- public void seriesCleared(ChartView chartView);
+ void seriesCleared(ChartView chartView);
/**
* Fired when a series is updated in a chart view's data set.
@@ -83,12 +82,12 @@ public interface ChartViewSeriesListener
* @param chartView The chart that has changed.
* @param index Index of the series that was updated.
*/
- public void seriesUpdated(ChartView chartView, int index);
+ void seriesUpdated(ChartView chartView, int index);
/**
* Fired when a chart view's series data is sorted.
*
* @param chartView Chart that changed.
*/
- public void seriesSorted(ChartView chartView);
+ void seriesSorted(ChartView chartView);
}
Modified: pivot/trunk/core/src/org/apache/pivot/collections/ListListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/ListListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/ListListener.java
(original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/ListListener.java Fri Mar
12 19:50:08 2021
@@ -20,36 +20,40 @@ import java.util.Comparator;
/**
* List listener interface.
+ *
+ * @param <T> Type of object stored in this list.
*/
public interface ListListener<T> {
/**
* List listener adapter.
+ *
+ * @param <T> Type of object stored in this list.
* @deprecated Since 2.1 and Java 8 the interface itself has default
implementations.
*/
@Deprecated
- public static class Adapter<T> implements ListListener<T> {
+ final class Adapter<T> implements ListListener<T> {
@Override
- public void itemInserted(List<T> list, int index) {
+ public void itemInserted(final List<T> list, final int index) {
// empty block
}
@Override
- public void itemsRemoved(List<T> list, int index, Sequence<T> items) {
+ public void itemsRemoved(final List<T> list, final int index, final
Sequence<T> items) {
// empty block
}
@Override
- public void itemUpdated(List<T> list, int index, T previousItem) {
+ public void itemUpdated(final List<T> list, final int index, final T
previousItem) {
// empty block
}
@Override
- public void listCleared(List<T> list) {
+ public void listCleared(final List<T> list) {
// empty block
}
@Override
- public void comparatorChanged(List<T> list, Comparator<T>
previousComparator) {
+ public void comparatorChanged(final List<T> list, final Comparator<T>
previousComparator) {
// empty block
}
}
Modified: pivot/trunk/core/src/org/apache/pivot/collections/MapListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/MapListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/MapListener.java
(original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/MapListener.java Fri Mar
12 19:50:08 2021
@@ -21,67 +21,76 @@ import org.apache.pivot.util.ListenerLis
/**
* Map listener interface.
+ *
+ * @param <K> Type of key object used in this map.
+ * @param <V> Type of value object stored for each key.
*/
public interface MapListener<K, V> {
/**
* Map listeners.
+ *
+ * @param <K> Type of key object used in this map.
+ * @param <V> Type of value object stored for each key.
*/
- public static class Listeners<K, V> extends ListenerList<MapListener<K,
V>> implements
+ class Listeners<K, V> extends ListenerList<MapListener<K, V>> implements
MapListener<K, V> {
@Override
- public void valueAdded(Map<K, V> map, K key) {
+ public void valueAdded(final Map<K, V> map, final K key) {
forEach(listener -> listener.valueAdded(map, key));
}
@Override
- public void valueRemoved(Map<K, V> map, K key, V value) {
+ public void valueRemoved(final Map<K, V> map, final K key, final V
value) {
forEach(listener -> listener.valueRemoved(map, key, value));
}
@Override
- public void valueUpdated(Map<K, V> map, K key, V previousValue) {
+ public void valueUpdated(final Map<K, V> map, final K key, final V
previousValue) {
forEach(listener -> listener.valueUpdated(map, key,
previousValue));
}
@Override
- public void mapCleared(Map<K, V> map) {
+ public void mapCleared(final Map<K, V> map) {
forEach(listener -> listener.mapCleared(map));
}
@Override
- public void comparatorChanged(Map<K, V> map, Comparator<K>
previousComparator) {
+ public void comparatorChanged(final Map<K, V> map, final Comparator<K>
previousComparator) {
forEach(listener -> listener.comparatorChanged(map,
previousComparator));
}
}
/**
* Map listener adapter.
+ *
+ * @param <K> Type of key object used in this map.
+ * @param <V> Type of value object stored for each key.
* @deprecated Since 2.1 and Java 8 the interface itself has default
implementations.
*/
@Deprecated
- public static class Adapter<K, V> implements MapListener<K, V> {
+ final class Adapter<K, V> implements MapListener<K, V> {
@Override
- public void valueAdded(Map<K, V> map, K key) {
+ public void valueAdded(final Map<K, V> map, final K key) {
// empty block
}
@Override
- public void valueUpdated(Map<K, V> map, K key, V previousValue) {
+ public void valueUpdated(final Map<K, V> map, final K key, final V
previousValue) {
// empty block
}
@Override
- public void valueRemoved(Map<K, V> map, K key, V value) {
+ public void valueRemoved(final Map<K, V> map, final K key, final V
value) {
// empty block
}
@Override
- public void mapCleared(Map<K, V> map) {
+ public void mapCleared(final Map<K, V> map) {
// empty block
}
@Override
- public void comparatorChanged(Map<K, V> map, Comparator<K>
previousComparator) {
+ public void comparatorChanged(final Map<K, V> map, final Comparator<K>
previousComparator) {
// empty block
}
}
Modified: pivot/trunk/core/src/org/apache/pivot/collections/QueueListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/QueueListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/QueueListener.java
(original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/QueueListener.java Fri
Mar 12 19:50:08 2021
@@ -21,57 +21,63 @@ import org.apache.pivot.util.ListenerLis
/**
* Queue listener interface.
+ *
+ * @param <T> The type of object stored in this queue.
*/
public interface QueueListener<T> {
/**
* Queue listeners.
+ *
+ * @param <T> Type of object stored in the queue.
*/
- public static class Listeners<T> extends ListenerList<QueueListener<T>>
implements
+ class Listeners<T> extends ListenerList<QueueListener<T>> implements
QueueListener<T> {
@Override
- public void itemEnqueued(Queue<T> queue, T item) {
+ public void itemEnqueued(final Queue<T> queue, final T item) {
forEach(listener -> listener.itemEnqueued(queue, item));
}
@Override
- public void itemDequeued(Queue<T> queue, T item) {
+ public void itemDequeued(final Queue<T> queue, final T item) {
forEach(listener -> listener.itemDequeued(queue, item));
}
@Override
- public void queueCleared(Queue<T> queue) {
+ public void queueCleared(final Queue<T> queue) {
forEach(listener -> listener.queueCleared(queue));
}
@Override
- public void comparatorChanged(Queue<T> queue, Comparator<T>
previousComparator) {
+ public void comparatorChanged(final Queue<T> queue, final
Comparator<T> previousComparator) {
forEach(listener -> listener.comparatorChanged(queue,
previousComparator));
}
}
/**
* QueueListener adapter.
+ *
+ * @param <T> Type of object stored in the queue.
* @deprecated Since 2.1 and Java 8 the interface itself has default
implementations.
*/
@Deprecated
- public static class Adapter<T> implements QueueListener<T> {
+ final class Adapter<T> implements QueueListener<T> {
@Override
- public void itemEnqueued(Queue<T> queue, T item) {
+ public void itemEnqueued(final Queue<T> queue, final T item) {
// empty block
}
@Override
- public void itemDequeued(Queue<T> queue, T item) {
+ public void itemDequeued(final Queue<T> queue, final T item) {
// empty block
}
@Override
- public void queueCleared(Queue<T> queue) {
+ public void queueCleared(final Queue<T> queue) {
// empty block
}
@Override
- public void comparatorChanged(Queue<T> queue, Comparator<T>
previousComparator) {
+ public void comparatorChanged(final Queue<T> queue, final
Comparator<T> previousComparator) {
// empty block
}
}
Modified: pivot/trunk/core/src/org/apache/pivot/collections/SetListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/SetListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/SetListener.java
(original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/SetListener.java Fri Mar
12 19:50:08 2021
@@ -21,57 +21,62 @@ import org.apache.pivot.util.ListenerLis
/**
* Set listener interface.
+ *
+ * @param <E> Type of objects stored in this set.
*/
public interface SetListener<E> {
/**
* Set listeners.
+ *
+ * @param <E> Type of object stored in this set.
*/
- public static class Listeners<E> extends ListenerList<SetListener<E>>
implements
- SetListener<E> {
+ class Listeners<E> extends ListenerList<SetListener<E>> implements
SetListener<E> {
@Override
- public void elementAdded(Set<E> set, E element) {
+ public void elementAdded(final Set<E> set, final E element) {
forEach(listener -> listener.elementAdded(set, element));
}
@Override
- public void elementRemoved(Set<E> set, E element) {
+ public void elementRemoved(final Set<E> set, final E element) {
forEach(listener -> listener.elementRemoved(set, element));
}
@Override
- public void setCleared(Set<E> set) {
+ public void setCleared(final Set<E> set) {
forEach(listener -> listener.setCleared(set));
}
@Override
- public void comparatorChanged(Set<E> set, Comparator<E>
previousComparator) {
+ public void comparatorChanged(final Set<E> set, final Comparator<E>
previousComparator) {
forEach(listener -> listener.comparatorChanged(set,
previousComparator));
}
}
/**
* Set listener adapter.
+ *
+ * @param <E> Type of object stored in this set.
* @deprecated Since 2.1 and Java 8 the interface itself has default
implementations.
*/
@Deprecated
- public static class Adapter<E> implements SetListener<E> {
+ final class Adapter<E> implements SetListener<E> {
@Override
- public void elementAdded(Set<E> set, E element) {
+ public void elementAdded(final Set<E> set, final E element) {
// empty block
}
@Override
- public void elementRemoved(Set<E> set, E element) {
+ public void elementRemoved(final Set<E> set, final E element) {
// empty block
}
@Override
- public void setCleared(Set<E> set) {
+ public void setCleared(final Set<E> set) {
// empty block
}
@Override
- public void comparatorChanged(Set<E> set, Comparator<E>
previousComparator) {
+ public void comparatorChanged(final Set<E> set, final Comparator<E>
previousComparator) {
// empty block
}
}
Modified: pivot/trunk/core/src/org/apache/pivot/collections/StackListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/StackListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/StackListener.java
(original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/StackListener.java Fri
Mar 12 19:50:08 2021
@@ -21,57 +21,63 @@ import org.apache.pivot.util.ListenerLis
/**
* Stack listener interface.
+ *
+ * @param <T> Type of object stored in this stack.
*/
public interface StackListener<T> {
/**
* Stack listeners.
+ *
+ * @param <T> Type of object stored in this stack.
*/
- public static class Listeners<T> extends ListenerList<StackListener<T>>
implements
+ class Listeners<T> extends ListenerList<StackListener<T>> implements
StackListener<T> {
@Override
- public void itemPushed(Stack<T> stack, T item) {
+ public void itemPushed(final Stack<T> stack, final T item) {
forEach(listener -> listener.itemPushed(stack, item));
}
@Override
- public void itemPopped(Stack<T> stack, T item) {
+ public void itemPopped(final Stack<T> stack, final T item) {
forEach(listener -> listener.itemPopped(stack, item));
}
@Override
- public void stackCleared(Stack<T> stack) {
+ public void stackCleared(final Stack<T> stack) {
forEach(listener -> listener.stackCleared(stack));
}
@Override
- public void comparatorChanged(Stack<T> stack, Comparator<T>
previousComparator) {
+ public void comparatorChanged(final Stack<T> stack, final
Comparator<T> previousComparator) {
forEach(listener -> listener.comparatorChanged(stack,
previousComparator));
}
}
/**
* StackListener adapter.
+ *
+ * @param <T> Type of object stored in this stack.
* @deprecated Since 2.1 and Java 8 the interface itself has default
implementations.
*/
@Deprecated
- public static class Adapter<T> implements StackListener<T> {
+ final class Adapter<T> implements StackListener<T> {
@Override
- public void itemPushed(Stack<T> stack, T item) {
+ public void itemPushed(final Stack<T> stack, final T item) {
// empty block
}
@Override
- public void itemPopped(Stack<T> stack, T item) {
+ public void itemPopped(final Stack<T> stack, final T item) {
// empty block
}
@Override
- public void stackCleared(Stack<T> stack) {
+ public void stackCleared(final Stack<T> stack) {
// empty block
}
@Override
- public void comparatorChanged(Stack<T> stack, Comparator<T>
previousComparator) {
+ public void comparatorChanged(final Stack<T> stack, final
Comparator<T> previousComparator) {
// empty block
}
}
Modified: pivot/trunk/core/src/org/apache/pivot/json/JSONSerializerListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/json/JSONSerializerListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/json/JSONSerializerListener.java
(original)
+++ pivot/trunk/core/src/org/apache/pivot/json/JSONSerializerListener.java Fri
Mar 12 19:50:08 2021
@@ -27,50 +27,50 @@ public interface JSONSerializerListener
/**
* JSON Serializer listeners.
*/
- public static class Listeners extends ListenerList<JSONSerializerListener>
+ final class Listeners extends ListenerList<JSONSerializerListener>
implements JSONSerializerListener {
@Override
- public void beginDictionary(JSONSerializer jsonSerializer,
Dictionary<String, ?> value) {
+ public void beginDictionary(final JSONSerializer jsonSerializer, final
Dictionary<String, ?> value) {
forEach(listener -> listener.beginDictionary(jsonSerializer,
value));
}
@Override
- public void endDictionary(JSONSerializer jsonSerializer) {
+ public void endDictionary(final JSONSerializer jsonSerializer) {
forEach(listener -> listener.endDictionary(jsonSerializer));
}
@Override
- public void readKey(JSONSerializer jsonSerializer, String key) {
+ public void readKey(final JSONSerializer jsonSerializer, final String
key) {
forEach(listener -> listener.readKey(jsonSerializer, key));
}
@Override
- public void beginSequence(JSONSerializer jsonSerializer, Sequence<?>
value) {
+ public void beginSequence(final JSONSerializer jsonSerializer, final
Sequence<?> value) {
forEach(listener -> listener.beginSequence(jsonSerializer, value));
}
@Override
- public void endSequence(JSONSerializer jsonSerializer) {
+ public void endSequence(final JSONSerializer jsonSerializer) {
forEach(listener -> listener.endSequence(jsonSerializer));
}
@Override
- public void readString(JSONSerializer jsonSerializer, String value) {
+ public void readString(final JSONSerializer jsonSerializer, final
String value) {
forEach(listener -> listener.readString(jsonSerializer, value));
}
@Override
- public void readNumber(JSONSerializer jsonSerializer, Number value) {
+ public void readNumber(final JSONSerializer jsonSerializer, final
Number value) {
forEach(listener -> listener.readNumber(jsonSerializer, value));
}
@Override
- public void readBoolean(JSONSerializer jsonSerializer, Boolean value) {
+ public void readBoolean(final JSONSerializer jsonSerializer, final
Boolean value) {
forEach(listener -> listener.readBoolean(jsonSerializer, value));
}
@Override
- public void readNull(JSONSerializer jsonSerializer) {
+ public void readNull(final JSONSerializer jsonSerializer) {
forEach(listener -> listener.readNull(jsonSerializer));
}
}
@@ -80,49 +80,49 @@ public interface JSONSerializerListener
* @deprecated Since 2.1 and Java 8 the interface itself has default
implementations.
*/
@Deprecated
- public static class Adapter implements JSONSerializerListener {
+ final class Adapter implements JSONSerializerListener {
@Override
- public void beginDictionary(JSONSerializer jsonSerializer,
Dictionary<String, ?> value) {
+ public void beginDictionary(final JSONSerializer jsonSerializer, final
Dictionary<String, ?> value) {
// empty block
}
@Override
- public void endDictionary(JSONSerializer jsonSerializer) {
+ public void endDictionary(final JSONSerializer jsonSerializer) {
// empty block
}
@Override
- public void readKey(JSONSerializer jsonSerializer, String key) {
+ public void readKey(final JSONSerializer jsonSerializer, final String
key) {
// empty block
}
@Override
- public void beginSequence(JSONSerializer jsonSerializer, Sequence<?>
value) {
+ public void beginSequence(final JSONSerializer jsonSerializer, final
Sequence<?> value) {
// empty block
}
@Override
- public void endSequence(JSONSerializer jsonSerializer) {
+ public void endSequence(final JSONSerializer jsonSerializer) {
// empty block
}
@Override
- public void readString(JSONSerializer jsonSerializer, String value) {
+ public void readString(final JSONSerializer jsonSerializer, final
String value) {
// empty block
}
@Override
- public void readNumber(JSONSerializer jsonSerializer, Number value) {
+ public void readNumber(final JSONSerializer jsonSerializer, final
Number value) {
// empty block
}
@Override
- public void readBoolean(JSONSerializer jsonSerializer, Boolean value) {
+ public void readBoolean(final JSONSerializer jsonSerializer, final
Boolean value) {
// empty block
}
@Override
- public void readNull(JSONSerializer jsonSerializer) {
+ public void readNull(final JSONSerializer jsonSerializer) {
// empty block
}
}
Modified: pivot/trunk/core/src/org/apache/pivot/util/MessageBusListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/util/MessageBusListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/util/MessageBusListener.java
(original)
+++ pivot/trunk/core/src/org/apache/pivot/util/MessageBusListener.java Fri Mar
12 19:50:08 2021
@@ -18,6 +18,8 @@ package org.apache.pivot.util;
/**
* Message bus listener interface.
+ *
+ * @param <T> The type of message being sent.
*/
public interface MessageBusListener<T> {
/**
@@ -26,5 +28,5 @@ public interface MessageBusListener<T> {
*
* @param message The message that was just sent.
*/
- public void messageSent(T message);
+ void messageSent(T message);
}
Modified: pivot/trunk/core/src/org/apache/pivot/xml/ElementListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/xml/ElementListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/xml/ElementListener.java (original)
+++ pivot/trunk/core/src/org/apache/pivot/xml/ElementListener.java Fri Mar 12
19:50:08 2021
@@ -26,39 +26,40 @@ public interface ElementListener {
/**
* Element listeners.
*/
- public static class Listeners extends ListenerList<ElementListener>
implements ElementListener {
+ final class Listeners extends ListenerList<ElementListener> implements
ElementListener {
@Override
- public void defaultNamespaceURIChanged(Element element, String
previousDefaultNamespaceURI) {
+ public void defaultNamespaceURIChanged(final Element element, final
String previousDefaultNamespaceURI) {
forEach(listener -> listener.defaultNamespaceURIChanged(element,
previousDefaultNamespaceURI));
}
@Override
- public void namespaceAdded(Element element, String prefix) {
+ public void namespaceAdded(final Element element, final String prefix)
{
forEach(listener -> listener.namespaceAdded(element, prefix));
}
@Override
- public void namespaceUpdated(Element element, String prefix, String
previousURI) {
+ public void namespaceUpdated(final Element element, final String
prefix, final String previousURI) {
forEach(listener -> listener.namespaceUpdated(element, prefix,
previousURI));
}
@Override
- public void namespaceRemoved(Element element, String prefix, String
uri) {
+ public void namespaceRemoved(final Element element, final String
prefix, final String uri) {
forEach(listener -> listener.namespaceRemoved(element, prefix,
uri));
}
@Override
- public void attributeInserted(Element element, int index) {
+ public void attributeInserted(final Element element, final int index) {
forEach(listener -> listener.attributeInserted(element, index));
}
@Override
- public void attributesRemoved(Element element, int index,
Sequence<Element.Attribute> attributes) {
+ public void attributesRemoved(final Element element, final int index,
+ final Sequence<Element.Attribute> attributes) {
forEach(listener -> listener.attributesRemoved(element, index,
attributes));
}
@Override
- public void attributeValueChanged(Element.Attribute attribute, String
previousValue) {
+ public void attributeValueChanged(final Element.Attribute attribute,
final String previousValue) {
forEach(listener -> listener.attributeValueChanged(attribute,
previousValue));
}
}
@@ -68,40 +69,40 @@ public interface ElementListener {
* @deprecated Since 2.1 and Java 8 the interface itself has default
implementations.
*/
@Deprecated
- public static class Adapter implements ElementListener {
+ final class Adapter implements ElementListener {
@Override
- public void defaultNamespaceURIChanged(Element element, String
previousDefaultNamespaceURI) {
+ public void defaultNamespaceURIChanged(final Element element, final
String previousDefaultNamespaceURI) {
// empty block
}
@Override
- public void namespaceAdded(Element element, String prefix) {
+ public void namespaceAdded(final Element element, final String prefix)
{
// empty block
}
@Override
- public void namespaceUpdated(Element element, String prefix, String
previousURI) {
+ public void namespaceUpdated(final Element element, final String
prefix, final String previousURI) {
// empty block
}
@Override
- public void namespaceRemoved(Element element, String prefix, String
uri) {
+ public void namespaceRemoved(final Element element, final String
prefix, final String uri) {
// empty block
}
@Override
- public void attributeInserted(Element element, int index) {
+ public void attributeInserted(final Element element, final int index) {
// empty block
}
@Override
- public void attributesRemoved(Element element, int index,
- Sequence<Element.Attribute> attributes) {
+ public void attributesRemoved(final Element element, final int index,
+ final Sequence<Element.Attribute> attributes) {
// empty block
}
@Override
- public void attributeValueChanged(Element.Attribute attribute, String
previousValue) {
+ public void attributeValueChanged(final Element.Attribute attribute,
final String previousValue) {
// empty block
}
}
Modified: pivot/trunk/core/src/org/apache/pivot/xml/NodeListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/xml/NodeListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/xml/NodeListener.java (original)
+++ pivot/trunk/core/src/org/apache/pivot/xml/NodeListener.java Fri Mar 12
19:50:08 2021
@@ -25,9 +25,9 @@ public interface NodeListener {
/**
* Node listeners.
*/
- public static class Listeners extends ListenerList<NodeListener>
implements NodeListener {
+ final class Listeners extends ListenerList<NodeListener> implements
NodeListener {
@Override
- public void parentChanged(Node node, Element previousParent) {
+ public void parentChanged(final Node node, final Element
previousParent) {
forEach(listener -> listener.parentChanged(node, previousParent));
}
}
@@ -38,5 +38,5 @@ public interface NodeListener {
* @param node The node that has moved.
* @param previousParent The previous parent of this node.
*/
- public void parentChanged(Node node, Element previousParent);
+ void parentChanged(Node node, Element previousParent);
}
Modified: pivot/trunk/core/src/org/apache/pivot/xml/XMLSerializerListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/xml/XMLSerializerListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/xml/XMLSerializerListener.java
(original)
+++ pivot/trunk/core/src/org/apache/pivot/xml/XMLSerializerListener.java Fri
Mar 12 19:50:08 2021
@@ -25,20 +25,20 @@ public interface XMLSerializerListener {
/**
* XML Serializer listeners.
*/
- public static class Listeners extends ListenerList<XMLSerializerListener>
+ final class Listeners extends ListenerList<XMLSerializerListener>
implements XMLSerializerListener {
@Override
- public void beginElement(XMLSerializer xmlSerializer, Element element)
{
+ public void beginElement(final XMLSerializer xmlSerializer, final
Element element) {
forEach(listener -> listener.beginElement(xmlSerializer, element));
}
@Override
- public void endElement(XMLSerializer xmlSerializer) {
+ public void endElement(final XMLSerializer xmlSerializer) {
forEach(listener -> listener.endElement(xmlSerializer));
}
@Override
- public void readTextNode(XMLSerializer xmlSerializer, TextNode
textNode) {
+ public void readTextNode(final XMLSerializer xmlSerializer, final
TextNode textNode) {
forEach(listener -> listener.readTextNode(xmlSerializer,
textNode));
}
}
@@ -48,19 +48,19 @@ public interface XMLSerializerListener {
* @deprecated Since 2.1 and Java 8 the interface itself has default
implementations.
*/
@Deprecated
- public static class Adapter implements XMLSerializerListener {
+ final class Adapter implements XMLSerializerListener {
@Override
- public void beginElement(XMLSerializer xmlSerializer, Element element)
{
+ public void beginElement(final XMLSerializer xmlSerializer, final
Element element) {
// empty block
}
@Override
- public void endElement(XMLSerializer xmlSerializer) {
+ public void endElement(final XMLSerializer xmlSerializer) {
// empty block
}
@Override
- public void readTextNode(XMLSerializer xmlSerializer, TextNode
textNode) {
+ public void readTextNode(final XMLSerializer xmlSerializer, final
TextNode textNode) {
// empty block
}
}
Modified:
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/bxmlexplorer/FakeWindowListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/tutorials/src/org/apache/pivot/tutorials/bxmlexplorer/FakeWindowListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
---
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/bxmlexplorer/FakeWindowListener.java
(original)
+++
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/bxmlexplorer/FakeWindowListener.java
Fri Mar 12 19:50:08 2021
@@ -21,34 +21,36 @@ import org.apache.pivot.util.ListenerLis
import org.apache.pivot.wtk.Component;
import org.apache.pivot.wtk.media.Image;
+/**
+ * Listener for events on our "fake" window.
+ */
public interface FakeWindowListener {
/**
* Fake window listeners.
*/
- public static class Listeners extends ListenerList<FakeWindowListener>
- implements FakeWindowListener {
+ final class Listeners extends ListenerList<FakeWindowListener> implements
FakeWindowListener {
@Override
- public void titleChanged(FakeWindow window, String previousTitle) {
+ public void titleChanged(final FakeWindow window, final String
previousTitle) {
forEach(listener -> listener.titleChanged(window, previousTitle));
}
@Override
- public void iconAdded(FakeWindow window, Image addedIcon) {
+ public void iconAdded(final FakeWindow window, final Image addedIcon) {
forEach(listener -> listener.iconAdded(window, addedIcon));
}
@Override
- public void iconInserted(FakeWindow window, Image addedIcon, int
index) {
+ public void iconInserted(final FakeWindow window, final Image
addedIcon, final int index) {
forEach(listener -> listener.iconInserted(window, addedIcon,
index));
}
@Override
- public void iconsRemoved(FakeWindow window, int index, Sequence<Image>
removed) {
+ public void iconsRemoved(final FakeWindow window, final int index,
final Sequence<Image> removed) {
forEach(listener -> listener.iconsRemoved(window, index, removed));
}
@Override
- public void contentChanged(FakeWindow window, Component
previousContent) {
+ public void contentChanged(final FakeWindow window, final Component
previousContent) {
forEach(listener -> listener.contentChanged(window,
previousContent));
}
@@ -57,36 +59,37 @@ public interface FakeWindowListener {
/**
* Called when a window's title has changed.
*
- * @param window
- * @param previousTitle
+ * @param window The window that has changed.
+ * @param previousTitle Previous title for the window.
*/
default void titleChanged(FakeWindow window, String previousTitle) {
}
/**
- * Called when a window's icon has changed.
+ * Called when an icon has been added to the window.
*
- * @param window
- * @param addedIcon
+ * @param window The window that has changed.
+ * @param addedIcon The new icon that has been added to the window.
*/
default void iconAdded(FakeWindow window, Image addedIcon) {
}
/**
- * Called when a window's icon has changed.
+ * Called when an icon has been inserted in the window's icon list.
*
- * @param window
- * @param addedIcon
+ * @param window The window that has changed.
+ * @param addedIcon The new icon that was inserted.
+ * @param index The index where the insertion occurred.
*/
default void iconInserted(FakeWindow window, Image addedIcon, int index) {
}
/**
- * Called when a window's icon has changed.
+ * Called when an icon has been removed from the window's icon list.
*
- * @param window
- * @param index
- * @param removed
+ * @param window The window that has changed.
+ * @param index The starting index of the removal.
+ * @param removed The list of removed icons.
*/
default void iconsRemoved(FakeWindow window, int index, Sequence<Image>
removed) {
}
@@ -94,8 +97,8 @@ public interface FakeWindowListener {
/**
* Called when a window's content component has changed.
*
- * @param window
- * @param previousContent
+ * @param window The window that has changed.
+ * @param previousContent The previous window content component.
*/
default void contentChanged(FakeWindow window, Component previousContent) {
}
Modified:
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/explorer/tools/ComponentInspectorListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/tutorials/src/org/apache/pivot/tutorials/explorer/tools/ComponentInspectorListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
---
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/explorer/tools/ComponentInspectorListener.java
(original)
+++
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/explorer/tools/ComponentInspectorListener.java
Fri Mar 12 19:50:08 2021
@@ -22,14 +22,15 @@ import org.apache.pivot.wtk.Component;
/**
* Component inspector listener interface.
*/
+@FunctionalInterface
public interface ComponentInspectorListener {
/**
* The component inspector listeners.
*/
- public static class Listeners extends
+ final class Listeners extends
ListenerList<ComponentInspectorListener> implements
ComponentInspectorListener {
@Override
- public void sourceChanged(ComponentInspector componentInspector,
Component previousSource) {
+ public void sourceChanged(final ComponentInspector componentInspector,
final Component previousSource) {
forEach(listener -> listener.sourceChanged(componentInspector,
previousSource));
}
}
@@ -37,8 +38,8 @@ public interface ComponentInspectorListe
/**
* Called when an component inspector's source component has changed.
*
- * @param componentInspector
- * @param previousSource
+ * @param componentInspector The inspector issuing this notification.
+ * @param previousSource The previous source component.
*/
- public void sourceChanged(ComponentInspector componentInspector, Component
previousSource);
+ void sourceChanged(ComponentInspector componentInspector, Component
previousSource);
}
Modified:
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/explorer/tools/EventLoggerListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/tutorials/src/org/apache/pivot/tutorials/explorer/tools/EventLoggerListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
---
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/explorer/tools/EventLoggerListener.java
(original)
+++
pivot/trunk/tutorials/src/org/apache/pivot/tutorials/explorer/tools/EventLoggerListener.java
Fri Mar 12 19:50:08 2021
@@ -28,25 +28,25 @@ public interface EventLoggerListener {
/**
* Event logger listeners.
*/
- public static class Listeners extends ListenerList<EventLoggerListener>
+ final class Listeners extends ListenerList<EventLoggerListener>
implements EventLoggerListener {
@Override
- public void sourceChanged(EventLogger eventLogger, Component
previousSource) {
+ public void sourceChanged(final EventLogger eventLogger, final
Component previousSource) {
forEach(listener -> listener.sourceChanged(eventLogger,
previousSource));
}
@Override
- public void eventIncluded(EventLogger eventLogger, Method event) {
+ public void eventIncluded(final EventLogger eventLogger, final Method
event) {
forEach(listener -> listener.eventIncluded(eventLogger, event));
}
@Override
- public void eventExcluded(EventLogger eventLogger, Method event) {
+ public void eventExcluded(final EventLogger eventLogger, final Method
event) {
forEach(listener -> listener.eventExcluded(eventLogger, event));
}
@Override
- public void eventFired(EventLogger eventLogger, Method event, Object[]
arguments) {
+ public void eventFired(final EventLogger eventLogger, final Method
event, final Object[] arguments) {
forEach(listener -> listener.eventFired(eventLogger, event,
arguments));
}
}
@@ -54,8 +54,8 @@ public interface EventLoggerListener {
/**
* Called when an event logger's source has changed.
*
- * @param eventLogger
- * @param previousSource
+ * @param eventLogger The event logger that has changed.
+ * @param previousSource The previous source component.
*/
default void sourceChanged(EventLogger eventLogger, Component
previousSource) {
}
@@ -64,8 +64,8 @@ public interface EventLoggerListener {
* Called when a declared event has been included in the list of logged
* events.
*
- * @param eventLogger
- * @param event
+ * @param eventLogger The event logger that has changed.
+ * @param event The new included event.
*/
default void eventIncluded(EventLogger eventLogger, Method event) {
}
@@ -74,8 +74,8 @@ public interface EventLoggerListener {
* Called when a declared event has been excluded from the list of logged
* events.
*
- * @param eventLogger
- * @param event
+ * @param eventLogger The event logger that has changed.
+ * @param event The newly excluded event.
*/
default void eventExcluded(EventLogger eventLogger, Method event) {
}
@@ -84,9 +84,9 @@ public interface EventLoggerListener {
* Called when an included event has been fired by the event logger's
* source.
*
- * @param eventLogger
- * @param event
- * @param arguments
+ * @param eventLogger The event logger that has changed.
+ * @param event The event that was fired.
+ * @param arguments Arguments sent along with the event.
*/
default void eventFired(EventLogger eventLogger, Method event, Object[]
arguments) {
}
Modified: pivot/trunk/web/src/org/apache/pivot/web/QueryListener.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/web/src/org/apache/pivot/web/QueryListener.java?rev=1887549&r1=1887548&r2=1887549&view=diff
==============================================================================
--- pivot/trunk/web/src/org/apache/pivot/web/QueryListener.java (original)
+++ pivot/trunk/web/src/org/apache/pivot/web/QueryListener.java Fri Mar 12
19:50:08 2021
@@ -27,8 +27,7 @@ public interface QueryListener<V> {
* Query listener listeners list.
* @param <V> The type associated with the query.
*/
- class Listeners<V> extends ListenerList<QueryListener<V>>
- implements QueryListener<V> {
+ class Listeners<V> extends ListenerList<QueryListener<V>> implements
QueryListener<V> {
@Override
public synchronized void connected(final Query<V> query) {
forEach(listener -> listener.connected(query));
