Re: [PR] Add GitHub Action to test website changes (ci) and automatically deploy on merge on main branch (deploy) [polaris-site]
flyrain merged PR #6: URL: https://github.com/apache/polaris-site/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris.apa
Re: [PR] Add GitHub Action to test website changes (ci) and automatically deploy on merge on main branch (deploy) [polaris-site]
flyrain commented on PR #6: URL: https://github.com/apache/polaris-site/pull/6#issuecomment-2380417087 Thanks @jbonofre for adding this. Thanks @vvcephei for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use
Re: [PR] Fixing links (new PR for approved PR #136) [polaris]
flyrain commented on code in PR #307: URL: https://github.com/apache/polaris/pull/307#discussion_r1779330709 ## docs/quickstart.md: ## @@ -158,14 +158,14 @@ This will create a new catalog called **quickstart_catalog**. The `DEFAULT_BASE_LOCATION` you provide will be the defa
Re: [PR] Fix home url within helm and update README.md [polaris]
flyrain commented on PR #326: URL: https://github.com/apache/polaris/pull/326#issuecomment-2380313166 Thanks @MonkeyCanCode for the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif
Re: [PR] Fix home url within helm and update README.md [polaris]
flyrain merged PR #326: URL: https://github.com/apache/polaris/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris.apac
Re: [PR] Add NotificationType.VALIDATE which can serve as a dry-run of a CREATE without a metadata file [polaris]
RussellSpitzer merged PR #321: URL: https://github.com/apache/polaris/pull/321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polar
Re: [PR] Add NotificationType.VALIDATE which can serve as a dry-run of a CREATE without a metadata file [polaris]
RussellSpitzer commented on PR #321: URL: https://github.com/apache/polaris/pull/321#issuecomment-2380186582 Thanks @dennishuo , thanks for reviews @collado-mike @tzuan16 and @sfc-gh-mparmar! -- This is an automated message from the Apache Git Service. To respond to the message, please l
Re: [PR] Add NotificationType.VALIDATE which can serve as a dry-run of a CREATE without a metadata file [polaris]
collado-mike commented on PR #321: URL: https://github.com/apache/polaris/pull/321#issuecomment-2380086779 > Yeah good point - I definitely also considered something along the lines of a "dry-run" parameter for this instead that could be generalized to other API requests. In this case when
[PR] Fix home url within helm [polaris]
MonkeyCanCode opened a new pull request, #326: URL: https://github.com/apache/polaris/pull/326 # Description The home URL within helm is outdated. Updated to reflect the apache one. Also, rerun helm-docs to reflect the added/removed config parameters. ## Type of change P
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
danielhumanmod commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1778021936 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanup
Re: [PR] Fix minor issues like possible NPE, unused local variable, typo. [polaris]
aihuaxu commented on code in PR #229: URL: https://github.com/apache/polaris/pull/229#discussion_r1777858344 ## polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -248,11 +248,17 @@ public void initialize(String name, Map properties)
Re: [PR] Add NotificationType.VALIDATE which can serve as a dry-run of a CREATE without a metadata file [polaris]
dennishuo commented on PR #321: URL: https://github.com/apache/polaris/pull/321#issuecomment-2378114368 > It would be nice to have a general `checkPrivileges` API so that a user can validate any privilege they require. it doesn't cover everything that's needed here, but maybe it's possible
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
flyrain commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r198698 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanupTask) {
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
collado-mike commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r192501 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanupTa
Re: [PR] Add NotificationType.VALIDATE which can serve as a dry-run of a CREATE without a metadata file [polaris]
dennishuo commented on code in PR #321: URL: https://github.com/apache/polaris/pull/321#discussion_r145434 ## polaris-service/src/test/java/org/apache/polaris/service/catalog/BasePolarisCatalogTest.java: ## @@ -360,6 +360,141 @@ public void testCreateNestedNamespaceUnderMiss
Re: [PR] Add NotificationType.VALIDATE which can serve as a dry-run of a CREATE without a metadata file [polaris]
dennishuo commented on code in PR #321: URL: https://github.com/apache/polaris/pull/321#discussion_r133297 ## polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -1873,6 +1878,51 @@ private boolean sendNotificationForTableLike(
Re: [PR] Add NotificationType.VALIDATE which can serve as a dry-run of a CREATE without a metadata file [polaris]
dennishuo commented on code in PR #321: URL: https://github.com/apache/polaris/pull/321#discussion_r132986 ## polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -1873,6 +1878,51 @@ private boolean sendNotificationForTableLike(
Re: [PR] Spark Jupyter getting started docker compose [polaris]
kevinjqliu commented on code in PR #295: URL: https://github.com/apache/polaris/pull/295#discussion_r1777610035 ## getting-started/spark/README.md: ## @@ -0,0 +1,51 @@ + + +# Getting Started with Spark and Apache Polaris + +This getting started guide provides a `docker-compose`
Re: [PR] Spark Jupyter getting started docker compose [polaris]
kevinjqliu commented on code in PR #295: URL: https://github.com/apache/polaris/pull/295#discussion_r1777609079 ## getting-started/spark/create-polaris-catalog.sh: ## Review Comment: ah i dont know how to use the polaris CLI, so i just copied directly from https://github.c
Re: [PR] Spark Jupyter getting started docker compose [polaris]
sfc-gh-emaynard commented on code in PR #295: URL: https://github.com/apache/polaris/pull/295#discussion_r1777608413 ## getting-started/spark/README.md: ## @@ -0,0 +1,51 @@ + + +# Getting Started with Spark and Apache Polaris + +This getting started guide provides a `docker-comp
Re: [PR] Spark Jupyter getting started docker compose [polaris]
sfc-gh-emaynard commented on code in PR #295: URL: https://github.com/apache/polaris/pull/295#discussion_r1777607868 ## getting-started/spark/create-polaris-catalog.sh: ## Review Comment: Sorry, I meant the `polaris` CLI instead of using `curl` -- This is an automated m
Re: [PR] Spark Jupyter getting started docker compose [polaris]
kevinjqliu commented on code in PR #295: URL: https://github.com/apache/polaris/pull/295#discussion_r1777606833 ## getting-started/spark/README.md: ## @@ -0,0 +1,51 @@ + + +# Getting Started with Spark and Apache Polaris + +This getting started guide provides a `docker-compose`
Re: [PR] Spark Jupyter getting started docker compose [polaris]
kevinjqliu commented on code in PR #295: URL: https://github.com/apache/polaris/pull/295#discussion_r1777605346 ## getting-started/spark/README.md: ## Review Comment: yes I'll admit, this README is a filler for now as a way to get spark & polaris up and running quickly
Re: [PR] Spark Jupyter getting started docker compose [polaris]
kevinjqliu commented on code in PR #295: URL: https://github.com/apache/polaris/pull/295#discussion_r1777604556 ## getting-started/spark/create-polaris-catalog.sh: ## Review Comment: might be, if you want a spark-shell. I think the jupyter notebook does a good job of expla
Re: [PR] Spark Jupyter getting started docker compose [polaris]
sfc-gh-emaynard commented on code in PR #295: URL: https://github.com/apache/polaris/pull/295#discussion_r1777594352 ## getting-started/spark/README.md: ## @@ -0,0 +1,51 @@ + + +# Getting Started with Spark and Apache Polaris + +This getting started guide provides a `docker-comp
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
collado-mike commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1777430437 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanupTa
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
flyrain commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1777443711 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanupTask) {
Re: [PR] Add NotificationType.VALIDATE which can serve as a dry-run of a CREATE without a metadata file [polaris]
tzuan16 commented on code in PR #321: URL: https://github.com/apache/polaris/pull/321#discussion_r1776478365 ## polaris-service/src/test/java/org/apache/polaris/service/catalog/BasePolarisCatalogTest.java: ## @@ -360,6 +360,141 @@ public void testCreateNestedNamespaceUnderMissin
Re: [PR] Add NotificationType.VALIDATE which can serve as a dry-run of a CREATE without a metadata file [polaris]
sfc-gh-mparmar commented on code in PR #321: URL: https://github.com/apache/polaris/pull/321#discussion_r1776444004 ## polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -1873,6 +1878,51 @@ private boolean sendNotificationForTableLike
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
danielhumanmod commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1776371069 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanup
Re: [PR] Upgrade to Gradle 8.10.2 [polaris]
jbonofre merged PR #325: URL: https://github.com/apache/polaris/pull/325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris.apa
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
danielhumanmod commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1776371069 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanup
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
danielhumanmod commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1776371069 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanup
[PR] Upgrade to Gradle 8.10.2 [polaris]
jbonofre opened a new pull request, #325: URL: https://github.com/apache/polaris/pull/325 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
danielhumanmod commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1776371069 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanup
Re: [PR] Bump up the default integration-test requests-per-second to 9999 vs 10 [polaris]
jbonofre merged PR #322: URL: https://github.com/apache/polaris/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris.apa
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
danielhumanmod commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1776371069 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanup
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
danielhumanmod commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1776371069 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanup
Re: [PR] Unwrap global rule in CODEOWNERS [polaris]
eric-maynard merged PR #324: URL: https://github.com/apache/polaris/pull/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris
Re: [PR] Refactor BasePolarisCatalog to use Iceberg's BadRequestException instead of jakarta [polaris]
eric-maynard merged PR #323: URL: https://github.com/apache/polaris/pull/323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris
Re: [PR] When a grant already exists, return the appropriate response [polaris]
eric-maynard commented on code in PR #243: URL: https://github.com/apache/polaris/pull/243#discussion_r1776349699 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ## @@ -257,
[PR] Unwrap global rule in CODEOWNERS [polaris]
ebyhr opened a new pull request, #324: URL: https://github.com/apache/polaris/pull/324 # Description Looks like the 1st bullet point is ignored after https://github.com/apache/polaris/pull/314 https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-featu
Re: [PR] When a grant already exists, return the appropriate response [polaris]
dennishuo commented on code in PR #243: URL: https://github.com/apache/polaris/pull/243#discussion_r1776342307 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ## @@ -257,6 +
Re: [PR] Bump up the default integration-test requests-per-second to 100 vs 10 [polaris]
dennishuo commented on PR #322: URL: https://github.com/apache/polaris/pull/322#issuecomment-2375795140 Good suggestion, bumped up to . In theory 100 might "accidentally" exercise the backoff once in awhile, but thinking about it more we should be more explicit if we really want to exer
[PR] Refactor BasePolarisCatalog to use Iceberg's BadRequestException instead of jakarta [polaris]
dennishuo opened a new pull request, #323: URL: https://github.com/apache/polaris/pull/323 # Description It looks like the jakarta flavor inadvertently got added by someone's IDE and now there's a needless mix of jakarta/iceberg BadRequestException Please include a summary of the c
Re: [PR] When a grant already exists, return the appropriate response [polaris]
eric-maynard commented on code in PR #243: URL: https://github.com/apache/polaris/pull/243#discussion_r1776302020 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ## @@ -257,
Re: [PR] When a grant already exists, return the appropriate response [polaris]
dennishuo commented on code in PR #243: URL: https://github.com/apache/polaris/pull/243#discussion_r1776300626 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ## @@ -257,6 +
[PR] Bump up the default integration-test requests-per-second to 100 vs 10 [polaris]
dennishuo opened a new pull request, #322: URL: https://github.com/apache/polaris/pull/322 At 10 per second, PolarisRestCatalogIntegrationTest takes about 2m50s. At 20 per second, it takes about 1m25s. At 50 per second, it takes about 30s. At 100 per second it takes about 19s. At 20
[PR] Add NotificationType.VALIDATE which can serve as a dry-run of a CREATE without a metadata file [polaris]
dennishuo opened a new pull request, #321: URL: https://github.com/apache/polaris/pull/321 # Description If a remote catalog or manual caller wants to ensure that permissions, paths, etc., are configured correctly to receive CREATE/UPDATE notifications before deciding to actually cre
Re: [PR] Using record to simplify class RequestThrottlingErrorResponse [polaris]
flyrain commented on PR #320: URL: https://github.com/apache/polaris/pull/320#issuecomment-2375234621 Thanks @eric-maynard for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec
Re: [PR] Using record to simplify class RequestThrottlingErrorResponse [polaris]
flyrain merged PR #320: URL: https://github.com/apache/polaris/pull/320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris.apac
Re: [PR] Fix minor issues like possible NPE, unused local variable, typo. [polaris]
RussellSpitzer commented on code in PR #229: URL: https://github.com/apache/polaris/pull/229#discussion_r1775947885 ## polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -248,11 +248,17 @@ public void initialize(String name, Map prop
Re: [PR] Fixing links [polaris]
RussellSpitzer commented on PR #136: URL: https://github.com/apache/polaris/pull/136#issuecomment-2374921436 Closed in favor of https://github.com/apache/polaris/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us
Re: [PR] Fixing links [polaris]
RussellSpitzer closed pull request #136: Fixing links URL: https://github.com/apache/polaris/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: co
[PR] Using record to simplify class RequestThrottlingErrorResponse [polaris]
flyrain opened a new pull request, #320: URL: https://github.com/apache/polaris/pull/320 # Description - [ ] Refactor # Checklist: Please delete options that are not relevant. - [ ] I have performed a self-review of my code -- This is an automated message from t
Re: [PR] Delete prev metadata and stat files in TableCleanUpTask [polaris]
collado-mike commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1775778183 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +159,13 @@ public boolean handleTask(TaskEntity cleanupTa
Re: [PR] Fixing links (new PR for approved PR #136) [polaris]
flyrain commented on code in PR #307: URL: https://github.com/apache/polaris/pull/307#discussion_r1775760934 ## docs/index.html: ## @@ -623,10 +623,10 @@ Building PolarisThis will create a new catalog called quickstart_catalog.
The <
Re: [PR] Sync polaris-server.yml [polaris]
eric-maynard merged PR #317: URL: https://github.com/apache/polaris/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris
Re: [PR] Sync polaris-server.yml [polaris]
eric-maynard commented on PR #317: URL: https://github.com/apache/polaris/pull/317#issuecomment-2374861505 Thanks for the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment
Re: [PR] Fixing links (new PR for approved PR #136) [polaris]
flyrain commented on code in PR #307: URL: https://github.com/apache/polaris/pull/307#discussion_r1775757361 ## docs/index.html: ## @@ -623,10 +623,10 @@ Building PolarisThis will create a new catalog called quickstart_catalog.
The <
Re: [PR] Fixing links (new PR for approved PR #136) [polaris]
eric-maynard commented on code in PR #307: URL: https://github.com/apache/polaris/pull/307#discussion_r1775743232 ## docs/index.html: ## @@ -623,10 +623,10 @@ Building PolarisThis will create a new catalog called quickstart_catalog.
Re: [I] [BUG] Exceptions (thread race conditions) when trying to create many tables with JDBC extension [polaris]
eric-maynard closed issue #56: [BUG] Exceptions (thread race conditions) when trying to create many tables with JDBC extension URL: https://github.com/apache/polaris/issues/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u
Re: [I] pyiceberg always return false for catalog.table_exists when using Snowflake managed Polaris service [polaris]
eric-maynard closed issue #96: pyiceberg always return false for catalog.table_exists when using Snowflake managed Polaris service URL: https://github.com/apache/polaris/issues/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a
Re: [I] [BUG] Incorrect usage of the X-Iceberg-Access-Delegation header [polaris]
eric-maynard commented on issue #146: URL: https://github.com/apache/polaris/issues/146#issuecomment-2374826838 Hey @dimas-b , I think you fixed this in #211, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the
Re: [PR] When a grant already exists, return the appropriate response [polaris]
eric-maynard commented on code in PR #243: URL: https://github.com/apache/polaris/pull/243#discussion_r1775706941 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ## @@ -257,
Re: [PR] When a grant already exists, return the appropriate response [polaris]
eric-maynard commented on code in PR #243: URL: https://github.com/apache/polaris/pull/243#discussion_r1775706941 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ## @@ -257,
Re: [PR] Spark Jupyter getting started docker compose [polaris]
kevinjqliu commented on PR #295: URL: https://github.com/apache/polaris/pull/295#issuecomment-2374710687 r? @flyrain @RussellSpitzer @collado-mike Also opened #319 to update the Polaris doc site once this is merged. -- This is an automated message from the Apache Git Service. To r
[I] [FEATURE REQUEST] Update Polaris doc site with new getting started examples [polaris]
kevinjqliu opened a new issue, #319: URL: https://github.com/apache/polaris/issues/319 ### Is your feature request related to a problem? Please describe. Context: https://github.com/apache/polaris/pull/295#issuecomment-2353450842 https://polaris.apache.org/docs/quickstart
Re: [PR] Sync polaris-server.yml [polaris]
eric-maynard commented on PR #317: URL: https://github.com/apache/polaris/pull/317#issuecomment-2374657943 LGTM! I would actually like us to add more null-checks for things like a missing io, but I tried doing it with Valid and NotNull annotations but didn't have much success.
[I] [FEATURE REQUEST] Pre-auth rate limiter [polaris]
andrew4699 opened a new issue, #318: URL: https://github.com/apache/polaris/issues/318 ### Is your feature request related to a problem? Please describe. In https://github.com/apache/polaris/pull/278 we added a post-auth rate limiter. We discussed that there should also likely be a pr
[PR] Sync polaris-server.yml [polaris]
MonkeyCanCode opened a new pull request, #317: URL: https://github.com/apache/polaris/pull/317 # Description There are couple additional non-optional parameters introduced for the last one month such as "io.factoryType" which can actually cause issue while using Polaris. This PR is t
Re: [PR] Cleanup "Check md link" config [polaris]
RussellSpitzer merged PR #245: URL: https://github.com/apache/polaris/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polar
Re: [PR] Cleanup "Check md link" config [polaris]
RussellSpitzer commented on PR #245: URL: https://github.com/apache/polaris/pull/245#issuecomment-2374411640 Thanks @kevinjqliu and @eric-maynard and @flyrain for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use
Re: [PR] Cleanup "Check md link" config [polaris]
kevinjqliu commented on PR #245: URL: https://github.com/apache/polaris/pull/245#issuecomment-2374370811 Thanks @flyrain. I double checked, this looks good to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the
Re: [PR] Clean up unused annotation [polaris]
RussellSpitzer merged PR #315: URL: https://github.com/apache/polaris/pull/315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polar
Re: [PR] Clean up unused annotation [polaris]
RussellSpitzer commented on PR #315: URL: https://github.com/apache/polaris/pull/315#issuecomment-2374349458 Thanks @flyrain and @eric-maynard for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above
Re: [PR] Update CODEOWNERS with New Committers [polaris]
flyrain merged PR #314: URL: https://github.com/apache/polaris/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris.apac
Re: [PR] Update CODEOWNERS with New Committers [polaris]
flyrain commented on PR #314: URL: https://github.com/apache/polaris/pull/314#issuecomment-2373107841 Thanks @RussellSpitzer! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.
[PR] Clean up unused annotation [polaris]
flyrain opened a new pull request, #315: URL: https://github.com/apache/polaris/pull/315 # Description This annotation exists in the core module already. ## Type of change - [ ] Clean up # Checklist: Please delete options that are not relevant. - [ ]
Re: [PR] Add SUPPORTED_CATALOG_STORAGE_TYPES to PolarisConfiguration [polaris]
RussellSpitzer merged PR #165: URL: https://github.com/apache/polaris/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polar
[PR] Update CODEOWNERS with New Committers [polaris]
RussellSpitzer opened a new pull request, #314: URL: https://github.com/apache/polaris/pull/314 @jbonofre - I think we are ready to do this? Are we waiting on anything else? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub
Re: [PR] Fix minor issues like possible NPE, unused local variable, typo. [polaris]
aihuaxu commented on code in PR #229: URL: https://github.com/apache/polaris/pull/229#discussion_r1774081171 ## polaris-service/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -248,11 +248,17 @@ public void initialize(String name, Map properties)
Re: [PR] Add eclipseLinkDeps options for Dockerfile and run.sh [polaris]
flyrain commented on PR #313: URL: https://github.com/apache/polaris/pull/313#issuecomment-2372352711 Thanks @MonkeyCanCode for the PR. Thanks @eric-maynard @aihuaxu for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi
Re: [PR] Add eclipseLinkDeps options for Dockerfile and run.sh [polaris]
flyrain merged PR #313: URL: https://github.com/apache/polaris/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris.apac
Re: [PR] When a grant already exists, return the appropriate response [polaris]
aihuaxu commented on code in PR #243: URL: https://github.com/apache/polaris/pull/243#discussion_r1774070188 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ## @@ -257,6 +26
Re: [PR] Add eclipseLinkDeps options for Dockerfile and run.sh [polaris]
MonkeyCanCode commented on code in PR #313: URL: https://github.com/apache/polaris/pull/313#discussion_r1773697779 ## README.md: ## @@ -67,10 +67,16 @@ Apache Polaris supports the following optional build options: ### More build and run options Running in Docker - `docker bu
Re: [PR] When a grant already exists, return the appropriate response [polaris]
eric-maynard commented on code in PR #243: URL: https://github.com/apache/polaris/pull/243#discussion_r1773683079 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java: ## @@ -257,
Re: [PR] Add eclipseLinkDeps options for Dockerfile and run.sh [polaris]
eric-maynard commented on code in PR #313: URL: https://github.com/apache/polaris/pull/313#discussion_r1773678719 ## README.md: ## @@ -67,10 +67,16 @@ Apache Polaris supports the following optional build options: ### More build and run options Running in Docker - `docker bui
Re: [PR] Add eclipseLinkDeps options for Dockerfile and run.sh [polaris]
eric-maynard commented on code in PR #313: URL: https://github.com/apache/polaris/pull/313#discussion_r1773678162 ## README.md: ## @@ -67,10 +67,16 @@ Apache Polaris supports the following optional build options: ### More build and run options Running in Docker - `docker bui
Re: [PR] Add eclipseLinkDeps options for Dockerfile and run.sh [polaris]
flyrain commented on PR #313: URL: https://github.com/apache/polaris/pull/313#issuecomment-2371768456 Hi @MonkeyCanCode, can you rebase for the conflict? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to
Re: [PR] Rate limiter [polaris]
flyrain commented on PR #278: URL: https://github.com/apache/polaris/pull/278#issuecomment-2371728877 This is an essential feature for production deployment! Thanks @andrew4699 for adding this. Thanks @mrcnc @snazy @eric-maynard @collado-mike for the review! -- This is an automated messa
Re: [PR] Rate limiter [polaris]
flyrain merged PR #278: URL: https://github.com/apache/polaris/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@polaris.apac
Re: [PR] Delete all related files in TableCleanUpTask [polaris]
danielhumanmod commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1772670475 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +160,22 @@ public boolean handleTask(TaskEntity cleanup
Re: [PR] Delete all related files in TableCleanUpTask [polaris]
danielhumanmod commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1772670475 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +160,22 @@ public boolean handleTask(TaskEntity cleanup
Re: [PR] Rate limiter [polaris]
andrew4699 commented on code in PR #278: URL: https://github.com/apache/polaris/pull/278#discussion_r1772447596 ## polaris-service/src/test/java/org/apache/polaris/service/ratelimiter/TokenBucketRateLimiterTest.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software F
Re: [PR] Rate limiter [polaris]
eric-maynard commented on code in PR #278: URL: https://github.com/apache/polaris/pull/278#discussion_r1772382706 ## polaris-service/src/test/java/org/apache/polaris/service/ratelimiter/TokenBucketRateLimiterTest.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software
Re: [PR] Rate limiter [polaris]
eric-maynard commented on code in PR #278: URL: https://github.com/apache/polaris/pull/278#discussion_r1772381344 ## polaris-service/src/main/java/org/apache/polaris/service/ratelimiter/RateLimiterKey.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (
Re: [I] DROP TABLE with PURGE does not delete metadata.json files [polaris]
flyrain commented on issue #289: URL: https://github.com/apache/polaris/issues/289#issuecomment-2369858442 Thanks @danielhumanmod for working on it. We will only need to add support for the historical metadata.json files and stats files. Others are token care already. -- This is an autom
Re: [PR] Delete all related files in TableCleanUpTask [polaris]
flyrain commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1772374436 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +160,22 @@ public boolean handleTask(TaskEntity cleanupTask) {
Re: [PR] Delete all related files in TableCleanUpTask [polaris]
flyrain commented on code in PR #312: URL: https://github.com/apache/polaris/pull/312#discussion_r1772374436 ## polaris-service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java: ## @@ -158,6 +160,22 @@ public boolean handleTask(TaskEntity cleanupTask) {
