[GitHub] merlimat commented on a change in pull request #2957: Add Connect and Read timeout to pulsar admin

2018-11-09 Thread GitBox
merlimat commented on a change in pull request #2957: Add Connect and Read timeout to pulsar admin URL: https://github.com/apache/pulsar/pull/2957#discussion_r232443830 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java ##

[GitHub] merlimat commented on issue #2961: Added pause and resume to Java client Consumer

2018-11-09 Thread GitBox
merlimat commented on issue #2961: Added pause and resume to Java client Consumer URL: https://github.com/apache/pulsar/pull/2961#issuecomment-437562685 run integration tests This is an automated message from the Apac

[pulsar] branch master updated: Don't use default values within the config. (#2971)

2018-11-09 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2abb172 Don't use default values within the

[GitHub] srkukarni closed pull request #2971: Don't use default values within the config.

2018-11-09 Thread GitBox
srkukarni closed pull request #2971: Don't use default values within the config. URL: https://github.com/apache/pulsar/pull/2971 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] sijie closed pull request #2960: Fix Get Function Cluster in Master Docs

2018-11-09 Thread GitBox
sijie closed pull request #2960: Fix Get Function Cluster in Master Docs URL: https://github.com/apache/pulsar/pull/2960 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull r

[pulsar] branch master updated: Fix Get Function Cluster in Master Docs (#2960)

2018-11-09 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 91a0488 Fix Get Function Cluster in Master Docs

[pulsar] branch master updated: improve python function packaging (#2965)

2018-11-09 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c704aaa improve python function packaging (#2965

[GitHub] sijie closed pull request #2965: improve python function packaging

2018-11-09 Thread GitBox
sijie closed pull request #2965: improve python function packaging URL: https://github.com/apache/pulsar/pull/2965 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] merlimat commented on issue #2960: Fix Get Function Cluster in Master Docs

2018-11-09 Thread GitBox
merlimat commented on issue #2960: Fix Get Function Cluster in Master Docs URL: https://github.com/apache/pulsar/pull/2960#issuecomment-437527941 Integration tests should be more stable in master now. If it doesn't pass it might be worth to just merge or rebase with master ---

[GitHub] srkukarni commented on a change in pull request #2970: Ignore the current class while going over variables

2018-11-09 Thread GitBox
srkukarni commented on a change in pull request #2970: Ignore the current class while going over variables URL: https://github.com/apache/pulsar/pull/2970#discussion_r232423175 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@

[GitHub] k2la commented on issue #2960: Fix Get Function Cluster in Master Docs

2018-11-09 Thread GitBox
k2la commented on issue #2960: Fix Get Function Cluster in Master Docs URL: https://github.com/apache/pulsar/pull/2960#issuecomment-437525409 run integration tests This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on a change in pull request #2970: Ignore the current class while going over variables

2018-11-09 Thread GitBox
merlimat commented on a change in pull request #2970: Ignore the current class while going over variables URL: https://github.com/apache/pulsar/pull/2970#discussion_r232420766 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@

[GitHub] srkukarni commented on a change in pull request #2970: Ignore the current class while going over variables

2018-11-09 Thread GitBox
srkukarni commented on a change in pull request #2970: Ignore the current class while going over variables URL: https://github.com/apache/pulsar/pull/2970#discussion_r232416982 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@

[GitHub] merlimat commented on a change in pull request #2970: Ignore the current class while going over variables

2018-11-09 Thread GitBox
merlimat commented on a change in pull request #2970: Ignore the current class while going over variables URL: https://github.com/apache/pulsar/pull/2970#discussion_r232416286 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java ## @@

[GitHub] srkukarni commented on issue #2970: Ignore the current class while going over variables

2018-11-09 Thread GitBox
srkukarni commented on issue #2970: Ignore the current class while going over variables URL: https://github.com/apache/pulsar/pull/2970#issuecomment-437519524 rerun integration tests rerun java8 tests This is an automated

[GitHub] srkukarni opened a new pull request #2971: Don't use default values within the config.

2018-11-09 Thread GitBox
srkukarni opened a new pull request #2971: Don't use default values within the config. URL: https://github.com/apache/pulsar/pull/2971 ### Motivation Make all variables based on Java Objects instead of native types. The reason is that now we will have a better idea which variables were

[GitHub] jai1 commented on a change in pull request #2961: Added pause and resume to Java client Consumer

2018-11-09 Thread GitBox
jai1 commented on a change in pull request #2961: Added pause and resume to Java client Consumer URL: https://github.com/apache/pulsar/pull/2961#discussion_r232412027 ## File path: pulsar-flink/src/test/java/org/apache/flink/streaming/connectors/pulsar/PulsarConsumerSourceTests.jav

[GitHub] merlimat commented on issue #2961: Added pause and resume to Java client Consumer

2018-11-09 Thread GitBox
merlimat commented on issue #2961: Added pause and resume to Java client Consumer URL: https://github.com/apache/pulsar/pull/2961#issuecomment-437511083 run integration tests This is an automated message from the Apache Git S

[GitHub] srkukarni commented on issue #2900: NoClassDefFoundError error happens when running custom source connector on cluster

2018-11-09 Thread GitBox
srkukarni commented on issue #2900: NoClassDefFoundError error happens when running custom source connector on cluster URL: https://github.com/apache/pulsar/issues/2900#issuecomment-437483802 I tested this on my local laptop. The example worked without any issues. One issue that I'm seei

[GitHub] srkukarni opened a new pull request #2970: Ignore the current class while going over variables

2018-11-09 Thread GitBox
srkukarni opened a new pull request #2970: Ignore the current class while going over variables URL: https://github.com/apache/pulsar/pull/2970 ### Motivation We go over all the declared fields in LocalRunner class to generate the command for localrunner. However one of the items tha

[GitHub] david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage

2018-11-09 Thread GitBox
david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r232363051 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/BlobStoreRepos

[GitHub] david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage

2018-11-09 Thread GitBox
david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r232363051 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/BlobStoreRepos

[pulsar] branch master updated: Websocket dead letter topic (PIP22) (#2968)

2018-11-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 34ab423 Websocket dead letter topic (PIP22) (#2

[GitHub] merlimat closed pull request #2968: Websocket dead letter topic (PIP22)

2018-11-09 Thread GitBox
merlimat closed pull request #2968: Websocket dead letter topic (PIP22) URL: https://github.com/apache/pulsar/pull/2968 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull req

[GitHub] jerrypeng commented on issue #2969: JSONSchema fails to serialise fields on objects that are nested in a collection

2018-11-09 Thread GitBox
jerrypeng commented on issue #2969: JSONSchema fails to serialise fields on objects that are nested in a collection URL: https://github.com/apache/pulsar/pull/2969#issuecomment-437462346 Let me take a look This is an automate

[GitHub] david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage

2018-11-09 Thread GitBox
david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r229770461 ## File path: tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/BlobStoreTestBase.java

[GitHub] sijie commented on issue #2936: [io][docs] introduce annotations for generating connector yaml config files

2018-11-09 Thread GitBox
sijie commented on issue #2936: [io][docs] introduce annotations for generating connector yaml config files URL: https://github.com/apache/pulsar/pull/2936#issuecomment-437434898 run integration tests This is an automated mes

[GitHub] sijie commented on a change in pull request #2966: Broke Pulsar-IO::HDFS into 3.x and 2.x versions

2018-11-09 Thread GitBox
sijie commented on a change in pull request #2966: Broke Pulsar-IO::HDFS into 3.x and 2.x versions URL: https://github.com/apache/pulsar/pull/2966#discussion_r232332652 ## File path: pulsar-io/hdfs3/src/test/java/org/apache/pulsar/io/hdfs3/sink/text/HdfsStringSinkTests.java ##

[GitHub] sijie commented on issue #2965: improve python function packaging

2018-11-09 Thread GitBox
sijie commented on issue #2965: improve python function packaging URL: https://github.com/apache/pulsar/pull/2965#issuecomment-437426058 run integration tests This is an automated message from the Apache Git Service. To respon

[pulsar] branch master updated: Add partitioned-topic stats internal admin-api (#2958)

2018-11-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 037c153 Add partitioned-topic stats internal ad

[GitHub] merlimat closed pull request #2958: Add partitioned-topic stats internal admin-api

2018-11-09 Thread GitBox
merlimat closed pull request #2958: Add partitioned-topic stats internal admin-api URL: https://github.com/apache/pulsar/pull/2958 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] davidtinker commented on issue #2961: Added pause and resume to Java client Consumer

2018-11-09 Thread GitBox
davidtinker commented on issue #2961: Added pause and resume to Java client Consumer URL: https://github.com/apache/pulsar/pull/2961#issuecomment-437378348 I added tests. Tx. This is an automated message from the Apache Git S

[GitHub] ivankelly commented on issue #2950: is Authentication available in java client?

2018-11-09 Thread GitBox
ivankelly commented on issue #2950: is Authentication available in java client? URL: https://github.com/apache/pulsar/issues/2950#issuecomment-437361118 @superbaobei There is a guide to setting up auth with TLS in our documents http://pulsar.apache.org/docs/en/security-tls-authentication/

[GitHub] ivankelly closed issue #2950: is Authentication available in java client?

2018-11-09 Thread GitBox
ivankelly closed issue #2950: is Authentication available in java client? URL: https://github.com/apache/pulsar/issues/2950 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] chrismiller opened a new pull request #2969: JSONSchema fails to serialise fields on objects that are nested in a collection

2018-11-09 Thread GitBox
chrismiller opened a new pull request #2969: JSONSchema fails to serialise fields on objects that are nested in a collection URL: https://github.com/apache/pulsar/pull/2969 ### Motivation The fix for #2577 (https://github.com/apache/pulsar/commit/701f3ea7e3541f61f064167043de04e8a2db

[GitHub] ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage

2018-11-09 Thread GitBox
ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage URL: https://github.com/apache/pulsar/pull/2865#discussion_r232235219 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/BlobStoreRepository.

[GitHub] cbornet opened a new pull request #2968: Websocket dead letter topic (PIP22)

2018-11-09 Thread GitBox
cbornet opened a new pull request #2968: Websocket dead letter topic (PIP22) URL: https://github.com/apache/pulsar/pull/2968 ### Motivation [PIP22 Dead Letter Topic](https://github.com/apache/pulsar/wiki/PIP-22%3A-Pulsar-Dead-Letter-Topic) is available in Java client but not in WebS

[GitHub] ivankelly commented on issue #2852: Add connection timeout client configuration option

2018-11-09 Thread GitBox
ivankelly commented on issue #2852: Add connection timeout client configuration option URL: https://github.com/apache/pulsar/pull/2852#issuecomment-437304774 rerun integration tests This is an automated message from the A

[GitHub] sijie commented on issue #2936: [io][docs] introduce annotations for generating connector yaml config files

2018-11-09 Thread GitBox
sijie commented on issue #2936: [io][docs] introduce annotations for generating connector yaml config files URL: https://github.com/apache/pulsar/pull/2936#issuecomment-437280763 run integration tests This is an automated mes