[GitHub] erenavsarogullari commented on issue #3039: [Pulsar-Flink] Add Batch Csv Sink Support

2018-11-21 Thread GitBox
erenavsarogullari commented on issue #3039: [Pulsar-Flink] Add Batch Csv Sink Support URL: https://github.com/apache/pulsar/pull/3039#issuecomment-440939194 rerun cpp tests This is an automated message from the Apache Git

[GitHub] merlimat commented on a change in pull request #3043: Set not just resource requests but also limits

2018-11-21 Thread GitBox
merlimat commented on a change in pull request #3043: Set not just resource requests but also limits URL: https://github.com/apache/pulsar/pull/3043#discussion_r235620989 ## File path:

[GitHub] srkukarni opened a new pull request #3043: Set not just resource requests but also limits

2018-11-21 Thread GitBox
srkukarni opened a new pull request #3043: Set not just resource requests but also limits URL: https://github.com/apache/pulsar/pull/3043 ### Motivation For functions, we need to set both resource requests and limits ### Modifications Describe the modifications you've

[GitHub] codelipenghui opened a new issue #3042: Get stats on a exist topic but got topic not found error

2018-11-21 Thread GitBox
codelipenghui opened a new issue #3042: Get stats on a exist topic but got topic not found error URL: https://github.com/apache/pulsar/issues/3042 Expected behavior Get a blank stats data rather than `Topic not found` error by `get partitioned stats` or `get stats` on a topic

[GitHub] codelipenghui commented on issue #3033: Expose Redelivery Count By Message Properties(issue-3030)

2018-11-21 Thread GitBox
codelipenghui commented on issue #3033: Expose Redelivery Count By Message Properties(issue-3030) URL: https://github.com/apache/pulsar/pull/3033#issuecomment-440922675 @merlimat I'm already address your suggestion, thanks a lot.

[GitHub] merlimat closed pull request #3023: Moved broker aspectj to zk-utils

2018-11-21 Thread GitBox
merlimat closed pull request #3023: Moved broker aspectj to zk-utils URL: https://github.com/apache/pulsar/pull/3023 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[pulsar] branch master updated: Moved broker aspectj to zk-utils (#3023)

2018-11-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 26b91bb Moved broker aspectj to zk-utils

[GitHub] merlimat commented on issue #844: Intermittent test failure UnAcknowledgedMessagesTimeoutTest.testFailoverSingleAckedPartitionedTopic

2018-11-21 Thread GitBox
merlimat commented on issue #844: Intermittent test failure UnAcknowledgedMessagesTimeoutTest.testFailoverSingleAckedPartitionedTopic URL: https://github.com/apache/pulsar/issues/844#issuecomment-440904392 I think this was actually fixed in #2590 . I haven't seen this test fail anytime

[GitHub] merlimat closed issue #844: Intermittent test failure UnAcknowledgedMessagesTimeoutTest.testFailoverSingleAckedPartitionedTopic

2018-11-21 Thread GitBox
merlimat closed issue #844: Intermittent test failure UnAcknowledgedMessagesTimeoutTest.testFailoverSingleAckedPartitionedTopic URL: https://github.com/apache/pulsar/issues/844 This is an automated message from the Apache

[GitHub] jiazhai commented on issue #2943: Issue #2657: change function cli getstate to use REST endpoint

2018-11-21 Thread GitBox
jiazhai commented on issue #2943: Issue #2657: change function cli getstate to use REST endpoint URL: https://github.com/apache/pulsar/pull/2943#issuecomment-440898692 rerun integration tests This is an automated message

[GitHub] jiazhai edited a comment on issue #2943: Issue #2657: change function cli getstate to use REST endpoint

2018-11-21 Thread GitBox
jiazhai edited a comment on issue #2943: Issue #2657: change function cli getstate to use REST endpoint URL: https://github.com/apache/pulsar/pull/2943#issuecomment-440630948 rerun integration tests org.apache.pulsar.tests.integration.offload.TestS3Offload.tiered-storage-test-suite

[GitHub] sijie edited a comment on issue #3034: Issue #2751: Add check to fix NPE

2018-11-21 Thread GitBox
sijie edited a comment on issue #3034: Issue #2751: Add check to fix NPE URL: https://github.com/apache/pulsar/pull/3034#issuecomment-440781810 run integration tests org.apache.pulsar.tests.integration.functions.PulsarFunctionsThreadTest.pulsar-test-suite

[GitHub] jiazhai commented on issue #3034: Issue #2751: Add check to fix NPE

2018-11-21 Thread GitBox
jiazhai commented on issue #3034: Issue #2751: Add check to fix NPE URL: https://github.com/apache/pulsar/pull/3034#issuecomment-440898605 run integration tests This is an automated message from the Apache Git Service. To

[GitHub] massakam commented on issue #3035: Update libcurl version included in docker images

2018-11-21 Thread GitBox
massakam commented on issue #3035: Update libcurl version included in docker images URL: https://github.com/apache/pulsar/pull/3035#issuecomment-440896513 rerun integration tests This is an automated message from the Apache

[GitHub] kaonick commented on issue #3031: Error open RocksDB database in docker

2018-11-21 Thread GitBox
kaonick commented on issue #3031: Error open RocksDB database in docker URL: https://github.com/apache/pulsar/issues/3031#issuecomment-440890636 I had tried it. That is no problem. Yes, I think is volumn handle error in windows. So need for help to solve it ?

[pulsar] branch merlimat-patch-2 updated (c108283 -> 1c9505a)

2018-11-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch merlimat-patch-2 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c108283 Update dockerfile-maven plugin add 0a7e133 Add default ackTimeout(30s) for dead letter

[pulsar] branch master updated: Fixed lookup of boost_python with boost-1.68 (#3041)

2018-11-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a77b760 Fixed lookup of boost_python with

[GitHub] merlimat closed pull request #3041: Fixed lookup of boost_python with boost-1.68

2018-11-21 Thread GitBox
merlimat closed pull request #3041: Fixed lookup of boost_python with boost-1.68 URL: https://github.com/apache/pulsar/pull/3041 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat commented on issue #3041: Fixed lookup of boost_python with boost-1.68

2018-11-21 Thread GitBox
merlimat commented on issue #3041: Fixed lookup of boost_python with boost-1.68 URL: https://github.com/apache/pulsar/pull/3041#issuecomment-440886882 > Should not the milestone be 2.2.1? Yes, I guess we'll need this to compile on branch-2.2 as well

[pulsar] branch master updated: Add default ackTimeout(30s) for dead letter policy (#3014)

2018-11-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0a7e133 Add default ackTimeout(30s) for dead

[GitHub] sijie closed pull request #3014: Add default ackTimeout(30s) for dead letter policy

2018-11-21 Thread GitBox
sijie closed pull request #3014: Add default ackTimeout(30s) for dead letter policy URL: https://github.com/apache/pulsar/pull/3014 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] massakam commented on issue #3041: Fixed lookup of boost_python with boost-1.68

2018-11-21 Thread GitBox
massakam commented on issue #3041: Fixed lookup of boost_python with boost-1.68 URL: https://github.com/apache/pulsar/pull/3041#issuecomment-440879893 Should not the milestone be 2.2.1? This is an automated message from the

[GitHub] merlimat opened a new pull request #3041: Fixed lookup of boost_python with boost-1.68

2018-11-21 Thread GitBox
merlimat opened a new pull request #3041: Fixed lookup of boost_python with boost-1.68 URL: https://github.com/apache/pulsar/pull/3041 ### Motivation The new build image use boost-1.68 that has a different naming for the boost_python library.

[GitHub] merlimat commented on issue #3035: Update libcurl version included in docker images

2018-11-21 Thread GitBox
merlimat commented on issue #3035: Update libcurl version included in docker images URL: https://github.com/apache/pulsar/pull/3035#issuecomment-440855799 Actually the reason is fail is that boost was updated from 1.64 to 1.68 (though in a previous commit, but that image was never

[GitHub] merlimat commented on issue #683: ReflectionFactory is internal proprietary API and may be removed

2018-11-21 Thread GitBox
merlimat commented on issue #683: ReflectionFactory is internal proprietary API and may be removed URL: https://github.com/apache/pulsar/issues/683#issuecomment-440852701 @sijie Yes, I think it would still be required to be fixed. In #3006 I just verified it compiles and run with Java 11

[GitHub] rdhabalia commented on issue #596: Remove non-persistent broker-mode once broker can handle both types of topic properly

2018-11-21 Thread GitBox
rdhabalia commented on issue #596: Remove non-persistent broker-mode once broker can handle both types of topic properly URL: https://github.com/apache/pulsar/issues/596#issuecomment-440851554 @sijie yes, I will address this issue soon. thanks.

[GitHub] erenavsarogullari commented on issue #3039: [Pulsar-Flink] Add Batch Csv Sink Support

2018-11-21 Thread GitBox
erenavsarogullari commented on issue #3039: [Pulsar-Flink] Add Batch Csv Sink Support URL: https://github.com/apache/pulsar/pull/3039#issuecomment-440849564 rerun java8 tests This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #3035: Update libcurl version included in docker images

2018-11-21 Thread GitBox
merlimat commented on issue #3035: Update libcurl version included in docker images URL: https://github.com/apache/pulsar/pull/3035#issuecomment-440845093 @massakam I'm seeing a problem with the new Docker image for Python: ``` Status: Downloaded newer image for

[pulsar] branch merlimat-patch-2 created (now c108283)

2018-11-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch merlimat-patch-2 in repository https://gitbox.apache.org/repos/asf/pulsar.git. at c108283 Update dockerfile-maven plugin This branch includes the following new commits: new c108283

[GitHub] merlimat opened a new pull request #3040: Update dockerfile-maven plugin

2018-11-21 Thread GitBox
merlimat opened a new pull request #3040: Update dockerfile-maven plugin URL: https://github.com/apache/pulsar/pull/3040 ### Motivation dockerfile-maven 1.3.7 has issues connecting to newer Docker daemons. Latest version works fine.

[pulsar] 01/01: Update dockerfile-maven plugin

2018-11-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch merlimat-patch-2 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit c108283f781e9a55503047bdbf019058554e4756 Author: Matteo Merli AuthorDate: Wed Nov 21 15:06:38 2018 -0800

[GitHub] cbornet commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
cbornet commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235562215 ## File path: pulsar-grpc/src/main/proto/PulsarGrpc.proto ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] merlimat commented on issue #3037: Disable ZK & BK fsync calls in integration tests

2018-11-21 Thread GitBox
merlimat commented on issue #3037: Disable ZK & BK fsync calls in integration tests URL: https://github.com/apache/pulsar/pull/3037#issuecomment-440841707 @ivankelly PTAL again This is an automated message from the Apache

[GitHub] sijie commented on issue #2957: Add Connect and Read timeout to pulsar admin

2018-11-21 Thread GitBox
sijie commented on issue #2957: Add Connect and Read timeout to pulsar admin URL: https://github.com/apache/pulsar/pull/2957#issuecomment-440835383 @merlimat can you review this PR again? This is an automated message from the

[GitHub] sijie commented on issue #2475: Add host name verification

2018-11-21 Thread GitBox
sijie commented on issue #2475: Add host name verification URL: https://github.com/apache/pulsar/pull/2475#issuecomment-440835239 @merlimat @ivankelly please review it. This is an automated message from the Apache Git

[GitHub] sijie commented on issue #2749: Admin API via PulsarProxy with authentication fails

2018-11-21 Thread GitBox
sijie commented on issue #2749: Admin API via PulsarProxy with authentication fails URL: https://github.com/apache/pulsar/issues/2749#issuecomment-440833857 This is fixed by #2986 This is an automated message from the

[GitHub] merlimat commented on a change in pull request #3037: Disable ZK & BK fsync calls in integration tests

2018-11-21 Thread GitBox
merlimat commented on a change in pull request #3037: Disable ZK & BK fsync calls in integration tests URL: https://github.com/apache/pulsar/pull/3037#discussion_r235549209 ## File path: conf/zookeeper.conf ## @@ -48,3 +48,8 @@ autopurge.snapRetainCount=3 # Purge task

[GitHub] sijie closed issue #1388: Intermittent test failures in BrokerBkEnsemblesTests.testSkipCorruptDataLedger()

2018-11-21 Thread GitBox
sijie closed issue #1388: Intermittent test failures in BrokerBkEnsemblesTests.testSkipCorruptDataLedger() URL: https://github.com/apache/pulsar/issues/1388 This is an automated message from the Apache Git Service. To

[pulsar] branch master updated: Add bookkeeper service and other fixes (#3026)

2018-11-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ac97846 Add bookkeeper service and other fixes

[GitHub] sijie commented on issue #596: Remove non-persistent broker-mode once broker can handle both types of topic properly

2018-11-21 Thread GitBox
sijie commented on issue #596: Remove non-persistent broker-mode once broker can handle both types of topic properly URL: https://github.com/apache/pulsar/issues/596#issuecomment-440821922 @rdhabalia is this feature still needed?

[GitHub] sijie closed issue #614: Itermittent test failure in ReplicatorTest.testResumptionAfterBacklogRelaxed

2018-11-21 Thread GitBox
sijie closed issue #614: Itermittent test failure in ReplicatorTest.testResumptionAfterBacklogRelaxed URL: https://github.com/apache/pulsar/issues/614 This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie commented on issue #614: Itermittent test failure in ReplicatorTest.testResumptionAfterBacklogRelaxed

2018-11-21 Thread GitBox
sijie commented on issue #614: Itermittent test failure in ReplicatorTest.testResumptionAfterBacklogRelaxed URL: https://github.com/apache/pulsar/issues/614#issuecomment-440821621 This duplicates #788 This is an automated

[GitHub] sijie commented on issue #630: Intermittent C++ test failure in LatchTest.testTimedWait

2018-11-21 Thread GitBox
sijie commented on issue #630: Intermittent C++ test failure in LatchTest.testTimedWait URL: https://github.com/apache/pulsar/issues/630#issuecomment-440820631 @jai1 is the right fix to increase the timeout in the test? This

[GitHub] sijie commented on issue #683: ReflectionFactory is internal proprietary API and may be removed

2018-11-21 Thread GitBox
sijie commented on issue #683: ReflectionFactory is internal proprietary API and may be removed URL: https://github.com/apache/pulsar/issues/683#issuecomment-440820183 @merlimat is this related to your recent changes for java11?

[GitHub] sijie commented on issue #752: Broker znode sometimes remains disappeared

2018-11-21 Thread GitBox
sijie commented on issue #752: Broker znode sometimes remains disappeared URL: https://github.com/apache/pulsar/issues/752#issuecomment-440819178 close due to no activities. This is an automated message from the Apache Git

[GitHub] sijie commented on issue #687: Provide configuration for stats update frequency for test clusters

2018-11-21 Thread GitBox
sijie commented on issue #687: Provide configuration for stats update frequency for test clusters URL: https://github.com/apache/pulsar/issues/687#issuecomment-440819332 ping @aahmed-se This is an automated message from the

[GitHub] sijie closed issue #752: Broker znode sometimes remains disappeared

2018-11-21 Thread GitBox
sijie closed issue #752: Broker znode sometimes remains disappeared URL: https://github.com/apache/pulsar/issues/752 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] sijie commented on issue #755: Possible message loss on redelivery

2018-11-21 Thread GitBox
sijie commented on issue #755: Possible message loss on redelivery URL: https://github.com/apache/pulsar/issues/755#issuecomment-440819034 close it due to inactivities This is an automated message from the Apache Git Service.

[GitHub] sijie closed issue #755: Possible message loss on redelivery

2018-11-21 Thread GitBox
sijie closed issue #755: Possible message loss on redelivery URL: https://github.com/apache/pulsar/issues/755 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] sijie commented on issue #3014: Add default ackTimeout(30s) for dead letter policy

2018-11-21 Thread GitBox
sijie commented on issue #3014: Add default ackTimeout(30s) for dead letter policy URL: https://github.com/apache/pulsar/pull/3014#issuecomment-440817485 run cpp tests This is an automated message from the Apache Git

[GitHub] cbornet commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
cbornet commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235543451 ## File path: pulsar-grpc/src/main/proto/PulsarGrpc.proto ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cbornet commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
cbornet commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235543000 ## File path: pulsar-grpc/src/main/proto/PulsarGrpc.proto ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cbornet commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
cbornet commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235541469 ## File path: pulsar-grpc/src/main/proto/PulsarGrpc.proto ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] cbornet commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
cbornet commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235540990 ## File path: pulsar-grpc/src/main/java/org/apache/pulsar/grpc/TestClient.java ## @@ -0,0 +1,72 @@ +package org.apache.pulsar.grpc; +

[GitHub] cbornet commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
cbornet commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235539898 ## File path: pulsar-grpc/src/main/java/org/apache/pulsar/grpc/ConsumerHandler.java ## @@ -0,0 +1,241 @@ +package

[GitHub] cbornet commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
cbornet commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235537791 ## File path: pulsar-grpc/src/main/java/org/apache/pulsar/grpc/Constant.java ## @@ -0,0 +1,9 @@ +package org.apache.pulsar.grpc;

[GitHub] erenavsarogullari opened a new pull request #3039: [Pulsar-Flink] Add Batch Csv Sink Support

2018-11-21 Thread GitBox
erenavsarogullari opened a new pull request #3039: [Pulsar-Flink] Add Batch Csv Sink Support URL: https://github.com/apache/pulsar/pull/3039 ### Motivation This PR aims to add Flink - Pulsar Batch Csv Sink Support. If user works with Flink DataSet API and would like to write the

[pulsar] branch master updated: [state] use closeAsync to close state storage client (#3028)

2018-11-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4e10472 [state] use closeAsync to close state

[GitHub] merlimat closed pull request #3028: [state] use closeAsync to close state storage client

2018-11-21 Thread GitBox
merlimat closed pull request #3028: [state] use closeAsync to close state storage client URL: https://github.com/apache/pulsar/pull/3028 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] ivankelly commented on a change in pull request #3037: Disable ZK & BK fsync calls in integration tests

2018-11-21 Thread GitBox
ivankelly commented on a change in pull request #3037: Disable ZK & BK fsync calls in integration tests URL: https://github.com/apache/pulsar/pull/3037#discussion_r235513680 ## File path: conf/zookeeper.conf ## @@ -48,3 +48,8 @@ autopurge.snapRetainCount=3 # Purge task

[GitHub] sijie commented on issue #3034: Issue #2751: Add check to fix NPE

2018-11-21 Thread GitBox
sijie commented on issue #3034: Issue #2751: Add check to fix NPE URL: https://github.com/apache/pulsar/pull/3034#issuecomment-440781810 run integration tests This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
sijie commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235512093 ## File path: pulsar-grpc/src/main/proto/PulsarGrpc.proto ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] sijie commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
sijie commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235512545 ## File path: pulsar-grpc/src/main/java/org/apache/pulsar/grpc/TestClient.java ## @@ -0,0 +1,72 @@ +package org.apache.pulsar.grpc; +

[GitHub] sijie commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
sijie commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235507717 ## File path: pulsar-grpc/src/main/java/org/apache/pulsar/grpc/Constant.java ## @@ -0,0 +1,9 @@ +package org.apache.pulsar.grpc;

[GitHub] sijie commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
sijie commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235509248 ## File path: pulsar-grpc/src/main/proto/PulsarGrpc.proto ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] sijie commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
sijie commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235508431 ## File path: pulsar-grpc/src/main/proto/PulsarGrpc.proto ## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] sijie commented on a change in pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
sijie commented on a change in pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032#discussion_r235511763 ## File path: pulsar-grpc/src/main/java/org/apache/pulsar/grpc/ConsumerHandler.java ## @@ -0,0 +1,241 @@ +package

[GitHub] jerrypeng commented on issue #3028: [state] use closeAsync to close state storage client

2018-11-21 Thread GitBox
jerrypeng commented on issue #3028: [state] use closeAsync to close state storage client URL: https://github.com/apache/pulsar/pull/3028#issuecomment-440778440 rerun cpp tests This is an automated message from the Apache Git

[pulsar] branch master updated: adding windowed metrics for functions (#3021)

2018-11-21 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 859c914 adding windowed metrics for

[GitHub] merlimat opened a new pull request #3038: Remove Log4J 1.x from the bin distribution

2018-11-21 Thread GitBox
merlimat opened a new pull request #3038: Remove Log4J 1.x from the bin distribution URL: https://github.com/apache/pulsar/pull/3038 ### Motivation For some reasons, Log4J 1.2.x was being included in the binary tar.gz, even though not used anymore.

[GitHub] merlimat commented on issue #3006: Fixes for Java 11

2018-11-21 Thread GitBox
merlimat commented on issue #3006: Fixes for Java 11 URL: https://github.com/apache/pulsar/pull/3006#issuecomment-440768937 run integration tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat opened a new pull request #3037: Disable ZK & BK fsync calls in integration tests

2018-11-21 Thread GitBox
merlimat opened a new pull request #3037: Disable ZK & BK fsync calls in integration tests URL: https://github.com/apache/pulsar/pull/3037 ### Motivation Fysncs are very slow when writing within Docker containers. We should disable these in ZooKeeper and Bookies when running

[GitHub] ivankelly commented on issue #3036: Use topic unload instead of broker restarts in TestS3Offload

2018-11-21 Thread GitBox
ivankelly commented on issue #3036: Use topic unload instead of broker restarts in TestS3Offload URL: https://github.com/apache/pulsar/pull/3036#issuecomment-440768169 Ya, I'd like to root cause it first. It's on my current in-progress queue, so shouldn't take too long.

[GitHub] merlimat commented on issue #3036: Use topic unload instead of broker restarts in TestS3Offload

2018-11-21 Thread GitBox
merlimat commented on issue #3036: Use topic unload instead of broker restarts in TestS3Offload URL: https://github.com/apache/pulsar/pull/3036#issuecomment-440767288 I was taking a look at that test though I don't have identified the reason for the failure. I was just seeing the

[GitHub] merlimat opened a new pull request #3036: Use topic unload instead of broker restarts in TestS3Offload

2018-11-21 Thread GitBox
merlimat opened a new pull request #3036: Use topic unload instead of broker restarts in TestS3Offload URL: https://github.com/apache/pulsar/pull/3036 ### Motivation Topic unload is a lighter way to clean up all the broker state for a topic compared to restarting the broker, though

[GitHub] sijie commented on issue #3031: Error open RocksDB database in docker

2018-11-21 Thread GitBox
sijie commented on issue #3031: Error open RocksDB database in docker URL: https://github.com/apache/pulsar/issues/3031#issuecomment-440750785 Can you try to remove “ -v d:/temp/data:/pulsar/data ” to use non-mounted directory? I think the problem is how docker handle volumes on windows.

[GitHub] massakam commented on issue #3035: Update libcurl version included in docker images

2018-11-21 Thread GitBox
massakam commented on issue #3035: Update libcurl version included in docker images URL: https://github.com/apache/pulsar/pull/3035#issuecomment-440735432 rerun integration tests This is an automated message from the Apache

[GitHub] merlimat commented on issue #3033: Expose Redelivery Count By Message Properties(issue-3030)

2018-11-21 Thread GitBox
merlimat commented on issue #3033: Expose Redelivery Count By Message Properties(issue-3030) URL: https://github.com/apache/pulsar/pull/3033#issuecomment-440728259 @codelipenghui The properties were meant to be completely application defined. That also might confuse some application that

[GitHub] massakam commented on issue #3035: Update libcurl version included in docker images

2018-11-21 Thread GitBox
massakam commented on issue #3035: Update libcurl version included in docker images URL: https://github.com/apache/pulsar/pull/3035#issuecomment-440698823 rerun integration tests This is an automated message from the Apache

[GitHub] massakam commented on issue #3024: Enable SSL of LibCurl linked to C++ library

2018-11-21 Thread GitBox
massakam commented on issue #3024: Enable SSL of LibCurl linked to C++ library URL: https://github.com/apache/pulsar/pull/3024#issuecomment-440664720 Image `apachepulsar/pulsar-build:manylinux-cp33-cp33m` could not be built due to an error: ``` ln: creating symbolic link

[GitHub] massakam opened a new pull request #3035: Update libcurl version included in docker images

2018-11-21 Thread GitBox
massakam opened a new pull request #3035: Update libcurl version included in docker images URL: https://github.com/apache/pulsar/pull/3035 This is a continuation of https://github.com/apache/pulsar/pull/3024. 1. For the debian image, we can not enable SSL unless the version of

[GitHub] jiazhai edited a comment on issue #2943: Issue #2657: change function cli getstate to use REST endpoint

2018-11-21 Thread GitBox
jiazhai edited a comment on issue #2943: Issue #2657: change function cli getstate to use REST endpoint URL: https://github.com/apache/pulsar/pull/2943#issuecomment-440566888 rerun integration tests org.apache.pulsar.tests.integration.offload.TestS3Offload.tiered-storage-test-suite

[GitHub] jiazhai commented on issue #2943: Issue #2657: change function cli getstate to use REST endpoint

2018-11-21 Thread GitBox
jiazhai commented on issue #2943: Issue #2657: change function cli getstate to use REST endpoint URL: https://github.com/apache/pulsar/pull/2943#issuecomment-440630948 rerun integration tests This is an automated message

[GitHub] jiazhai opened a new pull request #3034: Issue #2751: Add check to fix NPE

2018-11-21 Thread GitBox
jiazhai opened a new pull request #3034: Issue #2751: Add check to fix NPE URL: https://github.com/apache/pulsar/pull/3034 ### Motivation We may meet NPE like this: ``` java.lang.NullPointerException: null at

[GitHub] codelipenghui commented on issue #3033: Expose Redelivery Count By Message Properties(issue-3030)

2018-11-21 Thread GitBox
codelipenghui commented on issue #3033: Expose Redelivery Count By Message Properties(issue-3030) URL: https://github.com/apache/pulsar/pull/3033#issuecomment-440609430 Fix issue #2375 This is an automated message from the

[GitHub] codelipenghui commented on issue #2375: Support for delayed message delivery

2018-11-21 Thread GitBox
codelipenghui commented on issue #2375: Support for delayed message delivery URL: https://github.com/apache/pulsar/issues/2375#issuecomment-440609300 @Ah39 PR #3033 This is an automated message from the Apache Git Service.

[GitHub] codelipenghui opened a new pull request #3033: Expose Redelivery Count By Message Properties(issue-3030)

2018-11-21 Thread GitBox
codelipenghui opened a new pull request #3033: Expose Redelivery Count By Message Properties(issue-3030) URL: https://github.com/apache/pulsar/pull/3033 ### Motivation Use redelivery count as a solution for delayed message delivery feature. For example, set ackTimeout 30

[GitHub] Ah39 commented on issue #2375: Support for delayed message delivery

2018-11-21 Thread GitBox
Ah39 commented on issue #2375: Support for delayed message delivery URL: https://github.com/apache/pulsar/issues/2375#issuecomment-440603449 mark ,the feature have finished ?? This is an automated message from the Apache Git

[GitHub] jiazhai commented on issue #2943: Issue #2657: change function cli getstate to use REST endpoint

2018-11-21 Thread GitBox
jiazhai commented on issue #2943: Issue #2657: change function cli getstate to use REST endpoint URL: https://github.com/apache/pulsar/pull/2943#issuecomment-440600097 rerun integration tests This is an automated message

[GitHub] cbornet opened a new pull request #3032: Add gRPC proxy

2018-11-21 Thread GitBox
cbornet opened a new pull request #3032: Add gRPC proxy URL: https://github.com/apache/pulsar/pull/3032 ### Motivation gRPC+Protobuf has a number of advantages compared to websockets + JSON Protobuf: * Static data structures: data validation, better tooling, etc... *

[GitHub] kaonick opened a new issue #3031: Error open RocksDB database in docker

2018-11-21 Thread GitBox
kaonick opened a new issue #3031: Error open RocksDB database in docker URL: https://github.com/apache/pulsar/issues/3031 Below is what I run in windows10's dos command `D:\temp>docker run -it -p 6650:6650 -p 8080:8080 -v d:/temp/data:/pulsar/data apachepulsar/pulsar:2.2.0

[GitHub] sijie closed pull request #2976: add debezium source documentation

2018-11-21 Thread GitBox
sijie closed pull request #2976: add debezium source documentation URL: https://github.com/apache/pulsar/pull/2976 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[pulsar] branch master updated: add debezium source documentation (#2976)

2018-11-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new aaf224b add debezium source documentation