[GitHub] ngjaying commented on issue #3224: Function option --subscription-type does not work

2018-12-26 Thread GitBox
ngjaying commented on issue #3224: Function option --subscription-type does not work URL: https://github.com/apache/pulsar/issues/3224#issuecomment-449927635 @sijie It seems the processing guarantee will only set the subscription type to Shared or FailOver. Is it possible to set Exclusive

[GitHub] jerrypeng edited a comment on issue #3224: Function option --subscription-type does not work

2018-12-26 Thread GitBox
jerrypeng edited a comment on issue #3224: Function option --subscription-type does not work URL: https://github.com/apache/pulsar/issues/3224#issuecomment-449929845 @ngjaying there is really no point for a function to use an exclusive subscription since the failover subscription can be vi

[GitHub] jerrypeng commented on issue #3224: Function option --subscription-type does not work

2018-12-26 Thread GitBox
jerrypeng commented on issue #3224: Function option --subscription-type does not work URL: https://github.com/apache/pulsar/issues/3224#issuecomment-449929845 @ngjaying there is really no point for a function that uses an exclusive subscription since the failover subscription can be viewed

[GitHub] jerrypeng edited a comment on issue #3224: Function option --subscription-type does not work

2018-12-26 Thread GitBox
jerrypeng edited a comment on issue #3224: Function option --subscription-type does not work URL: https://github.com/apache/pulsar/issues/3224#issuecomment-449929845 @ngjaying there is really no point for a function to use an exclusive subscription since the failover subscription can be vi

[GitHub] jerrypeng edited a comment on issue #3224: Function option --subscription-type does not work

2018-12-26 Thread GitBox
jerrypeng edited a comment on issue #3224: Function option --subscription-type does not work URL: https://github.com/apache/pulsar/issues/3224#issuecomment-449929845 @ngjaying there is really no point for a function to use an exclusive subscription since the failover subscription can be vi

[pulsar] branch asf-site updated: Updated site at revision ea6f366

2018-12-26 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 5d59d3c Updated site at revision ea6f366 5d

[GitHub] sijie commented on issue #3061: [conf] keep bookkeeper.conf insync with 4.7.2 bookkeeper's conf template

2018-12-26 Thread GitBox
sijie commented on issue #3061: [conf] keep bookkeeper.conf insync with 4.7.2 bookkeeper's conf template URL: https://github.com/apache/pulsar/pull/3061#issuecomment-449933072 run integration tests This is an automated messag

[GitHub] ngjaying commented on issue #3224: Function option --subscription-type does not work

2018-12-26 Thread GitBox
ngjaying commented on issue #3224: Function option --subscription-type does not work URL: https://github.com/apache/pulsar/issues/3224#issuecomment-449936557 @jerrypeng I use pulsar function for a complicated scenario. The function need to consume 2 topics (rule, message). Each instance of

[GitHub] jiazhai commented on issue #3157: Refactored PulsarRecordCursor to avoid intermediate thread

2018-12-26 Thread GitBox
jiazhai commented on issue #3157: Refactored PulsarRecordCursor to avoid intermediate thread URL: https://github.com/apache/pulsar/pull/3157#issuecomment-449949249 @merlimat Here is the error in the report: ``` org.apache.pulsar.sql.presto.TestPulsarRecordCursor.setup java.

[GitHub] jiazhai edited a comment on issue #3157: Refactored PulsarRecordCursor to avoid intermediate thread

2018-12-26 Thread GitBox
jiazhai edited a comment on issue #3157: Refactored PulsarRecordCursor to avoid intermediate thread URL: https://github.com/apache/pulsar/pull/3157#issuecomment-449949249 @merlimat [Here](https://builds.apache.org/job/pulsar_precommit_java8/5506/testReport/junit/org.apache.pulsar.sql.prest

[GitHub] maskit commented on a change in pull request #3252: [dev] PIP 27: Add checklist in github pull request template

2018-12-26 Thread GitBox
maskit commented on a change in pull request #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#discussion_r243993709 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -1,12 +1,62 @@ +<-- +### Contribution

[GitHub] maskit commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template

2018-12-26 Thread GitBox
maskit commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#issuecomment-449965302 It seems like adding tests for a new feature is required but documentation is optional. Is it correct? If yes, can you expl

[GitHub] maskit edited a comment on issue #3252: [dev] PIP 27: Add checklist in github pull request template

2018-12-26 Thread GitBox
maskit edited a comment on issue #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#issuecomment-449965302 It seems like adding tests for a new feature is required but documentation is optional. Is it correct? If yes, can y

[GitHub] legendtkl commented on issue #3243: Document new rest api - getLastMessageId

2018-12-26 Thread GitBox
legendtkl commented on issue #3243: Document new rest api - getLastMessageId URL: https://github.com/apache/pulsar/pull/3243#issuecomment-449986166 I update the document. Would you help review it again? @sijie This is an auto

[GitHub] sijie closed pull request #3251: cli support for getting last message id of a topic

2018-12-26 Thread GitBox
sijie closed pull request #3251: cli support for getting last message id of a topic URL: https://github.com/apache/pulsar/pull/3251 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

[pulsar] branch master updated: cli support for get last message id of a topic (#3251)

2018-12-26 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 94a9423 cli support for get last message id of a

[GitHub] sijie commented on issue #3243: Document new rest api - getLastMessageId

2018-12-26 Thread GitBox
sijie commented on issue #3243: Document new rest api - getLastMessageId URL: https://github.com/apache/pulsar/pull/3243#issuecomment-449988133 well done @legendtkl This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on a change in pull request #3252: [dev] PIP 27: Add checklist in github pull request template

2018-12-26 Thread GitBox
sijie commented on a change in pull request #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#discussion_r244016860 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -1,12 +1,62 @@ +<-- +### Contribution C

[GitHub] sijie commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template

2018-12-26 Thread GitBox
sijie commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#issuecomment-449988743 > Is it correct? If yes, can you explain the intention? yes that's correct. because not every code change requires docum

[GitHub] sijie edited a comment on issue #3252: [dev] PIP 27: Add checklist in github pull request template

2018-12-26 Thread GitBox
sijie edited a comment on issue #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#issuecomment-449988743 > Is it correct? If yes, can you explain the intention? yes that's correct. because not every code change require

[GitHub] sijie commented on a change in pull request #3252: [dev] PIP 27: Add checklist in github pull request template

2018-12-26 Thread GitBox
sijie commented on a change in pull request #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#discussion_r244018371 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -1,12 +1,62 @@ +<-- +### Contribution C

[GitHub] sijie commented on issue #3241: add backwards compatiblity to 2.2 for function admin API

2018-12-26 Thread GitBox
sijie commented on issue #3241: add backwards compatiblity to 2.2 for function admin API URL: https://github.com/apache/pulsar/pull/3241#issuecomment-44543 > what would be the best way to do that in the integration tests? Is there an easy way to use a older client in the integration te

[GitHub] sijie closed issue #3233: Document new rest api - getLastMessageId

2018-12-26 Thread GitBox
sijie closed issue #3233: Document new rest api - getLastMessageId URL: https://github.com/apache/pulsar/issues/3233 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] sijie closed pull request #3243: Document new rest api - getLastMessageId

2018-12-26 Thread GitBox
sijie closed pull request #3243: Document new rest api - getLastMessageId URL: https://github.com/apache/pulsar/pull/3243 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull r

[pulsar] branch master updated: Document new rest api - getLastMessageId (#3243)

2018-12-26 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7a31352 Document new rest api - getLastMessageId

[GitHub] sijie commented on issue #3224: Function option --subscription-type does not work

2018-12-26 Thread GitBox
sijie commented on issue #3224: Function option --subscription-type does not work URL: https://github.com/apache/pulsar/issues/3224#issuecomment-45469 @ngjaying it is an interesting use case. However I think the key requirement here is not supporting exclusive subscription. > F

[GitHub] sijie commented on issue #3253: Can Producer and Consumer run with jdk1.7?

2018-12-26 Thread GitBox
sijie commented on issue #3253: Can Producer and Consumer run with jdk1.7? URL: https://github.com/apache/pulsar/issues/3253#issuecomment-450016718 @cumtwwei currently the java client requires java 8+, since it uses a lot of features like CompletableFuture, Java8 Functions. one thi

[GitHub] jerrypeng commented on issue #3241: add backwards compatiblity to 2.2 for function admin API

2018-12-26 Thread GitBox
jerrypeng commented on issue #3241: add backwards compatiblity to 2.2 for function admin API URL: https://github.com/apache/pulsar/pull/3241#issuecomment-450051468 @sijie ok let me think about what the best way to do the integration tests some more and I will submit a future PR for it sinc

[pulsar] branch master updated: add backwards compatiblity to 2.2 for function admin API (#3241)

2018-12-26 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e63b658 add backwards compatiblity to 2.2 fo

[GitHub] jiazhai commented on issue #3236: Add update for Bundle, Topic, Subscription, Consumer if exist in dashboard

2018-12-26 Thread GitBox
jiazhai commented on issue #3236: Add update for Bundle,Topic,Subscription,Consumer if exist in dashboard URL: https://github.com/apache/pulsar/pull/3236#issuecomment-450056691 run java8 tests This is an automated message fro

[GitHub] sijie commented on issue #3225: python example with aws loadbalancer connection stuck

2018-12-26 Thread GitBox
sijie commented on issue #3225: python example with aws loadbalancer connection stuck URL: https://github.com/apache/pulsar/issues/3225#issuecomment-450060967 @lxkaka have you fixed the problem? This is an automated message f

[GitHub] sijie commented on issue #3226: Unclosed consumer after calling closeAsync

2018-12-26 Thread GitBox
sijie commented on issue #3226: Unclosed consumer after calling closeAsync URL: https://github.com/apache/pulsar/issues/3226#issuecomment-450061060 @legendtkl is working on this issue. This is an automated message from the Apa

[GitHub] sijie closed issue #2551: Client switch connection between different pulsar cluster.

2018-12-26 Thread GitBox
sijie closed issue #2551: Client switch connection between different pulsar cluster. URL: https://github.com/apache/pulsar/issues/2551 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] sijie commented on issue #2551: Client switch connection between different pulsar cluster.

2018-12-26 Thread GitBox
sijie commented on issue #2551: Client switch connection between different pulsar cluster. URL: https://github.com/apache/pulsar/issues/2551#issuecomment-450062227 This is fixed by #2543 #2671 This is an automated message f

[GitHub] sijie commented on issue #1981: Poor autorecovery performance on dedicated hosts

2018-12-26 Thread GitBox
sijie commented on issue #1981: Poor autorecovery performance on dedicated hosts URL: https://github.com/apache/pulsar/issues/1981#issuecomment-450062397 Close due to inactivities. This is an automated message from the Apache

[GitHub] sijie commented on issue #2533: can't generate ca key using the open ssl cnf file suggested for TLS Auth

2018-12-26 Thread GitBox
sijie commented on issue #2533: can't generate ca key using the open ssl cnf file suggested for TLS Auth URL: https://github.com/apache/pulsar/issues/2533#issuecomment-450062337 @dsambandam sorry for late response. Is your problem resolved? -

[GitHub] sijie closed issue #1981: Poor autorecovery performance on dedicated hosts

2018-12-26 Thread GitBox
sijie closed issue #1981: Poor autorecovery performance on dedicated hosts URL: https://github.com/apache/pulsar/issues/1981 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] sijie commented on issue #1490: Linux/Homebrew Package for apache-pulsar

2018-12-26 Thread GitBox
sijie commented on issue #1490: Linux/Homebrew Package for apache-pulsar URL: https://github.com/apache/pulsar/issues/1490#issuecomment-450062515 @coderfender any updates about this task? This is an automated message from the

[GitHub] ngjaying commented on issue #3224: Function option --subscription-type does not work

2018-12-26 Thread GitBox
ngjaying commented on issue #3224: Function option --subscription-type does not work URL: https://github.com/apache/pulsar/issues/3224#issuecomment-450063145 @sijie This is exactly my requirement, thanks for summarizing it. T

[GitHub] hlouf opened a new issue #3254: can Online Upgraded Version

2018-12-26 Thread GitBox
hlouf opened a new issue #3254: can Online Upgraded Version URL: https://github.com/apache/pulsar/issues/3254 Expected behavior i install pulsar2.1.0 ,now i want to online upgraded pulsar2.2.0,how do i do it? Tell us what should happen Actual behavior Tell us w

[GitHub] hlouf commented on issue #3254: can Online Upgraded Version

2018-12-26 Thread GitBox
hlouf commented on issue #3254: can Online Upgraded Version URL: https://github.com/apache/pulsar/issues/3254#issuecomment-450066547 thanks !! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] codelipenghui opened a new issue #3255: [Feature] Support multi-topic and pattern-topic for PulsarConsumerSource in pulsar-flink

2018-12-26 Thread GitBox
codelipenghui opened a new issue #3255: [Feature] Support multi-topic and pattern-topic for PulsarConsumerSource in pulsar-flink URL: https://github.com/apache/pulsar/issues/3255 Expected behavior Use PulsarConsumerSource to consume messages from topics(multi or pattern).

[GitHub] sijie commented on issue #3254: can Online Upgraded Version

2018-12-26 Thread GitBox
sijie commented on issue #3254: can Online Upgraded Version URL: https://github.com/apache/pulsar/issues/3254#issuecomment-450067602 Pulsar maintains backward compatibilities between versions. so it is trivial to upgrade between versions. A typical sequence would be: - upgrade bookie

[GitHub] codelipenghui opened a new pull request #3256: Support multi-topic and pattern-topic for PulsarConsumerSource in pul…

2018-12-26 Thread GitBox
codelipenghui opened a new pull request #3256: Support multi-topic and pattern-topic for PulsarConsumerSource in pul… URL: https://github.com/apache/pulsar/pull/3256 ### Motivation Easier to consume multiple topics by PulsarConsumerSource. ### Modifications Add multi-to

[GitHub] codelipenghui commented on issue #3255: [Feature] Support multi-topic and pattern-topic for PulsarConsumerSource in pulsar-flink

2018-12-26 Thread GitBox
codelipenghui commented on issue #3255: [Feature] Support multi-topic and pattern-topic for PulsarConsumerSource in pulsar-flink URL: https://github.com/apache/pulsar/issues/3255#issuecomment-450090375 refer to #3256 This is