[GitHub] wolfstudy edited a comment on issue #3455: Acktimeout cannot be set in Go Client

2019-01-27 Thread GitBox
wolfstudy edited a comment on issue #3455: Acktimeout cannot be set in Go Client URL: https://github.com/apache/pulsar/issues/3455#issuecomment-458027958 @tfhappy hello, I run the code you provided, and have the same problem, but when I set the timeout time to 10s or more, this code works f

[GitHub] wolfstudy edited a comment on issue #3455: Acktimeout cannot be set in Go Client

2019-01-27 Thread GitBox
wolfstudy edited a comment on issue #3455: Acktimeout cannot be set in Go Client URL: https://github.com/apache/pulsar/issues/3455#issuecomment-458027958 @tfhappy hello, I run the code you provided, and have the same problem, but when I set the timeout time to 10s or more, this code works f

[GitHub] wolfstudy edited a comment on issue #3455: Acktimeout cannot be set in Go Client

2019-01-27 Thread GitBox
wolfstudy edited a comment on issue #3455: Acktimeout cannot be set in Go Client URL: https://github.com/apache/pulsar/issues/3455#issuecomment-458027958 @tfhappy hello, I run the code you provided, and have the same problem, but when I set the timeout time to 10s or more, this code works f

[GitHub] wolfstudy commented on issue #3455: Acktimeout cannot be set in Go Client

2019-01-27 Thread GitBox
wolfstudy commented on issue #3455: Acktimeout cannot be set in Go Client URL: https://github.com/apache/pulsar/issues/3455#issuecomment-458027958 @tfhappy hello, I run the code you provided, and have the same problem, but when I set the timeout time to 10s or more, this code works fine.

[GitHub] JevonQ commented on issue #3230: expect not restart application after more partitions created

2019-01-27 Thread GitBox
JevonQ commented on issue #3230: expect not restart application after more partitions created URL: https://github.com/apache/pulsar/issues/3230#issuecomment-458024623 > @foreversunyao producers/consumers are not directly connected to ZK. > > We have on the roadmap to add support for

[GitHub] sijie commented on a change in pull request #3432: [Issue 3431] Support Kafka-IO to pass extra configs

2019-01-27 Thread GitBox
sijie commented on a change in pull request #3432: [Issue 3431] Support Kafka-IO to pass extra configs URL: https://github.com/apache/pulsar/pull/3432#discussion_r251299942 ## File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSinkConfig.java ## @@ -

[GitHub] wolfstudy commented on issue #3443: [go-client] integrated `logrus`, `testify` and `go mod` for pulsar-client-go

2019-01-27 Thread GitBox
wolfstudy commented on issue #3443: [go-client] integrated `logrus`, `testify` and `go mod` for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3443#issuecomment-458011920 @merlimat PTAL again, thanks This is an a

[pulsar] branch master updated: Removed remaining import and usages of boost::shared_ptr (#3449)

2019-01-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 95d02d5 Removed remaining import and usages of

[GitHub] merlimat merged pull request #3449: Removed remaining import and usages of boost::shared_ptr

2019-01-27 Thread GitBox
merlimat merged pull request #3449: Removed remaining import and usages of boost::shared_ptr URL: https://github.com/apache/pulsar/pull/3449 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] jiazhai commented on issue #2659: Add backlog quota configuration on topic

2019-01-27 Thread GitBox
jiazhai commented on issue #2659: Add backlog quota configuration on topic URL: https://github.com/apache/pulsar/pull/2659#issuecomment-458004098 it seems that this PR would need address system topic first. This is an automate

[GitHub] jiazhai closed issue #2877: Add integration test for KafkaConnectSource

2019-01-27 Thread GitBox
jiazhai closed issue #2877: Add integration test for KafkaConnectSource URL: https://github.com/apache/pulsar/issues/2877 This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] jiazhai commented on issue #2877: Add integration test for KafkaConnectSource

2019-01-27 Thread GitBox
jiazhai commented on issue #2877: Add integration test for KafkaConnectSource URL: https://github.com/apache/pulsar/issues/2877#issuecomment-458004405 PR #3154 was for this, and was closed This is an automated message from the

[GitHub] jiazhai commented on issue #3062: [bookie] enable bookie http server

2019-01-27 Thread GitBox
jiazhai commented on issue #3062: [bookie] enable bookie http server URL: https://github.com/apache/pulsar/pull/3062#issuecomment-458003763 retest this please This is an automated message from the Apache Git Service. To respo

[GitHub] jiazhai commented on issue #3413: Fix: init of subcription rateLimiter to avoid race-condition and NPE

2019-01-27 Thread GitBox
jiazhai commented on issue #3413: Fix: init of subcription rateLimiter to avoid race-condition and NPE URL: https://github.com/apache/pulsar/pull/3413#issuecomment-458003593 @rdhabalia Thanks for the change. lgtm. but from the code, this looks like a lazy creation, which could avoid crea

[GitHub] jiazhai commented on issue #3444: Fix REST API document link

2019-01-27 Thread GitBox
jiazhai commented on issue #3444: Fix REST API document link URL: https://github.com/apache/pulsar/pull/3444#issuecomment-458002447 run integration tests This is an automated message from the Apache Git Service. To res

[GitHub] jiazhai commented on issue #3445: Add document for unloading namespace API

2019-01-27 Thread GitBox
jiazhai commented on issue #3445: Add document for unloading namespace API URL: https://github.com/apache/pulsar/pull/3445#issuecomment-458002668 run java8 tests This is an automated message from the Apache Git Service. To res

[GitHub] jiazhai commented on issue #3445: Add document for unloading namespace API

2019-01-27 Thread GitBox
jiazhai commented on issue #3445: Add document for unloading namespace API URL: https://github.com/apache/pulsar/pull/3445#issuecomment-458002637 run integration tests This is an automated message from the Apache Git Service.

[GitHub] jiazhai commented on issue #3449: Removed remaining import and usages of boost::shared_ptr

2019-01-27 Thread GitBox
jiazhai commented on issue #3449: Removed remaining import and usages of boost::shared_ptr URL: https://github.com/apache/pulsar/pull/3449#issuecomment-457999566 run integration tests This is an automated message from the Apa

[GitHub] tfhappy opened a new issue #3455: Acktimeout cannot be set in Go Client

2019-01-27 Thread GitBox
tfhappy opened a new issue #3455: Acktimeout cannot be set in Go Client URL: https://github.com/apache/pulsar/issues/3455 **Describe the bug** When I create a consumer and specify acktimeout, I can't start it. **To Reproduce** ``` package main import ( "context"

[GitHub] murong00 commented on issue #3432: [Issue 3431] Support Kafka-IO to pass extra configs

2019-01-27 Thread GitBox
murong00 commented on issue #3432: [Issue 3431] Support Kafka-IO to pass extra configs URL: https://github.com/apache/pulsar/pull/3432#issuecomment-457996405 @sijie @jiazhai PTAL, thanks! This is an automated message from the

[GitHub] ConcurrencyPractitioner commented on issue #3450: Adding configuration to disable auto-topic creation

2019-01-27 Thread GitBox
ConcurrencyPractitioner commented on issue #3450: Adding configuration to disable auto-topic creation URL: https://github.com/apache/pulsar/pull/3450#issuecomment-457994721 Ok, there are some kinks in my understanding. Wouldn't disabling ```createIfMissing``` also mean that no non-partiti

[GitHub] murong00 commented on a change in pull request #3432: [Issue 3431] Support Kafka-IO to pass extra configs

2019-01-27 Thread GitBox
murong00 commented on a change in pull request #3432: [Issue 3431] Support Kafka-IO to pass extra configs URL: https://github.com/apache/pulsar/pull/3432#discussion_r251279178 ## File path: site2/docs/io-kafka.md ## @@ -37,5 +38,6 @@ to a Kafka topic. | batchSize | `true`

[GitHub] murong00 commented on a change in pull request #3432: [Issue 3431] Support Kafka-IO to pass extra configs

2019-01-27 Thread GitBox
murong00 commented on a change in pull request #3432: [Issue 3431] Support Kafka-IO to pass extra configs URL: https://github.com/apache/pulsar/pull/3432#discussion_r251279252 ## File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java ##

[GitHub] murong00 commented on a change in pull request #3432: [Issue 3431] Support Kafka-IO to pass extra configs

2019-01-27 Thread GitBox
murong00 commented on a change in pull request #3432: [Issue 3431] Support Kafka-IO to pass extra configs URL: https://github.com/apache/pulsar/pull/3432#discussion_r251279178 ## File path: site2/docs/io-kafka.md ## @@ -37,5 +38,6 @@ to a Kafka topic. | batchSize | `true`

[GitHub] jerrypeng merged pull request #3397: Exposing more methods in Sink/Source Context

2019-01-27 Thread GitBox
jerrypeng merged pull request #3397: Exposing more methods in Sink/Source Context URL: https://github.com/apache/pulsar/pull/3397 This is an automated message from the Apache Git Service. To respond to the message, please lo

[pulsar] branch master updated: Exposing more methods in Sink/Source Context (#3397)

2019-01-27 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ee25415 Exposing more methods in Sink/Source

[GitHub] ConcurrencyPractitioner edited a comment on issue #3450: Adding configuration to disable auto-topic creation

2019-01-27 Thread GitBox
ConcurrencyPractitioner edited a comment on issue #3450: Adding configuration to disable auto-topic creation URL: https://github.com/apache/pulsar/pull/3450#issuecomment-457945680 Ok, I did some digging and here's what I found: ```createIfMissing``` is used when seeing if a Z-Node is alr

[GitHub] jiazhai commented on issue #3449: Removed remaining import and usages of boost::shared_ptr

2019-01-27 Thread GitBox
jiazhai commented on issue #3449: Removed remaining import and usages of boost::shared_ptr URL: https://github.com/apache/pulsar/pull/3449#issuecomment-457990913 run integration tests This is an automated message from the Apa

[GitHub] jiazhai commented on issue #3369: IndexOutOfBoundsException in kafka ConsumerExample

2019-01-27 Thread GitBox
jiazhai commented on issue #3369: IndexOutOfBoundsException in kafka ConsumerExample URL: https://github.com/apache/pulsar/issues/3369#issuecomment-457989329 @ambition119 đź‘Ť . Would you like to help adding some comments in the code or documentation for this issue? -

[GitHub] tuteng commented on issue #3447: Running commands pulsar-admin source localrun report class java.lang.NullPointerException: null

2019-01-27 Thread GitBox
tuteng commented on issue #3447: Running commands pulsar-admin source localrun report class java.lang.NullPointerException: null URL: https://github.com/apache/pulsar/issues/3447#issuecomment-457987244 Okay, I'll create a pr later. --

[GitHub] jiazhai edited a comment on issue #3454: [Feature Request] Dynamically refresh client after updating the number of partitions when the routing mode is not key hash

2019-01-27 Thread GitBox
jiazhai edited a comment on issue #3454: [Feature Request] Dynamically refresh client after updating the number of partitions when the routing mode is not key hash URL: https://github.com/apache/pulsar/issues/3454#issuecomment-457986298 issue #3230 is related -

[GitHub] jiazhai commented on issue #3454: [Feature Request] Dynamically refresh client after updating the number of partitions when the routing mode is not key hash

2019-01-27 Thread GitBox
jiazhai commented on issue #3454: [Feature Request] Dynamically refresh client after updating the number of partitions when the routing mode is not key hash URL: https://github.com/apache/pulsar/issues/3454#issuecomment-457986298 #3230 is related ---

[GitHub] merlimat merged pull request #3451: Fix incomplete documentation in cookbooks-retention-expiry

2019-01-27 Thread GitBox
merlimat merged pull request #3451: Fix incomplete documentation in cookbooks-retention-expiry URL: https://github.com/apache/pulsar/pull/3451 This is an automated message from the Apache Git Service. To respond to the messa

[pulsar] branch master updated: Fix incomplete documentation in cookbooks-retention-expiry (#3451)

2019-01-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2391503 Fix incomplete documentation in cookboo

[GitHub] jiazhai commented on issue #3447: Running commands pulsar-admin source localrun report class java.lang.NullPointerException: null

2019-01-27 Thread GitBox
jiazhai commented on issue #3447: Running commands pulsar-admin source localrun report class java.lang.NullPointerException: null URL: https://github.com/apache/pulsar/issues/3447#issuecomment-457984127 Thanks @tuteng for point it out, Would you like to solve this issue? --

[GitHub] jiazhai commented on issue #3446: Support Time Index to support seeking based on time in reader interface.

2019-01-27 Thread GitBox
jiazhai commented on issue #3446: Support Time Index to support seeking based on time in reader interface. URL: https://github.com/apache/pulsar/issues/3446#issuecomment-457983741 Thanks for point out, this is a good feature to have. --

[GitHub] merlimat commented on issue #3449: Removed remaining import and usages of boost::shared_ptr

2019-01-27 Thread GitBox
merlimat commented on issue #3449: Removed remaining import and usages of boost::shared_ptr URL: https://github.com/apache/pulsar/pull/3449#issuecomment-457982864 run integration tests This is an automated message from the Ap

[GitHub] merlimat merged pull request #3427: Add set python version script

2019-01-27 Thread GitBox
merlimat merged pull request #3427: Add set python version script URL: https://github.com/apache/pulsar/pull/3427 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and u

[pulsar] branch master updated: Add set python version script (#3427)

2019-01-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0446075 Add set python version script (#3427) 0

[pulsar] branch master updated: Update command usage for pulsar-perf cli command (#2895) (#3452)

2019-01-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 39e0f32 Update command usage for pulsar-perf cl

[GitHub] merlimat merged pull request #3452: Update command usage for pulsar-perf cli command (#2895)

2019-01-27 Thread GitBox
merlimat merged pull request #3452: Update command usage for pulsar-perf cli command (#2895) URL: https://github.com/apache/pulsar/pull/3452 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] ambition119 commented on a change in pull request #3434: [Issue 3390] UncaughtExceptionLogsNOTWork

2019-01-27 Thread GitBox
ambition119 commented on a change in pull request #3434: [Issue 3390] UncaughtExceptionLogsNOTWork URL: https://github.com/apache/pulsar/pull/3434#discussion_r251270165 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java ## @@ -273,8 +277,

[GitHub] ambition119 commented on issue #3379: Issue #3378: [pulsar-io] Support Pulsar to receive and send data from Apache NiFi

2019-01-27 Thread GitBox
ambition119 commented on issue #3379: Issue #3378: [pulsar-io] Support Pulsar to receive and send data from Apache NiFi URL: https://github.com/apache/pulsar/pull/3379#issuecomment-457977617 > overall looks good. left bunch of comments. > > Can you also add an integration test and a

[GitHub] wolfstudy commented on a change in pull request #3443: [go-client] integrated `logrus`, `testify` and `go mod` for pulsar-client-go

2019-01-27 Thread GitBox
wolfstudy commented on a change in pull request #3443: [go-client] integrated `logrus`, `testify` and `go mod` for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3443#discussion_r251267255 ## File path: pulsar-client-go/examples/consumer-listener/consumer-listener.go #

[GitHub] jerrypeng commented on issue #3397: Exposing more methods in Sink/Source Context

2019-01-27 Thread GitBox
jerrypeng commented on issue #3397: Exposing more methods in Sink/Source Context URL: https://github.com/apache/pulsar/pull/3397#issuecomment-457975537 rerun integration tests This is an automated message from the Apache G

[GitHub] ambition119 commented on issue #3369: IndexOutOfBoundsException

2019-01-27 Thread GitBox
ambition119 commented on issue #3369: IndexOutOfBoundsException URL: https://github.com/apache/pulsar/issues/3369#issuecomment-457975401 @jiazhai @sautran org.apache.pulsar.client.kafka.compat.examples.ConsumerExample.java should use pulsar shaded jar offered [KafkaConsumer](https://

[GitHub] merlimat commented on issue #3452: Update command usage for pulsar-perf cli command (#2895)

2019-01-27 Thread GitBox
merlimat commented on issue #3452: Update command usage for pulsar-perf cli command (#2895) URL: https://github.com/apache/pulsar/pull/3452#issuecomment-457975203 run cpp tests This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #3451: Fix incomplete documentation in cookbooks-retention-expiry

2019-01-27 Thread GitBox
merlimat commented on issue #3451: Fix incomplete documentation in cookbooks-retention-expiry URL: https://github.com/apache/pulsar/pull/3451#issuecomment-457975083 run integration tests This is an automated message from the

[GitHub] ambition119 commented on issue #3415: [pulsar-client] add BooleanSchema

2019-01-27 Thread GitBox
ambition119 commented on issue #3415: [pulsar-client] add BooleanSchema URL: https://github.com/apache/pulsar/pull/3415#issuecomment-457972545 run integration tests org.apache.pulsar.tests.integration.functions.PulsarFunctionsThreadTest.pulsar-test-suite ---

[GitHub] ConcurrencyPractitioner edited a comment on issue #3450: Adding configuration to disable auto-topic creation

2019-01-27 Thread GitBox
ConcurrencyPractitioner edited a comment on issue #3450: Adding configuration to disable auto-topic creation URL: https://github.com/apache/pulsar/pull/3450#issuecomment-457945680 Ok, I did some digging and here's what I found: ```createIfMissing``` is used when seeing if a Z-Node is alr

[GitHub] ConcurrencyPractitioner commented on issue #3450: Adding configuration to disable auto-topic creation

2019-01-27 Thread GitBox
ConcurrencyPractitioner commented on issue #3450: Adding configuration to disable auto-topic creation URL: https://github.com/apache/pulsar/pull/3450#issuecomment-457945680 Ok, I did some digging and here's what I found: ```createIfMissing``` is used when seeing if a Z-Node is already bu

[pulsar] branch master updated: UncaughtExceptionLogsNOTWork (#3434)

2019-01-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 32e7f33 UncaughtExceptionLogsNOTWork (#3434) 32

[GitHub] merlimat closed issue #3390: pulsar-daemon start broker without setting mandatory parameter failed without any errors

2019-01-27 Thread GitBox
merlimat closed issue #3390: pulsar-daemon start broker without setting mandatory parameter failed without any errors URL: https://github.com/apache/pulsar/issues/3390 This is an automated message from the Apache Git Service

[GitHub] merlimat merged pull request #3434: [Issue 3390] UncaughtExceptionLogsNOTWork

2019-01-27 Thread GitBox
merlimat merged pull request #3434: [Issue 3390] UncaughtExceptionLogsNOTWork URL: https://github.com/apache/pulsar/pull/3434 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] merlimat merged pull request #3441: CPP Client - initialize flushedPartitions_ correctly and fix make tes…

2019-01-27 Thread GitBox
merlimat merged pull request #3441: CPP Client - initialize flushedPartitions_ correctly and fix make tes… URL: https://github.com/apache/pulsar/pull/3441 This is an automated message from the Apache Git Service. To respond

[pulsar] branch master updated: CPP Client - initialize flushedPartitions_ correctly and fix make test rerunnable (#3441)

2019-01-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new eda414d CPP Client - initialize flushedPartitio

[GitHub] JevonQ opened a new issue #3454: [Feature Request] Dynamically refresh client after updating the number of partitions when the routing mode is not key hash

2019-01-27 Thread GitBox
JevonQ opened a new issue #3454: [Feature Request] Dynamically refresh client after updating the number of partitions when the routing mode is not key hash URL: https://github.com/apache/pulsar/issues/3454 According to the web page (admin-api-partitioned-topics, https://pulsar.apache.org/d

[GitHub] skyrocknroll opened a new issue #3453: Support subscribe position - initial or latest in python client

2019-01-27 Thread GitBox
skyrocknroll opened a new issue #3453: Support subscribe position - initial or latest in python client URL: https://github.com/apache/pulsar/issues/3453 **Is your feature request related to a problem? Please describe.** The subscribe method in python client does not support Subscriptio

[pulsar] branch asf-site updated: Updated site at revision 762e0ab

2019-01-27 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 96fdfd0 Updated site at revision 762e0ab 96

[GitHub] MarvinCai opened a new pull request #3452: Update command usage for pulsar-perf cli command (#2895)

2019-01-27 Thread GitBox
MarvinCai opened a new pull request #3452: Update command usage for pulsar-perf cli command (#2895) URL: https://github.com/apache/pulsar/pull/3452 ### Motivation Fix for issue: #2895 ### Changes As all required argument already have required flag for JCommander, update the do

[GitHub] jiazhai merged pull request #3312: Prevent dup consumers on same client cnx with shared subscription

2019-01-27 Thread GitBox
jiazhai merged pull request #3312: Prevent dup consumers on same client cnx with shared subscription URL: https://github.com/apache/pulsar/pull/3312 This is an automated message from the Apache Git Service. To respond to the

[pulsar] branch master updated: Prevent dup consumers on same client cnx with shared subscription (#3312)

2019-01-27 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository. zhaijia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 231db03 Prevent dup consumers on same client c