[GitHub] sijie commented on issue #3683: [schema] Introduce `GenericSchema` interface

2019-02-26 Thread GitBox
sijie commented on issue #3683: [schema] Introduce `GenericSchema` interface URL: https://github.com/apache/pulsar/pull/3683#issuecomment-467751680 run java8 tests This is an automated message from the Apache Git Service. To r

[GitHub] sijie commented on issue #3665: [schema] clean up the implementations of schema bc check

2019-02-26 Thread GitBox
sijie commented on issue #3665: [schema] clean up the implementations of schema bc check URL: https://github.com/apache/pulsar/pull/3665#issuecomment-467751612 run java8 tests This is an automated message from the Apache Git

[GitHub] sijie commented on issue #3691: fix Jenkins pulsar-website-build error 571

2019-02-26 Thread GitBox
sijie commented on issue #3691: fix Jenkins pulsar-website-build error 571 URL: https://github.com/apache/pulsar/pull/3691#issuecomment-467751521 run java8 tests This is an automated message from the Apache Git Service. To res

[GitHub] sijie commented on a change in pull request #3696: fix elasticsearch in pom Consistent with other IOs

2019-02-26 Thread GitBox
sijie commented on a change in pull request #3696: fix elasticsearch in pom Consistent with other IOs URL: https://github.com/apache/pulsar/pull/3696#discussion_r260617752 ## File path: pulsar-io/elastic-search/pom.xml ## @@ -56,13 +56,12 @@ org.apache.commons

[GitHub] sijie commented on issue #3348: Remove broker mode to handle persistent/non-persistent topics separately

2019-02-26 Thread GitBox
sijie commented on issue #3348: Remove broker mode to handle persistent/non-persistent topics separately URL: https://github.com/apache/pulsar/pull/3348#issuecomment-467749865 @rdhabalia it seems that you didn't reply to my comment. this PR removed settings from configurations. these shoul

[GitHub] aahmed-se commented on issue #3686: python bookkeeper client defective for python2 in mac

2019-02-26 Thread GitBox
aahmed-se commented on issue #3686: python bookkeeper client defective for python2 in mac URL: https://github.com/apache/pulsar/issues/3686#issuecomment-467748513 https://pypi.org/project/protobuf/ that's the latest version so it should fine to take a dependency on it. -

[GitHub] sijie commented on issue #3686: python bookkeeper client defective for python2 in mac

2019-02-26 Thread GitBox
sijie commented on issue #3686: python bookkeeper client defective for python2 in mac URL: https://github.com/apache/pulsar/issues/3686#issuecomment-467748026 @jerrypeng maybe we can set the version of protobuf to be 3.6.1 Th

[GitHub] sijie commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-26 Thread GitBox
sijie commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-467746388 run java8 tests This is an automate

[GitHub] hwind001 opened a new issue #3699: build failed without lombok

2019-02-26 Thread GitBox
hwind001 opened a new issue #3699: build failed without lombok URL: https://github.com/apache/pulsar/issues/3699 why use lombok plugin ? this plugin cause source build failed , not friendly to read source. very very not friendly ~~ trash -

[GitHub] srkukarni opened a new pull request #3698: Adjust the serving threads to have a minimum of threads

2019-02-26 Thread GitBox
srkukarni opened a new pull request #3698: Adjust the serving threads to have a minimum of threads URL: https://github.com/apache/pulsar/pull/3698 ### Motivation The current logic of determining the number of http serving threads has difficulties when the number of available cores are

[GitHub] srkukarni commented on issue #3693: Fix topic name logic for partitioned topics

2019-02-26 Thread GitBox
srkukarni commented on issue #3693: Fix topic name logic for partitioned topics URL: https://github.com/apache/pulsar/pull/3693#issuecomment-467734318 run java8 tests This is an automated message from the Apache Git Service. T

[GitHub] jerrypeng closed issue #3679: Pulsar SQL queries fail with "failed: refCnt: 0"

2019-02-26 Thread GitBox
jerrypeng closed issue #3679: Pulsar SQL queries fail with "failed: refCnt: 0" URL: https://github.com/apache/pulsar/issues/3679 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] xujianhai opened a new pull request #3697: add cli client consumer for standalone

2019-02-26 Thread GitBox
xujianhai opened a new pull request #3697: add cli client consumer for standalone URL: https://github.com/apache/pulsar/pull/3697 ### Contribution Checklist ### Motivation add cli usage demo in standalone mode. ### Modifications ### Verifying this change ###

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-26 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-467717718 @sijie I guess this could be merged unless you think there should be something el

[GitHub] ambition119 commented on a change in pull request #3691: fix Jenkins pulsar-website-build error 571

2019-02-26 Thread GitBox
ambition119 commented on a change in pull request #3691: fix Jenkins pulsar-website-build error 571 URL: https://github.com/apache/pulsar/pull/3691#discussion_r260565723 ## File path: site2/website/versioned_docs/version-2.3.0/io-cdc-canal.md ## @@ -2,6 +2,7 @@ id: io-cdc

[GitHub] jerrypeng commented on issue #3686: python bookkeeper client defective for python2 in mac

2019-02-26 Thread GitBox
jerrypeng commented on issue #3686: python bookkeeper client defective for python2 in mac URL: https://github.com/apache/pulsar/issues/3686#issuecomment-467690817 @sijie @srkukarni after I updated protobuf to the latest version for python2, I didn't get the error anymore: ``` Jer

[GitHub] aahmed-se commented on issue #3686: python bookkeeper client defective for python2 in mac

2019-02-26 Thread GitBox
aahmed-se commented on issue #3686: python bookkeeper client defective for python2 in mac URL: https://github.com/apache/pulsar/issues/3686#issuecomment-467689887 2.3.0.post1 is official release it's an update to 2.3.0 This i

[GitHub] sijie commented on a change in pull request #3691: fix Jenkins pulsar-website-build error 571

2019-02-26 Thread GitBox
sijie commented on a change in pull request #3691: fix Jenkins pulsar-website-build error 571 URL: https://github.com/apache/pulsar/pull/3691#discussion_r260554511 ## File path: site2/website/versioned_docs/version-2.3.0/io-cdc-canal.md ## @@ -2,6 +2,7 @@ id: io-cdc-canal

[GitHub] sijie commented on a change in pull request #3691: fix Jenkins pulsar-website-build error 571

2019-02-26 Thread GitBox
sijie commented on a change in pull request #3691: fix Jenkins pulsar-website-build error 571 URL: https://github.com/apache/pulsar/pull/3691#discussion_r260554598 ## File path: site2/website/versioned_docs/version-2.3.0/io-cdc.md ## @@ -2,6 +2,7 @@ id: io-cdc Review c

[GitHub] sijie commented on a change in pull request #3691: fix Jenkins pulsar-website-build error 571

2019-02-26 Thread GitBox
sijie commented on a change in pull request #3691: fix Jenkins pulsar-website-build error 571 URL: https://github.com/apache/pulsar/pull/3691#discussion_r260554537 ## File path: site2/website/versioned_docs/version-2.3.0/io-cdc-debezium.md ## @@ -2,6 +2,7 @@ id: io-cdc-de

[GitHub] srkukarni commented on issue #3693: Fix topic name logic for partitioned topics

2019-02-26 Thread GitBox
srkukarni commented on issue #3693: Fix topic name logic for partitioned topics URL: https://github.com/apache/pulsar/pull/3693#issuecomment-467678673 run java8 tests This is an automated message from the Apache Git Service. T

[GitHub] ambition119 opened a new pull request #3696: fix elasticsearch in pom Consistent with other IOs

2019-02-26 Thread GitBox
ambition119 opened a new pull request #3696: fix elasticsearch in pom Consistent with other IOs URL: https://github.com/apache/pulsar/pull/3696 <-- ### Contribution Checklist - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* s

[GitHub] ambition119 opened a new pull request #3695: Integration Hbase Test

2019-02-26 Thread GitBox
ambition119 opened a new pull request #3695: Integration Hbase Test URL: https://github.com/apache/pulsar/pull/3695 <-- ### Contribution Checklist - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actu

[GitHub] sijie commented on issue #3686: python bookkeeper client defective for python2 in mac

2019-02-26 Thread GitBox
sijie commented on issue #3686: python bookkeeper client defective for python2 in mac URL: https://github.com/apache/pulsar/issues/3686#issuecomment-467675729 @jerrypeng @srkukarni I am not able to reproduce what your problem at my mac using the 4.9.0 bookkeeper client. my mac is Mojave 10

[GitHub] ambition119 commented on issue #3691: fix Jenkins pulsar-website-build error 571

2019-02-26 Thread GitBox
ambition119 commented on issue #3691: fix Jenkins pulsar-website-build error 571 URL: https://github.com/apache/pulsar/pull/3691#issuecomment-467669899 run Integration Tests This is an automated message from the Apache Git Ser

[GitHub] merlimat commented on issue #3694: [Conf] Add Reasonable defaults to httpserverthreads

2019-02-26 Thread GitBox
merlimat commented on issue #3694: [Conf] Add Reasonable defaults to httpserverthreads URL: https://github.com/apache/pulsar/pull/3694#issuecomment-467658570 > I don't think we should change the default here. There is already a default mechanism implemented: Correct. If necessary w

[GitHub] aahmed-se opened a new pull request #3694: [Conf] Add Reasonable defaults to httpserverthreads

2019-02-26 Thread GitBox
aahmed-se opened a new pull request #3694: [Conf] Add Reasonable defaults to httpserverthreads URL: https://github.com/apache/pulsar/pull/3694 ### Modifications We add some reasonable defaults for the httpserver. ### Does this pull request potentially affect one of the followi

[GitHub] rdhabalia commented on issue #2954: Broker considers fail-over consumer priority-level

2019-02-26 Thread GitBox
rdhabalia commented on issue #2954: Broker considers fail-over consumer priority-level URL: https://github.com/apache/pulsar/pull/2954#issuecomment-467624751 retest this please This is an automated message from the Apache Git

[GitHub] rdhabalia commented on issue #3426: Handle replication-cluster list change for peer-cluster when zk-watch…

2019-02-26 Thread GitBox
rdhabalia commented on issue #3426: Handle replication-cluster list change for peer-cluster when zk-watch… URL: https://github.com/apache/pulsar/pull/3426#issuecomment-467624503 rerun integration tests This is an automated me

[GitHub] srkukarni commented on issue #3693: Fix topic name logic for partitioned topics

2019-02-26 Thread GitBox
srkukarni commented on issue #3693: Fix topic name logic for partitioned topics URL: https://github.com/apache/pulsar/pull/3693#issuecomment-467600890 @jerrypeng added unittest This is an automated message from the Apache Git

[GitHub] jerrypeng commented on issue #3686: python bookkeeper client defective for python2 in mac

2019-02-26 Thread GitBox
jerrypeng commented on issue #3686: python bookkeeper client defective for python2 in mac URL: https://github.com/apache/pulsar/issues/3686#issuecomment-467578182 @sijie @ivankelly @jiazhai can you please take look as this prevents running functions on MacOS using python2

[GitHub] rdhabalia commented on issue #2953: Avoid debug noise by consumer ack-tracker

2019-02-26 Thread GitBox
rdhabalia commented on issue #2953: Avoid debug noise by consumer ack-tracker URL: https://github.com/apache/pulsar/pull/2953#issuecomment-467570286 rerun java8 tests This is an automated message from the Apache Git Service. T

[GitHub] rdhabalia commented on issue #3426: Handle replication-cluster list change for peer-cluster when zk-watch…

2019-02-26 Thread GitBox
rdhabalia commented on issue #3426: Handle replication-cluster list change for peer-cluster when zk-watch… URL: https://github.com/apache/pulsar/pull/3426#issuecomment-467570148 retest this please This is an automated message

[GitHub] rdhabalia commented on issue #2954: Broker considers fail-over consumer priority-level

2019-02-26 Thread GitBox
rdhabalia commented on issue #2954: Broker considers fail-over consumer priority-level URL: https://github.com/apache/pulsar/pull/2954#issuecomment-467570219 retest this please This is an automated message from the Apache Git

[pulsar] branch master updated: Remove broker mode to handle persistent/non-persistent topics separately (#3348)

2019-02-26 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 77d4c28 Remove broker mode to handle persist

[GitHub] rdhabalia merged pull request #3348: Remove broker mode to handle persistent/non-persistent topics separately

2019-02-26 Thread GitBox
rdhabalia merged pull request #3348: Remove broker mode to handle persistent/non-persistent topics separately URL: https://github.com/apache/pulsar/pull/3348 This is an automated message from the Apache Git Service. To respo

[GitHub] rdhabalia commented on issue #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache

2019-02-26 Thread GitBox
rdhabalia commented on issue #3633: [pulsar-broker] Fix deadlock: add zk-operation timeout for blocking call on zk-cache URL: https://github.com/apache/pulsar/pull/3633#issuecomment-467569434 rerun java8 tests This is an auto

[pulsar] branch master updated: [pulsar-broker] fix: npe while acking message (#3687)

2019-02-26 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3ac67de [pulsar-broker] fix: npe while ackin

[GitHub] rdhabalia merged pull request #3687: [pulsar-broker] fix: npe while acking message

2019-02-26 Thread GitBox
rdhabalia merged pull request #3687: [pulsar-broker] fix: npe while acking message URL: https://github.com/apache/pulsar/pull/3687 This is an automated message from the Apache Git Service. To respond to the message, please l

[pulsar] branch master updated: Simplified the workflow of functionruntime manager (#3551)

2019-02-26 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 878362c Simplified the workflow of functionr

[GitHub] srkukarni merged pull request #3551: Simplified the workflow of functionruntime manager

2019-02-26 Thread GitBox
srkukarni merged pull request #3551: Simplified the workflow of functionruntime manager URL: https://github.com/apache/pulsar/pull/3551 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] jerrypeng commented on issue #3693: Fix topic name logic for partitioned topics

2019-02-26 Thread GitBox
jerrypeng commented on issue #3693: Fix topic name logic for partitioned topics URL: https://github.com/apache/pulsar/pull/3693#issuecomment-467561079 @srkukarni PR looks good. Can we add a unit test for this? This is an auto

[GitHub] srkukarni opened a new pull request #3693: Fix topic name logic for partitioned topics

2019-02-26 Thread GitBox
srkukarni opened a new pull request #3693: Fix topic name logic for partitioned topics URL: https://github.com/apache/pulsar/pull/3693 ### Motivation When python functions do explicit acking using context.ack method, the topic name that they pass could be a partitioned topic. Partit

[GitHub] david-streamlio closed issue #3692: Unable to build Docker images

2019-02-26 Thread GitBox
david-streamlio closed issue #3692: Unable to build Docker images URL: https://github.com/apache/pulsar/issues/3692 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] merlimat commented on issue #3687: [pulsar-broker] fix: npe while acking message

2019-02-26 Thread GitBox
merlimat commented on issue #3687: [pulsar-broker] fix: npe while acking message URL: https://github.com/apache/pulsar/pull/3687#issuecomment-467524705 rerun java8 tests This is an automated message from the Apache Git Service

[GitHub] merlimat commented on issue #3688: When the loadmanager leader is not available, fall through regular least loaded selection

2019-02-26 Thread GitBox
merlimat commented on issue #3688: When the loadmanager leader is not available, fall through regular least loaded selection URL: https://github.com/apache/pulsar/pull/3688#issuecomment-467524495 run java8 tests run integration tests -

[GitHub] david-streamlio opened a new issue #3692: Unable to build Docker images

2019-02-26 Thread GitBox
david-streamlio opened a new issue #3692: Unable to build Docker images URL: https://github.com/apache/pulsar/issues/3692 **Describe the bug** **To Reproduce** Steps to reproduce the behavior: 1. Check out the latest version from the master branch 2. run `mvn clean instal

[GitHub] ambition119 commented on issue #3369: IndexOutOfBoundsException in kafka ConsumerExample

2019-02-26 Thread GitBox
ambition119 commented on issue #3369: IndexOutOfBoundsException in kafka ConsumerExample URL: https://github.com/apache/pulsar/issues/3369#issuecomment-467489844 @sautran so this issue solved? This is an automated message fro

[GitHub] ambition119 opened a new pull request #3691: fix Jenkins pulsar-website-build error 571

2019-02-26 Thread GitBox
ambition119 opened a new pull request #3691: fix Jenkins pulsar-website-build error 571 URL: https://github.com/apache/pulsar/pull/3691 ### Motivation Jenkins pulsar-website-build error 571, error info: ```java Error: No 'original_id' field found in /pulsar/site2/website/versioned

[GitHub] ambition119 opened a new pull request #3691: fix Jenkins pulsar-website-build error 571

2019-02-26 Thread GitBox
ambition119 opened a new pull request #3691: fix Jenkins pulsar-website-build error 571 URL: https://github.com/apache/pulsar/pull/3691 ### Motivation Jenkins pulsar-website-build error 571, error info: ```java Error: No 'original_id' field found in /pulsar/site2/website/versioned

[GitHub] sijie commented on issue #3665: [schema] clean up the implementations of schema bc check

2019-02-26 Thread GitBox
sijie commented on issue #3665: [schema] clean up the implementations of schema bc check URL: https://github.com/apache/pulsar/pull/3665#issuecomment-467466366 run java8 tests This is an automated message from the Apache Git

[GitHub] sijie commented on issue #3665: [schema] clean up the implementations of schema bc check

2019-02-26 Thread GitBox
sijie commented on issue #3665: [schema] clean up the implementations of schema bc check URL: https://github.com/apache/pulsar/pull/3665#issuecomment-467466366 run java8 tests This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #3689: provide a *unack* mechanism to unack a message if the consumer can't process

2019-02-26 Thread GitBox
merlimat commented on issue #3689: provide a *unack* mechanism to unack a message if the consumer can't process URL: https://github.com/apache/pulsar/issues/3689#issuecomment-467445058 I have this in progress This is an auto

[GitHub] merlimat commented on issue #3689: provide a *unack* mechanism to unack a message if the consumer can't process

2019-02-26 Thread GitBox
merlimat commented on issue #3689: provide a *unack* mechanism to unack a message if the consumer can't process URL: https://github.com/apache/pulsar/issues/3689#issuecomment-467445058 I have this in progress This is an auto

[GitHub] sijie opened a new pull request #3690: [schema] Introduce GenericRecordBuilder and the avro implementation

2019-02-26 Thread GitBox
sijie opened a new pull request #3690: [schema] Introduce GenericRecordBuilder and the avro implementation URL: https://github.com/apache/pulsar/pull/3690 ### Motivation Provides a mechansim to produce a generic record in programming way. ### Modifications

[GitHub] sijie opened a new pull request #3690: [schema] Introduce GenericRecordBuilder and the avro implementation

2019-02-26 Thread GitBox
sijie opened a new pull request #3690: [schema] Introduce GenericRecordBuilder and the avro implementation URL: https://github.com/apache/pulsar/pull/3690 ### Motivation Provides a mechansim to produce a generic record in programming way. ### Modifications

[pulsar] branch master updated: [schema] Introduce schema builder to build schema. (#3682)

2019-02-26 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d46474b [schema] Introduce schema builder to bui

[pulsar] branch master updated: [schema] Introduce schema builder to build schema. (#3682)

2019-02-26 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d46474b [schema] Introduce schema builder to bui

[pulsar] branch master updated: [schema] Introduce multi version generic record schema (#3670)

2019-02-26 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3c36705 [schema] Introduce multi version generic

[GitHub] sijie merged pull request #3682: [schema] Introduce schema builder to build schema.

2019-02-26 Thread GitBox
sijie merged pull request #3682: [schema] Introduce schema builder to build schema. URL: https://github.com/apache/pulsar/pull/3682 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] sijie merged pull request #3682: [schema] Introduce schema builder to build schema.

2019-02-26 Thread GitBox
sijie merged pull request #3682: [schema] Introduce schema builder to build schema. URL: https://github.com/apache/pulsar/pull/3682 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] sijie merged pull request #3670: [schema] Introduce multi version generic record schema

2019-02-26 Thread GitBox
sijie merged pull request #3670: [schema] Introduce multi version generic record schema URL: https://github.com/apache/pulsar/pull/3670 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] sijie merged pull request #3670: [schema] Introduce multi version generic record schema

2019-02-26 Thread GitBox
sijie merged pull request #3670: [schema] Introduce multi version generic record schema URL: https://github.com/apache/pulsar/pull/3670 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] sijie opened a new issue #3689: provide a *unack* mechanism to unack a message if the consumer can't process

2019-02-26 Thread GitBox
sijie opened a new issue #3689: provide a *unack* mechanism to unack a message if the consumer can't process URL: https://github.com/apache/pulsar/issues/3689 **Is your feature request related to a problem? Please describe.** currently there is no way to only unack a message if the c

[GitHub] sijie opened a new issue #3689: provide a *unack* mechanism to unack a message if the consumer can't process

2019-02-26 Thread GitBox
sijie opened a new issue #3689: provide a *unack* mechanism to unack a message if the consumer can't process URL: https://github.com/apache/pulsar/issues/3689 **Is your feature request related to a problem? Please describe.** currently there is no way to only unack a message if the c

[GitHub] massakam commented on issue #3687: [pulsar-broker] fix: npe while acking message

2019-02-26 Thread GitBox
massakam commented on issue #3687: [pulsar-broker] fix: npe while acking message URL: https://github.com/apache/pulsar/pull/3687#issuecomment-467394398 rerun java8 tests This is an automated message from the Apache Git Service

[GitHub] jiazhai commented on issue #3682: [schema] Introduce schema builder to build schema.

2019-02-26 Thread GitBox
jiazhai commented on issue #3682: [schema] Introduce schema builder to build schema. URL: https://github.com/apache/pulsar/pull/3682#issuecomment-467368596 rerun java8 tests This is an automated message from the Apache Git Se