[GitHub] [pulsar] sijie opened a new issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
sijie opened a new issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741 **Describe the bug** Currently AvroSchema makes all fields allowNull, which makes the generated schema doesn't respect what POJO defines. **Expected behavior**

[GitHub] [pulsar] sijie commented on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
sijie commented on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469155655 @codelipenghui 's team is working on this issue. This is an automated message from the A

[GitHub] [pulsar] sijie opened a new issue #3742: AvroSchema should be constructing using writer schema and reader schema

2019-03-04 Thread GitBox
sijie opened a new issue #3742: AvroSchema should be constructing using writer schema and reader schema URL: https://github.com/apache/pulsar/issues/3742 **Is your feature request related to a problem? Please describe.** Currently POJO Avro Schema is using one schema for both its wri

[GitHub] [pulsar] sijie commented on issue #3742: AvroSchema should be constructing using writer schema and reader schema

2019-03-04 Thread GitBox
sijie commented on issue #3742: AvroSchema should be constructing using writer schema and reader schema URL: https://github.com/apache/pulsar/issues/3742#issuecomment-469158073 @codelipenghui 's team is working on a fix This

[GitHub] [pulsar] jiazhai opened a new pull request #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip

2019-03-04 Thread GitBox
jiazhai opened a new pull request #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip URL: https://github.com/apache/pulsar/pull/3743 This reverts commit 231db030b9529737237721059b2a5b3044d4cab1. <-- ### Contribution Checklist - Na

[GitHub] [pulsar] jiazhai commented on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip

2019-03-04 Thread GitBox
jiazhai commented on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip URL: https://github.com/apache/pulsar/pull/3743#issuecomment-469162908 @lovelle This fix has some issue. a subscribe is identified by "sub-name" + "topic-name". Would like to re

[GitHub] [pulsar] jiazhai edited a comment on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip

2019-03-04 Thread GitBox
jiazhai edited a comment on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip URL: https://github.com/apache/pulsar/pull/3743#issuecomment-469162908 @lovelle This fix has some issue. a subscribe is identified by "sub-name" + "topic-name". Would lik

[GitHub] [pulsar] sijie commented on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip

2019-03-04 Thread GitBox
sijie commented on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip URL: https://github.com/apache/pulsar/pull/3743#issuecomment-469163185 @jiazhai can you describe more on why you revert this commit? this would give context for other reviewers to re

[GitHub] [pulsar] skyrocknroll opened a new pull request #3744: Exposing getSchemaVersion in the client by making it public.

2019-03-04 Thread GitBox
skyrocknroll opened a new pull request #3744: Exposing getSchemaVersion in the client by making it public. URL: https://github.com/apache/pulsar/pull/3744 ### Motivation Exposing getSchemaVersion in the client by making it public. ### Modifications This change is a triv

[GitHub] [pulsar] murong00 commented on issue #3726: functions cli received HTTP 404 when trying to inspect a build-in I/O connector

2019-03-04 Thread GitBox
murong00 commented on issue #3726: functions cli received HTTP 404 when trying to inspect a build-in I/O connector URL: https://github.com/apache/pulsar/issues/3726#issuecomment-469165473 @srkukarni Thanks for point it out. As the functions/sources/sinks are treated seperately, I think we

[GitHub] [pulsar] jiazhai commented on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip

2019-03-04 Thread GitBox
jiazhai commented on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip URL: https://github.com/apache/pulsar/pull/3743#issuecomment-469168574 @sijie @lovelle Here is the error that user reported: ![wechatimg427](https://user-images.githubuserconten

[GitHub] [pulsar] jiazhai commented on issue #3740: fix document description bugs

2019-03-04 Thread GitBox
jiazhai commented on issue #3740: fix document description bugs URL: https://github.com/apache/pulsar/pull/3740#issuecomment-469168889 run java8 tests This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] jerrypeng commented on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng commented on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469168842 @sijie I don't quite follow. If a class has a field "Integer" than the field shoulda allow vs if the field is "int" then it shouldn't: ```

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469168842 @sijie I don't quite follow. If a class has a field "Integer" than the field should allow null vs if the field is "int" then it shouldn't:

[GitHub] [pulsar] jiazhai edited a comment on issue #3740: fix document description bugs

2019-03-04 Thread GitBox
jiazhai edited a comment on issue #3740: fix document description bugs URL: https://github.com/apache/pulsar/pull/3740#issuecomment-469168889 run java8 tests previous errors: ``` org.apache.pulsar.broker.service.ReplicatorTest.setup org.apache.pulsar.client.api.BrokerServiceLook

[GitHub] [pulsar] murong00 opened a new pull request #3745: [Issue #3726] Modify the usage of Connector CLI for better guidance

2019-03-04 Thread GitBox
murong00 opened a new pull request #3745: [Issue #3726] Modify the usage of Connector CLI for better guidance URL: https://github.com/apache/pulsar/pull/3745 ### Motivation Fixes #3726 ### Modifications Replace `functions` by `sink`. ---

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469168842 @sijie I don't quite follow. If a class has a field "Integer" than the field should allow null vs if the field is "int" then it shouldn't:

[GitHub] [pulsar] jerrypeng commented on issue #3737: [python client] set protobuf version to be larger than 3.6.0

2019-03-04 Thread GitBox
jerrypeng commented on issue #3737: [python client] set protobuf version to be larger than 3.6.0 URL: https://github.com/apache/pulsar/pull/3737#issuecomment-469171984 rerun java8 tests This is an automated message from the A

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-469172503 rerun java8 tests rerun integration tests rerun cpp tests This

[GitHub] [pulsar] jerrypeng commented on issue #3739: [Issue #3728] Add several instructions for IO Connectors

2019-03-04 Thread GitBox
jerrypeng commented on issue #3739: [Issue #3728] Add several instructions for IO Connectors URL: https://github.com/apache/pulsar/pull/3739#issuecomment-469172751 rerun java8 tests This is an automated message from the Apach

[GitHub] [pulsar] jiazhai merged pull request #3597: [Issue 3275][pulsar-io]Support source and sink of flume

2019-03-04 Thread GitBox
jiazhai merged pull request #3597: [Issue 3275][pulsar-io]Support source and sink of flume URL: https://github.com/apache/pulsar/pull/3597 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] ambition119 removed a comment on issue #3695: Hbase Connector Integration Test

2019-03-04 Thread GitBox
ambition119 removed a comment on issue #3695: Hbase Connector Integration Test URL: https://github.com/apache/pulsar/pull/3695#issuecomment-468549164 run java8 tests run integration tests This is an automated message from t

[GitHub] [pulsar] ivankelly commented on issue #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on issue #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#issuecomment-469213721 @jiazhai added @jerrypeng as he's been making some other auth changes lately. --

[GitHub] [pulsar] sijie commented on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
sijie commented on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469215115 @jerrypeng the main problem of this is : if we are serializing POJO into avro formats, it should be respecting to how AVRO generates schema for P

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262014275 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationSer

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262022837 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/Commands.java ## @@ -168,

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262021576 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262022910 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/Commands.java ## @@ -168,

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262014806 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationSta

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262022216 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthentic

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262019836 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262023365 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/Commands.java ## @@ -150,

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262021964 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationSta

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262013804 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationPro

[GitHub] [pulsar] ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262015438 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@

[GitHub] [pulsar] ivankelly commented on a change in pull request #3698: Adjust the serving threads to have a minimum of threads

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3698: Adjust the serving threads to have a minimum of threads URL: https://github.com/apache/pulsar/pull/3698#discussion_r262023860 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java

[GitHub] [pulsar] ivankelly commented on a change in pull request #3690: [schema] Introduce GenericRecordBuilder and the avro implementation

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3690: [schema] Introduce GenericRecordBuilder and the avro implementation URL: https://github.com/apache/pulsar/pull/3690#discussion_r262027147 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/G

[GitHub] [pulsar] skyrocknroll commented on issue #3744: Exposing getSchemaVersion in the client by making it public.

2019-03-04 Thread GitBox
skyrocknroll commented on issue #3744: Exposing getSchemaVersion in the client by making it public. URL: https://github.com/apache/pulsar/pull/3744#issuecomment-469229690 run java8 tests This is an automated message from the

[GitHub] [pulsar] sijie commented on a change in pull request #3690: [schema] Introduce GenericRecordBuilder and the avro implementation

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3690: [schema] Introduce GenericRecordBuilder and the avro implementation URL: https://github.com/apache/pulsar/pull/3690#discussion_r262032547 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/Gener

[GitHub] [pulsar] sijie commented on a change in pull request #3744: Exposing getSchemaVersion in the client by making it public.

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3744: Exposing getSchemaVersion in the client by making it public. URL: https://github.com/apache/pulsar/pull/3744#discussion_r262033470 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Message.java ##

[GitHub] [pulsar] skyrocknroll commented on a change in pull request #3744: Exposing getSchemaVersion in the client by making it public.

2019-03-04 Thread GitBox
skyrocknroll commented on a change in pull request #3744: Exposing getSchemaVersion in the client by making it public. URL: https://github.com/apache/pulsar/pull/3744#discussion_r262034505 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Message.java

[GitHub] [pulsar] jiazhai commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
jiazhai commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262044892 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationServi

[GitHub] [pulsar] lovelle commented on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip

2019-03-04 Thread GitBox
lovelle commented on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip URL: https://github.com/apache/pulsar/pull/3743#issuecomment-469249106 @jiazhai @sijie Oh sorry! I apologize for this inconvenience. @jiazhai is absolutelly right about this

[GitHub] [pulsar] jiazhai commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
jiazhai commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262056866 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -4

[GitHub] [pulsar] jiazhai commented on issue #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
jiazhai commented on issue #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#issuecomment-469259050 Thanks @ivankelly , updated it again. This is an automated message fr

[GitHub] [pulsar] lovelle opened a new pull request #3746: Bugfix prevent dup consumers for same topic subscription

2019-03-04 Thread GitBox
lovelle opened a new pull request #3746: Bugfix prevent dup consumers for same topic subscription URL: https://github.com/apache/pulsar/pull/3746 Fixes #3743 issue. Return previous instance of a consumer in the subscription processed should only be considered with the scope of th

[GitHub] [pulsar] lovelle commented on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip

2019-03-04 Thread GitBox
lovelle commented on issue #3743: Revert #3312 "Prevent dup consumers on same client cnx with shared subscrip URL: https://github.com/apache/pulsar/pull/3743#issuecomment-469271552 @sijie @jiazhai #3746 should fix this issue, could you please take look? Thanks!

[GitHub] [pulsar] jiazhai commented on a change in pull request #3677: PIP-30: interface and mutual change authentication

2019-03-04 Thread GitBox
jiazhai commented on a change in pull request #3677: PIP-30: interface and mutual change authentication URL: https://github.com/apache/pulsar/pull/3677#discussion_r262056866 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -4

[GitHub] [pulsar] ivankelly commented on a change in pull request #3690: [schema] Introduce GenericRecordBuilder and the avro implementation

2019-03-04 Thread GitBox
ivankelly commented on a change in pull request #3690: [schema] Introduce GenericRecordBuilder and the avro implementation URL: https://github.com/apache/pulsar/pull/3690#discussion_r262109792 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/generic/G

[GitHub] [pulsar] sijie opened a new pull request #3747: Closing FunctionAssignmentTailer should handle ConsumerAlreadyClosedException

2019-03-04 Thread GitBox
sijie opened a new pull request #3747: Closing FunctionAssignmentTailer should handle ConsumerAlreadyClosedException URL: https://github.com/apache/pulsar/pull/3747 *Motivation* Currently when FunctionAssignmentTailer throws RuntimeException when received exception when tailing th

[GitHub] [pulsar] sijie commented on issue #3744: Exposing getSchemaVersion in the client by making it public.

2019-03-04 Thread GitBox
sijie commented on issue #3744: Exposing getSchemaVersion in the client by making it public. URL: https://github.com/apache/pulsar/pull/3744#issuecomment-469314091 run java8 tests This is an automated message from the Apache

[GitHub] [pulsar] sijie commented on issue #3740: fix document description bugs

2019-03-04 Thread GitBox
sijie commented on issue #3740: fix document description bugs URL: https://github.com/apache/pulsar/pull/3740#issuecomment-469314779 run java8 tests This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] sijie commented on issue #3739: [Issue #3728] Add several instructions for IO Connectors

2019-03-04 Thread GitBox
sijie commented on issue #3739: [Issue #3728] Add several instructions for IO Connectors URL: https://github.com/apache/pulsar/pull/3739#issuecomment-469315289 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262136762 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthProvider.java

[GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262137147 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthProvider.java

[GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262141443 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java ##

[GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262140317 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntimeFactor

[GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262139874 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/NoOpFunctionAuthProvider.j

[GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262141898 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java ##

[GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262136164 ## File path: pulsar-functions/proto/src/main/proto/Function.proto ## @@ -141,6 +141,11 @@ message Func

[GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262142832 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java

[GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262138975 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthProvider.java

[GitHub] [pulsar] sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262141940 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java ##

[GitHub] [pulsar] sijie commented on a change in pull request #3722: Retry creation of assignment topic a few times before giving up

2019-03-04 Thread GitBox
sijie commented on a change in pull request #3722: Retry creation of assignment topic a few times before giving up URL: https://github.com/apache/pulsar/pull/3722#discussion_r262144333 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerM

[GitHub] [pulsar] sijie commented on issue #3721: Report direct memory used in Proxy to prometheus

2019-03-04 Thread GitBox
sijie commented on issue #3721: Report direct memory used in Proxy to prometheus URL: https://github.com/apache/pulsar/pull/3721#issuecomment-469323418 run java8 tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar] sijie commented on issue #3718: In Java allow messages that compress to <5mb to be sent with batching enabled

2019-03-04 Thread GitBox
sijie commented on issue #3718: In Java allow messages that compress to <5mb to be sent with batching enabled URL: https://github.com/apache/pulsar/pull/3718#issuecomment-469323757 run java8 tests This is an automated message

[GitHub] [pulsar] sijie commented on issue #3717: Expose Secrets in Source/SinkContext

2019-03-04 Thread GitBox
sijie commented on issue #3717: Expose Secrets in Source/SinkContext URL: https://github.com/apache/pulsar/pull/3717#issuecomment-469323952 retest this please This is an automated message from the Apache Git Service. To respon

[GitHub] [pulsar] sijie commented on issue #3714: [Issue #3712][python-client] exposing InitialPosition management in the ConsumerConfiguration.

2019-03-04 Thread GitBox
sijie commented on issue #3714: [Issue #3712][python-client] exposing InitialPosition management in the ConsumerConfiguration. URL: https://github.com/apache/pulsar/pull/3714#issuecomment-469324114 run java8 tests This is an

[GitHub] [pulsar] sijie commented on issue #3711: Update README.md with IDE setup for lombok

2019-03-04 Thread GitBox
sijie commented on issue #3711: Update README.md with IDE setup for lombok URL: https://github.com/apache/pulsar/pull/3711#issuecomment-469324359 run java8 tests This is an automated message from the Apache Git Service. To res

[GitHub] [pulsar] sijie commented on issue #3697: add cli client consumer for standalone

2019-03-04 Thread GitBox
sijie commented on issue #3697: add cli client consumer for standalone URL: https://github.com/apache/pulsar/pull/3697#issuecomment-469325498 run integration tests This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar] sijie commented on issue #3696: fix elasticsearch in pom Consistent with other IOs

2019-03-04 Thread GitBox
sijie commented on issue #3696: fix elasticsearch in pom Consistent with other IOs URL: https://github.com/apache/pulsar/pull/3696#issuecomment-469325698 run java8 tests This is an automated message from the Apache Git Servic

[GitHub] [pulsar] sijie commented on issue #3690: [schema] Introduce GenericRecordBuilder and the avro implementation

2019-03-04 Thread GitBox
sijie commented on issue #3690: [schema] Introduce GenericRecordBuilder and the avro implementation URL: https://github.com/apache/pulsar/pull/3690#issuecomment-469326051 run java8 tests This is an automated message from the

[GitHub] [pulsar] lovelle opened a new pull request #3748: [cpp client] Bugfix prevent dup consumer for same topic subscription

2019-03-04 Thread GitBox
lovelle opened a new pull request #3748: [cpp client] Bugfix prevent dup consumer for same topic subscription URL: https://github.com/apache/pulsar/pull/3748 Same fix as #3746 but for cpp client. ### Modifications - Filter consumers for the same topic name. - Add test t

[GitHub] [pulsar] merlimat commented on issue #3703: Added support for "negative acks" in Java client

2019-03-04 Thread GitBox
merlimat commented on issue #3703: Added support for "negative acks" in Java client URL: https://github.com/apache/pulsar/pull/3703#issuecomment-469340610 run java8 tests This is an automated message from the Apache Git Servi

[GitHub] [pulsar] jerrypeng commented on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng commented on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469351952 @sijie I don't understand why you say we are not respecting the rules of AVRO, we are using the official java AVRO library to schema generation. And

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469351952 @sijie I don't understand why you say we are not respecting the rules of AVRO, we are using the official java AVRO library to schema generatio

[pulsar] branch retry_creation updated: Use Action based retry mechanism

2019-03-04 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch retry_creation in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/retry_creation by this push: new 8092542 Use Action based ret

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262182960 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthProvider.j

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262182997 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthProvider.j

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262183601 ## File path: pulsar-functions/proto/src/main/proto/Function.proto ## @@ -141,6 +141,11 @@ message

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262186151 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/auth/FunctionAuthProvider.j

[pulsar] branch retry_creation updated: Fix build

2019-03-04 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch retry_creation in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/retry_creation by this push: new 5d5d13c Fix build 5d5d13c is

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262187660 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java

[pulsar] branch retry_creation updated: Catch interrupted exception

2019-03-04 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch retry_creation in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/retry_creation by this push: new 2654b10 Catch interrupted ex

[GitHub] [pulsar] srkukarni commented on a change in pull request #3722: Retry creation of assignment topic a few times before giving up

2019-03-04 Thread GitBox
srkukarni commented on a change in pull request #3722: Retry creation of assignment topic a few times before giving up URL: https://github.com/apache/pulsar/pull/3722#discussion_r262190045 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Schedu

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262191642 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntimeFa

[GitHub] [pulsar] jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on a change in pull request #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#discussion_r262192649 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.j

[pulsar] branch retry_creation updated: Fix unittest

2019-03-04 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch retry_creation in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/retry_creation by this push: new f62c945 Fix unittest f62c945

[GitHub] [pulsar] merlimat merged pull request #3711: Update README.md with IDE setup for lombok

2019-03-04 Thread GitBox
merlimat merged pull request #3711: Update README.md with IDE setup for lombok URL: https://github.com/apache/pulsar/pull/3711 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] merlimat merged pull request #3697: add cli client consumer for standalone

2019-03-04 Thread GitBox
merlimat merged pull request #3697: add cli client consumer for standalone URL: https://github.com/apache/pulsar/pull/3697 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[pulsar] branch master updated: add cli client consumer for standalone (#3697)

2019-03-04 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e06a894 add cli client consumer for standalone

[pulsar] branch master updated: Update README.md with IDE setup for lombok (#3711)

2019-03-04 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d84b687 Update README.md with IDE setup for lom

[GitHub] [pulsar] merlimat merged pull request #3744: Exposing getSchemaVersion in the client by making it public.

2019-03-04 Thread GitBox
merlimat merged pull request #3744: Exposing getSchemaVersion in the client by making it public. URL: https://github.com/apache/pulsar/pull/3744 This is an automated message from the Apache Git Service. To respond to the mes

[pulsar] branch master updated: Exposing getSchemaVersion in the client by making it public. (#3744)

2019-03-04 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d847c35 Exposing getSchemaVersion in the client

[GitHub] [pulsar] lovelle commented on issue #3748: [cpp client] Bugfix prevent dup consumer for same topic subscription

2019-03-04 Thread GitBox
lovelle commented on issue #3748: [cpp client] Bugfix prevent dup consumer for same topic subscription URL: https://github.com/apache/pulsar/pull/3748#issuecomment-469389590 run java8 tests This is an automated message from t

[pulsar] branch retry_creation updated: Added header

2019-03-04 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch retry_creation in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/retry_creation by this push: new bbfb1cb Added header bbfb1cb

[GitHub] [pulsar] srkukarni commented on issue #3698: Adjust the serving threads to have a minimum of threads

2019-03-04 Thread GitBox
srkukarni commented on issue #3698: Adjust the serving threads to have a minimum of threads URL: https://github.com/apache/pulsar/pull/3698#issuecomment-469395359 run java8 tests run integration tests This is an automated

[GitHub] [pulsar] srkukarni commented on issue #3704: On publish failures, log error and count them as sys exceptions

2019-03-04 Thread GitBox
srkukarni commented on issue #3704: On publish failures, log error and count them as sys exceptions URL: https://github.com/apache/pulsar/pull/3704#issuecomment-469395190 run java8 tests run integration tests This is an au

[GitHub] [pulsar] merlimat opened a new pull request #3749: On shutdown, kill the function instance thread after interrupt attempt

2019-03-04 Thread GitBox
merlimat opened a new pull request #3749: On shutdown, kill the function instance thread after interrupt attempt URL: https://github.com/apache/pulsar/pull/3749 ### Motivation In thread runtime worker shutdown, the thread might not be responding to an interrupt request. We should at

[GitHub] [pulsar] merlimat commented on issue #3747: Closing FunctionAssignmentTailer should handle ConsumerAlreadyClosedException

2019-03-04 Thread GitBox
merlimat commented on issue #3747: Closing FunctionAssignmentTailer should handle ConsumerAlreadyClosedException URL: https://github.com/apache/pulsar/pull/3747#issuecomment-469396430 @sijie I think the shutdown timeout is still happening in this PR. should be fixed in https://github.com/a

  1   2   3   >