[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276113655 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] Xlingxiao commented on issue #4049: Cant use the Admin Rest API

2019-04-17 Thread GitBox
Xlingxiao commented on issue #4049: Cant use the Admin Rest API URL: https://github.com/apache/pulsar/issues/4049#issuecomment-483992196 > @Xlingxiao > > ``` > create > curl -v -H 'Content-type':'application/json' -X PUT -d "4" http://localhost:8080/admin/v2/persistent/lx/java/

[GitHub] [pulsar] Xlingxiao closed issue #4049: Cant use the Admin Rest API

2019-04-17 Thread GitBox
Xlingxiao closed issue #4049: Cant use the Admin Rest API URL: https://github.com/apache/pulsar/issues/4049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] sijie commented on a change in pull request #4063: [pulsar-common] MaxMessageSize to user configuration

2019-04-17 Thread GitBox
sijie commented on a change in pull request #4063: [pulsar-common] MaxMessageSize to user configuration URL: https://github.com/apache/pulsar/pull/4063#discussion_r276135792 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/PulsarDecoder.java ## @@ -6

[GitHub] [pulsar] massakam opened a new pull request #4064: [client] Set actual topic name to partitioned consumer

2019-04-17 Thread GitBox
massakam opened a new pull request #4064: [client] Set actual topic name to partitioned consumer URL: https://github.com/apache/pulsar/pull/4064 ### Motivation When I got "proxy stats" from our WebSocket proxy, it contained a large number of entries as follows: ```sh $ cur

[GitHub] [pulsar] merlimat commented on a change in pull request #4063: [pulsar-common] MaxMessageSize to user configuration

2019-04-17 Thread GitBox
merlimat commented on a change in pull request #4063: [pulsar-common] MaxMessageSize to user configuration URL: https://github.com/apache/pulsar/pull/4063#discussion_r276206010 ## File path: pulsar-common/src/test/java/org/apache/pulsar/common/api/PulsarDecoderTest.java ##

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276206700 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(c

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276206700 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(c

[GitHub] [pulsar] merlimat commented on a change in pull request #4064: [client] Set actual topic name to partitioned consumer

2019-04-17 Thread GitBox
merlimat commented on a change in pull request #4064: [client] Set actual topic name to partitioned consumer URL: https://github.com/apache/pulsar/pull/4064#discussion_r276208227 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java #

[GitHub] [pulsar] massakam commented on a change in pull request #4064: [client] Set actual topic name to partitioned consumer

2019-04-17 Thread GitBox
massakam commented on a change in pull request #4064: [client] Set actual topic name to partitioned consumer URL: https://github.com/apache/pulsar/pull/4064#discussion_r276215196 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java #

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276216671 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct

[GitHub] [pulsar] merlimat commented on a change in pull request #4064: [client] Set actual topic name to partitioned consumer

2019-04-17 Thread GitBox
merlimat commented on a change in pull request #4064: [client] Set actual topic name to partitioned consumer URL: https://github.com/apache/pulsar/pull/4064#discussion_r276219377 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java #

[GitHub] [pulsar] merlimat commented on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
merlimat commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484069171 > I have looked into the pull request. This is actually a simpler implementation of PIP-26. Is that a bad thing? Is there any limitation i

[GitHub] [pulsar] merlimat commented on a change in pull request #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects

2019-04-17 Thread GitBox
merlimat commented on a change in pull request #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects URL: https://github.com/apache/pulsar/pull/4059#discussion_r276223329 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integrati

[GitHub] [pulsar] massakam commented on a change in pull request #4064: [client] Set actual topic name to partitioned consumer

2019-04-17 Thread GitBox
massakam commented on a change in pull request #4064: [client] Set actual topic name to partitioned consumer URL: https://github.com/apache/pulsar/pull/4064#discussion_r276225629 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java #

[GitHub] [pulsar] merlimat commented on a change in pull request #4064: [client] Set actual topic name to partitioned consumer

2019-04-17 Thread GitBox
merlimat commented on a change in pull request #4064: [client] Set actual topic name to partitioned consumer URL: https://github.com/apache/pulsar/pull/4064#discussion_r276226920 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java #

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276226983 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(c

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276226983 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(c

[GitHub] [pulsar] joefk commented on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
joefk commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484105300 >The changes to the dispatcher itself have been isolated in a very few specific points. It should be easy to review and verify that with feature tu

[GitHub] [pulsar] joefk edited a comment on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
joefk edited a comment on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484105300 >The changes to the dispatcher itself have been isolated in a very few specific points. It should be easy to review and verify that with feat

[GitHub] [pulsar] joefk edited a comment on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
joefk edited a comment on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484105300 >The changes to the dispatcher itself have been isolated in a very few specific points. It should be easy to review and verify that with feat

[GitHub] [pulsar] lovelle commented on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
lovelle commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484107066 > Is that a bad thing? Is there any limitation in this approach? To me this is one of the best things about this pull, and absolutely not a

[GitHub] [pulsar] joefk edited a comment on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
joefk edited a comment on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484105300 >The changes to the dispatcher itself have been isolated in a very few specific points. It should be easy to review and verify that with feat

[GitHub] [pulsar] massakam commented on issue #4064: [client] Set actual topic name to partitioned consumer

2019-04-17 Thread GitBox
massakam commented on issue #4064: [client] Set actual topic name to partitioned consumer URL: https://github.com/apache/pulsar/pull/4064#issuecomment-484128032 rerun java8 tests This is an automated message from the Apache G

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276226983 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(c

[GitHub] [pulsar] merlimat commented on issue #3597: [Issue 3275][pulsar-io]Support source and sink of flume

2019-04-17 Thread GitBox
merlimat commented on issue #3597: [Issue 3275][pulsar-io]Support source and sink of flume URL: https://github.com/apache/pulsar/pull/3597#issuecomment-484158992 @tuteng I've seen a failure in the tests for this connector. ``` Standard Output Created annotation listener 14:

[GitHub] [pulsar] merlimat commented on issue #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects

2019-04-17 Thread GitBox
merlimat commented on issue #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects URL: https://github.com/apache/pulsar/pull/4059#issuecomment-484162027 run java8 tests This is an automated mes

[GitHub] [pulsar] merlimat opened a new pull request #4065: Fixed regex for Pulsar version correction

2019-04-17 Thread GitBox
merlimat opened a new pull request #4065: Fixed regex for Pulsar version correction URL: https://github.com/apache/pulsar/pull/4065 ### Motivation There's a method that is correcting the version to make sure it complies with SemVer (eg: has 1.2.3 format and not just 1.2). The regex

[GitHub] [pulsar] massakam commented on issue #4064: [client] Set actual topic name to partitioned consumer

2019-04-17 Thread GitBox
massakam commented on issue #4064: [client] Set actual topic name to partitioned consumer URL: https://github.com/apache/pulsar/pull/4064#issuecomment-484178802 rerun java8 tests This is an automated message from the Apache G

[GitHub] [pulsar] merlimat opened a new pull request #4066: Allow to configure the managed ledger cache eviction frequency

2019-04-17 Thread GitBox
merlimat opened a new pull request #4066: Allow to configure the managed ledger cache eviction frequency URL: https://github.com/apache/pulsar/pull/4066 ### Motivation Currently there's a rate limiter that avoid evicting from cache each time the read position is updated but rather o

[GitHub] [pulsar] sijie commented on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
sijie commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484199134 > Is that a bad thing? Is there any limitation in this approach? > The changes to the dispatcher itself have been isolated in a very few

[GitHub] [pulsar] sijie edited a comment on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
sijie edited a comment on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484199134 > Is that a bad thing? Is there any limitation in this approach? > The changes to the dispatcher itself have been isolated in a very fe

[GitHub] [pulsar] sijie edited a comment on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
sijie edited a comment on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484199134 > Is that a bad thing? Is there any limitation in this approach? It is not a bad thing. I am actually super happy to see this happe

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276370232 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276370232 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] merlimat commented on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
merlimat commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484235391 > DelayedDeliveryTracker and DelayedMessageIndex are just two different implementations of one same things. If the current implementation of Del

[GitHub] [pulsar] merlimat removed a comment on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
merlimat removed a comment on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484235391 > DelayedDeliveryTracker and DelayedMessageIndex are just two different implementations of one same things. If the current implementatio

[GitHub] [pulsar] merlimat commented on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
merlimat commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484240339 > DelayedDeliveryTracker and DelayedMessageIndex are just two different implementations of one same things. If the current implementation of Del

[GitHub] [pulsar] jerrypeng commented on issue #4058: improve data-generator source performance

2019-04-17 Thread GitBox
jerrypeng commented on issue #4058: improve data-generator source performance URL: https://github.com/apache/pulsar/pull/4058#issuecomment-484254844 rerun java8 tests This is an automated message from the Apache Git Se

[GitHub] [pulsar] devinbost closed issue #4021: Pulsar-admin commands do not support parallelization

2019-04-17 Thread GitBox
devinbost closed issue #4021: Pulsar-admin commands do not support parallelization URL: https://github.com/apache/pulsar/issues/4021 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] jerrypeng opened a new pull request #4067: Fix connectors nested configs

2019-04-17 Thread GitBox
jerrypeng opened a new pull request #4067: Fix connectors nested configs URL: https://github.com/apache/pulsar/pull/4067 ### Motivation Updating a source or sink with configs that have nested structures with cause client error: ``` org.apache.pulsar.client.admin.Pu

[GitHub] [pulsar] jerrypeng commented on issue #4067: Fix connectors nested configs

2019-04-17 Thread GitBox
jerrypeng commented on issue #4067: Fix connectors nested configs URL: https://github.com/apache/pulsar/pull/4067#issuecomment-484273433 @devinbost please also have look This is an automated message from the Apache Git Service

[GitHub] [pulsar] merlimat merged pull request #4064: [client] Set actual topic name to partitioned consumer

2019-04-17 Thread GitBox
merlimat merged pull request #4064: [client] Set actual topic name to partitioned consumer URL: https://github.com/apache/pulsar/pull/4064 This is an automated message from the Apache Git Service. To respond to the message,

[pulsar] branch master updated: [client] Set actual topic name to partitioned consumer (#4064)

2019-04-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new bc24013 [client] Set actual topic name to parti

[GitHub] [pulsar] jerrypeng commented on issue #4058: improve data-generator source performance

2019-04-17 Thread GitBox
jerrypeng commented on issue #4058: improve data-generator source performance URL: https://github.com/apache/pulsar/pull/4058#issuecomment-484285841 rerun java8 tests This is an automated message from the Apache Git Service. T

[GitHub] [pulsar] jerrypeng commented on issue #4065: Fixed regex for Pulsar version correction

2019-04-17 Thread GitBox
jerrypeng commented on issue #4065: Fixed regex for Pulsar version correction URL: https://github.com/apache/pulsar/pull/4065#issuecomment-484286142 rerun java8 tests This is an automated message from the Apache Git Service. T

[pulsar] branch master updated: Fix connectors nested configs (#4067)

2019-04-17 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new eacd108 Fix connectors nested configs (#4067

[GitHub] [pulsar] jerrypeng merged pull request #4067: Fix connectors nested configs

2019-04-17 Thread GitBox
jerrypeng merged pull request #4067: Fix connectors nested configs URL: https://github.com/apache/pulsar/pull/4067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [pulsar] rdhabalia opened a new pull request #4068: [pulsar-function] fix worker-stats broken admin-api

2019-04-17 Thread GitBox
rdhabalia opened a new pull request #4068: [pulsar-function] fix worker-stats broken admin-api URL: https://github.com/apache/pulsar/pull/4068 ### Motivation Start broker and function-worker in separate process. function-worker is not serving `worker-stats` resources which gives 404 htt

[pulsar] branch master updated: Fix update cli source sink (#4061)

2019-04-17 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a8cd98c Fix update cli source sink (#4061) a

[GitHub] [pulsar] jerrypeng merged pull request #4061: Fix update cli source sink

2019-04-17 Thread GitBox
jerrypeng merged pull request #4061: Fix update cli source sink URL: https://github.com/apache/pulsar/pull/4061 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] sijie commented on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
sijie commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484329137 @merlimat : great! These comments around API and protocol changes are great if it can be done when PIP-26 was sent out. A `DelayedDeliveryTracker`

[GitHub] [pulsar] jerrypeng commented on issue #4058: improve data-generator source performance

2019-04-17 Thread GitBox
jerrypeng commented on issue #4058: improve data-generator source performance URL: https://github.com/apache/pulsar/pull/4058#issuecomment-484329310 rerun java8 tests This is an automated message from the Apache Git Service. T

[GitHub] [pulsar] sijie commented on issue #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
sijie commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484329644 Also can you provide a namespace policy to enable and disable this feature per namespace as what PIP-26 proposed? It doesn't have to be in this PR,

[GitHub] [pulsar] sijie commented on a change in pull request #4062: Delayed message delivery implementation

2019-04-17 Thread GitBox
sijie commented on a change in pull request #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#discussion_r276497213 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -111,7 +111,10 @@ message MessageMetadata {

[GitHub] [pulsar] jerrypeng opened a new pull request #4069: Fix: Exception when switch cluster from auth enabled to auth disabled

2019-04-17 Thread GitBox
jerrypeng opened a new pull request #4069: Fix: Exception when switch cluster from auth enabled to auth disabled URL: https://github.com/apache/pulsar/pull/4069 ### Motivation When switching between authentication enabled and disabled, NPE could happen. -

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276512005 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struc

[GitHub] [pulsar] wolfstudy edited a comment on issue #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy edited a comment on issue #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#issuecomment-484349207 @sijie @merlimat PTAL again This is an automated message fro

[GitHub] [pulsar] wolfstudy commented on issue #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on issue #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#issuecomment-484349207 @sijie @merlimat PTAL This is an automated message from the Apache

[GitHub] [pulsar] wolfstudy edited a comment on issue #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy edited a comment on issue #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#issuecomment-484349207 add properties for `SchemaInfo`. @sijie @merlimat PTAL again

[GitHub] [pulsar] heronr opened a new issue #4070: [pulsar-client-cpp] Deadlock when closing the pulsar Client

2019-04-17 Thread GitBox
heronr opened a new issue #4070: [pulsar-client-cpp] Deadlock when closing the pulsar Client URL: https://github.com/apache/pulsar/issues/4070 **Describe the bug** There is a consistent deadlock when closing an instance of pulsar::Client if there is an active Consumer subscription. This

[pulsar] branch master updated: Fixed regex for Pulsar version correction (#4065)

2019-04-17 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d25dc2f Fixed regex for Pulsar version correctio

[GitHub] [pulsar] sijie merged pull request #4065: Fixed regex for Pulsar version correction

2019-04-17 Thread GitBox
sijie merged pull request #4065: Fixed regex for Pulsar version correction URL: https://github.com/apache/pulsar/pull/4065 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] sijie commented on issue #4031: Feature - support seek() on Reader

2019-04-17 Thread GitBox
sijie commented on issue #4031: Feature - support seek() on Reader URL: https://github.com/apache/pulsar/pull/4031#issuecomment-484361697 @jai1 can you please take a look again? This is an automated message from the Apache Git

[pulsar] branch master updated: improve data-generator source performance (#4058)

2019-04-17 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b50e0eb improve data-generator source performanc

[GitHub] [pulsar] sijie merged pull request #4058: improve data-generator source performance

2019-04-17 Thread GitBox
sijie merged pull request #4058: improve data-generator source performance URL: https://github.com/apache/pulsar/pull/4058 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] heronr opened a new pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows

2019-04-17 Thread GitBox
heronr opened a new pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows URL: https://github.com/apache/pulsar/pull/4071 Fixes #2461 ### Motivation My motivation was to be able to use the pulsar cpp client on

[GitHub] [pulsar] codelipenghui commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery

2019-04-17 Thread GitBox
codelipenghui commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#discussion_r276524062 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java

[GitHub] [pulsar] codelipenghui commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery

2019-04-17 Thread GitBox
codelipenghui commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#discussion_r276524062 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java

[GitHub] [pulsar] codelipenghui commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery

2019-04-17 Thread GitBox
codelipenghui commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#discussion_r276524062 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java

[GitHub] [pulsar] codelipenghui commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery

2019-04-17 Thread GitBox
codelipenghui commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#discussion_r276524062 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java

[GitHub] [pulsar] codelipenghui commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery

2019-04-17 Thread GitBox
codelipenghui commented on a change in pull request #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#discussion_r276524062 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java

[GitHub] [pulsar] jerrypeng opened a new issue #4072: Exception in bookie when Function state enabled

2019-04-17 Thread GitBox
jerrypeng opened a new issue #4072: Exception in bookie when Function state enabled URL: https://github.com/apache/pulsar/issues/4072 **Describe the bug** These exception are thrown in bookies when function state is enabled. Seems like there is something wrong with table service

[GitHub] [pulsar] jerrypeng commented on issue #4072: Exception in bookie when Function state enabled

2019-04-17 Thread GitBox
jerrypeng commented on issue #4072: Exception in bookie when Function state enabled URL: https://github.com/apache/pulsar/issues/4072#issuecomment-484367571 [bookie.logs.zip](https://github.com/apache/pulsar/files/3092955/bookie.logs.zip) Full bookie logs --

[GitHub] [pulsar] jerrypeng commented on issue #4072: Exception in bookie when Function state enabled

2019-04-17 Thread GitBox
jerrypeng commented on issue #4072: Exception in bookie when Function state enabled URL: https://github.com/apache/pulsar/issues/4072#issuecomment-484369361 Seems like this is fixed by: This is fixed by https://github.com/apache/bookkeeper/pull/2022 need to wait for a BK 4.9.2 rel

[pulsar] branch master updated: Fix: Exception when switch cluster from auth enabled to auth disabled (#4069)

2019-04-17 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6a2db62 Fix: Exception when switch cluster f

[GitHub] [pulsar] jerrypeng merged pull request #4069: Fix: Exception when switch cluster from auth enabled to auth disabled

2019-04-17 Thread GitBox
jerrypeng merged pull request #4069: Fix: Exception when switch cluster from auth enabled to auth disabled URL: https://github.com/apache/pulsar/pull/4069 This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] jerrypeng commented on issue #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects

2019-04-17 Thread GitBox
jerrypeng commented on issue #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects URL: https://github.com/apache/pulsar/pull/4059#issuecomment-484370595 rerun java8 tests This is an automated

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276523508 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,504 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276523569 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,504 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276522865 ## File path: pulsar-client-go/pulsar/c_producer.go ## @@ -212,10 +237,22 @@ func pulsarProducerSendC

[GitHub] [pulsar] jiazhai commented on a change in pull request #3915: [PIP28][PROXY] Pulsar Proxy Gateway Improvement

2019-04-17 Thread GitBox
jiazhai commented on a change in pull request #3915: [PIP28][PROXY] Pulsar Proxy Gateway Improvement URL: https://github.com/apache/pulsar/pull/3915#discussion_r276532568 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ParserProxyHandler.java ## @

[GitHub] [pulsar] jiazhai opened a new issue #4073: Add Document for jdbc sink connector

2019-04-17 Thread GitBox
jiazhai opened a new issue #4073: Add Document for jdbc sink connector URL: https://github.com/apache/pulsar/issues/4073 Add Document for jdbc sink connector This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar] jiazhai opened a new issue #4074: update debezium connector documentation

2019-04-17 Thread GitBox
jiazhai opened a new issue #4074: update debezium connector documentation URL: https://github.com/apache/pulsar/issues/4074 After move it out of Kafka-connect-source, debezium connector documentation need some update. May need provide doc for mysql and postgres connector --

[GitHub] [pulsar] jiazhai opened a new issue #4075: Debezium postgres connector will hang when create snap

2019-04-17 Thread GitBox
jiazhai opened a new issue #4075: Debezium postgres connector will hang when create snap URL: https://github.com/apache/pulsar/issues/4075 **Describe the bug** Debezium postgres connector will first create a snap for current table. And this step will hang if the table is too big.