[GitHub] [pulsar] codelipenghui commented on issue #4079: PIP-34 Key_Shared subscription core implementation.

2019-04-20 Thread GitBox
codelipenghui commented on issue #4079: PIP-34 Key_Shared subscription core implementation. URL: https://github.com/apache/pulsar/pull/4079#issuecomment-485206863 run java8 tests run cpp tests This is an automated message

[GitHub] [pulsar] jerrypeng merged pull request #4081: For functions metrics in prometheus also remove TYPE

2019-04-20 Thread GitBox
jerrypeng merged pull request #4081: For functions metrics in prometheus also remove TYPE URL: https://github.com/apache/pulsar/pull/4081 This is an automated message from the Apache Git Service. To respond to the message, p

[pulsar] branch master updated: For functions metrics in prometheus also remove TYPE (#4081)

2019-04-20 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7b2bf95 For functions metrics in prometheus

[GitHub] [pulsar] ConcurrencyPractitioner commented on issue #3217: Auto scaling up and down number of partitions

2019-04-20 Thread GitBox
ConcurrencyPractitioner commented on issue #3217: Auto scaling up and down number of partitions URL: https://github.com/apache/pulsar/issues/3217#issuecomment-485203073 Oh sorry, found the answer. Will be editing the doc within a few days. :) --

[GitHub] [pulsar] jerrypeng edited a comment on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
jerrypeng edited a comment on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485191485 @sijie adding another support for ```MessageBuilder process(I input, Context context);``` will likely involve adding another function in

[GitHub] [pulsar] jerrypeng edited a comment on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
jerrypeng edited a comment on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485191485 @sijie adding another support for ```MessageBuilder process(I input, Context context);``` will likely involve adding another function in

[GitHub] [pulsar] jerrypeng commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
jerrypeng commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485191485 @sijie adding another support for ```MessageBuilder process(I input, Context context);``` will likely involve adding another function interface

[GitHub] [pulsar] jerrypeng edited a comment on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
jerrypeng edited a comment on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485191485 @sijie adding another support for ```MessageBuilder process(I input, Context context);``` will likely involve adding another function in

[GitHub] [pulsar] jerrypeng commented on issue #4081: For functions metrics in prometheus also remove TYPE

2019-04-20 Thread GitBox
jerrypeng commented on issue #4081: For functions metrics in prometheus also remove TYPE URL: https://github.com/apache/pulsar/pull/4081#issuecomment-485186956 rerun java8 tests This is an automated message from the A

[GitHub] [pulsar] merlimat commented on issue #4046: [pulsar-io] [doc] Add docs for Redis sink

2019-04-20 Thread GitBox
merlimat commented on issue #4046: [pulsar-io] [doc] Add docs for Redis sink URL: https://github.com/apache/pulsar/pull/4046#issuecomment-485164403 run java8 tests run cpp tests This is an automated message from the Apache

[GitHub] [pulsar] merlimat commented on issue #4083: [pulsar-proxy]Add the LookupProxyHandler handle getSchema request and test

2019-04-20 Thread GitBox
merlimat commented on issue #4083: [pulsar-proxy]Add the LookupProxyHandler handle getSchema request and test URL: https://github.com/apache/pulsar/pull/4083#issuecomment-485164307 run java8 tests This is an automated message

[GitHub] [pulsar] merlimat commented on issue #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects

2019-04-20 Thread GitBox
merlimat commented on issue #4059: Ensure Pulsar HTTP proxy carries over Authorization header after 307 redirects URL: https://github.com/apache/pulsar/pull/4059#issuecomment-485164357 run java8 tests This is an automated mes

[GitHub] [pulsar] merlimat commented on issue #4084: [c++][pulsar-client-cpp] Protect against double joining the worker thread in ExecutorService::close()

2019-04-20 Thread GitBox
merlimat commented on issue #4084: [c++][pulsar-client-cpp] Protect against double joining the worker thread in ExecutorService::close() URL: https://github.com/apache/pulsar/pull/4084#issuecomment-485164254 run java8 tests T

[pulsar] branch master updated: Fix: set receive queue size for sinks (#4091)

2019-04-20 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 84a4141 Fix: set receive queue size for sinks (

[GitHub] [pulsar] merlimat merged pull request #4091: Fix: set receive queue size for sinks

2019-04-20 Thread GitBox
merlimat merged pull request #4091: Fix: set receive queue size for sinks URL: https://github.com/apache/pulsar/pull/4091 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] lovelle removed a comment on issue #3962: Feature / Interceptor for negative ack redelivery

2019-04-20 Thread GitBox
lovelle removed a comment on issue #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#issuecomment-485133456 run java8 tests This is an automated message from the Apache G

[GitHub] [pulsar] lovelle commented on issue #3962: Feature / Interceptor for negative ack redelivery

2019-04-20 Thread GitBox
lovelle commented on issue #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#issuecomment-485149966 run java8 tests This is an automated message from the Apache Git Servi

[GitHub] [pulsar] jerrypeng commented on issue #4091: Fix: set receive queue size for sinks

2019-04-20 Thread GitBox
jerrypeng commented on issue #4091: Fix: set receive queue size for sinks URL: https://github.com/apache/pulsar/pull/4091#issuecomment-485149683 rerun java8 tests This is an automated message from the Apache Git Service. To re

[pulsar] branch master updated: Optimizing performance for Pulsar function archive download (#4082)

2019-04-20 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c3e8a33 Optimizing performance for Pulsar funct

[GitHub] [pulsar] merlimat merged pull request #4082: Optimizing performance for Pulsar function archive download

2019-04-20 Thread GitBox
merlimat merged pull request #4082: Optimizing performance for Pulsar function archive download URL: https://github.com/apache/pulsar/pull/4082 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] lovelle commented on issue #3962: Feature / Interceptor for negative ack redelivery

2019-04-20 Thread GitBox
lovelle commented on issue #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#issuecomment-485141788 run java8 tests This is an automated message from the Apache Git Servi

[GitHub] [pulsar] lovelle removed a comment on issue #3962: Feature / Interceptor for negative ack redelivery

2019-04-20 Thread GitBox
lovelle removed a comment on issue #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#issuecomment-485054225 run java8 tests This is an automated message from the Apache G

[GitHub] [pulsar] lovelle commented on issue #3962: Feature / Interceptor for negative ack redelivery

2019-04-20 Thread GitBox
lovelle commented on issue #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#issuecomment-485133456 run java8 tests This is an automated message from the Apache Git Servi

[GitHub] [pulsar] lovelle removed a comment on issue #3962: Feature / Interceptor for negative ack redelivery

2019-04-20 Thread GitBox
lovelle removed a comment on issue #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#issuecomment-485115237 run java8 tests This is an automated message from the Apache G

[GitHub] [pulsar] lovelle commented on issue #3962: Feature / Interceptor for negative ack redelivery

2019-04-20 Thread GitBox
lovelle commented on issue #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#issuecomment-485115237 run java8 tests This is an automated message from the Apache Git Servi

[GitHub] [pulsar] lovelle removed a comment on issue #3962: Feature / Interceptor for negative ack redelivery

2019-04-20 Thread GitBox
lovelle removed a comment on issue #3962: Feature / Interceptor for negative ack redelivery URL: https://github.com/apache/pulsar/pull/3962#issuecomment-485042243 run java8 tests This is an automated message from the Apache G

[GitHub] [pulsar] sijie commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
sijie commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485083825 > Yes but we need this. As I said, it can be add to the wrapper of sendAsync. For handling the output result, I have mentioned followin

[GitHub] [pulsar] foreversunyao opened a new issue #4094: [WIP][Pipeline Plugin] add Pipeline plugin feature to pulsar

2019-04-20 Thread GitBox
foreversunyao opened a new issue #4094: [WIP][Pipeline Plugin] add Pipeline plugin feature to pulsar URL: https://github.com/apache/pulsar/issues/4094 **Is your feature request related to a problem? Please describe.** Currently we already have pulsar-io framework to let us make sourc

[GitHub] [pulsar] jerrypeng edited a comment on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
jerrypeng edited a comment on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485080376 > The only function code involve in current context.publish is “this.statsManager.incrSysExceptions(e);”. Yes but we need this.

[GitHub] [pulsar] jerrypeng commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
jerrypeng commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485080376 > The only function code involve in current context.publish is “this.statsManager.incrSysExceptions(e);”. Yes but we need this. @s

[GitHub] [pulsar] sijie commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
sijie commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485079466 The only function code involve in current context.publish is “this.statsManager.incrSysExceptions(e);”. --

[GitHub] [pulsar] sijie commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
sijie commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485079116 I strongly believe newOutputMessage is the right approach for deprecating context.publish. All context.publish methods should be deprecated and they

[GitHub] [pulsar] jerrypeng commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
jerrypeng commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485077510 Besides for this "TypedMessageBuilder messageBuilder = newOutputMessage("output", Schema.JSON());" we would need to wrap sendAsync somehow so t

[GitHub] [pulsar] jerrypeng commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
jerrypeng commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485076939 @sijie I don't want to yet introduce another way for users to publish messages. We already have the publish method so lets just keep it. We ca

[GitHub] [pulsar] sijie commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
sijie commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485075756 It doesn’t break the abstraction. The context.publish was designed for function users publishing messages inside a function. There is no difference

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-20 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277129050 ## File path: pulsar-client-go/pulsar/client.go ## @@ -103,16 +103,22 @@ type Client interface {

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-20 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277128960 ## File path: pulsar-client-go/pulsar/message.go ## @@ -66,6 +69,9 @@ type Message interface {

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-20 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277129084 ## File path: pulsar-client-go/pulsar/c_message.go ## @@ -97,8 +98,8 @@ func buildMessage(message

[GitHub] [pulsar] jerrypeng commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
jerrypeng commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485072935 @sijie I strongly disagree. Allowing users to the send out messages via ``` messageBuilder.value("my-topic").key("key").properties("mypr

[GitHub] [pulsar] wolfstudy commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
wolfstudy commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485072795 > @wolfstudy after looking a bit more into #4009, it is similar but it is a different topic. The request is for attaching properties to the resu

[GitHub] [pulsar] sijie commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
sijie commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485071664 @wolfstudy after looking a bit more into #4009, it is similar but it is a different topic. The request is for attaching properties to the result ret

[GitHub] [pulsar] sijie commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
sijie commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485070898 Jerry, I don’t think we should reinvent a new API. We should just use message builder hence whatever is available in pulsar client is available to

[GitHub] [pulsar] jiazhai commented on issue #4079: PIP-34 Key_Shared subscription core implementation.

2019-04-20 Thread GitBox
jiazhai commented on issue #4079: PIP-34 Key_Shared subscription core implementation. URL: https://github.com/apache/pulsar/pull/4079#issuecomment-485070511 retest this please This is an automated message from the Apache Git

[GitHub] [pulsar] wolfstudy edited a comment on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
wolfstudy edited a comment on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485070352 > The usage would something like this: > > ``` > MessageConf messageConf = MessageConf.Builder().key("key").properties(myPrope

[GitHub] [pulsar] wolfstudy commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
wolfstudy commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485070352 > The usage would something like this: > > ``` > MessageConf messageConf = MessageConf.Builder().key("key").properties(myProperties).b

[GitHub] [pulsar] jerrypeng commented on issue #4082: Optimizing performance for Pulsar function archive download

2019-04-20 Thread GitBox
jerrypeng commented on issue #4082: Optimizing performance for Pulsar function archive download URL: https://github.com/apache/pulsar/pull/4082#issuecomment-485068876 rerun java8 tests This is an automated message from the Ap

[GitHub] [pulsar] wolfstudy commented on a change in pull request #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
wolfstudy commented on a change in pull request #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#discussion_r277127761 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java

[GitHub] [pulsar] sijie commented on a change in pull request #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
sijie commented on a change in pull request #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#discussion_r277127575 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java ##

[GitHub] [pulsar] sijie commented on issue #4093: [issue#4042] improve java functions API

2019-04-20 Thread GitBox
sijie commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-485067523 @wolfstudy thank you for picking this up! #4009 and #4042 are addressing the same problem.