[GitHub] [pulsar] jerrypeng commented on a change in pull request #4174: [go function] support localrun and cluster mode for go function

2019-05-02 Thread GitBox
jerrypeng commented on a change in pull request #4174: [go function] support localrun and cluster mode for go function URL: https://github.com/apache/pulsar/pull/4174#discussion_r280671510 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/Runt

[GitHub] [pulsar] jerrypeng commented on issue #4174: [go function] support localrun and cluster mode for go function

2019-05-02 Thread GitBox
jerrypeng commented on issue #4174: [go function] support localrun and cluster mode for go function URL: https://github.com/apache/pulsar/pull/4174#issuecomment-488961361 LGTM @srkukarni you want to take a look as well? This

[GitHub] [pulsar] jerrypeng commented on issue #4093: [issue#4042] improve java functions API

2019-05-02 Thread GitBox
jerrypeng commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-488959606 run java8 tests This is an automated message from the Apache Git Servic

[GitHub] [pulsar] sijie commented on a change in pull request #4192: [pulsar-broker]Support key value schema compatibility checker

2019-05-02 Thread GitBox
sijie commented on a change in pull request #4192: [pulsar-broker]Support key value schema compatibility checker URL: https://github.com/apache/pulsar/pull/4192#discussion_r280668231 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/KeyValueSchemaCom

[pulsar] branch branch-2.3 updated: AlwaysCompatible doesn't use AlwaysSchemaValidator in 2.3.1 (#4181)

2019-05-02 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch branch-2.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.3 by this push: new bb21790 AlwaysCompatible doesn't use Alw

[GitHub] [pulsar] sijie commented on a change in pull request #4192: [pulsar-broker]Support key value schema compatibility checker

2019-05-02 Thread GitBox
sijie commented on a change in pull request #4192: [pulsar-broker]Support key value schema compatibility checker URL: https://github.com/apache/pulsar/pull/4192#discussion_r280668507 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/KeyValueSchemaCom

[GitHub] [pulsar] sijie commented on a change in pull request #4192: [pulsar-broker]Support key value schema compatibility checker

2019-05-02 Thread GitBox
sijie commented on a change in pull request #4192: [pulsar-broker]Support key value schema compatibility checker URL: https://github.com/apache/pulsar/pull/4192#discussion_r280669726 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/KeyValueSchemaCom

[GitHub] [pulsar] sijie merged pull request #4181: AlwaysCompatible doesn't use AlwaysSchemaValidator in 2.3.1

2019-05-02 Thread GitBox
sijie merged pull request #4181: AlwaysCompatible doesn't use AlwaysSchemaValidator in 2.3.1 URL: https://github.com/apache/pulsar/pull/4181 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] sijie commented on a change in pull request #4192: [pulsar-broker]Support key value schema compatibility checker

2019-05-02 Thread GitBox
sijie commented on a change in pull request #4192: [pulsar-broker]Support key value schema compatibility checker URL: https://github.com/apache/pulsar/pull/4192#discussion_r280669921 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/KeyValueSchemaCom

[GitHub] [pulsar] jerrypeng opened a new pull request #4198: Allow users to update auth data during function update

2019-05-02 Thread GitBox
jerrypeng opened a new pull request #4198: Allow users to update auth data during function update URL: https://github.com/apache/pulsar/pull/4198 ### Motivation Currently, after a function is submitted there is no way to update the auth data associated with the function. Us

[GitHub] [pulsar] sijie commented on issue #4166: Allow use of pulsar-client-all shaded jar from java-module-system

2019-05-02 Thread GitBox
sijie commented on issue #4166: Allow use of pulsar-client-all shaded jar from java-module-system URL: https://github.com/apache/pulsar/pull/4166#issuecomment-488947445 > I believe that in order for Pulsar to be a fully java-module-system compatible client, there need to be some more work

[GitHub] [pulsar] sijie commented on a change in pull request #4174: [go function] support localrun and cluster mode for go function

2019-05-02 Thread GitBox
sijie commented on a change in pull request #4174: [go function] support localrun and cluster mode for go function URL: https://github.com/apache/pulsar/pull/4174#discussion_r280666784 ## File path: pulsar-functions/secrets/src/main/java/org/apache/pulsar/functions/secretsproviderc

[GitHub] [pulsar] sijie commented on issue #4174: [go function] support localrun and cluster mode for go function

2019-05-02 Thread GitBox
sijie commented on issue #4174: [go function] support localrun and cluster mode for go function URL: https://github.com/apache/pulsar/pull/4174#issuecomment-488947111 run java8 tests This is an automated message from the Apac

[GitHub] [pulsar] wolfstudy commented on issue #4093: [issue#4042] improve java functions API

2019-05-02 Thread GitBox
wolfstudy commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-488931618 run java8 tests This is an automated message from the Apache Git Service. To re

[GitHub] [pulsar] sijie commented on issue #4178: [Tests] Enable Schema Integration Tests

2019-05-02 Thread GitBox
sijie commented on issue #4178: [Tests] Enable Schema Integration Tests URL: https://github.com/apache/pulsar/pull/4178#issuecomment-488926162 run integration tests This is an automated message from the Apache Git Service. To

[pulsar] branch master updated: Fix issue #4182 (#4187)

2019-05-02 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0dac8d1 Fix issue #4182 (#4187) 0dac8d1 is descr

[GitHub] [pulsar] sijie closed issue #4182: GenericAvroSchema should set supportSchemaVersioning to true

2019-05-02 Thread GitBox
sijie closed issue #4182: GenericAvroSchema should set supportSchemaVersioning to true URL: https://github.com/apache/pulsar/issues/4182 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [pulsar] sijie merged pull request #4187: Set supportSchemaVersioning to true by default in GenericAvroSchema

2019-05-02 Thread GitBox
sijie merged pull request #4187: Set supportSchemaVersioning to true by default in GenericAvroSchema URL: https://github.com/apache/pulsar/pull/4187 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] sijie commented on issue #4161: [transaction][coordinator] add the interfaces for transaction metadata store and an in-memory implementation

2019-05-02 Thread GitBox
sijie commented on issue #4161: [transaction][coordinator] add the interfaces for transaction metadata store and an in-memory implementation URL: https://github.com/apache/pulsar/pull/4161#issuecomment-488925106 @ivankelly @merlimat addressed your comments. PTAL - hence we can move forward

[GitHub] [pulsar] sijie commented on a change in pull request #4161: [transaction][coordinator] add the interfaces for transaction metadata store and an in-memory implementation

2019-05-02 Thread GitBox
sijie commented on a change in pull request #4161: [transaction][coordinator] add the interfaces for transaction metadata store and an in-memory implementation URL: https://github.com/apache/pulsar/pull/4161#discussion_r280660620 ## File path: pulsar-transaction/common/src/main/ja

[GitHub] [pulsar] merlimat commented on a change in pull request #4062: Delayed message delivery implementation

2019-05-02 Thread GitBox
merlimat commented on a change in pull request #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#discussion_r280646491 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -311,15 +307,

[GitHub] [pulsar] aahmed-se commented on issue #4181: AlwaysCompatible doesn't use AlwaysSchemaValidator in 2.3.1

2019-05-02 Thread GitBox
aahmed-se commented on issue #4181: AlwaysCompatible doesn't use AlwaysSchemaValidator in 2.3.1 URL: https://github.com/apache/pulsar/pull/4181#issuecomment-488865837 run java8 tests This is an automated message from the

[GitHub] [pulsar] merlimat commented on issue #4197: Avoid payload copy when inserting into managed ledger cache

2019-05-02 Thread GitBox
merlimat commented on issue #4197: Avoid payload copy when inserting into managed ledger cache URL: https://github.com/apache/pulsar/pull/4197#issuecomment-488857587 run integration tests This is an automated message from the

[GitHub] [pulsar] merlimat commented on a change in pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors

2019-05-02 Thread GitBox
merlimat commented on a change in pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors URL: https://github.com/apache/pulsar/pull/4196#discussion_r280569875 ## File path: conf/pulsar_env.sh ## @@ -48,7 +48,7 @@ PULSAR_MEM=${PULSAR_MEM:-"-Xms2g -

[GitHub] [pulsar] merlimat commented on a change in pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors

2019-05-02 Thread GitBox
merlimat commented on a change in pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors URL: https://github.com/apache/pulsar/pull/4196#discussion_r280569698 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/stats/JvmMetrics.java ###

[GitHub] [pulsar] merlimat opened a new pull request #4197: Avoid payload copy when inserting into managed ledger cache

2019-05-02 Thread GitBox
merlimat opened a new pull request #4197: Avoid payload copy when inserting into managed ledger cache URL: https://github.com/apache/pulsar/pull/4197 ### Motivation After #4066, we now have a strict upper bound for the time spent in cache by entries. Since this was the principal rea

[GitHub] [pulsar] rdhabalia commented on a change in pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors

2019-05-02 Thread GitBox
rdhabalia commented on a change in pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors URL: https://github.com/apache/pulsar/pull/4196#discussion_r280565131 ## File path: conf/pulsar_env.sh ## @@ -48,7 +48,7 @@ PULSAR_MEM=${PULSAR_MEM:-"-Xms2g

[GitHub] [pulsar] rdhabalia commented on a change in pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors

2019-05-02 Thread GitBox
rdhabalia commented on a change in pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors URL: https://github.com/apache/pulsar/pull/4196#discussion_r280564767 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/stats/JvmMetrics.java ##

[pulsar] branch master updated: provide better error handling logic for when a tenant doesn't exist (#4188)

2019-05-02 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0920e6a provide better error handling logic

[GitHub] [pulsar] jerrypeng merged pull request #4188: provide better error handling logic for function authorization when a tenant doesn't exist

2019-05-02 Thread GitBox
jerrypeng merged pull request #4188: provide better error handling logic for function authorization when a tenant doesn't exist URL: https://github.com/apache/pulsar/pull/4188 This is an automated message from the Apache Git

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors

2019-05-02 Thread GitBox
jerrypeng commented on a change in pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors URL: https://github.com/apache/pulsar/pull/4196#discussion_r280561812 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/stats/JvmMetrics.java ##

[GitHub] [pulsar] merlimat opened a new pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors

2019-05-02 Thread GitBox
merlimat opened a new pull request #4196: Configure static PulsarByteBufAllocator to handle OOM errors URL: https://github.com/apache/pulsar/pull/4196 ### Motivation In BK 4.9 we introduce a `ByteBufAllocatorBuilder` to configure all the aspect of the Netty ByteBuf allocator, includ

[GitHub] [pulsar] merlimat commented on issue #4181: AlwaysCompatible doesn't use AlwaysSchemaValidator in 2.3.1

2019-05-02 Thread GitBox
merlimat commented on issue #4181: AlwaysCompatible doesn't use AlwaysSchemaValidator in 2.3.1 URL: https://github.com/apache/pulsar/pull/4181#issuecomment-488787913 run java8 tests run integration tests This is an automat

[GitHub] [pulsar] Jeggikkentur closed pull request #4195: Updated pom.xml

2019-05-02 Thread GitBox
Jeggikkentur closed pull request #4195: Updated pom.xml URL: https://github.com/apache/pulsar/pull/4195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] Jeggikkentur opened a new pull request #4195: Updated pom.xml

2019-05-02 Thread GitBox
Jeggikkentur opened a new pull request #4195: Updated pom.xml URL: https://github.com/apache/pulsar/pull/4195 Updated mockito-core to ver. 2.27.0 - https://mvnrepository.com/artifact/org.mockito/mockito-core <-- ### Contribution Checklist - Name the pull request in the

[GitHub] [pulsar] wolfstudy commented on a change in pull request #4093: [issue#4042] improve java functions API

2019-05-02 Thread GitBox
wolfstudy commented on a change in pull request #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#discussion_r280530558 ## File path: pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/PublishFunctionWi

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4174: [go function] support localrun and cluster mode for go function

2019-05-02 Thread GitBox
jerrypeng commented on a change in pull request #4174: [go function] support localrun and cluster mode for go function URL: https://github.com/apache/pulsar/pull/4174#discussion_r280527932 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/Runt

[GitHub] [pulsar] jerrypeng commented on issue #4188: provide better error handling logic for function authorization when a tenant doesn't exist

2019-05-02 Thread GitBox
jerrypeng commented on issue #4188: provide better error handling logic for function authorization when a tenant doesn't exist URL: https://github.com/apache/pulsar/pull/4188#issuecomment-488765870 rerun java8 tests This is a

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4093: [issue#4042] improve java functions API

2019-05-02 Thread GitBox
jerrypeng commented on a change in pull request #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#discussion_r280524340 ## File path: pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/PublishFunctionWi

[GitHub] [pulsar] srkukarni commented on a change in pull request #4188: provide better error handling logic for function authorization when a tenant doesn't exist

2019-05-02 Thread GitBox
srkukarni commented on a change in pull request #4188: provide better error handling logic for function authorization when a tenant doesn't exist URL: https://github.com/apache/pulsar/pull/4188#discussion_r280524345 ## File path: pulsar-functions/worker/src/main/java/org/apache/pul

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4093: [issue#4042] improve java functions API

2019-05-02 Thread GitBox
jerrypeng commented on a change in pull request #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#discussion_r280524325 ## File path: pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/PublishFunction.j

[GitHub] [pulsar] jerrypeng commented on a change in pull request #4188: provide better error handling logic for function authorization when a tenant doesn't exist

2019-05-02 Thread GitBox
jerrypeng commented on a change in pull request #4188: provide better error handling logic for function authorization when a tenant doesn't exist URL: https://github.com/apache/pulsar/pull/4188#discussion_r280523794 ## File path: pulsar-functions/worker/src/main/java/org/apache/pul

[GitHub] [pulsar] waxzce opened a new issue #4194: Use graalVM native image to build client and client admin

2019-05-02 Thread GitBox
waxzce opened a new issue #4194: Use graalVM native image to build client and client admin URL: https://github.com/apache/pulsar/issues/4194 Using the pulsar-admin command can be very frustrating because of the startup time. That's one point were graalVM native image is interesting: build

[GitHub] [pulsar] merlimat commented on a change in pull request #4166: Allow use of pulsar-client-all shaded jar from java-module-system

2019-05-02 Thread GitBox
merlimat commented on a change in pull request #4166: Allow use of pulsar-client-all shaded jar from java-module-system URL: https://github.com/apache/pulsar/pull/4166#discussion_r280471878 ## File path: pulsar-client-all/pom.xml ## @@ -98,6 +98,7 @@

[GitHub] [pulsar] Jeggikkentur closed pull request #4193: Update pom.xml

2019-05-02 Thread GitBox
Jeggikkentur closed pull request #4193: Update pom.xml URL: https://github.com/apache/pulsar/pull/4193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [pulsar] Jeggikkentur opened a new pull request #4193: Update pom.xml

2019-05-02 Thread GitBox
Jeggikkentur opened a new pull request #4193: Update pom.xml URL: https://github.com/apache/pulsar/pull/4193 <-- ### Contribution Checklist - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issu

[pulsar] branch master updated: Allow to configure the managed ledger cache eviction frequency (#4066)

2019-05-02 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f5c7b22 Allow to configure the managed ledger c

[GitHub] [pulsar] merlimat merged pull request #4066: Allow to configure the managed ledger cache eviction frequency

2019-05-02 Thread GitBox
merlimat merged pull request #4066: Allow to configure the managed ledger cache eviction frequency URL: https://github.com/apache/pulsar/pull/4066 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] NotBad4U commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms

2019-05-02 Thread GitBox
NotBad4U commented on issue #4055: could not determine kind of name for C.pulsar_configure_set_negative_ack_redelivery_delay_ms URL: https://github.com/apache/pulsar/issues/4055#issuecomment-488694574 I encounter the same errors with the `client-cpp 2.3.1`. Fixing the pulsar-client-go ve

[GitHub] [pulsar] kimcs commented on issue #4166: Allow use of pulsar-client-all shaded jar from java-module-system

2019-05-02 Thread GitBox
kimcs commented on issue #4166: Allow use of pulsar-client-all shaded jar from java-module-system URL: https://github.com/apache/pulsar/pull/4166#issuecomment-488693598 @sijie I attempted to use the pulsar-client-all shaded jar, and had success with some minor modifications, they are now w

[GitHub] [pulsar] cdbartholomew commented on issue #4183: [Issue 3112][Broker Prometheus Metrics]Fix Duplicate Prometheus TYPE fix and add test

2019-05-02 Thread GitBox
cdbartholomew commented on issue #4183: [Issue 3112][Broker Prometheus Metrics]Fix Duplicate Prometheus TYPE fix and add test URL: https://github.com/apache/pulsar/pull/4183#issuecomment-488677944 @jerrypeng that PR (#4136) removes the TYPEs altogether, so now there are no type definitions

[GitHub] [pulsar] wolfstudy commented on issue #4174: [go function] support localrun and cluster mode for go function

2019-05-02 Thread GitBox
wolfstudy commented on issue #4174: [go function] support localrun and cluster mode for go function URL: https://github.com/apache/pulsar/pull/4174#issuecomment-488671290 run java8 tests This is an automated message from the

[GitHub] [pulsar] tuteng commented on a change in pull request #4177: [pulsar-clients]Support nested struct for GenericRecord

2019-05-02 Thread GitBox
tuteng commented on a change in pull request #4177: [pulsar-clients]Support nested struct for GenericRecord URL: https://github.com/apache/pulsar/pull/4177#discussion_r280376590 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/SchemaBuilderTest.java #

[GitHub] [pulsar] tuteng commented on a change in pull request #4177: [pulsar-clients]Support nested struct for GenericRecord

2019-05-02 Thread GitBox
tuteng commented on a change in pull request #4177: [pulsar-clients]Support nested struct for GenericRecord URL: https://github.com/apache/pulsar/pull/4177#discussion_r280376590 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/SchemaBuilderTest.java #

[GitHub] [pulsar] wolfstudy commented on issue #4093: [issue#4042] improve java functions API

2019-05-02 Thread GitBox
wolfstudy commented on issue #4093: [issue#4042] improve java functions API URL: https://github.com/apache/pulsar/pull/4093#issuecomment-488635662 @jerrypeng @srkukarni can you review this again? thanks This is an automated me

[GitHub] [pulsar] tuteng opened a new pull request #4192: Support key value schema compatibility checker

2019-05-02 Thread GitBox
tuteng opened a new pull request #4192: Support key value schema compatibility checker URL: https://github.com/apache/pulsar/pull/4192 ### Motivation The key/value types can be AVRO or JSON. Both AVRO and JSON supports schema evolution. We should add a key/value schema compatibi

[pulsar] branch asf-site updated: Updated site at revision 97bc7e0

2019-05-02 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 638473a Updated site at revision 97bc7e0 63

[GitHub] [pulsar] wolfstudy commented on issue #4174: [go function] support localrun and cluster mode for go function

2019-05-02 Thread GitBox
wolfstudy commented on issue #4174: [go function] support localrun and cluster mode for go function URL: https://github.com/apache/pulsar/pull/4174#issuecomment-488570779 @sijie @jerrypeng PTAL again This is an automated