[GitHub] [pulsar] codelipenghui commented on issue #4666: Doc release 2.4.0

2019-07-03 Thread GitBox
codelipenghui commented on issue #4666: Doc release 2.4.0 URL: https://github.com/apache/pulsar/pull/4666#issuecomment-508354136 @jiazhai I have addressed your comments, PTAL. This is an automated message from the Apache Git S

[GitHub] [pulsar] codelipenghui commented on issue #4669: Don't consider deleted schema when checking compatibility

2019-07-03 Thread GitBox
codelipenghui commented on issue #4669: Don't consider deleted schema when checking compatibility URL: https://github.com/apache/pulsar/pull/4669#issuecomment-508352696 rerun java8 tests This is an automated message from the

[GitHub] [pulsar] codelipenghui commented on issue #4666: Doc release 2.4.0

2019-07-03 Thread GitBox
codelipenghui commented on issue #4666: Doc release 2.4.0 URL: https://github.com/apache/pulsar/pull/4666#issuecomment-508335003 run java8 tests This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] sijie commented on issue #4646: [pulsar-sql]deserialize the avro schema data by correct reader

2019-07-03 Thread GitBox
sijie commented on issue #4646: [pulsar-sql]deserialize the avro schema data by correct reader URL: https://github.com/apache/pulsar/pull/4646#issuecomment-508310173 @congbobo184 okay. thanks This is an automated message from

[GitHub] [pulsar] congbobo184 closed pull request #4646: [pulsar-sql]deserialize the avro schema data by correct reader

2019-07-03 Thread GitBox
congbobo184 closed pull request #4646: [pulsar-sql]deserialize the avro schema data by correct reader URL: https://github.com/apache/pulsar/pull/4646 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar] congbobo184 commented on issue #4646: [pulsar-sql]deserialize the avro schema data by correct reader

2019-07-03 Thread GitBox
congbobo184 commented on issue #4646: [pulsar-sql]deserialize the avro schema data by correct reader URL: https://github.com/apache/pulsar/pull/4646#issuecomment-508307591 > @congbobo184 okay I will review this PR. I will close this PR and then come up with a new PR similar to #4151

[GitHub] [pulsar] merlimat opened a new pull request #4671: Upgrade to Mockito 2.x

2019-07-03 Thread GitBox
merlimat opened a new pull request #4671: Upgrade to Mockito 2.x URL: https://github.com/apache/pulsar/pull/4671 ## Motivation Upgrading to Mockito 2.28 and PowerMock 2.0. This a pre-step to be able to run CI with Java 11 / 12

[GitHub] [pulsar] merlimat commented on issue #4664: Renamed C++ logger enum names to avoid conflicts with compiler macros

2019-07-03 Thread GitBox
merlimat commented on issue #4664: Renamed C++ logger enum names to avoid conflicts with compiler macros URL: https://github.com/apache/pulsar/pull/4664#issuecomment-508274405 run cpp tests run integration tests This is an

[GitHub] [pulsar] ivankelly commented on issue #4669: Don't consider deleted schema when checking compatibility

2019-07-03 Thread GitBox
ivankelly commented on issue #4669: Don't consider deleted schema when checking compatibility URL: https://github.com/apache/pulsar/pull/4669#issuecomment-508271739 rerun java8 tests This is an automated message from the Apac

[GitHub] [pulsar] merlimat merged pull request #4577: fix issue when submitting NAR via file url

2019-07-03 Thread GitBox
merlimat merged pull request #4577: fix issue when submitting NAR via file url URL: https://github.com/apache/pulsar/pull/4577 This is an automated message from the Apache Git Service. To respond to the message, please log on

[pulsar] branch master updated: fix issue when submitting NAR via file url (#4577)

2019-07-03 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e8025d5 fix issue when submitting NAR via file

[GitHub] [pulsar] vzhikserg commented on a change in pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation

2019-07-03 Thread GitBox
vzhikserg commented on a change in pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation URL: https://github.com/apache/pulsar/pull/4670#discussion_r300160119 ## File path: site2/docs/client-libraries-java.md ## @@ -602,6 +603,24 @@

[GitHub] [pulsar] merlimat commented on a change in pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation

2019-07-03 Thread GitBox
merlimat commented on a change in pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation URL: https://github.com/apache/pulsar/pull/4670#discussion_r300159463 ## File path: site2/docs/client-libraries-java.md ## @@ -602,6 +603,24 @@

[GitHub] [pulsar] vzhikserg commented on a change in pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation

2019-07-03 Thread GitBox
vzhikserg commented on a change in pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation URL: https://github.com/apache/pulsar/pull/4670#discussion_r300158086 ## File path: site2/docs/client-libraries-java.md ## @@ -602,6 +603,24 @@

[GitHub] [pulsar] merlimat commented on a change in pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation

2019-07-03 Thread GitBox
merlimat commented on a change in pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation URL: https://github.com/apache/pulsar/pull/4670#discussion_r300155752 ## File path: site2/docs/client-libraries-java.md ## @@ -602,6 +603,24 @@

[GitHub] [pulsar] merlimat commented on a change in pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation

2019-07-03 Thread GitBox
merlimat commented on a change in pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation URL: https://github.com/apache/pulsar/pull/4670#discussion_r300155806 ## File path: site2/docs/client-libraries-java.md ## @@ -602,6 +603,24 @@

[GitHub] [pulsar] merlimat commented on issue #4669: Don't consider deleted schema when checking compatibility

2019-07-03 Thread GitBox
merlimat commented on issue #4669: Don't consider deleted schema when checking compatibility URL: https://github.com/apache/pulsar/pull/4669#issuecomment-508256587 run cpp tests This is an automated message from the Apache Gi

[GitHub] [pulsar] Guy-Dipietro-Bose commented on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ?

2019-07-03 Thread GitBox
Guy-Dipietro-Bose commented on issue #4540: Pulsar Client has no support in Mac 10.14.5 (18F132) ? URL: https://github.com/apache/pulsar/issues/4540#issuecomment-508240414 This issue also occurs with 2.4.0. I'm unable to use any version greater than 2.2.1. With 2.3.0 I see when run

[GitHub] [pulsar] vzhikserg opened a new pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation

2019-07-03 Thread GitBox
vzhikserg opened a new pull request #4670: [doc] Add code samples for Protobuf and Avro schemas in java documentation URL: https://github.com/apache/pulsar/pull/4670 ### Motivation We could not find Java examples which would include Avro and Protobuf schemas, but from the other [doc

[GitHub] [pulsar] merlimat commented on issue #4623: Fixed the default port for https and http in admin client

2019-07-03 Thread GitBox
merlimat commented on issue #4623: Fixed the default port for https and http in admin client URL: https://github.com/apache/pulsar/pull/4623#issuecomment-508223854 retest this please This is an automated message from the Apac

[GitHub] [pulsar] merlimat merged pull request #4657: [#4569][pulsar-client] C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout. (#4569)

2019-07-03 Thread GitBox
merlimat merged pull request #4657: [#4569][pulsar-client] C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout. (#4569) URL: https://github.com/apache/pulsar/pull/4657 Thi

[GitHub] [pulsar] merlimat closed issue #4569: C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout.

2019-07-03 Thread GitBox
merlimat closed issue #4569: C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout. URL: https://github.com/apache/pulsar/issues/4569 This is an automated message from the Ap

[pulsar] branch master updated: C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout. (#4569) (#4657)

2019-07-03 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2f68615 C++ client producer sendAsync() method

[GitHub] [pulsar] merlimat commented on issue #4664: Renamed C++ logger enum names to avoid conflicts with compiler macros

2019-07-03 Thread GitBox
merlimat commented on issue #4664: Renamed C++ logger enum names to avoid conflicts with compiler macros URL: https://github.com/apache/pulsar/pull/4664#issuecomment-508204974 retest this please This is an automated message f

[GitHub] [pulsar] merlimat commented on issue #4669: Don't consider deleted schema when checking compatibility

2019-07-03 Thread GitBox
merlimat commented on issue #4669: Don't consider deleted schema when checking compatibility URL: https://github.com/apache/pulsar/pull/4669#issuecomment-508196608 retest this please This is an automated message from the Apac

[GitHub] [pulsar] merlimat commented on issue #4657: [#4569][pulsar-client] C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout. (#4569)

2019-07-03 Thread GitBox
merlimat commented on issue #4657: [#4569][pulsar-client] C++ client producer sendAsync() method will be blocked forever, if enough batched messages sent timeout. (#4569) URL: https://github.com/apache/pulsar/pull/4657#issuecomment-508196296 run cpp tests -

[GitHub] [pulsar] congbobo184 commented on issue #4667: Modify file system offload version to 2.5.0-SNAPSHOT

2019-07-03 Thread GitBox
congbobo184 commented on issue #4667: Modify file system offload version to 2.5.0-SNAPSHOT URL: https://github.com/apache/pulsar/pull/4667#issuecomment-508196503 > run java8 tests 👍👍 This is an automated message from t

[GitHub] [pulsar] merlimat merged pull request #4665: [pulsar-broker] avoid retrying deleting namespace when topic is already deleted/fenced

2019-07-03 Thread GitBox
merlimat merged pull request #4665: [pulsar-broker] avoid retrying deleting namespace when topic is already deleted/fenced URL: https://github.com/apache/pulsar/pull/4665 This is an automated message from the Apache Git Serv

[pulsar] branch master updated (7afdf6b -> b367206)

2019-07-03 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 7afdf6b A modified version (#4667) add b367206 [pulsar-broker] avoid retrying deleting namespace when topic i

[pulsar] branch master updated: A modified version (#4667)

2019-07-03 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7afdf6b A modified version (#4667) 7afdf6b is d

[GitHub] [pulsar] merlimat merged pull request #4667: Modify file system offload version to 2.5.0-SNAPSHOT

2019-07-03 Thread GitBox
merlimat merged pull request #4667: Modify file system offload version to 2.5.0-SNAPSHOT URL: https://github.com/apache/pulsar/pull/4667 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [pulsar] jerrypeng commented on issue #4577: fix issue when submitting NAR via file url

2019-07-03 Thread GitBox
jerrypeng commented on issue #4577: fix issue when submitting NAR via file url URL: https://github.com/apache/pulsar/pull/4577#issuecomment-508186894 rerun integration tests This is an automated message from the Apache Git Ser

[GitHub] [pulsar] ivankelly removed a comment on issue #4667: Modify file system offload version to 2.5.0-SNAPSHOT

2019-07-03 Thread GitBox
ivankelly removed a comment on issue #4667: Modify file system offload version to 2.5.0-SNAPSHOT URL: https://github.com/apache/pulsar/pull/4667#issuecomment-508165902 CI won't pass until #4667 is merged. This is an automated

[GitHub] [pulsar] ivankelly commented on issue #4667: Modify file system offload version to 2.5.0-SNAPSHOT

2019-07-03 Thread GitBox
ivankelly commented on issue #4667: Modify file system offload version to 2.5.0-SNAPSHOT URL: https://github.com/apache/pulsar/pull/4667#issuecomment-508165902 CI won't pass until #4667 is merged. This is an automated message

[GitHub] [pulsar] ivankelly commented on issue #4669: Don't consider deleted schema when checking compatibility

2019-07-03 Thread GitBox
ivankelly commented on issue #4669: Don't consider deleted schema when checking compatibility URL: https://github.com/apache/pulsar/pull/4669#issuecomment-508166082 CI won't pass until #4667 is merged. This is an automated me

[GitHub] [pulsar] ivankelly opened a new pull request #4669: Don't consider deleted schema when checking compatibility

2019-07-03 Thread GitBox
ivankelly opened a new pull request #4669: Don't consider deleted schema when checking compatibility URL: https://github.com/apache/pulsar/pull/4669 feca5bbb changed topic delete logic to delete the schema when the topic is deleted (though this only seems to be enabled for idle topic

[GitHub] [pulsar] massakam commented on issue #4635: Bookie down causes deadlock in broker

2019-07-03 Thread GitBox
massakam commented on issue #4635: Bookie down causes deadlock in broker URL: https://github.com/apache/pulsar/issues/4635#issuecomment-508150928 However, `pulsar-ordered-OrderedExecutor-2-0-EventThread` seems to block itself until a timeout occurs. ``` "pulsar-ordered-OrderedExecutor

[GitHub] [pulsar] codelipenghui commented on issue #4667: Modify file system offload version to 2.5.0-SNAPSHOT

2019-07-03 Thread GitBox
codelipenghui commented on issue #4667: Modify file system offload version to 2.5.0-SNAPSHOT URL: https://github.com/apache/pulsar/pull/4667#issuecomment-508130394 run java8 tests This is an automated message from the Apache

[GitHub] [pulsar] jiazhai commented on a change in pull request #4666: Doc release 2.4.0

2019-07-03 Thread GitBox
jiazhai commented on a change in pull request #4666: Doc release 2.4.0 URL: https://github.com/apache/pulsar/pull/4666#discussion_r299912979 ## File path: site2/website/versioned_docs/version-2.4.0/io-cdc-canal.md ## @@ -0,0 +1,175 @@ +--- +id: version-2.4.0-io-cdc-canal +t

[GitHub] [pulsar] jiazhai commented on a change in pull request #4666: Doc release 2.4.0

2019-07-03 Thread GitBox
jiazhai commented on a change in pull request #4666: Doc release 2.4.0 URL: https://github.com/apache/pulsar/pull/4666#discussion_r299912328 ## File path: site2/website/versioned_docs/version-2.4.0/io-cdc-canal.md ## @@ -0,0 +1,175 @@ +--- +id: version-2.4.0-io-cdc-canal +t

[GitHub] [pulsar] tuteng commented on issue #4668: Add Debezium Postgresql integration test

2019-07-03 Thread GitBox
tuteng commented on issue #4668: Add Debezium Postgresql integration test URL: https://github.com/apache/pulsar/pull/4668#issuecomment-508055318 Can you add a more detailed test? For example, actively insert a piece of data into PostgreSql, then receive it use consumer, and finally compare

[GitHub] [pulsar] congbobo184 commented on issue #4667: Modify file system offload version to 2.5.0-SNAPSHOT

2019-07-03 Thread GitBox
congbobo184 commented on issue #4667: Modify file system offload version to 2.5.0-SNAPSHOT URL: https://github.com/apache/pulsar/pull/4667#issuecomment-508039523 run java8 tests This is an automated message from the Apache Gi

[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.

2019-07-03 Thread GitBox
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#issuecomment-508000241 @sijie Oh, sorry i forgot it, i will send a email soon. This is an

[GitHub] [pulsar] liketic commented on issue #4640: [Doc] Fix FAQ broken link

2019-07-03 Thread GitBox
liketic commented on issue #4640: [Doc] Fix FAQ broken link URL: https://github.com/apache/pulsar/pull/4640#issuecomment-507995130 run java8 tests This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] codelipenghui commented on issue #4667: Modify file system version

2019-07-03 Thread GitBox
codelipenghui commented on issue #4667: Modify file system version URL: https://github.com/apache/pulsar/pull/4667#issuecomment-507993976 run java8 tests This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] willome opened a new pull request #4668: Add Debezium Postgresql integration test

2019-07-03 Thread GitBox
willome opened a new pull request #4668: Add Debezium Postgresql integration test URL: https://github.com/apache/pulsar/pull/4668 Provide new CDC/Debezium Postgresql Integration test. Only Mysql one was present. This is an

[GitHub] [pulsar] willome closed pull request #4660: Add Debezium Postgresql Integration test

2019-07-03 Thread GitBox
willome closed pull request #4660: Add Debezium Postgresql Integration test URL: https://github.com/apache/pulsar/pull/4660 This is an automated message from the Apache Git Service. To respond to the message, please log on to