[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312737067 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBuilderImpl.java

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312737760 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312739173 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessagesImpl.java ## @@

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312739722 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java ## @@

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312739935 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessagesImpl.java ## @@

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312740260 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java ## @@

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312740276 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/BatchReceivePolicy.java ##

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312740293 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Messages.java ## @@ -

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312740282 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/BatchReceivePolicy.java ##

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312740300 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/BatchReceivePolicy.java ##

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312740338 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312740347 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312740422 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java

[GitHub] [pulsar] codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on a change in pull request #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#discussion_r312740632 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java ## @@

[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#issuecomment-520232917 @sijie Thanks for the review, i have addressed your comments, please take a look. -

[GitHub] [pulsar] sijie merged pull request #4930: [pulsar-client] Fix broken replication msg to specific cluster

2019-08-11 Thread GitBox
sijie merged pull request #4930: [pulsar-client] Fix broken replication msg to specific cluster URL: https://github.com/apache/pulsar/pull/4930 This is an automated message from the Apache Git Service. To respond to the mess

[pulsar] branch master updated: [pulsar-client] Fix broken replication msg to specific cluster (#4930)

2019-08-11 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 02f9fd3 [pulsar-client] Fix broken replication m

[GitHub] [pulsar] sijie commented on issue #4910: [doc] Add a documentation page for metrics reference

2019-08-11 Thread GitBox
sijie commented on issue #4910: [doc] Add a documentation page for metrics reference URL: https://github.com/apache/pulsar/pull/4910#issuecomment-520281659 run cpp tests run java8 tests This is an automated message from th

[GitHub] [pulsar] sijie merged pull request #4921: [4920][proxy] Add option to disable authentication for proxy /metrics

2019-08-11 Thread GitBox
sijie merged pull request #4921: [4920][proxy] Add option to disable authentication for proxy /metrics URL: https://github.com/apache/pulsar/pull/4921 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] sijie closed issue #4920: `/metrics` endpoint in proxy is behind authentication

2019-08-11 Thread GitBox
sijie closed issue #4920: `/metrics` endpoint in proxy is behind authentication URL: https://github.com/apache/pulsar/issues/4920 This is an automated message from the Apache Git Service. To respond to the message, please lo

[pulsar] branch master updated: Add option to disable authentication for proxy /metrics (#4921)

2019-08-11 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new be7b24f Add option to disable authentication for

[GitHub] [pulsar] codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client.

2019-08-11 Thread GitBox
codelipenghui commented on issue #4621: [PIP-38] Support batch receive in java client. URL: https://github.com/apache/pulsar/pull/4621#issuecomment-520282807 run cpp tests This is an automated message from the Apache Git Serv

[GitHub] [pulsar] zymap commented on a change in pull request #4927: [Transaction][Buffer] Provide an asynchronous method to create a transaction buffer

2019-08-11 Thread GitBox
zymap commented on a change in pull request #4927: [Transaction][Buffer] Provide an asynchronous method to create a transaction buffer URL: https://github.com/apache/pulsar/pull/4927#discussion_r312772433 ## File path: pulsar-transaction/buffer/src/main/java/org/apache/pulsar/trans

[GitHub] [pulsar] congbobo184 commented on a change in pull request #4877: Add schema admin api get schema info with schema version

2019-08-11 Thread GitBox
congbobo184 commented on a change in pull request #4877: Add schema admin api get schema info with schema version URL: https://github.com/apache/pulsar/pull/4877#discussion_r312772646 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchemaInfo

[GitHub] [pulsar] congbobo184 commented on a change in pull request #4877: Add schema admin api get schema info with schema version

2019-08-11 Thread GitBox
congbobo184 commented on a change in pull request #4877: Add schema admin api get schema info with schema version URL: https://github.com/apache/pulsar/pull/4877#discussion_r312772646 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchemaInfo

[GitHub] [pulsar] congbobo184 commented on a change in pull request #4877: Add schema admin api get schema info with schema version

2019-08-11 Thread GitBox
congbobo184 commented on a change in pull request #4877: Add schema admin api get schema info with schema version URL: https://github.com/apache/pulsar/pull/4877#discussion_r312772719 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchemaInfo

[GitHub] [pulsar] fxbing opened a new issue #4933: Backlog size calculation errors can result in unlimited messages being produced

2019-08-11 Thread GitBox
fxbing opened a new issue #4933: Backlog size calculation errors can result in unlimited messages being produced URL: https://github.com/apache/pulsar/issues/4933 **Describe the bug** Backlogs are sets of unacknowledged messages for a topic that have been stored by bookies even if not

[GitHub] [pulsar] Anonymitaet opened a new pull request #4934: [Doc] Update Schema Guide

2019-08-11 Thread GitBox
Anonymitaet opened a new pull request #4934: [Doc] Update Schema Guide URL: https://github.com/apache/pulsar/pull/4934 1. Add descriptions. 2. Delete the following files because their contents are already in the new Schema Guide. - concepts-schema-registry.md (contents are

[GitHub] [pulsar] Anonymitaet commented on issue #4934: [Doc] Update Schema Guide

2019-08-11 Thread GitBox
Anonymitaet commented on issue #4934: [Doc] Update Schema Guide URL: https://github.com/apache/pulsar/pull/4934#issuecomment-520291380 @sijie could you please help review? Thank you This is an automated message from the Apache

[GitHub] [pulsar] zymap opened a new pull request #4935: [WIP][Transaction][Buffer] handle command `EndTxnOnPartitiion`

2019-08-11 Thread GitBox
zymap opened a new pull request #4935: [WIP][Transaction][Buffer] handle command `EndTxnOnPartitiion` URL: https://github.com/apache/pulsar/pull/4935 ### Motivation *Add handler for the command `EndTxnOnPartitioin*

[GitHub] [pulsar] zymap closed pull request #4923: [Transaction][buffer] create a commit marker at topic ledger

2019-08-11 Thread GitBox
zymap closed pull request #4923: [Transaction][buffer] create a commit marker at topic ledger URL: https://github.com/apache/pulsar/pull/4923 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] Anonymitaet closed issue #4905: [Doc] Fix display issue of swagger doc

2019-08-11 Thread GitBox
Anonymitaet closed issue #4905: [Doc] Fix display issue of swagger doc URL: https://github.com/apache/pulsar/issues/4905 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] Anonymitaet commented on issue #4905: [Doc] Fix display issue of swagger doc

2019-08-11 Thread GitBox
Anonymitaet commented on issue #4905: [Doc] Fix display issue of swagger doc URL: https://github.com/apache/pulsar/issues/4905#issuecomment-520291885 Fixed in https://github.com/apache/pulsar/pull/4901#event-2548070643 This is

[GitHub] [pulsar] Anonymitaet edited a comment on issue #4905: [Doc] Fix display issue of swagger doc

2019-08-11 Thread GitBox
Anonymitaet edited a comment on issue #4905: [Doc] Fix display issue of swagger doc URL: https://github.com/apache/pulsar/issues/4905#issuecomment-520291885 Fixed in https://github.com/apache/pulsar/pull/4901 This is an autom

[GitHub] [pulsar] Anonymitaet commented on issue #4789: [Doc] Add Schema Chapter

2019-08-11 Thread GitBox
Anonymitaet commented on issue #4789: [Doc] Add Schema Chapter URL: https://github.com/apache/pulsar/issues/4789#issuecomment-520292037 All schema related PRs have been merged. This is an automated message from the Apache Git

[GitHub] [pulsar] Anonymitaet closed issue #4789: [Doc] Add Schema Chapter

2019-08-11 Thread GitBox
Anonymitaet closed issue #4789: [Doc] Add Schema Chapter URL: https://github.com/apache/pulsar/issues/4789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar] zymap closed pull request #4925: [Transaction][Buffer] add transaction suffix on the topic name

2019-08-11 Thread GitBox
zymap closed pull request #4925: [Transaction][Buffer] add transaction suffix on the topic name URL: https://github.com/apache/pulsar/pull/4925 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] zymap commented on issue #4935: [WIP][Transaction][Buffer] handle command `EndTxnOnPartitiion`

2019-08-11 Thread GitBox
zymap commented on issue #4935: [WIP][Transaction][Buffer] handle command `EndTxnOnPartitiion` URL: https://github.com/apache/pulsar/pull/4935#issuecomment-520292790 @sijie Please help me take a look when you have time. Thanks ---

[GitHub] [pulsar] fxbing opened a new pull request #4936: Fix backlog size bug

2019-08-11 Thread GitBox
fxbing opened a new pull request #4936: Fix backlog size bug URL: https://github.com/apache/pulsar/pull/4936 fix #4933 Backlogs are sets of unacknowledged messages for a topic that have been stored by bookies even if not consumed. But in fact, if the topic has not been consumed, you ca

[GitHub] [pulsar] fxbing commented on issue #4933: Backlog size calculation errors can result in unlimited messages being produced

2019-08-11 Thread GitBox
fxbing commented on issue #4933: Backlog size calculation errors can result in unlimited messages being produced URL: https://github.com/apache/pulsar/issues/4933#issuecomment-520293734 fixed in #4936 This is an automated m

[GitHub] [pulsar] pouledodue opened a new issue #4937: Retrieve schema instance from schema info for type 'NONE'

2019-08-11 Thread GitBox
pouledodue opened a new issue #4937: Retrieve schema instance from schema info for type 'NONE' URL: https://github.com/apache/pulsar/issues/4937 ``` pulsar-admin functions trigger --fqfn test/app/func1 --trigger-value yoshi java.util.concurrent.ExecutionException: java.lang.Illeg