[GitHub] [pulsar] codelipenghui commented on issue #4975: Fix the getSchema logic in pulsar proxy

2019-08-18 Thread GitBox
codelipenghui commented on issue #4975: Fix the getSchema logic in pulsar proxy URL: https://github.com/apache/pulsar/pull/4975#issuecomment-522423186 @congbobo184 Please help take a look these changes, thanks. This is an auto

[GitHub] [pulsar] congbobo184 commented on issue #4950: Modify rest api post schema compatibility strategy

2019-08-18 Thread GitBox
congbobo184 commented on issue #4950: Modify rest api post schema compatibility strategy URL: https://github.com/apache/pulsar/pull/4950#issuecomment-522403315 run java8 tests This is an automated message from the Apache Git

[GitHub] [pulsar] yittg commented on a change in pull request #4972: [pulsar-client-cpp] fix snappy compressor compile error

2019-08-18 Thread GitBox
yittg commented on a change in pull request #4972: [pulsar-client-cpp] fix snappy compressor compile error URL: https://github.com/apache/pulsar/pull/4972#discussion_r315007541 ## File path: pulsar-client-cpp/docker-lib-check.sh ## @@ -0,0 +1,23 @@ +#!/bin/bash +# +# Licen

[GitHub] [pulsar] yittg commented on a change in pull request #4972: [pulsar-client-cpp] fix snappy compressor compile error

2019-08-18 Thread GitBox
yittg commented on a change in pull request #4972: [pulsar-client-cpp] fix snappy compressor compile error URL: https://github.com/apache/pulsar/pull/4972#discussion_r315007541 ## File path: pulsar-client-cpp/docker-lib-check.sh ## @@ -0,0 +1,23 @@ +#!/bin/bash +# +# Licen

[GitHub] [pulsar] yittg commented on a change in pull request #4972: [pulsar-client-cpp] fix snappy compressor compile error

2019-08-18 Thread GitBox
yittg commented on a change in pull request #4972: [pulsar-client-cpp] fix snappy compressor compile error URL: https://github.com/apache/pulsar/pull/4972#discussion_r315007541 ## File path: pulsar-client-cpp/docker-lib-check.sh ## @@ -0,0 +1,23 @@ +#!/bin/bash +# +# Licen

[GitHub] [pulsar] mingfang commented on issue #4964: Broker unable to restart

2019-08-18 Thread GitBox
mingfang commented on issue #4964: Broker unable to restart URL: https://github.com/apache/pulsar/issues/4964#issuecomment-522356041 Is there CI/CD to push daily builds to Docker Hub? Or do I have to build my own image? Thi

[GitHub] [pulsar] rdhabalia commented on issue #4964: Broker unable to restart

2019-08-18 Thread GitBox
rdhabalia commented on issue #4964: Broker unable to restart URL: https://github.com/apache/pulsar/issues/4964#issuecomment-522355728 can you try with this fix #4965 This is an automated message from the Apache Git Service. T

[pulsar] branch master updated: Fix: NPE while cleaning up namespace node (#4965)

2019-08-18 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 41bc407 Fix: NPE while cleaning up namespace

[GitHub] [pulsar] rdhabalia merged pull request #4965: Fix: NPE while cleaning up namespace node

2019-08-18 Thread GitBox
rdhabalia merged pull request #4965: Fix: NPE while cleaning up namespace node URL: https://github.com/apache/pulsar/pull/4965 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] sijie commented on issue #4951: Fix pull request 4700

2019-08-18 Thread GitBox
sijie commented on issue #4951: Fix pull request 4700 URL: https://github.com/apache/pulsar/pull/4951#issuecomment-522338886 run java8 tests This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] sijie commented on issue #4910: [doc] Add a documentation page for metrics reference

2019-08-18 Thread GitBox
sijie commented on issue #4910: [doc] Add a documentation page for metrics reference URL: https://github.com/apache/pulsar/pull/4910#issuecomment-522338837 @Jennifer88huang I have addressed your review comments. This is an au

[GitHub] [pulsar] sijie commented on issue #4965: Fix: NPE while cleaning up namespace node

2019-08-18 Thread GitBox
sijie commented on issue #4965: Fix: NPE while cleaning up namespace node URL: https://github.com/apache/pulsar/pull/4965#issuecomment-522338401 run java8 tests This is an automated message from the Apache Git Service. To resp

[GitHub] [pulsar] sijie commented on a change in pull request #4972: [pulsar-client-cpp] fix snappy compressor compile error

2019-08-18 Thread GitBox
sijie commented on a change in pull request #4972: [pulsar-client-cpp] fix snappy compressor compile error URL: https://github.com/apache/pulsar/pull/4972#discussion_r314994038 ## File path: pulsar-client-cpp/docker-lib-check.sh ## @@ -0,0 +1,23 @@ +#!/bin/bash +# +# Licen

[GitHub] [pulsar] sijie merged pull request #4946: [pulsar-functions][python-examples] Fixing python function example custom_object_function.py

2019-08-18 Thread GitBox
sijie merged pull request #4946: [pulsar-functions][python-examples] Fixing python function example custom_object_function.py URL: https://github.com/apache/pulsar/pull/4946 This is an automated message from the Apache Git S

[pulsar] branch master updated: fixing python function example custom_object_function.py (#4946)

2019-08-18 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 33441ea fixing python function example custom_ob

[GitHub] [pulsar] sijie commented on issue #4974: [Issue 4956]Add default loader for latest pyyaml

2019-08-18 Thread GitBox
sijie commented on issue #4974: [Issue 4956]Add default loader for latest pyyaml URL: https://github.com/apache/pulsar/pull/4974#issuecomment-522338125 run cpp tests This is an automated message from the Apache Git Service. To

[pulsar] branch master updated (2c21500 -> 1691cc8)

2019-08-18 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 2c21500 prevent fd leakage when WorkerUtils.downloadFromBookkeeper (#4970) add 1691cc8 [Transaction] Introduce

[GitHub] [pulsar] sijie merged pull request #4952: [Transaction] Introduce Transaction Client API

2019-08-18 Thread GitBox
sijie merged pull request #4952: [Transaction] Introduce Transaction Client API URL: https://github.com/apache/pulsar/pull/4952 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] tuteng commented on issue #4974: [Issue 4956]Add default loader for latest pyyaml

2019-08-18 Thread GitBox
tuteng commented on issue #4974: [Issue 4956]Add default loader for latest pyyaml URL: https://github.com/apache/pulsar/pull/4974#issuecomment-522325150 run cpp tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar] yittg commented on issue #4972: [pulsar-client-cpp] fix snappy compressor compile error

2019-08-18 Thread GitBox
yittg commented on issue #4972: [pulsar-client-cpp] fix snappy compressor compile error URL: https://github.com/apache/pulsar/pull/4972#issuecomment-522320665 run java8 tests This is an automated message from the Apache Git S

[GitHub] [pulsar] sijie commented on issue #4951: Fix pull request 4700

2019-08-18 Thread GitBox
sijie commented on issue #4951: Fix pull request 4700 URL: https://github.com/apache/pulsar/pull/4951#issuecomment-522318987 run java8 tests This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] sijie commented on issue #4946: [pulsar-functions][python-examples] Fixing python function example custom_object_function.py

2019-08-18 Thread GitBox
sijie commented on issue #4946: [pulsar-functions][python-examples] Fixing python function example custom_object_function.py URL: https://github.com/apache/pulsar/pull/4946#issuecomment-522318963 run java8 tests This is an au

[GitHub] [pulsar] sijie commented on issue #4974: [Issue 4956]Add default loader for latest pyyaml

2019-08-18 Thread GitBox
sijie commented on issue #4974: [Issue 4956]Add default loader for latest pyyaml URL: https://github.com/apache/pulsar/pull/4974#issuecomment-522318493 run cpp tests This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] sijie commented on issue #4952: [Transaction] Introduce Transaction Client API

2019-08-18 Thread GitBox
sijie commented on issue #4952: [Transaction] Introduce Transaction Client API URL: https://github.com/apache/pulsar/pull/4952#issuecomment-522318471 run cpp tests run java8 tests This is an automated message from the Apach

[GitHub] [pulsar] sijie closed issue #4969: FD leakage found in FunctionActioner.downloadFile

2019-08-18 Thread GitBox
sijie closed issue #4969: FD leakage found in FunctionActioner.downloadFile URL: https://github.com/apache/pulsar/issues/4969 This is an automated message from the Apache Git Service. To respond to the message, please log on

[pulsar] branch master updated (93d95c7 -> 2c21500)

2019-08-18 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 93d95c7 expose getLastMessageId method in ConsumerImpl (#4911) add 2c21500 prevent fd leakage when WorkerUtils.

[GitHub] [pulsar] sijie merged pull request #4970: [Issue 4969] fix fd leakage in FunctionActioner.downloadFile

2019-08-18 Thread GitBox
sijie merged pull request #4970: [Issue 4969] fix fd leakage in FunctionActioner.downloadFile URL: https://github.com/apache/pulsar/pull/4970 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] sijie closed issue #3506: Functions missing from REST api docs

2019-08-18 Thread GitBox
sijie closed issue #3506: Functions missing from REST api docs URL: https://github.com/apache/pulsar/issues/3506 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] sijie commented on issue #3506: Functions missing from REST api docs

2019-08-18 Thread GitBox
sijie commented on issue #3506: Functions missing from REST api docs URL: https://github.com/apache/pulsar/issues/3506#issuecomment-522318081 The docs of functions, sinks and sources are all added. This is an automated message

[GitHub] [pulsar] sijie commented on issue #3506: Functions missing from REST api docs

2019-08-18 Thread GitBox
sijie commented on issue #3506: Functions missing from REST api docs URL: https://github.com/apache/pulsar/issues/3506#issuecomment-522318084 The docs of functions, sinks and sources are all added. This is an automated message

[GitHub] [pulsar] sijie closed issue #3510: Tiered Storage Offloaders download link is dead in the Docs

2019-08-18 Thread GitBox
sijie closed issue #3510: Tiered Storage Offloaders download link is dead in the Docs URL: https://github.com/apache/pulsar/issues/3510 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [pulsar] sijie commented on issue #3510: Tiered Storage Offloaders download link is dead in the Docs

2019-08-18 Thread GitBox
sijie commented on issue #3510: Tiered Storage Offloaders download link is dead in the Docs URL: https://github.com/apache/pulsar/issues/3510#issuecomment-522317793 since 2.2.2 was released, close this issue. This is an autom

[GitHub] [pulsar] sijie closed issue #3480: ack not return error when consumer closed

2019-08-18 Thread GitBox
sijie closed issue #3480: ack not return error when consumer closed URL: https://github.com/apache/pulsar/issues/3480 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [pulsar] sijie closed issue #3463: Unable to delete a namespace using pulsar-admin CLI

2019-08-18 Thread GitBox
sijie closed issue #3463: Unable to delete a namespace using pulsar-admin CLI URL: https://github.com/apache/pulsar/issues/3463 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] sijie commented on issue #3463: Unable to delete a namespace using pulsar-admin CLI

2019-08-18 Thread GitBox
sijie commented on issue #3463: Unable to delete a namespace using pulsar-admin CLI URL: https://github.com/apache/pulsar/issues/3463#issuecomment-522317245 Closed this issue since it seems to be related GKE issue. This is an

[GitHub] [pulsar] sijie commented on issue #3436: Add configuration properties to limit the automatic creation of topics.

2019-08-18 Thread GitBox
sijie commented on issue #3436: Add configuration properties to limit the automatic creation of topics. URL: https://github.com/apache/pulsar/issues/3436#issuecomment-522317157 This is fixed by #3450 This is an automated mes

[GitHub] [pulsar] sijie closed issue #3436: Add configuration properties to limit the automatic creation of topics.

2019-08-18 Thread GitBox
sijie closed issue #3436: Add configuration properties to limit the automatic creation of topics. URL: https://github.com/apache/pulsar/issues/3436 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] sijie closed issue #3396: Add missing methods to SinkContext & SourceContext interfaces

2019-08-18 Thread GitBox
sijie closed issue #3396: Add missing methods to SinkContext & SourceContext interfaces URL: https://github.com/apache/pulsar/issues/3396 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [pulsar] sijie commented on issue #3396: Add missing methods to SinkContext & SourceContext interfaces

2019-08-18 Thread GitBox
sijie commented on issue #3396: Add missing methods to SinkContext & SourceContext interfaces URL: https://github.com/apache/pulsar/issues/3396#issuecomment-522316936 This is fixed by #3397 This is an automated message from t

[GitHub] [pulsar] sijie closed issue #3402: OutOfDirectMemoryError

2019-08-18 Thread GitBox
sijie closed issue #3402: OutOfDirectMemoryError URL: https://github.com/apache/pulsar/issues/3402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] sijie commented on issue #3402: OutOfDirectMemoryError

2019-08-18 Thread GitBox
sijie commented on issue #3402: OutOfDirectMemoryError URL: https://github.com/apache/pulsar/issues/3402#issuecomment-522316893 @sautran the settings are available since 2.3.0 This is an automated message from the Apache Git S

[GitHub] [pulsar] sijie closed issue #3404: Nightly builds

2019-08-18 Thread GitBox
sijie closed issue #3404: Nightly builds URL: https://github.com/apache/pulsar/issues/3404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] sijie commented on issue #3404: Nightly builds

2019-08-18 Thread GitBox
sijie commented on issue #3404: Nightly builds URL: https://github.com/apache/pulsar/issues/3404#issuecomment-522316735 Question is answered. So closed this issue. This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar] sijie commented on issue #3408: pulsar golang error

2019-08-18 Thread GitBox
sijie commented on issue #3408: pulsar golang error URL: https://github.com/apache/pulsar/issues/3408#issuecomment-522316665 @chowyu08 any more context about this issue? This is an automated message from the Apache Git Service

[GitHub] [pulsar] sijie commented on issue #3419: [Question] Some questions about namespace bundle splitting

2019-08-18 Thread GitBox
sijie commented on issue #3419: [Question] Some questions about namespace bundle splitting URL: https://github.com/apache/pulsar/issues/3419#issuecomment-522316509 > Yes, my question is about this. If the bundle only contains one partition and the partition is still overloaded, is there a

[GitHub] [pulsar] sijie closed issue #3382: What's purpose of ackId when publishing to a topic ?

2019-08-18 Thread GitBox
sijie closed issue #3382: What's purpose of ackId when publishing to a topic ? URL: https://github.com/apache/pulsar/issues/3382 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] sijie commented on issue #3367: Dashboard docker shows no data

2019-08-18 Thread GitBox
sijie commented on issue #3367: Dashboard docker shows no data URL: https://github.com/apache/pulsar/issues/3367#issuecomment-522316178 Closed it since it is related to advertisedAddress. This is an automated message from the

[GitHub] [pulsar] sijie closed issue #3367: Dashboard docker shows no data

2019-08-18 Thread GitBox
sijie closed issue #3367: Dashboard docker shows no data URL: https://github.com/apache/pulsar/issues/3367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar] sijie closed issue #3305: "--global-zookeeper" already deprecated and hidden but still referenced in documentation

2019-08-18 Thread GitBox
sijie closed issue #3305: "--global-zookeeper" already deprecated and hidden but still referenced in documentation URL: https://github.com/apache/pulsar/issues/3305 This is an automated message from the Apache Git Service. T

[GitHub] [pulsar] sijie commented on issue #3294: [IO] [Kafka] a Kafka source submitted with invalid configuration stucks without consuming from Kafka topics

2019-08-18 Thread GitBox
sijie commented on issue #3294: [IO] [Kafka] a Kafka source submitted with invalid configuration stucks without consuming from Kafka topics URL: https://github.com/apache/pulsar/issues/3294#issuecomment-522315870 The issue has been fixed in 2.3.0 ---

[GitHub] [pulsar] sijie closed issue #3294: [IO] [Kafka] a Kafka source submitted with invalid configuration stucks without consuming from Kafka topics

2019-08-18 Thread GitBox
sijie closed issue #3294: [IO] [Kafka] a Kafka source submitted with invalid configuration stucks without consuming from Kafka topics URL: https://github.com/apache/pulsar/issues/3294 This is an automated message from the Ap

[GitHub] [pulsar] sijie closed issue #2576: Pulsar client consume command fails with java.lang.IllegalArgumentException: port out of range:-1

2019-08-18 Thread GitBox
sijie closed issue #2576: Pulsar client consume command fails with java.lang.IllegalArgumentException: port out of range:-1 URL: https://github.com/apache/pulsar/issues/2576 This is an automated message from the Apache Git S

[GitHub] [pulsar] sijie commented on issue #3259: [Question]How to configure log level for pulsar functions

2019-08-18 Thread GitBox
sijie commented on issue #3259: [Question]How to configure log level for pulsar functions URL: https://github.com/apache/pulsar/issues/3259#issuecomment-522315587 Closed the question since the question is answered This is an

[GitHub] [pulsar] sijie closed issue #3259: [Question]How to configure log level for pulsar functions

2019-08-18 Thread GitBox
sijie closed issue #3259: [Question]How to configure log level for pulsar functions URL: https://github.com/apache/pulsar/issues/3259 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [pulsar] sijie commented on issue #4971: docker image should have C++ client installed

2019-08-18 Thread GitBox
sijie commented on issue #4971: docker image should have C++ client installed URL: https://github.com/apache/pulsar/issues/4971#issuecomment-522315231 @freeznet I believe the docker image should have C++ client installed. otherwise python client is unable to be used and python functions can

[GitHub] [pulsar] sijie commented on issue #4959: Pulsar admin always timeout until restart the broker

2019-08-18 Thread GitBox
sijie commented on issue #4959: Pulsar admin always timeout until restart the broker URL: https://github.com/apache/pulsar/issues/4959#issuecomment-522314962 @codelipenghui It might be related the issues we have seen in broker that admin requests don't timeout and block the http requests.

[GitHub] [pulsar] sijie commented on issue #4954: 'msgBacklog' is wrong when use Producer.sendAsync() send message

2019-08-18 Thread GitBox
sijie commented on issue #4954: 'msgBacklog' is wrong when use Producer.sendAsync() send message URL: https://github.com/apache/pulsar/issues/4954#issuecomment-522314574 @benxinglong I am not sure if this is a problem. Because sendAsync are async operations. There is no guarantee that all

[GitHub] [pulsar] sijie commented on issue #4947: [function]Does the pulsar support connecting to the database in function?

2019-08-18 Thread GitBox
sijie commented on issue #4947: [function]Does the pulsar support connecting to the database in function? URL: https://github.com/apache/pulsar/issues/4947#issuecomment-522314341 @LeisureChou in theory you can just open a connection to a data in the constructor of the function, so that yo

[GitHub] [pulsar] sijie commented on issue #4937: Retrieve schema instance from schema info for type 'NONE'

2019-08-18 Thread GitBox
sijie commented on issue #4937: Retrieve schema instance from schema info for type 'NONE' URL: https://github.com/apache/pulsar/issues/4937#issuecomment-522313744 @pouledodue interesting. Can you describe more about this case? - what is the function? - does the topic `test/app/fu

[GitHub] [pulsar] sijie commented on issue #4926: Add more config for auto-topic-creation

2019-08-18 Thread GitBox
sijie commented on issue #4926: Add more config for auto-topic-creation URL: https://github.com/apache/pulsar/issues/4926#issuecomment-522313070 This will be fixed by #4963 This is an automated message from the Apache Git Ser

[GitHub] [pulsar] sijie commented on issue #4904: [Pulsar IO]Pulsar IO support automatic loading of connector

2019-08-18 Thread GitBox
sijie commented on issue #4904: [Pulsar IO]Pulsar IO support automatic loading of connector URL: https://github.com/apache/pulsar/issues/4904#issuecomment-522312563 @aahmed-se what @tuteng is looking for is a mechanism (or an http endpoint) to trigger reloading connectors when people addi

[GitHub] [pulsar] sijie commented on issue #4974: [Issue 4956]Add default loader for latest pyyaml

2019-08-18 Thread GitBox
sijie commented on issue #4974: [Issue 4956]Add default loader for latest pyyaml URL: https://github.com/apache/pulsar/pull/4974#issuecomment-522310483 run cpp tests This is an automated message from the Apache Git Service. To

[pulsar] branch asf-site updated: Updated site at revision 93d95c7

2019-08-18 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 6429cf6 Updated site at revision 93d95c7 64

[GitHub] [pulsar] sijie commented on issue #4965: Fix: NPE while cleaning up namespace node

2019-08-18 Thread GitBox
sijie commented on issue #4965: Fix: NPE while cleaning up namespace node URL: https://github.com/apache/pulsar/pull/4965#issuecomment-522299969 run java8 tests This is an automated message from the Apache Git Service. To resp

[GitHub] [pulsar] sijie commented on issue #4972: [pulsar-client-cpp] fix snappy compressor compile error

2019-08-18 Thread GitBox
sijie commented on issue #4972: [pulsar-client-cpp] fix snappy compressor compile error URL: https://github.com/apache/pulsar/pull/4972#issuecomment-522299957 run java8 tests This is an automated message from the Apache Git S

[GitHub] [pulsar] sijie commented on issue #4953: [transaction] Add transaction coordinator client

2019-08-18 Thread GitBox
sijie commented on issue #4953: [transaction] Add transaction coordinator client URL: https://github.com/apache/pulsar/pull/4953#issuecomment-522299932 run java8 tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar] sijie commented on issue #4811: [Issue: 3161][Go client] Return Message ID for send

2019-08-18 Thread GitBox
sijie commented on issue #4811: [Issue: 3161][Go client] Return Message ID for send URL: https://github.com/apache/pulsar/pull/4811#issuecomment-522299865 Ping @merlimat @rdhabalia @massakam This is an automated message from

[GitHub] [pulsar] sijie commented on a change in pull request #4927: [Transaction][Buffer] Provide an asynchronous method to create a transaction buffer

2019-08-18 Thread GitBox
sijie commented on a change in pull request #4927: [Transaction][Buffer] Provide an asynchronous method to create a transaction buffer URL: https://github.com/apache/pulsar/pull/4927#discussion_r314972622 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/Top

[GitHub] [pulsar] sijie commented on a change in pull request #4927: [Transaction][Buffer] Provide an asynchronous method to create a transaction buffer

2019-08-18 Thread GitBox
sijie commented on a change in pull request #4927: [Transaction][Buffer] Provide an asynchronous method to create a transaction buffer URL: https://github.com/apache/pulsar/pull/4927#discussion_r314972379 ## File path: pulsar-transaction/buffer/src/main/java/org/apache/pulsar/trans

[GitHub] [pulsar] sijie commented on a change in pull request #4927: [Transaction][Buffer] Provide an asynchronous method to create a transaction buffer

2019-08-18 Thread GitBox
sijie commented on a change in pull request #4927: [Transaction][Buffer] Provide an asynchronous method to create a transaction buffer URL: https://github.com/apache/pulsar/pull/4927#discussion_r314972506 ## File path: pulsar-transaction/buffer/src/main/java/org/apache/pulsar/trans

[GitHub] [pulsar] sijie commented on issue #4946: [pulsar-functions][python-examples] Fixing python function example custom_object_function.py

2019-08-18 Thread GitBox
sijie commented on issue #4946: [pulsar-functions][python-examples] Fixing python function example custom_object_function.py URL: https://github.com/apache/pulsar/pull/4946#issuecomment-522299217 run cpp tests run java8 tests -

[GitHub] [pulsar] sijie closed issue #4909: Expose getLastMessageId method from consumerImpl

2019-08-18 Thread GitBox
sijie closed issue #4909: Expose getLastMessageId method from consumerImpl URL: https://github.com/apache/pulsar/issues/4909 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [pulsar] sijie merged pull request #4911: expose getLastMessageId method in ConsumerImpl

2019-08-18 Thread GitBox
sijie merged pull request #4911: expose getLastMessageId method in ConsumerImpl URL: https://github.com/apache/pulsar/pull/4911 This is an automated message from the Apache Git Service. To respond to the message, please log o

[pulsar] branch master updated (1c3b6f2 -> 93d95c7)

2019-08-18 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1c3b6f2 [dashboard] integrate peek into messages page (#4966) add 93d95c7 expose getLastMessageId method in Con

[GitHub] [pulsar] sijie commented on issue #4951: Fix pull request 4700

2019-08-18 Thread GitBox
sijie commented on issue #4951: Fix pull request 4700 URL: https://github.com/apache/pulsar/pull/4951#issuecomment-522299002 run java8 tests This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] sijie opened a new pull request #4975: Fix the getSchema logic in pulsar proxy

2019-08-18 Thread GitBox
sijie opened a new pull request #4975: Fix the getSchema logic in pulsar proxy URL: https://github.com/apache/pulsar/pull/4975 *Motivation* The getSchema logic in Pulsar proxy handler doesn't handle the case that the request doesn't have schema version. *Modification*

[GitHub] [pulsar] sijie commented on issue #4952: [Transaction] Introduce Transaction Client API

2019-08-18 Thread GitBox
sijie commented on issue #4952: [Transaction] Introduce Transaction Client API URL: https://github.com/apache/pulsar/pull/4952#issuecomment-522298647 run integration tests This is an automated message from the Apache Git Servi