[GitHub] [pulsar] merlimat commented on a change in pull request #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference

2019-09-21 Thread GitBox
merlimat commented on a change in pull request #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference URL: https://github.com/apache/pulsar/pull/5246#discussion_r326880310 ## File path: pulsar-client-cpp/lib/ConnectionPool.cc

[GitHub] [pulsar] sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer

2019-09-21 Thread GitBox
sijie commented on issue #5045: [client] Introduce `batchingMaxBytes` setting in pulsar producer URL: https://github.com/apache/pulsar/pull/5045#issuecomment-533840098 run java8 tests This is an automated message from the Apa

[pulsar] branch master updated: [Doc] Add *Kafka sink connector guide* (#5210)

2019-09-21 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c728bd5 [Doc] Add *Kafka sink connector guide* (

[GitHub] [pulsar] sijie merged pull request #5210: [Doc] Add *Kafka sink connector guide*

2019-09-21 Thread GitBox
sijie merged pull request #5210: [Doc] Add *Kafka sink connector guide* URL: https://github.com/apache/pulsar/pull/5210 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pulsar] sijie commented on issue #5230: Allow for topic deletions with regex consumers

2019-09-21 Thread GitBox
sijie commented on issue #5230: Allow for topic deletions with regex consumers URL: https://github.com/apache/pulsar/pull/5230#issuecomment-533839846 @jiazhai since you are familiar with regex subscription and also involved in the original discussion, can you please take a look at this chan

[GitHub] [pulsar] jerrypeng commented on issue #5243: Bug in Message Deduplication that may cause incorrect client/broker interaction

2019-09-21 Thread GitBox
jerrypeng commented on issue #5243: Bug in Message Deduplication that may cause incorrect client/broker interaction URL: https://github.com/apache/pulsar/pull/5243#issuecomment-533833526 rerun integration tests This is an aut

[GitHub] [pulsar] massakam opened a new pull request #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference

2019-09-21 Thread GitBox
massakam opened a new pull request #5246: [Issue #5234][pulsar-client-cpp] Fix memory leak caused by deadline_timer holding object reference URL: https://github.com/apache/pulsar/pull/5246 Fixes #5234 ### Motivation In the C++ client library, memory usage increases as producer

[GitHub] [pulsar] vzhikserg commented on issue #5205: [doc] Fix broken links to the info about schemas and Schema Registry

2019-09-21 Thread GitBox
vzhikserg commented on issue #5205: [doc] Fix broken links to the info about schemas and Schema Registry URL: https://github.com/apache/pulsar/pull/5205#issuecomment-533815707 run integration tests This is an automated messag

[GitHub] [pulsar] MarvinCai commented on issue #5148: Validate topic name before creating partition/non partition topic via admin cli.

2019-09-21 Thread GitBox
MarvinCai commented on issue #5148: Validate topic name before creating partition/non partition topic via admin cli. URL: https://github.com/apache/pulsar/pull/5148#issuecomment-533811442 run java8 tests run integration tests -

[GitHub] [pulsar] MarvinCai removed a comment on issue #5148: Validate topic name before creating partition/non partition topic via admin cli.

2019-09-21 Thread GitBox
MarvinCai removed a comment on issue #5148: Validate topic name before creating partition/non partition topic via admin cli. URL: https://github.com/apache/pulsar/pull/5148#issuecomment-533811306 run java8 test run integration test ---

[GitHub] [pulsar] MarvinCai commented on issue #5148: Validate topic name before creating partition/non partition topic via admin cli.

2019-09-21 Thread GitBox
MarvinCai commented on issue #5148: Validate topic name before creating partition/non partition topic via admin cli. URL: https://github.com/apache/pulsar/pull/5148#issuecomment-533811306 run java8 test run integration test ---

[GitHub] [pulsar] MarvinCai removed a comment on issue #5148: Validate topic name before creating partition/non partition topic via admin cli.

2019-09-21 Thread GitBox
MarvinCai removed a comment on issue #5148: Validate topic name before creating partition/non partition topic via admin cli. URL: https://github.com/apache/pulsar/pull/5148#issuecomment-533811204 rerun java8 test rerun integration test ---

[GitHub] [pulsar] MarvinCai commented on issue #5148: Validate topic name before creating partition/non partition topic via admin cli.

2019-09-21 Thread GitBox
MarvinCai commented on issue #5148: Validate topic name before creating partition/non partition topic via admin cli. URL: https://github.com/apache/pulsar/pull/5148#issuecomment-533811204 rerun java8 test rerun integration test ---

[GitHub] [pulsar] merlimat commented on issue #5232: Upgrade dependencies for security fixes

2019-09-21 Thread GitBox
merlimat commented on issue #5232: Upgrade dependencies for security fixes URL: https://github.com/apache/pulsar/pull/5232#issuecomment-533806218 run java8 tests This is an automated message from the Apache Git Service. To re

[GitHub] [pulsar] Anonymitaet commented on issue #5226: [Doc] Add *HDFS2 sink connector guide*

2019-09-21 Thread GitBox
Anonymitaet commented on issue #5226: [Doc] Add *HDFS2 sink connector guide* URL: https://github.com/apache/pulsar/pull/5226#issuecomment-533799644 run java8 tests This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar] Anonymitaet commented on issue #5226: [Doc] Add *HDFS2 sink connector guide*

2019-09-21 Thread GitBox
Anonymitaet commented on issue #5226: [Doc] Add *HDFS2 sink connector guide* URL: https://github.com/apache/pulsar/pull/5226#issuecomment-533799590 run java8 tests This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar] Anonymitaet commented on issue #5214: [Doc] Add *Kinesis sink connector guide*

2019-09-21 Thread GitBox
Anonymitaet commented on issue #5214: [Doc] Add *Kinesis sink connector guide* URL: https://github.com/apache/pulsar/pull/5214#issuecomment-533799374 run java8 tests This is an automated message from the Apache Git Service. T

[GitHub] [pulsar] Anonymitaet commented on issue #5211: [Doc] Add *Kinesis source connector guide*

2019-09-21 Thread GitBox
Anonymitaet commented on issue #5211: [Doc] Add *Kinesis source connector guide* URL: https://github.com/apache/pulsar/pull/5211#issuecomment-533799364 run java8 tests This is an automated message from the Apache Git Service.

[GitHub] [pulsar-client-go] mileschao opened a new pull request #65: [Issue 64] fix bug: type assert cause panic

2019-09-21 Thread GitBox
mileschao opened a new pull request #65: [Issue 64] fix bug: type assert cause panic URL: https://github.com/apache/pulsar-client-go/pull/65 Signed-off-by: miles.j.chao [miles.j.c...@gmail.com](miles.j.c...@gmail.com) Fixes #64 ### Motivation 1. type assert may cause p

[GitHub] [pulsar] yittg commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema

2019-09-21 Thread GitBox
yittg commented on a change in pull request #5165: [PIP-43] Support producer to send msg with different schema URL: https://github.com/apache/pulsar/pull/5165#discussion_r326855318 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java ##

[GitHub] [pulsar] liketic commented on issue #5147: Deprecate getstatus subcommand for source command

2019-09-21 Thread GitBox
liketic commented on issue #5147: Deprecate getstatus subcommand for source command URL: https://github.com/apache/pulsar/pull/5147#issuecomment-533786085 run java8 tests This is an automated message from the Apache Git Servi

[GitHub] [pulsar] aahmed-se commented on issue #5245: Skip test1 [skip ci]

2019-09-21 Thread GitBox
aahmed-se commented on issue #5245: Skip test1 [skip ci] URL: https://github.com/apache/pulsar/pull/5245#issuecomment-533783828 [skip ci] This is an automated message from the Apache Git Service. To respond to the message, ple