[GitHub] [pulsar] wolfstudy commented on issue #5357: [functions][Issue:5350]Fix pulsar can't load the customized SerDe

2019-10-27 Thread GitBox
wolfstudy commented on issue #5357: [functions][Issue:5350]Fix pulsar can't load the customized SerDe URL: https://github.com/apache/pulsar/pull/5357#issuecomment-546806837 @sijie PTAL again, thanks. This is an automated mess

[GitHub] [pulsar] wolfstudy commented on issue #5357: [functions][Issue:5350]Fix pulsar can't load the customized SerDe

2019-10-27 Thread GitBox
wolfstudy commented on issue #5357: [functions][Issue:5350]Fix pulsar can't load the customized SerDe URL: https://github.com/apache/pulsar/pull/5357#issuecomment-546806636 run java8 tests This is an automated message from th

[GitHub] [pulsar] jiazhai commented on issue #5365: python API missing `is_read_compacted` in create_reader()

2019-10-27 Thread GitBox
jiazhai commented on issue #5365: python API missing `is_read_compacted` in create_reader() URL: https://github.com/apache/pulsar/issues/5365#issuecomment-546805357 will look into it. This is an automated message from the Apa

[GitHub] [pulsar] jiazhai opened a new pull request #5477: Issue #5349: wrongly report "3600 messages have timed-out"

2019-10-27 Thread GitBox
jiazhai opened a new pull request #5477: Issue #5349: wrongly report "3600 messages have timed-out" URL: https://github.com/apache/pulsar/pull/5477 Fix #5349 5349 wrongly report "3600 messages have timed-out". This is caused by wrong parameter passed into log.

[GitHub] [pulsar] jiazhai commented on issue #5349: UnAckedMessageTracker: 3600 messages have timed-out... but they haven't?

2019-10-27 Thread GitBox
jiazhai commented on issue #5349: UnAckedMessageTracker: 3600 messages have timed-out... but they haven't? URL: https://github.com/apache/pulsar/issues/5349#issuecomment-546794439 will look into it. This is an automated messa

[GitHub] [pulsar] hrsakai commented on issue #5387: When I create many PulsarClients and Consumers, fail to resolve hostname

2019-10-27 Thread GitBox
hrsakai commented on issue #5387: When I create many PulsarClients and Consumers, fail to resolve hostname URL: https://github.com/apache/pulsar/issues/5387#issuecomment-546790819 Fixed by https://github.com/apache/pulsar/pull/3613 --

[GitHub] [pulsar] hrsakai closed issue #5387: When I create many PulsarClients and Consumers, fail to resolve hostname

2019-10-27 Thread GitBox
hrsakai closed issue #5387: When I create many PulsarClients and Consumers, fail to resolve hostname URL: https://github.com/apache/pulsar/issues/5387 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] sijie opened a new issue #5476: Message deduplication is not well handled when batching is enabled with external provided sequenceId

2019-10-27 Thread GitBox
sijie opened a new issue #5476: Message deduplication is not well handled when batching is enabled with external provided sequenceId URL: https://github.com/apache/pulsar/issues/5476 **Describe the bug** Current implementation of Pulsar producer doesn't check the sequenceId when add

[GitHub] [pulsar] Jennifer88huang opened a new issue #5475: Doc display issue on message deduplication page

2019-10-27 Thread GitBox
Jennifer88huang opened a new issue #5475: Doc display issue on message deduplication page URL: https://github.com/apache/pulsar/issues/5475 **Describe the bug** There are some display issues at http://pulsar.apache.org/docs/en/cookbooks-deduplication/ See the following images ![i

[GitHub] [pulsar] merlimat commented on issue #3555: Allow to automatically assign TCP ports when starting a broker

2019-10-27 Thread GitBox
merlimat commented on issue #3555: Allow to automatically assign TCP ports when starting a broker URL: https://github.com/apache/pulsar/pull/3555#issuecomment-546766067 > my point is to prevent mistakes like what we did in bookkeeper. 0 is only useful in tests, but it is actually harmful i

[GitHub] [pulsar] yittg commented on issue #5466: move general schema hash to common module

2019-10-27 Thread GitBox
yittg commented on issue #5466: move general schema hash to common module URL: https://github.com/apache/pulsar/pull/5466#issuecomment-546765174 run java8 tests run cpp tests This is an automated message from the Apache Git

[GitHub] [pulsar] codelipenghui commented on issue #5388: [PIP-47] Introduce sticky consumer

2019-10-27 Thread GitBox
codelipenghui commented on issue #5388: [PIP-47] Introduce sticky consumer URL: https://github.com/apache/pulsar/pull/5388#issuecomment-546765224 @sijie Yes, it should be PIP-47 This is an automated message from the Apache Git

[GitHub] [pulsar] codelipenghui commented on issue #5457: [transaction-coordinator] Ownership change listeners

2019-10-27 Thread GitBox
codelipenghui commented on issue #5457: [transaction-coordinator] Ownership change listeners URL: https://github.com/apache/pulsar/pull/5457#issuecomment-546765092 @sijie I have addressed your comments, please take a look. Th

[GitHub] [pulsar] Jennifer88huang commented on issue #5467: [website] Update PMC and committer info in team.js

2019-10-27 Thread GitBox
Jennifer88huang commented on issue #5467: [website] Update PMC and committer info in team.js URL: https://github.com/apache/pulsar/pull/5467#issuecomment-546756604 run java8 tests This is an automated message from the Apache

[pulsar] branch master updated (6fb5fd2 -> 89e3f30)

2019-10-27 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository. zhaijia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6fb5fd2 put protocol handler after loadmanagement (#5473) add 89e3f30 make some method of ManagedLedger publi

[GitHub] [pulsar] jiazhai merged pull request #5472: Make some common use method of ManagedLedger public

2019-10-27 Thread GitBox
jiazhai merged pull request #5472: Make some common use method of ManagedLedger public URL: https://github.com/apache/pulsar/pull/5472 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [pulsar] Jennifer88huang commented on issue #5402: [doc]missing coding guide

2019-10-27 Thread GitBox
Jennifer88huang commented on issue #5402: [doc]missing coding guide URL: https://github.com/apache/pulsar/issues/5402#issuecomment-546756396 @kevenYLi Thank you very much for raising the issue, @gm7y8 is fixing it in #5425. So I'll close this issue currently. ---

[GitHub] [pulsar] Jennifer88huang closed issue #5402: [doc]missing coding guide

2019-10-27 Thread GitBox
Jennifer88huang closed issue #5402: [doc]missing coding guide URL: https://github.com/apache/pulsar/issues/5402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] Jennifer88huang commented on issue #5402: [doc]missing coding guide

2019-10-27 Thread GitBox
Jennifer88huang commented on issue #5402: [doc]missing coding guide URL: https://github.com/apache/pulsar/issues/5402#issuecomment-546756271 Duplicate with https://github.com/apache/pulsar/issues/5425. A contributor named `gm7y8` is fixing it.

[GitHub] [pulsar] Jennifer88huang commented on issue #5368: [docs] Contradictory information about what versions of python are supported

2019-10-27 Thread GitBox
Jennifer88huang commented on issue #5368: [docs] Contradictory information about what versions of python are supported URL: https://github.com/apache/pulsar/issues/5368#issuecomment-546755879 @sijie Sure. This is an automated

[GitHub] [pulsar] ccronemberger commented on issue #5346: bin/pulsar standalone --zookeeper-port 2183 does not work with version 2.4.1

2019-10-27 Thread GitBox
ccronemberger commented on issue #5346: bin/pulsar standalone --zookeeper-port 2183 does not work with version 2.4.1 URL: https://github.com/apache/pulsar/issues/5346#issuecomment-546750324 Hi, Yes, I have changed all places were I found port 2181. I will double check anyway. Regards

[GitHub] [pulsar] codelipenghui commented on issue #5472: Make some common use method of ManagedLedger public

2019-10-27 Thread GitBox
codelipenghui commented on issue #5472: Make some common use method of ManagedLedger public URL: https://github.com/apache/pulsar/pull/5472#issuecomment-546749432 run cpp tests This is an automated message from the Apache Git

[GitHub] [pulsar] fhalim commented on issue #5430: Flink connector sink doesn't work on blink SQL context

2019-10-27 Thread GitBox
fhalim commented on issue #5430: Flink connector sink doesn't work on blink SQL context URL: https://github.com/apache/pulsar/issues/5430#issuecomment-546746378 @sijie thanks so much for the information. I did not see any artifacts for `pulsar-flink-connector` at https://dl.bintray.com/st

[GitHub] [pulsar] fhalim closed issue #5430: Flink connector sink doesn't work on blink SQL context

2019-10-27 Thread GitBox
fhalim closed issue #5430: Flink connector sink doesn't work on blink SQL context URL: https://github.com/apache/pulsar/issues/5430 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] limadelrey opened a new issue #5474: Support CDC Connector for MongoDB

2019-10-27 Thread GitBox
limadelrey opened a new issue #5474: Support CDC Connector for MongoDB URL: https://github.com/apache/pulsar/issues/5474 At this moment, Apache Pulsar's [documentation](https://pulsar.apache.org/docs/en/io-cdc/) on CDC Connectors states the following information: > "The CDC Source

[GitHub] [pulsar] addisonj commented on issue #5398: [functions] Distribute the CA for KubernetesSecretsTokenAuthProvider

2019-10-27 Thread GitBox
addisonj commented on issue #5398: [functions] Distribute the CA for KubernetesSecretsTokenAuthProvider URL: https://github.com/apache/pulsar/pull/5398#issuecomment-546730980 rerun java8 tests This is an automated message fro

[GitHub] [pulsar] addisonj commented on issue #5383: deleteSubscription fails and leaves a dangling thread in jetty threadpool

2019-10-27 Thread GitBox
addisonj commented on issue #5383: deleteSubscription fails and leaves a dangling thread in jetty threadpool URL: https://github.com/apache/pulsar/issues/5383#issuecomment-546730930 I haven't validated for sure... but based on where the thread was left dangling it *could* still be a proble

[GitHub] [pulsar] hanbo1990 commented on issue #5326: pulsar released package missing configuraion for ranges from bookkie

2019-10-27 Thread GitBox
hanbo1990 commented on issue #5326: pulsar released package missing configuraion for ranges from bookkie URL: https://github.com/apache/pulsar/issues/5326#issuecomment-546729063 Sure, I will do it. This is an automated messa

[GitHub] [pulsar-client-go] cckellogg opened a new pull request #77: [ISSUE #72] Fix data race conditions.

2019-10-27 Thread GitBox
cckellogg opened a new pull request #77: [ISSUE #72] Fix data race conditions. URL: https://github.com/apache/pulsar-client-go/pull/77 Fixes #72 This patch adds locking to fix all the data race warnings when discovered when running. `go test ./... -race` -

[GitHub] [pulsar] candlerb commented on issue #5370: sql worker on Ubuntu 18: libprocname.so failing, and failing JVM vendor check

2019-10-27 Thread GitBox
candlerb commented on issue #5370: sql worker on Ubuntu 18: libprocname.so failing, and failing JVM vendor check URL: https://github.com/apache/pulsar/issues/5370#issuecomment-546720772 > the presto version was just updated recently in master. Thanks! I can't see the commit wh

[GitHub] [pulsar] sijie commented on issue #5467: [website] Update PMC and committer info in team.js

2019-10-27 Thread GitBox
sijie commented on issue #5467: [website] Update PMC and committer info in team.js URL: https://github.com/apache/pulsar/pull/5467#issuecomment-546716720 run java8 tests This is an automated message from the Apache Git Servic

[GitHub] [pulsar] sijie commented on issue #5452: PersistentTopicMessagingTest and NonPersistentTopicMessagingTest broken and not running

2019-10-27 Thread GitBox
sijie commented on issue #5452: PersistentTopicMessagingTest and NonPersistentTopicMessagingTest broken and not running URL: https://github.com/apache/pulsar/issues/5452#issuecomment-546716409 this is fixed by #5456 This is

[GitHub] [pulsar] sijie closed issue #5452: PersistentTopicMessagingTest and NonPersistentTopicMessagingTest broken and not running

2019-10-27 Thread GitBox
sijie closed issue #5452: PersistentTopicMessagingTest and NonPersistentTopicMessagingTest broken and not running URL: https://github.com/apache/pulsar/issues/5452 This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] sijie commented on issue #5454: mysql JDBC Sink - consumer error

2019-10-27 Thread GitBox
sijie commented on issue #5454: mysql JDBC Sink - consumer error URL: https://github.com/apache/pulsar/issues/5454#issuecomment-546716367 @tuteng I suspected the problem from the schema uploaded by python client. Can you try to reproduce the problem using the example provided by @jm7647 ?

[GitHub] [pulsar] sijie commented on issue #5430: Flink connector sink doesn't work on blink SQL context

2019-10-27 Thread GitBox
sijie commented on issue #5430: Flink connector sink doesn't work on blink SQL context URL: https://github.com/apache/pulsar/issues/5430#issuecomment-546716081 @fhalim for the integration with Flink 1.9, you might checkout this out : https://github.com/streamnative/pulsar-flink We a

[GitHub] [pulsar] sijie commented on issue #5433: Implementing a Sink to a non thread-safe destination

2019-10-27 Thread GitBox
sijie commented on issue #5433: Implementing a Sink to a non thread-safe destination URL: https://github.com/apache/pulsar/issues/5433#issuecomment-546715842 > Is the write method of a class implementing the Pulsar Sink interface expected to be thread safe? yes. > When exactl

[GitHub] [pulsar] sijie commented on issue #5447: Apache Beam support for Pulsar

2019-10-27 Thread GitBox
sijie commented on issue #5447: Apache Beam support for Pulsar URL: https://github.com/apache/pulsar/issues/5447#issuecomment-546715605 @svenhornberg there is a discussion in BEAM mailing list. We will collaborate with beam community on adding a pulsar connector in BEAM repo. -

[GitHub] [pulsar] sijie commented on issue #5402: [doc]missing coding guide

2019-10-27 Thread GitBox
sijie commented on issue #5402: [doc]missing coding guide URL: https://github.com/apache/pulsar/issues/5402#issuecomment-546714941 @Anonymitaet @Jennifer88huang please help with this issue. This is an automated message from th

[GitHub] [pulsar] sijie commented on issue #5396: anonymousUserRole is not consistently applied on http endpoint

2019-10-27 Thread GitBox
sijie commented on issue #5396: anonymousUserRole is not consistently applied on http endpoint URL: https://github.com/apache/pulsar/issues/5396#issuecomment-546714757 We also found some other inconsistencies around authorization. @wolfstudy and @zymap are working on submitting a PIP to im

[GitHub] [pulsar] volfco commented on issue #5274: geo replicated subscribers

2019-10-27 Thread GitBox
volfco commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-546714656 @sijie I'll try that tomorrow and let you know if it meets my need. I didn't see that in my search of the docs --

[GitHub] [pulsar] sijie commented on issue #5393: Support service mesh for pulsar

2019-10-27 Thread GitBox
sijie commented on issue #5393: Support service mesh for pulsar URL: https://github.com/apache/pulsar/issues/5393#issuecomment-546714505 @xujianhai666 Can you provide more information? This is an automated message from the Apa

[GitHub] [pulsar] sijie commented on issue #5383: deleteSubscription fails and leaves a dangling thread in jetty threadpool

2019-10-27 Thread GitBox
sijie commented on issue #5383: deleteSubscription fails and leaves a dangling thread in jetty threadpool URL: https://github.com/apache/pulsar/issues/5383#issuecomment-546714059 @addisonj are you saying this is still a problem in master? ---

[GitHub] [pulsar] sijie commented on issue #5373: Pulsar Standalone is shutdown before complete starting

2019-10-27 Thread GitBox
sijie commented on issue #5373: Pulsar Standalone is shutdown before complete starting URL: https://github.com/apache/pulsar/issues/5373#issuecomment-546713678 @ronaldofreitas Can you try to start with `bin/pulsar standalone -nss`? --

[GitHub] [pulsar] sijie commented on issue #5370: sql worker on Ubuntu 18: libprocname.so failing, and failing JVM vendor check

2019-10-27 Thread GitBox
sijie commented on issue #5370: sql worker on Ubuntu 18: libprocname.so failing, and failing JVM vendor check URL: https://github.com/apache/pulsar/issues/5370#issuecomment-546713559 @candlerb the presto version was just updated recently in master. -

[GitHub] [pulsar] sijie commented on issue #5368: [docs] Contradictory information about what versions of python are supported

2019-10-27 Thread GitBox
sijie commented on issue #5368: [docs] Contradictory information about what versions of python are supported URL: https://github.com/apache/pulsar/issues/5368#issuecomment-546713456 @Jennifer88huang I think @tuteng was looking into fixing the API generation. Can you work with him on this?

[GitHub] [pulsar] sijie commented on issue #5348: Load tls file fail on Windows

2019-10-27 Thread GitBox
sijie commented on issue #5348: Load tls file fail on Windows URL: https://github.com/apache/pulsar/issues/5348#issuecomment-546713051 @liangyuanpeng it seems that you are using the truststore as a keystore. Can you double check if you are using the right keys?

[GitHub] [pulsar] sijie commented on issue #5345: [Doc] Fix doc issues related to BookKeeper, Python Client, and so on

2019-10-27 Thread GitBox
sijie commented on issue #5345: [Doc] Fix doc issues related to BookKeeper, Python Client, and so on URL: https://github.com/apache/pulsar/issues/5345#issuecomment-546712742 @Anonymitaet was this fixed? This is an automated m

[GitHub] [pulsar] sijie commented on issue #5346: bin/pulsar standalone --zookeeper-port 2183 does not work with version 2.4.1

2019-10-27 Thread GitBox
sijie commented on issue #5346: bin/pulsar standalone --zookeeper-port 2183 does not work with version 2.4.1 URL: https://github.com/apache/pulsar/issues/5346#issuecomment-546712836 @ccronemberger did you change standalone.conf (which is the right conf used by pulsar standalone)?

[GitHub] [pulsar] sijie commented on issue #5326: pulsar released package missing configuraion for ranges from bookkie

2019-10-27 Thread GitBox
sijie commented on issue #5326: pulsar released package missing configuraion for ranges from bookkie URL: https://github.com/apache/pulsar/issues/5326#issuecomment-546712571 @hanbo1990 yeah, this should be simple fix. do you want to try to make a contribution to this?

[GitHub] [pulsar] sijie commented on issue #5325: Pulsar on k8s: broker start failure when set functionsWorkerEnabled=true

2019-10-27 Thread GitBox
sijie commented on issue #5325: Pulsar on k8s: broker start failure when set functionsWorkerEnabled=true URL: https://github.com/apache/pulsar/issues/5325#issuecomment-546712469 yeah I think @stupidusername already provided the right solution ---

[GitHub] [pulsar] sijie commented on issue #5311: Mysterious random errorless failures of functions and sinks - only resolved by restarting brokers

2019-10-27 Thread GitBox
sijie commented on issue #5311: Mysterious random errorless failures of functions and sinks - only resolved by restarting brokers URL: https://github.com/apache/pulsar/issues/5311#issuecomment-546712209 @codelipenghui @wolfstudy can you help with this issue? ---

[GitHub] [pulsar] sijie commented on issue #5310: Add meta-data to DLQ

2019-10-27 Thread GitBox
sijie commented on issue #5310: Add meta-data to DLQ URL: https://github.com/apache/pulsar/issues/5310#issuecomment-546711996 @codelipenghui @congbobo184 this is a good feature to add to DLQ This is an automated message from t

[GitHub] [pulsar] sijie commented on issue #5309: [docs] Clarify wording around retention policies

2019-10-27 Thread GitBox
sijie commented on issue #5309: [docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/issues/5309#issuecomment-546711910 /cc @Jennifer88huang @Anonymitaet This is an automated message from the

[GitHub] [pulsar] sijie commented on issue #5309: [docs] Clarify wording around retention policies

2019-10-27 Thread GitBox
sijie commented on issue #5309: [docs] Clarify wording around retention policies URL: https://github.com/apache/pulsar/issues/5309#issuecomment-546711854 @rocketraman your understanding is correct. Can you submit a pull request for it? --

[GitHub] [pulsar] sijie commented on issue #5304: Loading certificates from classpath rather from filesystem

2019-10-27 Thread GitBox
sijie commented on issue #5304: Loading certificates from classpath rather from filesystem URL: https://github.com/apache/pulsar/issues/5304#issuecomment-546711756 @vl185050 can you provide more information about how do you configure the certificates file?

[GitHub] [pulsar] sijie commented on issue #5300: presto connection to pulsar issues

2019-10-27 Thread GitBox
sijie commented on issue #5300: presto connection to pulsar issues URL: https://github.com/apache/pulsar/issues/5300#issuecomment-546711668 @tooptoop4 it seems that you attempted to query topics without schema. The presto integration didn't handle topics without schema. There is a fix in m

[GitHub] [pulsar] sijie commented on issue #5294: Getting errors when creating JWT

2019-10-27 Thread GitBox
sijie commented on issue #5294: Getting errors when creating JWT URL: https://github.com/apache/pulsar/issues/5294#issuecomment-546711508 @Loghijiaha Can you provide the error messages you encountered when you ran the commands? --

[GitHub] [pulsar] sijie commented on issue #5287: presto connector - how to specify cluster (multi broker/zk) connection

2019-10-27 Thread GitBox
sijie commented on issue #5287: presto connector - how to specify cluster (multi broker/zk) connection URL: https://github.com/apache/pulsar/issues/5287#issuecomment-546711363 @zymap can you please help with this question? If this is not documented, can you work with @Jennifer88huang or @A

[GitHub] [pulsar] sijie commented on issue #5285: Schema support for Flatbuffers??

2019-10-27 Thread GitBox
sijie commented on issue #5285: Schema support for Flatbuffers?? URL: https://github.com/apache/pulsar/issues/5285#issuecomment-546711275 @cavanaug As what Matteo pointed out, the serialization and deserialization are only done at the client side. Brokers only deal with the schema d

[GitHub] [pulsar] sijie commented on issue #5274: geo replicated subscribers

2019-10-27 Thread GitBox
sijie commented on issue #5274: geo replicated subscribers URL: https://github.com/apache/pulsar/issues/5274#issuecomment-546710980 @volfco you might check out the replicated subscription introduced in 2.4.0. that can potentially solve you problem. -

[GitHub] [pulsar] sijie commented on issue #5269: Flaky test in DebeziumMySqlSourceTester

2019-10-27 Thread GitBox
sijie commented on issue #5269: Flaky test in DebeziumMySqlSourceTester URL: https://github.com/apache/pulsar/issues/5269#issuecomment-546710846 @tuteng +1 can you try to do what you suggested? This is an automated message fro

[GitHub] [pulsar] sijie commented on issue #5262: pulsar SQL (Presto) can only query data less than 100000

2019-10-27 Thread GitBox
sijie commented on issue #5262: pulsar SQL (Presto) can only query data less than 10 URL: https://github.com/apache/pulsar/issues/5262#issuecomment-546710726 @JointHero what is the retention for your topic? did you set the data retention to long enough so that the data will be

[GitHub] [pulsar] sijie commented on issue #5252: support cloud event

2019-10-27 Thread GitBox
sijie commented on issue #5252: support cloud event URL: https://github.com/apache/pulsar/issues/5252#issuecomment-546709900 @tangxusc there was actually a proposal I sent to cloud events a year ago. we can pick it up again. also if you are interested in contributing this, you are very wel

[GitHub] [pulsar] sijie commented on issue #5458: [cpp-build] Do not install libsnappy at each build

2019-10-27 Thread GitBox
sijie commented on issue #5458: [cpp-build] Do not install libsnappy at each build URL: https://github.com/apache/pulsar/pull/5458#issuecomment-546709375 run java8 tests run integration tests This is an automated message f

[GitHub] [pulsar] sijie commented on a change in pull request #5457: [transaction-coordinator] Ownership change listeners

2019-10-27 Thread GitBox
sijie commented on a change in pull request #5457: [transaction-coordinator] Ownership change listeners URL: https://github.com/apache/pulsar/pull/5457#discussion_r339350441 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java

[GitHub] [pulsar] sijie commented on a change in pull request #5457: [transaction-coordinator] Ownership change listeners

2019-10-27 Thread GitBox
sijie commented on a change in pull request #5457: [transaction-coordinator] Ownership change listeners URL: https://github.com/apache/pulsar/pull/5457#discussion_r339350510 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java

[GitHub] [pulsar] sijie commented on a change in pull request #5457: [transaction-coordinator] Ownership change listeners

2019-10-27 Thread GitBox
sijie commented on a change in pull request #5457: [transaction-coordinator] Ownership change listeners URL: https://github.com/apache/pulsar/pull/5457#discussion_r339350852 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicOwnershipListener.java ##

[GitHub] [pulsar] sijie commented on a change in pull request #5457: [transaction-coordinator] Ownership change listeners

2019-10-27 Thread GitBox
sijie commented on a change in pull request #5457: [transaction-coordinator] Ownership change listeners URL: https://github.com/apache/pulsar/pull/5457#discussion_r339350289 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceBundleOwnershipListene

[GitHub] [pulsar] sijie closed pull request #5464: [Issue 5387] Update Netty version for improving memory usage

2019-10-27 Thread GitBox
sijie closed pull request #5464: [Issue 5387] Update Netty version for improving memory usage URL: https://github.com/apache/pulsar/pull/5464 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] sijie commented on issue #5464: [Issue 5387] Update Netty version for improving memory usage

2019-10-27 Thread GitBox
sijie commented on issue #5464: [Issue 5387] Update Netty version for improving memory usage URL: https://github.com/apache/pulsar/pull/5464#issuecomment-546707748 The netty version is already upgraded as part of #3613 This

[GitHub] [pulsar] sijie commented on issue #5466: move general schema hash to common module

2019-10-27 Thread GitBox
sijie commented on issue #5466: move general schema hash to common module URL: https://github.com/apache/pulsar/pull/5466#issuecomment-546707546 run java8 tests run cpp tests This is an automated message from the Apache Git

[GitHub] [pulsar] sijie commented on issue #5469: added deletion of state for Functions

2019-10-27 Thread GitBox
sijie commented on issue #5469: added deletion of state for Functions URL: https://github.com/apache/pulsar/pull/5469#issuecomment-546707425 > Would you like to see that in this PR or is a separate PR alright? A separate PR is good. // run integration tests ---

[GitHub] [pulsar] sijie commented on a change in pull request #5470: Adding Spark example to Write Pojo classes to Stream

2019-10-27 Thread GitBox
sijie commented on a change in pull request #5470: Adding Spark example to Write Pojo classes to Stream URL: https://github.com/apache/pulsar/pull/5470#discussion_r339349828 ## File path: examples/spark/src/main/java/org/apache/spark/streaming/receiver/example/ProducerSparkWithPoj

[GitHub] [pulsar] sijie commented on a change in pull request #5470: Adding Spark example to Write Pojo classes to Stream

2019-10-27 Thread GitBox
sijie commented on a change in pull request #5470: Adding Spark example to Write Pojo classes to Stream URL: https://github.com/apache/pulsar/pull/5470#discussion_r339349789 ## File path: docker-compose/standalone-dashboard/docker-compose.yml ## @@ -23,9 +23,9 @@ services

[GitHub] [pulsar] sijie commented on a change in pull request #5357: [functions][Issue:5350]Fix pulsar can't load the customized SerDe

2019-10-27 Thread GitBox
sijie commented on a change in pull request #5357: [functions][Issue:5350]Fix pulsar can't load the customized SerDe URL: https://github.com/apache/pulsar/pull/5357#discussion_r339349691 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/TopicS

[GitHub] [pulsar] sijie commented on a change in pull request #5357: [functions][Issue:5350]Fix pulsar can't load the customized SerDe

2019-10-27 Thread GitBox
sijie commented on a change in pull request #5357: [functions][Issue:5350]Fix pulsar can't load the customized SerDe URL: https://github.com/apache/pulsar/pull/5357#discussion_r339349701 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/Pul

[GitHub] [pulsar] sijie commented on issue #5472: Make some common use method of ManagedLedger public

2019-10-27 Thread GitBox
sijie commented on issue #5472: Make some common use method of ManagedLedger public URL: https://github.com/apache/pulsar/pull/5472#issuecomment-546706658 run cpp tests This is an automated message from the Apache Git Service

[GitHub] [pulsar] sijie merged pull request #5473: put protocol handler start after loadmanagement service

2019-10-27 Thread GitBox
sijie merged pull request #5473: put protocol handler start after loadmanagement service URL: https://github.com/apache/pulsar/pull/5473 This is an automated message from the Apache Git Service. To respond to the message, pl

[pulsar] branch master updated (43984ba -> 6fb5fd2)

2019-10-27 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 43984ba Update resources.js (#5468) add 6fb5fd2 put protocol handler after loadmanagement (#5473) No new revis

[GitHub] [pulsar] sijie commented on issue #5467: [website] Update PMC and committer info in team.js

2019-10-27 Thread GitBox
sijie commented on issue #5467: [website] Update PMC and committer info in team.js URL: https://github.com/apache/pulsar/pull/5467#issuecomment-546706340 run java8 tests This is an automated message from the Apache Git Servic

[GitHub] [pulsar] jiazhai opened a new pull request #5473: put protocol handler start after loadmanagement service

2019-10-27 Thread GitBox
jiazhai opened a new pull request #5473: put protocol handler start after loadmanagement service URL: https://github.com/apache/pulsar/pull/5473 Pulsar service is available only after loadmanagement service is started, or user will meet error of bundle service errors when access pulsar ser

[GitHub] [pulsar] jiazhai opened a new pull request #5472: Make some common use method of ManagedLedger public

2019-10-27 Thread GitBox
jiazhai opened a new pull request #5472: Make some common use method of ManagedLedger public URL: https://github.com/apache/pulsar/pull/5472 Some of the ManagedLedger methods, such as hasMoreEntries/getPreviousPosition/getNextValidPosition, are protected. This change try to make them publ