[GitHub] [pulsar] wolfstudy opened a new pull request #6974: Fix 2.4.0 missing docs of cgo client

2020-05-17 Thread GitBox
wolfstudy opened a new pull request #6974: URL: https://github.com/apache/pulsar/pull/6974 Signed-off-by: xiaolong.ran ### Motivation Fix 2.4.0 missing docs of cgo client This is an automated me

[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #251: Expose replicated from filed on message struct

2020-05-17 Thread GitBox
wolfstudy opened a new pull request #251: URL: https://github.com/apache/pulsar-client-go/pull/251 Signed-off-by: xiaolong.ran Master Issue: #243 ### Motivation - Expose isReplicated and replicatedFrom for Pulsar message ### Modifications - Add `replicate

[GitHub] [pulsar-client-go] yarthur1 commented on pull request #249: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-17 Thread GitBox
yarthur1 commented on pull request #249: URL: https://github.com/apache/pulsar-client-go/pull/249#issuecomment-629813082 I hope that both before send and time wait for response should check timeout.I don't want to wait send func always,because I meet this situation where pulsar broker has

[GitHub] [pulsar-client-go] merlimat merged pull request #251: Expose replicated from filed on message struct

2020-05-17 Thread GitBox
merlimat merged pull request #251: URL: https://github.com/apache/pulsar-client-go/pull/251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[pulsar-client-go] branch master updated: Expose replicated from filed on message struct (#251)

2020-05-17 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new e1c3822 Expose replicated from filed

[GitHub] [pulsar-client-go] WJL3333 opened a new pull request #252: Add checkout by context

2020-05-17 Thread GitBox
WJL opened a new pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252 <-- ### Contribution Checklist - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.

[GitHub] [pulsar-client-go] WJL3333 closed pull request #249: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-17 Thread GitBox
WJL closed pull request #249: URL: https://github.com/apache/pulsar-client-go/pull/249 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-client-go] WJL3333 commented on pull request #249: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-17 Thread GitBox
WJL commented on pull request #249: URL: https://github.com/apache/pulsar-client-go/pull/249#issuecomment-629815523 closed and goto https://github.com/apache/pulsar-client-go/pull/252 This is an automated message from the

[GitHub] [pulsar-client-go] wolfstudy closed issue #243: Expose isReplicated and replicatedFrom for Pulsar message.

2020-05-17 Thread GitBox
wolfstudy closed issue #243: URL: https://github.com/apache/pulsar-client-go/issues/243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-client-go] wolfstudy commented on issue #243: Expose isReplicated and replicatedFrom for Pulsar message.

2020-05-17 Thread GitBox
wolfstudy commented on issue #243: URL: https://github.com/apache/pulsar-client-go/issues/243#issuecomment-629817978 The feature will be impled in @251 This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar-client-go] rueian commented on a change in pull request #248: Call pending callbacks of connection after run loop stopped (#239)

2020-05-17 Thread GitBox
rueian commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r426214384 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")

[GitHub] [pulsar-client-go] rueian commented on a change in pull request #248: Call pending callbacks of connection after run loop stopped (#239)

2020-05-17 Thread GitBox
rueian commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r426214384 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")

[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-17 Thread GitBox
merlimat commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r426287863 ## File path: pulsar/internal/blocking_queue.go ## @@ -34,6 +34,11 @@ type BlockingQueue interface { // Poll dequeue one item, return nil

[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #6974: Fix 2.4.0 missing docs of cgo client

2020-05-17 Thread GitBox
Huanli-Meng commented on a change in pull request #6974: URL: https://github.com/apache/pulsar/pull/6974#discussion_r426329764 ## File path: site2/website/versioned_docs/version-2.4.0/client-libraries-go.md ## @@ -90,6 +90,21 @@ func main() { } ``` +### Client operations +

[GitHub] [pulsar] jiazhai commented on issue #6961: Borderline too big messages hangs topic

2020-05-17 Thread GitBox
jiazhai commented on issue #6961: URL: https://github.com/apache/pulsar/issues/6961#issuecomment-629900774 Hi @baynes What is the broker side log shows? In broker.conf, there is an item: ``` # Max size of messages. maxMessageSize=5242880 ``` Usually you need to config it

[GitHub] [pulsar] jiazhai commented on issue #6960: Duplicated messages are sent to dead letter topic

2020-05-17 Thread GitBox
jiazhai commented on issue #6960: URL: https://github.com/apache/pulsar/issues/6960#issuecomment-629902251 @bigbang489 Thanks for reporting this issue, Could this be stable reproduced? It would be appreciate if you could provide your code example to reproduce it. -

[GitHub] [pulsar] cckellogg commented on a change in pull request #6972: Add Annotations for config validation checking

2020-05-17 Thread GitBox
cckellogg commented on a change in pull request #6972: URL: https://github.com/apache/pulsar/pull/6972#discussion_r426335178 ## File path: pulsar-common/src/test/java/org/apache/pulsar/common/validator/ConfigValidationTest.java ## @@ -0,0 +1,148 @@ +/** + * Licensed to the Apa

[GitHub] [pulsar] jiazhai commented on issue #6962: Pulsar Admin API / Incomplete OpenAPI Spec

2020-05-17 Thread GitBox
jiazhai commented on issue #6962: URL: https://github.com/apache/pulsar/issues/6962#issuecomment-629903935 @gotopanic Thanks for reporting this issue. Would you like to contribute to it? This is an automated message from the

[GitHub] [pulsar] jiazhai commented on issue #6965: Consumer pause do not work

2020-05-17 Thread GitBox
jiazhai commented on issue #6965: URL: https://github.com/apache/pulsar/issues/6965#issuecomment-629904860 @youzipi Thanks for reporting this issue. We will take a look into it. This is an automated message from the Apache G

[GitHub] [pulsar] jiazhai commented on issue #6967: pulsar cli option documented but the code is not in the 2.5 branche

2020-05-17 Thread GitBox
jiazhai commented on issue #6967: URL: https://github.com/apache/pulsar/issues/6967#issuecomment-629906423 @Mefl Thanks for the issue reporting. Looks like this is a bug in doc release. Seems 2.5.1 doc included content that should not be included. @Mefl Would you like to help fix this do

[GitHub] [pulsar] jiazhai commented on issue #6967: pulsar cli option documented but the code is not in the 2.5 branche

2020-05-17 Thread GitBox
jiazhai commented on issue #6967: URL: https://github.com/apache/pulsar/issues/6967#issuecomment-629906508 also @tuteng who is the release manager of 2.5.1. This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] jiazhai commented on issue #6969: Brokers crash if all bookies are full

2020-05-17 Thread GitBox
jiazhai commented on issue #6969: URL: https://github.com/apache/pulsar/issues/6969#issuecomment-629908155 @trexinc Thanks for the reporting of this issue. Would you please help collect the broker logs when this error happens. -

[GitHub] [pulsar-client-go] jiazhai commented on issue #250: SDK crashes on ARM

2020-05-17 Thread GitBox
jiazhai commented on issue #250: URL: https://github.com/apache/pulsar-client-go/issues/250#issuecomment-629909658 @wolfstudy Would you please help take a look? This is an automated message from the Apache Git Service. To re

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #248: Call pending callbacks of connection after run loop stopped (#239)

2020-05-17 Thread GitBox
cckellogg commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r426339996 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")

[GitHub] [pulsar] jiazhai commented on pull request #6966: [broker] Fix bug that causes delivery of messages to stop on Shared subscription

2020-05-17 Thread GitBox
jiazhai commented on pull request #6966: URL: https://github.com/apache/pulsar/pull/6966#issuecomment-629914223 @massakam Since 2.5.2 was send out for vote, could we add it to 2.5.3? This is an automated message from the Apac

[GitHub] [pulsar] jiazhai edited a comment on pull request #6471: [Issue #5395][broker] Implement AutoTopicCreation by namespace override

2020-05-17 Thread GitBox
jiazhai edited a comment on pull request #6471: URL: https://github.com/apache/pulsar/pull/6471#issuecomment-625732030 For merge conflict. mark as 2.5.2 and cherry-picked into branch-2.5 This is an automated message from the

[GitHub] [pulsar-client-go] zr-hebo opened a new pull request #253: Improve go client sending performance

2020-05-17 Thread GitBox
zr-hebo opened a new pull request #253: URL: https://github.com/apache/pulsar-client-go/pull/253 Improve the sending performance to 5 message per second, by - Add buffer pool, avoid make slice every time need getting buffer; - Increased buffer size in various place.

[GitHub] [pulsar] srkukarni commented on a change in pull request #6972: Add Annotations for config validation checking

2020-05-17 Thread GitBox
srkukarni commented on a change in pull request #6972: URL: https://github.com/apache/pulsar/pull/6972#discussion_r426348720 ## File path: pulsar-common/src/test/java/org/apache/pulsar/common/validator/ConfigValidationTest.java ## @@ -0,0 +1,148 @@ +/** + * Licensed to the Apa

[GitHub] [pulsar] massakam commented on pull request #6966: [broker] Fix bug that causes delivery of messages to stop on Shared subscription

2020-05-17 Thread GitBox
massakam commented on pull request #6966: URL: https://github.com/apache/pulsar/pull/6966#issuecomment-629921280 @jiazhai Okay. Changed the release label to 2.5.3. This is an automated message from the Apache Git Service. To

[GitHub] [pulsar-client-go] rueian commented on a change in pull request #248: Call pending callbacks of connection after run loop stopped (#239)

2020-05-17 Thread GitBox
rueian commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r426358653 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")

[GitHub] [pulsar] lukestephenson commented on issue #6950: loadBalancerSourceRanges on helm templates for pulsar manager and grafana

2020-05-17 Thread GitBox
lukestephenson commented on issue #6950: URL: https://github.com/apache/pulsar/issues/6950#issuecomment-629935323 @sijie Thanks for pointing me at the new repo. When will the new repo become the official one that the pulsar deployment docs are pointed to? Thanks

[GitHub] [pulsar-client-go] wolfstudy commented on issue #188: Is this project support "if one pulsar broker dead,the request will request other brokers"

2020-05-17 Thread GitBox
wolfstudy commented on issue #188: URL: https://github.com/apache/pulsar-client-go/issues/188#issuecomment-629945755 @zxbfeng As @cckellogg said, will close this issue, If there is any problem please reopen it This is a

[GitHub] [pulsar-client-go] wolfstudy closed issue #188: Is this project support "if one pulsar broker dead,the request will request other brokers"

2020-05-17 Thread GitBox
wolfstudy closed issue #188: URL: https://github.com/apache/pulsar-client-go/issues/188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-client-go] WJL3333 commented on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-17 Thread GitBox
WJL commented on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-629949404 hi,this pr has some bad test case,i'm working on it. any suggestions?i'm new to unit test. This is an au

[pulsar-client-go] branch master updated (e1c3822 -> bc647c6)

2020-05-17 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git. from e1c3822 Expose replicated from filed on message struct (#251) add bc647c6 Fix data race when accessing

[GitHub] [pulsar-client-go] wolfstudy merged pull request #215: [Issue 213] Fix data race when accessing partition producer state

2020-05-17 Thread GitBox
wolfstudy merged pull request #215: URL: https://github.com/apache/pulsar-client-go/pull/215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-client-go] wolfstudy closed issue #213: Race access of partitionProducer.state

2020-05-17 Thread GitBox
wolfstudy closed issue #213: URL: https://github.com/apache/pulsar-client-go/issues/213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-client-go] WJL3333 edited a comment on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-17 Thread GitBox
WJL edited a comment on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-629949404 hi, this pr has some bad test case, i'm working on it. any suggestions?i'm new to unit test. and i found in some case send timeout is a bit longer then expect. t

[pulsar] branch master updated: Modify ThreadRuntime to allow custom secrets providers (#6971)

2020-05-17 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7a76954 Modify ThreadRuntime to allow custom

[GitHub] [pulsar] jerrypeng merged pull request #6971: Modify ThreadRuntime to allow custom secrets providers

2020-05-17 Thread GitBox
jerrypeng merged pull request #6971: URL: https://github.com/apache/pulsar/pull/6971 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] wolfstudy merged pull request #6974: Fix 2.4.0 missing docs of cgo client

2020-05-17 Thread GitBox
wolfstudy merged pull request #6974: URL: https://github.com/apache/pulsar/pull/6974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated (7a76954 -> f5223fc)

2020-05-17 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 7a76954 Modify ThreadRuntime to allow custom secrets providers (#6971) add f5223fc Fix 2.4.0 missing docs of cgo

[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #254: Fix send async comments

2020-05-17 Thread GitBox
wolfstudy opened a new pull request #254: URL: https://github.com/apache/pulsar-client-go/pull/254 Fixes #208 ### Motivation - Fix send async comments This is an automated message fr

[GitHub] [pulsar-client-go] wolfstudy commented on issue #223: Reader can not read new messages after subscribing with LatestMessageID

2020-05-17 Thread GitBox
wolfstudy commented on issue #223: URL: https://github.com/apache/pulsar-client-go/issues/223#issuecomment-629962535 > I expect to be able to read `hello-1` as latest message somehow, since it's the latest message. Your code using `EarliestMessageID()` will read the `hello-0` message.

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-17 Thread GitBox
wolfstudy commented on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-629964211 > hi, this pr has some bad test case, i'm working on it. any suggestions?i'm new to unit test. > and i found in some case send timeout is a bit longer then expect. tr

[GitHub] [pulsar-client-go] dsmlily closed issue #155: The availablePermits of the topic is twice as much as the consumer.ReceiverQueueSize

2020-05-17 Thread GitBox
dsmlily closed issue #155: URL: https://github.com/apache/pulsar-client-go/issues/155 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar-client-go] Anonymitaet commented on a change in pull request #254: Fix send async comments

2020-05-17 Thread GitBox
Anonymitaet commented on a change in pull request #254: URL: https://github.com/apache/pulsar-client-go/pull/254#discussion_r426388616 ## File path: pulsar/producer.go ## @@ -128,6 +128,8 @@ type Producer interface { Send(context.Context, *ProducerMessage) (MessageID, e

[GitHub] [pulsar] jiazhai commented on a change in pull request #6684: Support function with format: Function>

2020-05-17 Thread GitBox
jiazhai commented on a change in pull request #6684: URL: https://github.com/apache/pulsar/pull/6684#discussion_r426390027 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstance.java ## @@ -40,9 +45,18 @@ private Function f

[GitHub] [pulsar-client-go] Anonymitaet commented on a change in pull request #254: Fix send async comments

2020-05-17 Thread GitBox
Anonymitaet commented on a change in pull request #254: URL: https://github.com/apache/pulsar-client-go/pull/254#discussion_r426388616 ## File path: pulsar/producer.go ## @@ -128,6 +128,8 @@ type Producer interface { Send(context.Context, *ProducerMessage) (MessageID, e

[GitHub] [pulsar-client-go] wolfstudy merged pull request #254: Fix send async comments

2020-05-17 Thread GitBox
wolfstudy merged pull request #254: URL: https://github.com/apache/pulsar-client-go/pull/254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[pulsar-client-go] branch master updated: Fix send async comments (#254)

2020-05-17 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 77f0806 Fix send async comments (#254) 7

[GitHub] [pulsar-client-go] wolfstudy closed issue #208: Support `producer.SendAsync` not blocking if queue is full

2020-05-17 Thread GitBox
wolfstudy closed issue #208: URL: https://github.com/apache/pulsar-client-go/issues/208 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-client-go] wolfstudy commented on issue #241: HasNext returns false when message is available

2020-05-17 Thread GitBox
wolfstudy commented on issue #241: URL: https://github.com/apache/pulsar-client-go/issues/241#issuecomment-629976251 You can try to use the following code example: ``` consumer, err := client.CreateReader(pulsar.ReaderOptions{ Topic: "persistent://public/defau

[GitHub] [pulsar] Huanli-Meng commented on issue #6110: [Doc 2.5.0] The content of Connector Admin CLI is blank

2020-05-17 Thread GitBox
Huanli-Meng commented on issue #6110: URL: https://github.com/apache/pulsar/issues/6110#issuecomment-629981440 it seems this bug is fixed. in 2.5.0 and later releases, "connector Admin CLI" is moved from reference section to Pulsar IO connection. and the doc name is changed from "connector

[GitHub] [pulsar] youzipi commented on issue #6965: Consumer pause do not work

2020-05-17 Thread GitBox
youzipi commented on issue #6965: URL: https://github.com/apache/pulsar/issues/6965#issuecomment-629982830 I checked the UT `org.apache.pulsar.client.api.SimpleProducerConsumerTest#testPauseAndResume` ```java log.info("Giving message listener an opportunity to receive messages

[GitHub] [pulsar] youzipi edited a comment on issue #6965: Consumer pause do not work

2020-05-17 Thread GitBox
youzipi edited a comment on issue #6965: URL: https://github.com/apache/pulsar/issues/6965#issuecomment-629982830 I checked the UT `org.apache.pulsar.client.api.SimpleProducerConsumerTest#testPauseAndResume` ```java log.info("Giving message listener an opportunity to receive me