[GitHub] [pulsar] Anonymitaet commented on issue #6882: 2.5.1 documentation contains the out-of-date documentation of kubernetes deployment

2020-05-20 Thread GitBox
Anonymitaet commented on issue #6882: URL: https://github.com/apache/pulsar/issues/6882#issuecomment-631918952 @Huanli-Meng Since you worked on this issue and discussed w/ sijie before, could u pls double-check the issue status? thanks -

[GitHub] [pulsar] huangdx0726 commented on pull request #5716: [Issues 5709]remove the namespace checking

2020-05-20 Thread GitBox
huangdx0726 commented on pull request #5716: URL: https://github.com/apache/pulsar/pull/5716#issuecomment-631917063 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] srkukarni opened a new pull request #7010: Fix null pointer when getting function instance metrics.

2020-05-20 Thread GitBox
srkukarni opened a new pull request #7010: URL: https://github.com/apache/pulsar/pull/7010 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] snowcrumble commented on a change in pull request #6023: [pulsar-client-go]Add DeliverAfter option for go client

2020-05-20 Thread GitBox
snowcrumble commented on a change in pull request #6023: URL: https://github.com/apache/pulsar/pull/6023#discussion_r428475163 ## File path: pulsar-client-go/pulsar/producer_test.go ## @@ -416,3 +416,71 @@ func TestProducer_SendAndGetMsgID(t *testing.T) { assert

[GitHub] [pulsar] snowcrumble commented on a change in pull request #6023: [pulsar-client-go]Add DeliverAfter option for go client

2020-05-20 Thread GitBox
snowcrumble commented on a change in pull request #6023: URL: https://github.com/apache/pulsar/pull/6023#discussion_r428473920 ## File path: pulsar-client-go/pulsar/producer_test.go ## @@ -416,3 +416,71 @@ func TestProducer_SendAndGetMsgID(t *testing.T) { assert

[GitHub] [pulsar] srkukarni opened a new pull request #7009: Fix swagger annotations for builtin sources/sinks rest api

2020-05-20 Thread GitBox
srkukarni opened a new pull request #7009: URL: https://github.com/apache/pulsar/pull/7009 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] cckellogg opened a new pull request #7008: Fix possible null pointer when getting instance metrics.

2020-05-20 Thread GitBox
cckellogg opened a new pull request #7008: URL: https://github.com/apache/pulsar/pull/7008 Fix issue in the ThreadRuntime where the instance will throw a null pointer exception when asked for metrics. ``` 0521 04:13:50 INFO | "javaInstanceRunnable null

[GitHub] [pulsar] zplinuxlover commented on pull request #6903: PIP-61: Advertise multiple addresses

2020-05-20 Thread GitBox
zplinuxlover commented on pull request #6903: URL: https://github.com/apache/pulsar/pull/6903#issuecomment-631899841 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the me

[pulsar-client-go] branch master updated: fix: wrong target (#256)

2020-05-20 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 7055076 fix: wrong target (#256) 7055

[GitHub] [pulsar-client-go] merlimat merged pull request #256: Fix perf-producer target

2020-05-20 Thread GitBox
merlimat merged pull request #256: URL: https://github.com/apache/pulsar-client-go/pull/256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pulsar-client-go] jonyhy96 commented on pull request #256: Fix perf-producer target

2020-05-20 Thread GitBox
jonyhy96 commented on pull request #256: URL: https://github.com/apache/pulsar-client-go/pull/256#issuecomment-631876799 /cc @wolfstudy This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [pulsar-client-go] WJL3333 commented on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-631875982 @merlimat @cckellogg @jerrypeng @wolfstudy i think the code works fine now. could you take a look.some logic rewrited.

[GitHub] [pulsar-client-go] jonyhy96 opened a new pull request #256: Fix perf-producer target

2020-05-20 Thread GitBox
jonyhy96 opened a new pull request #256: URL: https://github.com/apache/pulsar-client-go/pull/256 Signed-off-by: haoyun ### Motivation Fix the wrong target in perf-producer ### Modifications - Change the target of quantile in perf-producer from 0.90 to 0.50 ---

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-631864693 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-631862526 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] xuesong172500 opened a new pull request #7007: issue #6698, Add instantiation interface in Pulsar function (#6706)

2020-05-20 Thread GitBox
xuesong172500 opened a new pull request #7007: URL: https://github.com/apache/pulsar/pull/7007 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes #6698 (or if this PR is one task of a github issue, please add Master Issue: # to link to the master issue.)

[GitHub] [pulsar-client-go] yarthur1 commented on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
yarthur1 commented on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-631855578 @WJL Based on your comit,I have modified something,can you check it? https://github.com/WJL/pulsar-client-go/pull/1 --

[GitHub] [pulsar-client-go] yarthur1 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
yarthur1 commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428423636 ## File path: pulsar/internal/blocking_queue.go ## @@ -131,6 +139,21 @@ func (bq *blockingQueue) Poll() interface{} { return bq.dequeue()

[GitHub] [pulsar] jiazhai closed issue #7001: The `managedLedgerMaxEntriesPerLedger` parameter does not take effect

2020-05-20 Thread GitBox
jiazhai closed issue #7001: URL: https://github.com/apache/pulsar/issues/7001 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] jiazhai commented on issue #7001: The `managedLedgerMaxEntriesPerLedger` parameter does not take effect

2020-05-20 Thread GitBox
jiazhai commented on issue #7001: URL: https://github.com/apache/pulsar/issues/7001#issuecomment-631854513 both of them take effect. it is aimed to not rollover ledgers too frequently. This is an automated message from the

[GitHub] [pulsar] jiazhai commented on issue #7000: Offload data from bk to aws-s3 error on 2.5.2

2020-05-20 Thread GitBox
jiazhai commented on issue #7000: URL: https://github.com/apache/pulsar/issues/7000#issuecomment-631853378 Seems this is Root Caused by @codelipenghui and @gaoran10 . Would you please help paste the founding? This is an aut

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-631851508 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] xuesong172500 opened a new pull request #7006: issue #6698, Add instantiation interface in Pulsar function (#6706)

2020-05-20 Thread GitBox
xuesong172500 opened a new pull request #7006: URL: https://github.com/apache/pulsar/pull/7006 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] zplinuxlover commented on pull request #6903: PIP-61: Advertise multiple addresses

2020-05-20 Thread GitBox
zplinuxlover commented on pull request #6903: URL: https://github.com/apache/pulsar/pull/6903#issuecomment-631846330 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] codelipenghui commented on pull request #6977: Introduce messages fence mechanism for Key_Shared subscription

2020-05-20 Thread GitBox
codelipenghui commented on pull request #6977: URL: https://github.com/apache/pulsar/pull/6977#issuecomment-631836725 @merlimat I have added a pointer to indicate where the consumer joined and if the pointer has been mark deleted, the dispatcher dispatch messages to the consumer. The fence

[GitHub] [pulsar] sijie closed pull request #6801: [functions] Don't auth functions worker metrics endpoint

2020-05-20 Thread GitBox
sijie closed pull request #6801: URL: https://github.com/apache/pulsar/pull/6801 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-client-go] zr-hebo closed pull request #253: Improve go client sending performance

2020-05-20 Thread GitBox
zr-hebo closed pull request #253: URL: https://github.com/apache/pulsar-client-go/pull/253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-client-go] zr-hebo commented on pull request #253: Improve go client sending performance

2020-05-20 Thread GitBox
zr-hebo commented on pull request #253: URL: https://github.com/apache/pulsar-client-go/pull/253#issuecomment-631830729 I will do more benchmark, and commit PR if necessary. This is an automated message from the Apache Git Se

[GitHub] [pulsar-client-go] zr-hebo commented on pull request #253: Improve go client sending performance

2020-05-20 Thread GitBox
zr-hebo commented on pull request #253: URL: https://github.com/apache/pulsar-client-go/pull/253#issuecomment-631830230 > > Improve the sending performance to 5 message per second, by > > Have you tried to benchmark the client using non-persistent topics? I did benchmark an

[GitHub] [pulsar] zplinuxlover commented on pull request #6903: PIP-61: Advertise multiple addresses

2020-05-20 Thread GitBox
zplinuxlover commented on pull request #6903: URL: https://github.com/apache/pulsar/pull/6903#issuecomment-631825192 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] xgdgsc commented on issue #6981: copy webpage doc code includes "$"

2020-05-20 Thread GitBox
xgdgsc commented on issue #6981: URL: https://github.com/apache/pulsar/issues/6981#issuecomment-631817472 https://github.com/facebook/docusaurus/issues/1745 Then I would remove all the $? This is an automated message from th

[GitHub] [pulsar] nicolo-paganin commented on pull request #6895: [#6003][pulsar-functions] Possibility to add builtin Functions

2020-05-20 Thread GitBox
nicolo-paganin commented on pull request #6895: URL: https://github.com/apache/pulsar/pull/6895#issuecomment-631802090 @codelipenghui I think I need some help, there are 5 CI tests that I really don't know.. something that I never modified.. ---

[GitHub] [pulsar] srkukarni commented on pull request #6983: Added ability to add annotations to Connector Configs

2020-05-20 Thread GitBox
srkukarni commented on pull request #6983: URL: https://github.com/apache/pulsar/pull/6983#issuecomment-631759029 @jerrypeng wrt your comment on the correct interface, yes in hindsight it does seem as if we should have had an explicit config class in the open. Almost all of the connectors

[GitHub] [pulsar] srkukarni commented on a change in pull request #6983: Added ability to add annotations to Connector Configs

2020-05-20 Thread GitBox
srkukarni commented on a change in pull request #6983: URL: https://github.com/apache/pulsar/pull/6983#discussion_r428338513 ## File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfigUtils.java ## @@ -580,4 +595,24 @@ public static SinkConf

[GitHub] [pulsar] jerrypeng edited a comment on pull request #6983: Added ability to add annotations to Connector Configs

2020-05-20 Thread GitBox
jerrypeng edited a comment on pull request #6983: URL: https://github.com/apache/pulsar/pull/6983#issuecomment-631748364 @srkukarni thinking more about it, I am wondering for sources and sinks whether the following interface is appropriate now that we formalized the concept of a connector

[GitHub] [pulsar] jerrypeng commented on pull request #6983: Added ability to add annotations to Connector Configs

2020-05-20 Thread GitBox
jerrypeng commented on pull request #6983: URL: https://github.com/apache/pulsar/pull/6983#issuecomment-631748364 @srkukarni thinking more about it, I am wondering for sources and sinks whether the following interface is appropriate now that we formalized the concept of a connector config.

[GitHub] [pulsar] jerrypeng commented on a change in pull request #6983: Added ability to add annotations to Connector Configs

2020-05-20 Thread GitBox
jerrypeng commented on a change in pull request #6983: URL: https://github.com/apache/pulsar/pull/6983#discussion_r428328609 ## File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfigUtils.java ## @@ -580,4 +595,24 @@ public static SinkConf

[GitHub] [pulsar] jerrypeng commented on a change in pull request #6983: Added ability to add annotations to Connector Configs

2020-05-20 Thread GitBox
jerrypeng commented on a change in pull request #6983: URL: https://github.com/apache/pulsar/pull/6983#discussion_r428327699 ## File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfigUtils.java ## @@ -580,4 +595,24 @@ public static SinkConf

[GitHub] [pulsar] jerrypeng commented on pull request #6993: Secrets provider should be initialized for each new function

2020-05-20 Thread GitBox
jerrypeng commented on pull request #6993: URL: https://github.com/apache/pulsar/pull/6993#issuecomment-631742352 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] jerrypeng commented on pull request #6993: Secrets provider should be initialized for each new function

2020-05-20 Thread GitBox
jerrypeng commented on pull request #6993: URL: https://github.com/apache/pulsar/pull/6993#issuecomment-631688523 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] rounak11 commented on issue #6236: SSL/TLS Configuration for Zookeeper,BookKeeper and Pulsar

2020-05-20 Thread GitBox
rounak11 commented on issue #6236: URL: https://github.com/apache/pulsar/issues/6236#issuecomment-631656687 @hari819 Can you please share zk config with PEM configuration. This is an automated message from the Apache Git Serv

[GitHub] [pulsar-client-go] WJL3333 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428220361 ## File path: pulsar/internal/blocking_queue.go ## @@ -131,6 +139,21 @@ func (bq *blockingQueue) Poll() interface{} { return bq.dequeue()

[GitHub] [pulsar-client-go] WJL3333 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428223019 ## File path: pulsar/internal/blocking_queue.go ## @@ -131,6 +139,21 @@ func (bq *blockingQueue) Poll() interface{} { return bq.dequeue()

[GitHub] [pulsar] jerrypeng commented on pull request #6993: Secrets provider should be initialized for each new function

2020-05-20 Thread GitBox
jerrypeng commented on pull request #6993: URL: https://github.com/apache/pulsar/pull/6993#issuecomment-631648857 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar-client-go] WJL3333 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428220361 ## File path: pulsar/internal/blocking_queue.go ## @@ -131,6 +139,21 @@ func (bq *blockingQueue) Poll() interface{} { return bq.dequeue()

[GitHub] [pulsar-client-go] WJL3333 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428215256 ## File path: pulsar/producer_partition.go ## @@ -299,12 +333,57 @@ func (p *partitionProducer) internalSend(request *sendRequest) { } }

[GitHub] [pulsar-client-go] WJL3333 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428214592 ## File path: pulsar/producer_partition.go ## @@ -493,11 +637,100 @@ func (p *partitionProducer) Close() { wg.Wait() } +func (p *partiti

[GitHub] [pulsar-client-go] WJL3333 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428214995 ## File path: pulsar/producer_partition.go ## @@ -299,12 +333,57 @@ func (p *partitionProducer) internalSend(request *sendRequest) { } }

[GitHub] [pulsar-client-go] WJL3333 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428214744 ## File path: pulsar/producer_partition.go ## @@ -343,94 +444,136 @@ func (p *partitionProducer) internalFlush(fr *flushRequest) {

[GitHub] [pulsar-client-go] WJL3333 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428214034 ## File path: pulsar/producer_partition.go ## @@ -343,94 +444,136 @@ func (p *partitionProducer) internalFlush(fr *flushRequest) {

[GitHub] [pulsar-client-go] WJL3333 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428214286 ## File path: pulsar/producer_partition.go ## @@ -343,94 +444,136 @@ func (p *partitionProducer) internalFlush(fr *flushRequest) {

[GitHub] [pulsar-client-go] WJL3333 commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
WJL commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428213897 ## File path: pulsar/internal/blocking_queue.go ## @@ -141,6 +164,16 @@ func (bq *blockingQueue) Peek() interface{} { return bq.items[bq.he

[GitHub] [pulsar] jerrypeng commented on pull request #6993: Secrets provider should be initialized for each new function

2020-05-20 Thread GitBox
jerrypeng commented on pull request #6993: URL: https://github.com/apache/pulsar/pull/6993#issuecomment-631621529 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] wolfstudy commented on pull request #6993: Secrets provider should be initialized for each new function

2020-05-20 Thread GitBox
wolfstudy commented on pull request #6993: URL: https://github.com/apache/pulsar/pull/6993#issuecomment-631614046 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] wolfstudy commented on a change in pull request #6023: [pulsar-client-go]Add DeliverAfter option for go client

2020-05-20 Thread GitBox
wolfstudy commented on a change in pull request #6023: URL: https://github.com/apache/pulsar/pull/6023#discussion_r428176058 ## File path: pulsar-client-go/pulsar/producer_test.go ## @@ -416,3 +416,71 @@ func TestProducer_SendAndGetMsgID(t *testing.T) { assert.N

[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-20 Thread GitBox
merlimat commented on a change in pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#discussion_r428177301 ## File path: pulsar/internal/blocking_queue.go ## @@ -131,6 +139,21 @@ func (bq *blockingQueue) Poll() interface{} { return bq.dequeue()

[GitHub] [pulsar] merlimat commented on pull request #6977: Introduce messages fence mechanism for Key_Shared subscription

2020-05-20 Thread GitBox
merlimat commented on pull request #6977: URL: https://github.com/apache/pulsar/pull/6977#issuecomment-631604909 @codelipenghui This is not quite what I was describing in the comment. I don't think it's desirable to "fence" the individual messages, rather just keeping a pointer to where th

[GitHub] [pulsar] wolfstudy commented on issue #4752: [docs] Add Go SerDe option

2020-05-20 Thread GitBox
wolfstudy commented on issue #4752: URL: https://github.com/apache/pulsar/issues/4752#issuecomment-631604298 > @wolfstudy Could you please help double-check is the SerDe support in Go Functions? Currently, the SerDe not support in Go Functions --

[GitHub] [pulsar] sijie commented on issue #6587: Requesting Pulsar to support IoT protocols - STOMP, AMQP, MQTT, WSS

2020-05-20 Thread GitBox
sijie commented on issue #6587: URL: https://github.com/apache/pulsar/issues/6587#issuecomment-631581083 @davidlanouette No. `kop` doesn't depend on the streamnative platform. `kop` is a protocol handler that you can install it natively in your existing Pulsar cluster. Also streamnative pl

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-631575552 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-631575362 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-631552315 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-631552037 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] huangdx0726 commented on issue #6957: PulsarIO [Debezium] - Support MS SqlServer

2020-05-20 Thread GitBox
huangdx0726 commented on issue #6957: URL: https://github.com/apache/pulsar/issues/6957#issuecomment-631526590 I'll work on it This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] davidlanouette commented on issue #6587: Requesting Pulsar to support IoT protocols - STOMP, AMQP, MQTT, WSS

2020-05-20 Thread GitBox
davidlanouette commented on issue #6587: URL: https://github.com/apache/pulsar/issues/6587#issuecomment-631516434 My team also is seriously considering Pulsar to replace ActiveMQ 5 (yes, it's way overdue), but we have a lot of STOMP and AMQP clients. @sijie Does the `kop` project dep

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-631488235 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-631487701 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] itaross opened a new issue #7005: Update documentation with possibility to use local run with Pulsar IO sinks and sources

2020-05-20 Thread GitBox
itaross opened a new issue #7005: URL: https://github.com/apache/pulsar/issues/7005 In the documentation is not specified how to debug locally the connectors directly with Java as for their functions counter part (https://pulsar.apache.org/docs/en/io-debug/) Update the docs with exp

[GitHub] [pulsar] itaross opened a new issue #7004: Local Runner is looking for connectors only in default location

2020-05-20 Thread GitBox
itaross opened a new issue #7004: URL: https://github.com/apache/pulsar/issues/7004 If this setting is overridden in the configuration file, the local runner will no longer work. https://github.com/apache/pulsar/blob/cc15ad58583a640ad311fe5a91a9968ed46bf335/pulsar-functions/localrun

[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #6998: Add multi-hosts example for bookkeeperMetadataServiceUri

2020-05-20 Thread GitBox
Huanli-Meng commented on a change in pull request #6998: URL: https://github.com/apache/pulsar/pull/6998#discussion_r427982456 ## File path: site2/docs/reference-configuration.md ## @@ -183,7 +183,7 @@ Pulsar brokers are responsible for handling incoming messages from producer

[GitHub] [pulsar] hari819 commented on issue #6236: SSL/TLS Configuration for Zookeeper,BookKeeper and Pulsar

2020-05-20 Thread GitBox
hari819 commented on issue #6236: URL: https://github.com/apache/pulsar/issues/6236#issuecomment-631438426 > > @rounak11 I have fixed the links. Please check them again. > > Is there a way to use PEM keys for ZK? yes , but from zookeeper 3.5.5 version

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-631412172 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-631412158 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] equanz commented on pull request #6996: [pulsar-client] Fix incorrect partitioned producer stats

2020-05-20 Thread GitBox
equanz commented on pull request #6996: URL: https://github.com/apache/pulsar/pull/6996#issuecomment-631409936 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] Huanli-Meng commented on issue #6927: Add C# client documentation

2020-05-20 Thread GitBox
Huanli-Meng commented on issue #6927: URL: https://github.com/apache/pulsar/issues/6927#issuecomment-631395516 1. Update the following docs: - Use Pulsar with client libraries - Transport encryption using TLS - authentication using TLS - authentication using JWT - sidebar.jso

[pulsar] branch master updated: [release][website] change version order for 2.5.2 (#6999)

2020-05-20 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository. zhaijia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new cc15ad5 [release][website] change version orde

[GitHub] [pulsar] jiazhai merged pull request #6999: [release][website] change version order

2020-05-20 Thread GitBox
jiazhai merged pull request #6999: URL: https://github.com/apache/pulsar/pull/6999 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] Huanli-Meng opened a new pull request #7003: Add Docs for c# client

2020-05-20 Thread GitBox
Huanli-Meng opened a new pull request #7003: URL: https://github.com/apache/pulsar/pull/7003 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] iravishah commented on issue #6991: java.util.concurrent.TimeoutException: Idle timeout expired: 300000/300000 ms

2020-05-20 Thread GitBox
iravishah commented on issue #6991: URL: https://github.com/apache/pulsar/issues/6991#issuecomment-631362682 I have configured this parameter but after the defined time it will close the connection right? So, How can I keep it alive forever? I can't afford the message drop because of re

[GitHub] [pulsar] 315157973 commented on pull request #6968: Fixes #6929 KeyValue schema supports nested generics type

2020-05-20 Thread GitBox
315157973 commented on pull request #6968: URL: https://github.com/apache/pulsar/pull/6968#issuecomment-631358959 > @315157973 the direction of this change looks great in general. However, I am not sure adding `Type functionGenericType` into the source and sink configs is the best solution

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-631356794 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-20 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-631356936 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] jiazhai commented on issue #6991: java.util.concurrent.TimeoutException: Idle timeout expired: 300000/300000 ms

2020-05-20 Thread GitBox
jiazhai commented on issue #6991: URL: https://github.com/apache/pulsar/issues/6991#issuecomment-631354365 @iravishah sorry, I see, seems this is a different issue. fir the idle timeout, you need this config. ``` webSocketSessionIdleTimeoutMillis ``` try set and add it into you

[GitHub] [pulsar] zplinuxlover commented on pull request #6903: PIP-61: Advertise multiple addresses

2020-05-20 Thread GitBox
zplinuxlover commented on pull request #6903: URL: https://github.com/apache/pulsar/pull/6903#issuecomment-631352928 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] codelipenghui commented on pull request #6895: [#6003][pulsar-functions] Possibility to add builtin Functions

2020-05-20 Thread GitBox
codelipenghui commented on pull request #6895: URL: https://github.com/apache/pulsar/pull/6895#issuecomment-631348503 @nicolo-paganin Could you please take a look at the failed CI tests? This is an automated message from the

[GitHub] [pulsar] huangdx0726 commented on pull request #5716: [Issues 5709]remove the namespace checking

2020-05-20 Thread GitBox
huangdx0726 commented on pull request #5716: URL: https://github.com/apache/pulsar/pull/5716#issuecomment-631344700 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] iravishah edited a comment on issue #6991: java.util.concurrent.TimeoutException: Idle timeout expired: 300000/300000 ms

2020-05-20 Thread GitBox
iravishah edited a comment on issue #6991: URL: https://github.com/apache/pulsar/issues/6991#issuecomment-631253211 How should I tweak these options to keep alive the socket connection? How this will resolve the Idle timeout? From my client, I am doing a ping call to make connectio

[GitHub] [pulsar] iravishah edited a comment on issue #6991: java.util.concurrent.TimeoutException: Idle timeout expired: 300000/300000 ms

2020-05-20 Thread GitBox
iravishah edited a comment on issue #6991: URL: https://github.com/apache/pulsar/issues/6991#issuecomment-631253211 How should I tweak these options to keep alive the socket connection? How this will resolve the Idle timeout? From my client, I am doing a ping call still its not abl

[GitHub] [pulsar] xgdgsc commented on issue #2997: apache pulsar 安全认证问题

2020-05-20 Thread GitBox
xgdgsc commented on issue #2997: URL: https://github.com/apache/pulsar/issues/2997#issuecomment-631310370 @jiazhai Can you elaborate on how to enable tls on `standalone.conf` ? I tried some editing and it doesn' t start listening on TLS ports.

[GitHub] [pulsar] zplinuxlover commented on pull request #6903: PIP-61: Advertise multiple addresses

2020-05-20 Thread GitBox
zplinuxlover commented on pull request #6903: URL: https://github.com/apache/pulsar/pull/6903#issuecomment-631297957 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [pulsar] Omega-Ariston commented on issue #7002: There are invalid links in the document

2020-05-20 Thread GitBox
Omega-Ariston commented on issue #7002: URL: https://github.com/apache/pulsar/issues/7002#issuecomment-631293172 Yeah, I found that as well. The button in pic 1 only works in English site. As for the link in pic 2, I reckon it points to the same endpoint as the one in pic 1, which is : h

[GitHub] [pulsar] jiawulin001 opened a new issue #7002: There are invalid links in the document

2020-05-20 Thread GitBox
jiawulin001 opened a new issue #7002: URL: https://github.com/apache/pulsar/issues/7002 1.`REST API` menu is invalid ![捕获1](https://user-images.githubusercontent.com/14244944/82417785-a0bdc600-9aae-11ea-952b-8010fa15d8c6.PNG) 2.The page opened through the `REST` link o

[GitHub] [pulsar] wolfstudy commented on issue #7000: Offload data from bk to aws-s3 error on 2.5.2

2020-05-20 Thread GitBox
wolfstudy commented on issue #7000: URL: https://github.com/apache/pulsar/issues/7000#issuecomment-631289759 On `2.5.1`, everything is ok. It seems that we made corresponding changes in 2.5.2 This is an automated message fro

[GitHub] [pulsar] wolfstudy opened a new issue #7001: The `managedLedgerMaxEntriesPerLedger` parameter does not take effect

2020-05-20 Thread GitBox
wolfstudy opened a new issue #7001: URL: https://github.com/apache/pulsar/issues/7001 **Describe the bug** conf/standalone.conf: ``` managedLedgerMinLedgerRolloverTimeMinutes=2 managedLedgerMaxEntriesPerLedger=5000 ``` I'm testing offload-related functions local

[GitHub] [pulsar] wolfstudy opened a new issue #7000: Offload data from bk to aws-s3 error on 2.5.2

2020-05-20 Thread GitBox
wolfstudy opened a new issue #7000: URL: https://github.com/apache/pulsar/issues/7000 **Describe the bug** conf/standalone.conf: ``` managedLedgerOffloadDriver=aws-s3 s3ManagedLedgerOffloadBucket=test-pulsar-offload s3ManagedLedgerOffloadRegion=us-west-2 s3Manag