[GitHub] [pulsar] wolfstudy opened a new pull request #7031: Add pulsar SQL woker metrics to repo

2020-05-24 Thread GitBox
wolfstudy opened a new pull request #7031: URL: https://github.com/apache/pulsar/pull/7031 Signed-off-by: xiaolong.ran Fixes #6897 ### Motivation - Add pulsar SQL woker metrics to repo This is an

[GitHub] [pulsar] stupidusername edited a comment on issue #5157: [docs] How does --processing-guarantees affect source connectors?

2020-05-24 Thread GitBox
stupidusername edited a comment on issue #5157: URL: https://github.com/apache/pulsar/issues/5157#issuecomment-633390668 I've been doing some tests using this source connector: [sequence_source](https://github.com/Antti-Kaikkonen/PulsarSequenceSource). I tested different

[GitHub] [pulsar] stupidusername commented on issue #5157: [docs] How does --processing-guarantees affect source connectors?

2020-05-24 Thread GitBox
stupidusername commented on issue #5157: URL: https://github.com/apache/pulsar/issues/5157#issuecomment-633390668 I've been doing some tests using this source connector: [sequence_source](https://github.com/Antti-Kaikkonen/PulsarSequenceSource). I tested different combinations of

[GitHub] [pulsar] wolfstudy commented on pull request #7030: [Issue: 7029] Fix presto SQL does not start prometheus service by default

2020-05-24 Thread GitBox
wolfstudy commented on pull request #7030: URL: https://github.com/apache/pulsar/pull/7030#issuecomment-633383154 @sijie @jiazhai @codelipenghui PTAL thanks. This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] wolfstudy opened a new pull request #7030: [Issue: 7029] Fix presto SQL does not start prometheus service by default

2020-05-24 Thread GitBox
wolfstudy opened a new pull request #7030: URL: https://github.com/apache/pulsar/pull/7030 Signed-off-by: xiaolong.ran Fixes #7029 ### Motivation As described in # 7029, when starting `sql-worker`, users expect to be able to correctly access the service port of

[GitHub] [pulsar] wolfstudy opened a new issue #7029: By default, presto SQL does not start the prometheus service

2020-05-24 Thread GitBox
wolfstudy opened a new issue #7029: URL: https://github.com/apache/pulsar/issues/7029 **Describe the bug** When starting `sql-worker` and using telnet to check the service, the following problems were found: ```bash telnet localhost:9092 ``` Output: ```

[GitHub] [pulsar] lukestephenson opened a new issue #7028: Support shared subscriptions on compacted topics

2020-05-24 Thread GitBox
lukestephenson opened a new issue #7028: URL: https://github.com/apache/pulsar/issues/7028 **Is your feature request related to a problem? Please describe.** I'm evaluating Pulsar. A primary use case of mine is large (more than 1 billion unique keyed messages) compacted topics. To

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-24 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-633372143 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #248: Clean callbacks of connection after run loop stopped (#239)

2020-05-24 Thread GitBox
cckellogg commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r429725687 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")

[GitHub] [pulsar] Huanli-Meng commented on pull request #6946: Polish helm related docs

2020-05-24 Thread GitBox
Huanli-Meng commented on pull request #6946: URL: https://github.com/apache/pulsar/pull/6946#issuecomment-633351468 @lukestephenson , Thanks for your feedback. I will check the doc and fix it as soon as possible. This is an

[GitHub] [pulsar] codelipenghui commented on a change in pull request #6903: PIP-61: Advertise multiple addresses

2020-05-24 Thread GitBox
codelipenghui commented on a change in pull request #6903: URL: https://github.com/apache/pulsar/pull/6903#discussion_r429707325 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -36,11 +36,7 @@ import java.lang.reflect.Method;

[GitHub] [pulsar] lukestephenson commented on pull request #6946: Polish helm related docs

2020-05-24 Thread GitBox
lukestephenson commented on pull request #6946: URL: https://github.com/apache/pulsar/pull/6946#issuecomment-633348940 Hello. I'm not sure if it is related to this PR, but in 2.5.2 of the docs, the section to "Run Pulsar in Kubernetes" has disappeared from "Get started".

[pulsar] branch master updated: Add the pulsar functions metrics (#7016)

2020-05-24 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new cd2 Add the pulsar functions metrics (#7016)

[GitHub] [pulsar] wolfstudy merged pull request #7016: Add the pulsar functions metrics

2020-05-24 Thread GitBox
wolfstudy merged pull request #7016: URL: https://github.com/apache/pulsar/pull/7016 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] wolfstudy closed issue #6898: [document] document for Pulsar Function worker metrics.

2020-05-24 Thread GitBox
wolfstudy closed issue #6898: URL: https://github.com/apache/pulsar/issues/6898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar-translation] Omega-Ariston opened a new pull request #32: [docs]added some docs to tran

2020-05-24 Thread GitBox
Omega-Ariston opened a new pull request #32: URL: https://github.com/apache/pulsar-translation/pull/32 added the following docs to translate: ``` getting-started-helm.md admin-api-namespaces.md client-libraries-node.md cookbooks-compaction.md ``` likely to have

[GitHub] [pulsar] codelipenghui commented on pull request #4955: [PIP-39] Introduce system topic and topic policies service

2020-05-24 Thread GitBox
codelipenghui commented on pull request #4955: URL: https://github.com/apache/pulsar/pull/4955#issuecomment-633341028 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level

2020-05-24 Thread GitBox
codelipenghui commented on pull request #6052: URL: https://github.com/apache/pulsar/pull/6052#issuecomment-633340804 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] lukestephenson opened a new pull request #7027: [pulsar-client] Fix typo in exception message

2020-05-24 Thread GitBox
lukestephenson opened a new pull request #7027: URL: https://github.com/apache/pulsar/pull/7027 Fixing a typo in an exception message This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-translation] Omega-Ariston closed pull request #30: [docs] adds some docs to tran

2020-05-24 Thread GitBox
Omega-Ariston closed pull request #30: URL: https://github.com/apache/pulsar-translation/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-24 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-68099 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-24 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-68067 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] sijie commented on issue #7019: Webhook Size is always zero

2020-05-24 Thread GitBox
sijie commented on issue #7019: URL: https://github.com/apache/pulsar/issues/7019#issuecomment-67431 @rajasekar33 Can you clarify which component you are using? There is no "beam" component in pulsar. This is an

[GitHub] [pulsar] sijie commented on issue #7013: pulsar/deployment/kubernetes/helm/scripts not included in release tarball

2020-05-24 Thread GitBox
sijie commented on issue #7013: URL: https://github.com/apache/pulsar/issues/7013#issuecomment-66625 @xgdgsc Yes. The helm chart is intended to not include the source tarball. You can use the git version. Currently, we also moved the helm chart to a separated repo:

[GitHub] [pulsar] hangc0276 commented on pull request #6719: fix consumer fetch message number maps to read entry number bug and expose avgMessagesPerEntry metric

2020-05-24 Thread GitBox
hangc0276 commented on pull request #6719: URL: https://github.com/apache/pulsar/pull/6719#issuecomment-65925 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] Huanli-Meng commented on issue #6882: 2.5.1 documentation contains the out-of-date documentation of kubernetes deployment

2020-05-24 Thread GitBox
Huanli-Meng commented on issue #6882: URL: https://github.com/apache/pulsar/issues/6882#issuecomment-64494 @sijie , it seems that the issue is fixed as we checked before. if not, could you please identify which are old contents? Thx.

[GitHub] [pulsar] codelipenghui closed issue #6896: [document] document for Pulsar Proxy metrics.

2020-05-24 Thread GitBox
codelipenghui closed issue #6896: URL: https://github.com/apache/pulsar/issues/6896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] codelipenghui merged pull request #7015: Add pulsar proxy metrics

2020-05-24 Thread GitBox
codelipenghui merged pull request #7015: URL: https://github.com/apache/pulsar/pull/7015 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[pulsar] branch master updated: Add pulsar proxy metrics (#7015)

2020-05-24 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 262ec0e7 Add pulsar proxy metrics (#7015)

[GitHub] [pulsar] charvakcpatel007 opened a new pull request #7026: Billing metric update to zookeeper store

2020-05-24 Thread GitBox
charvakcpatel007 opened a new pull request #7026: URL: https://github.com/apache/pulsar/pull/7026 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-24 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-633254242 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[pulsar] branch master updated (6e6e4e2 -> e5c29ac)

2020-05-24 Thread zhaijia
This is an automated email from the ASF dual-hosted git repository. zhaijia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6e6e4e2 Secrets provider should be initialized for each new function (#6993) add e5c29ac [docs] Fix typo in

[GitHub] [pulsar] jiazhai merged pull request #7023: [docs] Fix typo in the dotnet (C# client) docs

2020-05-24 Thread GitBox
jiazhai merged pull request #7023: URL: https://github.com/apache/pulsar/pull/7023 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] hangc0276 commented on pull request #6719: fix consumer fetch message number maps to read entry number bug and expose avgMessagesPerEntry metric

2020-05-24 Thread GitBox
hangc0276 commented on pull request #6719: URL: https://github.com/apache/pulsar/pull/6719#issuecomment-633234340 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-24 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-633233962 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-24 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-633233948 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] hangc0276 commented on pull request #6719: fix consumer fetch message number maps to read entry number bug and expose avgMessagesPerEntry metric

2020-05-24 Thread GitBox
hangc0276 commented on pull request #6719: URL: https://github.com/apache/pulsar/pull/6719#issuecomment-633225871 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] cdbartholomew commented on pull request #7024: [Issue 7022][Prometheus]Fix for topic out Prometheus metrics

2020-05-24 Thread GitBox
cdbartholomew commented on pull request #7024: URL: https://github.com/apache/pulsar/pull/7024#issuecomment-633219965 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] stupidusername commented on issue #6317: A source connector created with --processing-guarantees EFFECTIVELY_ONCE produces messages one at a time.

2020-05-24 Thread GitBox
stupidusername commented on issue #6317: URL: https://github.com/apache/pulsar/issues/6317#issuecomment-633214447 I don't understand something. How do you preserve message order without waiting for a message to be acknowledged before producing the next message?

[GitHub] [pulsar] BewareMyPower commented on pull request #6796: [C++] Support cumulative acknowledgement when consuming partitioned topics

2020-05-24 Thread GitBox
BewareMyPower commented on pull request #6796: URL: https://github.com/apache/pulsar/pull/6796#issuecomment-633200307 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] BewareMyPower commented on pull request #6827: [Issue 6822][C++] Fix segmentation fault if handleSendTimeout() is called after closeAsync()

2020-05-24 Thread GitBox
BewareMyPower commented on pull request #6827: URL: https://github.com/apache/pulsar/pull/6827#issuecomment-633200288 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] hangc0276 commented on pull request #6719: fix consumer fetch message number maps to read entry number bug and expose avgMessagesPerEntry metric

2020-05-24 Thread GitBox
hangc0276 commented on pull request #6719: URL: https://github.com/apache/pulsar/pull/6719#issuecomment-633199901 > @hangc0276 If you have time, please help take a look at the failed tests and resolve the conflicts. And I think you can add a flag in the broker and disable it by default.

[GitHub] [pulsar] vzhikserg commented on pull request #7020: Make the json node field in GenericRecord public

2020-05-24 Thread GitBox
vzhikserg commented on pull request #7020: URL: https://github.com/apache/pulsar/pull/7020#issuecomment-633194343 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] wolfstudy commented on pull request #7016: Add the pulsar functions metrics

2020-05-24 Thread GitBox
wolfstudy commented on pull request #7016: URL: https://github.com/apache/pulsar/pull/7016#issuecomment-633194179 @codelipenghui PTAL thanks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] wolfstudy commented on pull request #7015: Add pulsar proxy metrics

2020-05-24 Thread GitBox
wolfstudy commented on pull request #7015: URL: https://github.com/apache/pulsar/pull/7015#issuecomment-633194162 @codelipenghui PTAL This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-client-go] wolfstudy commented on issue #240: Check max message size in go client

2020-05-24 Thread GitBox
wolfstudy commented on issue #240: URL: https://github.com/apache/pulsar-client-go/issues/240#issuecomment-633193726 @keithnull will track this task This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar-client-go] yarthur1 opened a new pull request #262: Add checkout by context

2020-05-24 Thread GitBox
yarthur1 opened a new pull request #262: URL: https://github.com/apache/pulsar-client-go/pull/262 Fixes #242 ### Motivation add send timeout ### Modifications https://github.com/apache/pulsar-client-go/pull/252 based on pull 252 commit, add following