Huanli-Meng commented on pull request #7468:
URL: https://github.com/apache/pulsar/pull/7468#issuecomment-656522260
@jiazhai @Jennifer88huang , could you please help review the PR?
This is an automated message from the Apache
rdhabalia opened a new pull request #7501:
URL: https://github.com/apache/pulsar/pull/7501
### Motivation
`pulsarClient.close()` doesn't forcefully close the client but it waits for
pending publish. For test-cleanup method we should shutdown pulsar-client
forcefully.
-
Huanli-Meng commented on a change in pull request #7471:
URL: https://github.com/apache/pulsar/pull/7471#discussion_r452667831
##
File path: site2/docs/concepts-proxy-sni-routing.md
##
@@ -5,29 +5,31 @@ sidebar_label: Proxy support with SNI routing
---
## Pulsar Proxy with
wolfstudy commented on pull request #321:
URL: https://github.com/apache/pulsar-client-go/pull/321#issuecomment-656580884
Thanks @shohi work for this, the change LGTM +1, I added some descriptive
information about this pull request, PTAL
---
tongsucn opened a new issue #7502:
URL: https://github.com/apache/pulsar/issues/7502
**Describe the bug**
When enabling `-Wall`, the library cannot be successfully compiled:
1. Non-virtual destructor in base class:
`pulsar-client-cpp/lib/auth/AuthOauth2.h:47:7: error: base cla
tongsucn opened a new pull request #7503:
URL: https://github.com/apache/pulsar/pull/7503
Fixes #7502
The compilation problem described in #7502 is resolved.
This is an automated message from the Apache Git Service.
T
sbourkeostk commented on issue #7489:
URL: https://github.com/apache/pulsar/issues/7489#issuecomment-656705729
I don't think there's a problem in the Prometheus client, it's Pulsar that's
creating the new metrics by setting a new label. Prometheus is clear in it's
advice about not overusin
merlimat commented on pull request #7499:
URL: https://github.com/apache/pulsar/pull/7499#issuecomment-656706289
@rdhabalia there is already a mechanism in place. ptal at #7406
This is an automated message from the Apache Git
merlimat commented on pull request #7495:
URL: https://github.com/apache/pulsar/pull/7495#issuecomment-656708101
> it would be better to have a testcase cover this.
it's not easy to test since the error only happens in background
-
xuesong172500 opened a new issue #7504:
URL: https://github.com/apache/pulsar/issues/7504
**Describe the bug**
error log in pulsar-broker-xx.log
22:16:07.855 [pulsar-web-40-5] ERROR
org.apache.pulsar.broker.admin.impl.ClustersBase - [null] Failed to get
clusters/pulsar-cluster/namesp
aloyszhang commented on issue #7476:
URL: https://github.com/apache/pulsar/issues/7476#issuecomment-656712253
@sijie, Both `DiscoveryServiceServlet` and `BrokerDiscoveryProvider ` will
be started if runs discovery service .
aloyszhang edited a comment on issue #7476:
URL: https://github.com/apache/pulsar/issues/7476#issuecomment-656712253
@sijie, Both `DiscoveryServiceServlet` and `BrokerDiscoveryProvider ` will
be started if run discovery service .
--
aloyszhang edited a comment on issue #7476:
URL: https://github.com/apache/pulsar/issues/7476#issuecomment-656712253
@sijie,
At the first time, I thoung it was caused by session expires, by no
SessionExpired related log can be found.
```java
localZkConnectionSvc.start(new Zookee
aloyszhang edited a comment on issue #7476:
URL: https://github.com/apache/pulsar/issues/7476#issuecomment-656712253
@sijie,
This problem has happened several times in our pulsar cluster. At the first
time, I thought it was caused by session expires, but no SessionExpired
related log
aloyszhang edited a comment on issue #7476:
URL: https://github.com/apache/pulsar/issues/7476#issuecomment-656712253
@sijie, Thanks for you reply.
This problem has happened several times in our pulsar cluster. At the first
time, I thought it was caused by session expires, but no Sessio
xuesong172500 opened a new issue #7505:
URL: https://github.com/apache/pulsar/issues/7505
**Describe the bug**
After creating functions, the function runs normally. Stop function starts
function again. The following error is reported in the function log. Update
function is invalid. You
horsteff commented on issue #7492:
URL: https://github.com/apache/pulsar/issues/7492#issuecomment-656769281
@sijie Yes, that's what I had in mind. I'm already working on it and will
make a pull request then.
One question: After digging a little in the code and thinking about possible
merlimat commented on pull request #322:
URL: https://github.com/apache/pulsar-client-go/pull/322#issuecomment-656778535
I'm not sure how is this different than applications just using Logrus APIs
to configure the logging?
-
merlimat merged pull request #321:
URL: https://github.com/apache/pulsar-client-go/pull/321
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 6188199 add Name method to Consumer i
merlimat merged pull request #319:
URL: https://github.com/apache/pulsar-client-go/pull/319
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 9065cb7 Do not allocate MessageIDs on
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 80fd41f Add rerun feature test comman
merlimat merged pull request #311:
URL: https://github.com/apache/pulsar-client-go/pull/311
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
rdhabalia merged pull request #7501:
URL: https://github.com/apache/pulsar/pull/7501
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
rdhabalia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 9f9db24e [pulsar-test] shutdown pulsar-client
merlimat merged pull request #7495:
URL: https://github.com/apache/pulsar/pull/7495
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new d8fd8ea Get last entry is trying to read entry
merlimat merged pull request #317:
URL: https://github.com/apache/pulsar-client-go/pull/317
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git
The following commit(s) were added to refs/heads/master by this push:
new 220dcb4 Export client metrics to Prom
sijie opened a new pull request #7506:
URL: https://github.com/apache/pulsar/pull/7506
*Motivation*
Currently broker has a timeout mechanism on loading topics. However the
underlying managed ledger library
doesn't provide a timeout mechanism. This will get into a situation that: A
devinbost commented on issue #7489:
URL: https://github.com/apache/pulsar/issues/7489#issuecomment-656861153
@sijie I'm open to contributing a fix for this, but if it will change the
end-user data contract, we'd need to vet it with the community. I'll need to
investigate the matter further
sijie commented on pull request #7430:
URL: https://github.com/apache/pulsar/pull/7430#issuecomment-656861938
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the message,
merlimat commented on issue #7489:
URL: https://github.com/apache/pulsar/issues/7489#issuecomment-656862813
> but if it will change the end-user data contract
This is not changing the data contract. This is just a metric to help
debuggabiity.
I think the timestamp was there t
devinbost removed a comment on issue #7489:
URL: https://github.com/apache/pulsar/issues/7489#issuecomment-656871407
@matthewfollegot
Since we're using the Prometheus Counter's internal state to keep track of
our exceptions, every time an exception is thrown, we're still adding the
exc
devinbost commented on issue #7489:
URL: https://github.com/apache/pulsar/issues/7489#issuecomment-656871407
@matthewfollegot
Since we're using the Prometheus Counter's internal state to keep track of
our exceptions, every time an exception is thrown, we're still adding the
exception t
devinbost commented on issue #7489:
URL: https://github.com/apache/pulsar/issues/7489#issuecomment-656871611
@merlimat
Since we're using the Prometheus Counter's internal state to keep track of
our exceptions, every time an exception is thrown, we're still adding the
exception to the
devinbost edited a comment on issue #7489:
URL: https://github.com/apache/pulsar/issues/7489#issuecomment-656871611
@merlimat
Since we're using the Prometheus Counter's internal state to keep track of
our exceptions in our Java implementation, every time an exception is thrown,
we're
devinbost commented on issue #7489:
URL: https://github.com/apache/pulsar/issues/7489#issuecomment-656873339
It looks like we might be able to just remove the timestamp for the Go
functions implementation, but is it that simple on the Java side?
--
rdhabalia commented on pull request #7499:
URL: https://github.com/apache/pulsar/pull/7499#issuecomment-656881392
#7406 manages broker-wide throttling at the IO thread level and we can still
reproduce above issue with the #7406 fix.
This PR actually manages this back-pressure at the brok
merlimat commented on pull request #7499:
URL: https://github.com/apache/pulsar/pull/7499#issuecomment-656882367
@rdhabalia The change in #7406 is to avoid any contention in write path and
to impose a global max.
This is an
addisonj commented on a change in pull request #7506:
URL: https://github.com/apache/pulsar/pull/7506#discussion_r453069297
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##
@@ -320,18 +335,32 @@ public void asyncOpe
merlimat commented on pull request #7506:
URL: https://github.com/apache/pulsar/pull/7506#issuecomment-656888277
> The completable future will never return. So any sub-sequent topic lookups
will fail because any
attempts to load a topic will never attempt to re-open a managed ledger.
merlimat opened a new pull request #7507:
URL: https://github.com/apache/pulsar/pull/7507
### Motivation
The function test is failing if the request is being made while the leader
is still initializing.
This is an aut
merlimat opened a new pull request #7508:
URL: https://github.com/apache/pulsar/pull/7508
### Motivation
There is the possibility of deadlock if a request to create function is
received while the leader is still tailing the topic with the updates.
The leader is trying to get
jerrypeng commented on a change in pull request #7507:
URL: https://github.com/apache/pulsar/pull/7507#discussion_r453082083
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java
##
@@ -1493,6 +1493,7 @@ public void testPulsarFunctionStatus(
merlimat commented on a change in pull request #7507:
URL: https://github.com/apache/pulsar/pull/7507#discussion_r453086632
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java
##
@@ -1493,6 +1493,7 @@ public void testPulsarFunctionStatus()
merlimat closed issue #6116:
URL: https://github.com/apache/pulsar/issues/6116
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from d8fd8ea Get last entry is trying to read entry -1 (#7495)
add 02fa64c Update connectors.js (#7472)
No new rev
merlimat merged pull request #7472:
URL: https://github.com/apache/pulsar/pull/7472
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sijie commented on pull request #7506:
URL: https://github.com/apache/pulsar/pull/7506#issuecomment-656909319
@merlimat it is stuck in LedgerRecoveryOp when recovering cursors. I haven't
caught the real exception. My feeling is more coming from the zookeeper side.
The chaos test we did is
rdhabalia commented on pull request #7499:
URL: https://github.com/apache/pulsar/pull/7499#issuecomment-656911219
> The change in #7406 is to avoid any contention in write path and to impose
a global max.
I have gone through with #7406 PR but as I said it distributes max global
byte
jerrypeng opened a new pull request #7509:
URL: https://github.com/apache/pulsar/pull/7509
### Motivation
Wait under worker is done with becoming leader routine before performing
operations like updateFunctionOnLeader.
If we don't, a deadlock can happen :
Jetty - Cr
rdhabalia commented on pull request #7499:
URL: https://github.com/apache/pulsar/pull/7499#issuecomment-656922057
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the messa
sijie commented on a change in pull request #7506:
URL: https://github.com/apache/pulsar/pull/7506#discussion_r453106816
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##
@@ -320,18 +335,32 @@ public void asyncOpen(f
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 5fd96e2 The test should wait until the worker l
merlimat merged pull request #7507:
URL: https://github.com/apache/pulsar/pull/7507
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jerrypeng opened a new pull request #7510:
URL: https://github.com/apache/pulsar/pull/7510
### Motivation
Some exceptions are being ignored in Pulsar admin, more especially in
Functions, Sources, and Sinks. We need to bubble up these exceptions so it is
easier to debug.
-
merlimat commented on pull request #7499:
URL: https://github.com/apache/pulsar/pull/7499#issuecomment-656944897
> g: 1gb across 30 IO threads means 1 IO thread can only do 33MB it means as
a user I have to create multiple connections and hope it will be served by
other IO thread to get hi
codelipenghui commented on pull request #7506:
URL: https://github.com/apache/pulsar/pull/7506#issuecomment-656952881
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the m
merlimat opened a new pull request #7511:
URL: https://github.com/apache/pulsar/pull/7511
### Motivation
`pulsar-client-api` is meant to be free of dependencies. This is to ensure
that:
1. this module can be left out of shading
2. we're not exposing in API symbols that are n
taiyang-li commented on pull request #322:
URL: https://github.com/apache/pulsar-client-go/pull/322#issuecomment-656955488
Pulsar-client-go use default logger std allaround.
In most cases, this will work , because users are able to SetOutput
SetFormatter SetLevel (refer to
https://g
rdhabalia commented on pull request #7499:
URL: https://github.com/apache/pulsar/pull/7499#issuecomment-656959121
> Finally, the number of messages/s is not a good proxy measure for the
amount of memory required in the broker
Yes, I will add restriction based on number bytes as well
mikecaat opened a new issue #7512:
URL: https://github.com/apache/pulsar/issues/7512
**Describe the bug**
If the replicator-dispatch-rate is not configured, the geo-replication
policy is not be updated.
**To Reproduce**
1. make three pulsar clusters(cluster-a,cluster-b,cluster-
rdhabalia commented on pull request #7473:
URL: https://github.com/apache/pulsar/pull/7473#issuecomment-656965741
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the messa
mikecaat opened a new pull request #7513:
URL: https://github.com/apache/pulsar/pull/7513
### Motivation
To fix typo in default configuration.
### Modifications
Change "replicatioPolicyCheckDurationSeconds" to
"replicatio**n**PolicyCheckDurationSeconds."
-
codelipenghui commented on issue #7512:
URL: https://github.com/apache/pulsar/issues/7512#issuecomment-656967808
@mikecaat Thanks for the feedback, the behavior is not expected. I think you
have found the root cause, are you interested in fixing it?
---
codelipenghui commented on pull request #7499:
URL: https://github.com/apache/pulsar/pull/7499#issuecomment-656968891
> Yes, I will add restriction based on number bytes as well along with
number of messages.
Is it the same as #6178 does?
---
codelipenghui commented on pull request #7498:
URL: https://github.com/apache/pulsar/pull/7498#issuecomment-656969804
/pulsarbot run-failure-checks
This is an automated message from the Apache Git Service.
To respond to the m
rdhabalia commented on pull request #7499:
URL: https://github.com/apache/pulsar/pull/7499#issuecomment-656974378
> Is it the same as #6178 does?
Yes, but #6178 uses a volatile counter and that creates contention in write
path and therefore, @merlimat tried to remove it in #7406 by u
sxpsxp12 commented on issue #7479:
URL: https://github.com/apache/pulsar/issues/7479#issuecomment-656974919
I think the problem is not the type of compression, I switch compression to
other, still does not work
This is an au
mikecaat opened a new pull request #7514:
URL: https://github.com/apache/pulsar/pull/7514
Fixes #7512
### Motivation
To change the replication policy dynamically without configuring the
replicator-dispatch-rate parameter.
### Modifications
To handle java.util.NoS
mikecaat commented on issue #7512:
URL: https://github.com/apache/pulsar/issues/7512#issuecomment-656976130
@codelipenghui Thanks for replying. Since I made pull request, please review
it.
This is an automated message from t
mikecaat edited a comment on issue #7512:
URL: https://github.com/apache/pulsar/issues/7512#issuecomment-656976130
@codelipenghui Thanks for replying. Since I made the pull request, please
review it.
This is an automated mes
jiazhai commented on a change in pull request #7430:
URL: https://github.com/apache/pulsar/pull/7430#discussion_r453152431
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -196,6 +196,7 @@ enum ServerError {
TransactionCoordinatorNotFound = 20; // Transac
sxpsxp12 removed a comment on issue #7479:
URL: https://github.com/apache/pulsar/issues/7479#issuecomment-656974919
I think the problem is not the type of compression, I switch compression to
other, still does not work
This
This is an automated email from the ASF dual-hosted git repository.
jerrypeng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 5fd96e2 The test should wait until the worker leader is ready,
otherwise the request to create function will fai
jerrypeng merged pull request #7510:
URL: https://github.com/apache/pulsar/pull/7510
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sxpsxp12 commented on issue #7479:
URL: https://github.com/apache/pulsar/issues/7479#issuecomment-656992587
**The test results are the same with versions 2.5.2 cgo client and 2.6.0 cgo
client**
# Organized the following information
## Work 1
1. producer config
```
79 matches
Mail list logo
