[GitHub] [pulsar] yanshuchong opened a new issue #9007: How to resolve BK Error while recovering ledger

2020-12-18 Thread GitBox
yanshuchong opened a new issue #9007: URL: https://github.com/apache/pulsar/issues/9007 pulsar broker version 2.7.0 bookkeeper version 4.10.0 -- **Pulsar Broker Error log when client producer message** 15:01:12.364 [BookKeeperClientWorker-OrderedExecutor-

[GitHub] [pulsar] jiazhai commented on pull request #7848: take seek time into account in Reader#hasMessageAvailable

2020-12-18 Thread GitBox
jiazhai commented on pull request #7848: URL: https://github.com/apache/pulsar/pull/7848#issuecomment-748400832 > @codelipenghui Since this PR changes the seek response from `CommandSuccess` to `CommandSeekResponse`, the other clients may fail with `seek`. Is it proper to include this PR i

[GitHub] [pulsar] jerrypeng opened a new pull request #9006: Adding timeout to open table call for function state

2020-12-18 Thread GitBox
jerrypeng opened a new pull request #9006: URL: https://github.com/apache/pulsar/pull/9006 ### Motivation The openTable() may block indefinitely if a timeout is not specified. This could be a bug in the table service client, however we should add a timeout as a good measure.

[GitHub] [pulsar] jerrypeng opened a new pull request #9005: Allow stats operations not to be blocked in functions

2020-12-18 Thread GitBox
jerrypeng opened a new pull request #9005: URL: https://github.com/apache/pulsar/pull/9005 ### Motivation Operations in regards to stats can happen out of band of the main function thread. Currently, all stats operations for a function instance are unnecessarily synchronized wi

[pulsar] branch master updated: PIP-68: WaitForExclusive producer access mode (#8992)

2020-12-18 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 99476d3 PIP-68: WaitForExclusive producer acces

[GitHub] [pulsar] merlimat merged pull request #8992: PIP-68: WaitForExclusive producer access mode

2020-12-18 Thread GitBox
merlimat merged pull request #8992: URL: https://github.com/apache/pulsar/pull/8992 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] merlimat commented on a change in pull request #8992: PIP-68: WaitForExclusive producer access mode

2020-12-18 Thread GitBox
merlimat commented on a change in pull request #8992: URL: https://github.com/apache/pulsar/pull/8992#discussion_r546073971 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -1192,6 +1193,17 @@ protected void handleProducer(final C

[GitHub] [pulsar] merlimat commented on a change in pull request #8992: PIP-68: WaitForExclusive producer access mode

2020-12-18 Thread GitBox
merlimat commented on a change in pull request #8992: URL: https://github.com/apache/pulsar/pull/8992#discussion_r546073784 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -1192,6 +1193,17 @@ protected void handleProducer(final C

[GitHub] [pulsar] eolivelli commented on a change in pull request #8998: Improve error handling when broker doesn't trust client certificates

2020-12-18 Thread GitBox
eolivelli commented on a change in pull request #8998: URL: https://github.com/apache/pulsar/pull/8998#discussion_r546073190 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationDataCommand.java ## @@ -94,6 +96,7 @@ public bool

[GitHub] [pulsar] merlimat commented on a change in pull request #8992: PIP-68: WaitForExclusive producer access mode

2020-12-18 Thread GitBox
merlimat commented on a change in pull request #8992: URL: https://github.com/apache/pulsar/pull/8992#discussion_r546073335 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java ## @@ -468,6 +469,19 @@ protected void handleProducerSuccess(Comm

[GitHub] [pulsar] eolivelli commented on a change in pull request #8992: PIP-68: WaitForExclusive producer access mode

2020-12-18 Thread GitBox
eolivelli commented on a change in pull request #8992: URL: https://github.com/apache/pulsar/pull/8992#discussion_r546070668 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -1192,6 +1193,17 @@ protected void handleProducer(final

[GitHub] [pulsar] merlimat commented on a change in pull request #8962: [ShadeTest]Add integration shade test for pulsar-client and pulsar-cient-admin.

2020-12-18 Thread GitBox
merlimat commented on a change in pull request #8962: URL: https://github.com/apache/pulsar/pull/8962#discussion_r545998010 ## File path: pulsar-client-shaded/pom.xml ## @@ -104,6 +104,7 @@ org.apache.pulsar:pulsar-client-ori

[GitHub] [pulsar] sijie commented on pull request #8998: Improve error handling when broker doesn't trust client certificates

2020-12-18 Thread GitBox
sijie commented on pull request #8998: URL: https://github.com/apache/pulsar/pull/8998#issuecomment-748230980 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] sijie commented on pull request #8930: Monitor if a cursor moves its mark-delete position

2020-12-18 Thread GitBox
sijie commented on pull request #8930: URL: https://github.com/apache/pulsar/pull/8930#issuecomment-748230744 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] zzzming commented on pull request #8995: remove duplicated broker prometheus metrics type

2020-12-18 Thread GitBox
zzzming commented on pull request #8995: URL: https://github.com/apache/pulsar/pull/8995#issuecomment-748209345 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] hpvd commented on issue #9004: Pulsar Schema API: provide Type information for Fields

2020-12-18 Thread GitBox
hpvd commented on issue #9004: URL: https://github.com/apache/pulsar/issues/9004#issuecomment-748177377 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar] eolivelli commented on pull request #8995: remove duplicated broker prometheus metrics type

2020-12-18 Thread GitBox
eolivelli commented on pull request #8995: URL: https://github.com/apache/pulsar/pull/8995#issuecomment-748119867 @sijie @wolfstudy can we pick this change to 2.6.3 and 2.7.1 ? This is an automated message from the Apache Gi

[GitHub] [pulsar] zzzming commented on a change in pull request #8995: remove duplicated broker prometheus metrics type

2020-12-18 Thread GitBox
zzzming commented on a change in pull request #8995: URL: https://github.com/apache/pulsar/pull/8995#discussion_r545865868 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java ## @@ -591,18 +595,63 @@ public void testManagedLedger

[GitHub] [pulsar] zzzming commented on a change in pull request #8995: remove duplicated broker prometheus metrics type

2020-12-18 Thread GitBox
zzzming commented on a change in pull request #8995: URL: https://github.com/apache/pulsar/pull/8995#discussion_r545864142 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java ## @@ -591,18 +595,63 @@ public void testManagedLedger

[GitHub] [pulsar] eolivelli opened a new issue #9004: Pulsar Schema API: provide Type information for Fields

2020-12-18 Thread GitBox
eolivelli opened a new issue #9004: URL: https://github.com/apache/pulsar/issues/9004 Currently the "Field" API reports only the field name and a field index. Kafka Connects reports the data type as well. This is very useful for code that processes inbound events with general purpose

[GitHub] [pulsar] gaoran10 commented on a change in pull request #8985: [Issue 8887][tiered-storage-jcloud] support tiered-storage provider by aliyun OSS

2020-12-18 Thread GitBox
gaoran10 commented on a change in pull request #8985: URL: https://github.com/apache/pulsar/pull/8985#discussion_r545789742 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java ## @@ -162,6 +165,28

[GitHub] [pulsar] gaoran10 commented on a change in pull request #8985: [Issue 8887][tiered-storage-jcloud] support tiered-storage provider by aliyun OSS

2020-12-18 Thread GitBox
gaoran10 commented on a change in pull request #8985: URL: https://github.com/apache/pulsar/pull/8985#discussion_r545789742 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java ## @@ -162,6 +165,28

[GitHub] [pulsar] gaoran10 commented on a change in pull request #8985: [Issue 8887][tiered-storage-jcloud] support tiered-storage provider by aliyun OSS

2020-12-18 Thread GitBox
gaoran10 commented on a change in pull request #8985: URL: https://github.com/apache/pulsar/pull/8985#discussion_r545789742 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java ## @@ -162,6 +165,28

[GitHub] [pulsar] gaoran10 commented on a change in pull request #8985: [Issue 8887][tiered-storage-jcloud] support tiered-storage provider by aliyun OSS

2020-12-18 Thread GitBox
gaoran10 commented on a change in pull request #8985: URL: https://github.com/apache/pulsar/pull/8985#discussion_r545789742 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java ## @@ -162,6 +165,28

[GitHub] [pulsar] codelipenghui commented on pull request #8998: Improve error handling when broker doesn't trust client certificates

2020-12-18 Thread GitBox
codelipenghui commented on pull request #8998: URL: https://github.com/apache/pulsar/pull/8998#issuecomment-748057143 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] gaoran10 commented on pull request #8938: [Tiered Storage] Exclude current ledger from offload deque

2020-12-18 Thread GitBox
gaoran10 commented on pull request #8938: URL: https://github.com/apache/pulsar/pull/8938#issuecomment-748049293 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] Huanli-Meng commented on pull request #9003: [Doc]--Update schema primitive type contents.

2020-12-18 Thread GitBox
Huanli-Meng commented on pull request #9003: URL: https://github.com/apache/pulsar/pull/9003#issuecomment-748030509 @jianyun8023 , please help review the PR. Thanks. This is an automated message from the Apache Git Service. T

[GitHub] [pulsar] Huanli-Meng opened a new pull request #9003: [Doc]--Update schema primitive type contents.

2020-12-18 Thread GitBox
Huanli-Meng opened a new pull request #9003: URL: https://github.com/apache/pulsar/pull/9003 ### Motivation In PR #7874, Instant, LocalDate, LocalTime, LocalDateTime are added to Pulsar's primitive schemas codes. But doc is not updated accordingly. ### Modifications

[GitHub] [pulsar] gaoran10 commented on pull request #8938: [Tiered Storage] Exclude current ledger from offload deque

2020-12-18 Thread GitBox
gaoran10 commented on pull request #8938: URL: https://github.com/apache/pulsar/pull/8938#issuecomment-748010783 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] zymap commented on a change in pull request #8996: Ack response implementation

2020-12-18 Thread GitBox
zymap commented on a change in pull request #8996: URL: https://github.com/apache/pulsar/pull/8996#discussion_r545742033 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/AcknowledgmentsGroupingTracker.java ## @@ -31,12 +34,27 @@ boolean isDuplicat

[GitHub] [pulsar] sijia-w opened a new pull request #9002: Fix Workaround in versioned docs since 2.4.0

2020-12-18 Thread GitBox
sijia-w opened a new pull request #9002: URL: https://github.com/apache/pulsar/pull/9002 Update the Workaround section in versioned docs since 2.4.0. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] yufan022 commented on pull request #8985: [Issue 8887][tiered-storage-jcloud] support tiered-storage provider by aliyun OSS

2020-12-18 Thread GitBox
yufan022 commented on pull request #8985: URL: https://github.com/apache/pulsar/pull/8985#issuecomment-747991984 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [pulsar] Renkai opened a new pull request #9001: [Build]Add provided dependency to make IDE eaiser to analyse code

2020-12-18 Thread GitBox
Renkai opened a new pull request #9001: URL: https://github.com/apache/pulsar/pull/9001 Since we have used shaded dependency, which IDE may not analyze well, add a provided dependency will make IDE find the right dependency code without changing the build result.

[GitHub] [pulsar] massakam opened a new pull request #9000: [pulsar-perf] Enable pulsar-perf to load WebSocket service URL from conf file

2020-12-18 Thread GitBox
massakam opened a new pull request #9000: URL: https://github.com/apache/pulsar/pull/9000 ### Motivation Currently, the command line option `--proxy-url` is required when running the subcommand `websocket-producer` of `pulsar-perf`. ```sh $ ./bin/pulsar-perf websocket-produ

[pulsar] branch master updated (5ee37b7 -> 2ef5ab5)

2020-12-18 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5ee37b7 Update maven artifact version (#8966) add 2ef5ab5 [docs] Fix workaround for functions worker errors (#8

[GitHub] [pulsar] sijie merged pull request #8958: [docs] Fix workaround for functions worker errors

2020-12-18 Thread GitBox
sijie merged pull request #8958: URL: https://github.com/apache/pulsar/pull/8958 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] yufan022 commented on a change in pull request #8985: [Issue 8887][tiered-storage-jcloud] support tiered-storage provider by aliyun OSS

2020-12-18 Thread GitBox
yufan022 commented on a change in pull request #8985: URL: https://github.com/apache/pulsar/pull/8985#discussion_r545664486 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java ## @@ -162,6 +165,48

[GitHub] [pulsar] RobertIndie commented on pull request #8962: [ShadeTest]Add integration shade test for pulsar-client and pulsar-cient-admin.

2020-12-18 Thread GitBox
RobertIndie commented on pull request #8962: URL: https://github.com/apache/pulsar/pull/8962#issuecomment-747950685 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] sijie commented on a change in pull request #8995: remove duplicated broker prometheus metrics type

2020-12-18 Thread GitBox
sijie commented on a change in pull request #8995: URL: https://github.com/apache/pulsar/pull/8995#discussion_r545660683 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java ## @@ -591,18 +595,63 @@ public void testManagedLedgerSt

[GitHub] [pulsar] astifter opened a new issue #8999: https://pulsar.apache.org/api/python/ Points to Very Old Version (Instead of Latest)

2020-12-18 Thread GitBox
astifter opened a new issue #8999: URL: https://github.com/apache/pulsar/issues/8999 https://pulsar.apache.org/api/python/ points to the first ever released Python API. This was confusing me for the longest time until I figured out that the latest API doc is actually at https://pulsar.apa

[GitHub] [pulsar] sijie opened a new pull request #8998: Improve error handling when broker doesn't trust client certificates

2020-12-18 Thread GitBox
sijie opened a new pull request #8998: URL: https://github.com/apache/pulsar/pull/8998 *Motivation* When TLS throws `SSLPeerUnverifiedException`, broker doesn't log any information and just returns `null`. It makes users very hard to debug problem. *Changes* Improve

[GitHub] [pulsar] sijie commented on issue #8982: code quality issue: pulsar 2.7.0 check style issue. don't we run check style before we release it??

2020-12-18 Thread GitBox
sijie commented on issue #8982: URL: https://github.com/apache/pulsar/issues/8982#issuecomment-747938998 have you tried run `mvn clean install -DskipTests`? This is the command we used for release builds. This is an automate

[GitHub] [pulsar] Renkai commented on a change in pull request #8985: [Issue 8887][tiered-storage-jcloud] support tiered-storage provider by aliyun OSS

2020-12-18 Thread GitBox
Renkai commented on a change in pull request #8985: URL: https://github.com/apache/pulsar/pull/8985#discussion_r545636617 ## File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java ## @@ -162,6 +165,48 @

[GitHub] [pulsar] ltamber commented on pull request #8913: [Pulsar C++ Client] make pool connections configurable in perf tools

2020-12-18 Thread GitBox
ltamber commented on pull request #8913: URL: https://github.com/apache/pulsar/pull/8913#issuecomment-747933387 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message